mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 00:56:28 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
299 lines
13 KiB
C#
299 lines
13 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
// CA2000: system-under-test disposables are created per test and released at teardown;
|
|
// there is no cross-test resource leak. Suppressed file-level for the suite.
|
|
#pragma warning disable CA2000 // Dispose objects before losing scope
|
|
|
|
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
|
|
// adds noise without a behavioural benefit. Disabled file-level for the suite.
|
|
#pragma warning disable CA2007
|
|
|
|
using System;
|
|
using System.Threading.Tasks;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Redundancy;
|
|
using Opc.Ua.Redundancy.Server;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Server.Tests.Redundancy
|
|
{
|
|
/// <summary>
|
|
/// Tests best-effort continuation point envelope mirroring.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Distributed")]
|
|
[Category("ContinuationPoints")]
|
|
public class SharedContinuationPointStoreTests
|
|
{
|
|
[Test]
|
|
public async Task BrowseContinuationPointEnvelopeReplicatesAcrossStoresAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore primary = CreateStore(kv);
|
|
await using SharedKeyValueSubscriptionStore backup = CreateStore(kv);
|
|
var sessionId = new NodeId(Guid.NewGuid(), 1);
|
|
var continuationPointId = Guid.NewGuid();
|
|
|
|
primary.StoreContinuationPoint(CreateBrowseEnvelope(sessionId, continuationPointId));
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await backup.LoadContinuationPointsAsync(sessionId).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Has.Count.EqualTo(1));
|
|
ContinuationPointEnvelope envelope = envelopes[0];
|
|
Assert.That(envelope.Id, Is.EqualTo(continuationPointId));
|
|
Assert.That(envelope.OwnerSessionId, Is.EqualTo(sessionId));
|
|
Assert.That(envelope.Kind, Is.EqualTo(ContinuationPointKind.Browse));
|
|
Assert.That(envelope.BrowseNodeId, Is.EqualTo(new NodeId("Demo", 2)));
|
|
Assert.That(envelope.MaxResultsToReturn, Is.EqualTo(10));
|
|
Assert.That(envelope.ResultMask, Is.EqualTo(BrowseResultMask.All));
|
|
}
|
|
|
|
[Test]
|
|
public async Task RemovedContinuationPointEnvelopeDoesNotLoadOnBackupAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore primary = CreateStore(kv);
|
|
await using SharedKeyValueSubscriptionStore backup = CreateStore(kv);
|
|
var sessionId = new NodeId(Guid.NewGuid(), 1);
|
|
var continuationPointId = Guid.NewGuid();
|
|
|
|
primary.StoreContinuationPoint(CreateBrowseEnvelope(sessionId, continuationPointId));
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
primary.RemoveContinuationPoint(sessionId, ContinuationPointKind.Browse, continuationPointId);
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await backup.LoadContinuationPointsAsync(sessionId).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task BrowseNextForMirroredOpaqueContinuationPointFailsGracefullyAsync()
|
|
{
|
|
MasterNodeManager manager = CreateMasterNodeManager();
|
|
var session = new Mock<ISession>();
|
|
ByteString continuationPoint = Guid.NewGuid().ToByteArray().ToByteString();
|
|
session
|
|
.Setup(s => s.ContinuationPoints.RestoreBrowse(continuationPoint))
|
|
.Returns((ContinuationPoint?)null);
|
|
var context = new OperationContext(session.Object, DiagnosticsMasks.None);
|
|
|
|
(ArrayOf<BrowseResult> results, _) = await manager.BrowseNextAsync(
|
|
context,
|
|
false,
|
|
[continuationPoint]).ConfigureAwait(false);
|
|
|
|
Assert.That(results, Has.Count.EqualTo(1));
|
|
Assert.That(results[0].StatusCode, Is.EqualTo(StatusCodes.BadContinuationPointInvalid));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LoadUnknownSessionReturnsNoEnvelopesAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore store = CreateStore(kv);
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await store.LoadContinuationPointsAsync(new NodeId(Guid.NewGuid(), 1)).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task SecondBrowseContinuationPointEnvelopeReplicatesAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore primary = CreateStore(kv);
|
|
await using SharedKeyValueSubscriptionStore backup = CreateStore(kv);
|
|
var sessionId = new NodeId(Guid.NewGuid(), 1);
|
|
var continuationPointId = Guid.NewGuid();
|
|
|
|
primary.StoreContinuationPoint(new ContinuationPointEnvelope
|
|
{
|
|
Id = continuationPointId,
|
|
OwnerSessionId = sessionId,
|
|
Kind = ContinuationPointKind.Browse,
|
|
Index = 5
|
|
});
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await backup.LoadContinuationPointsAsync(sessionId).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Has.Count.EqualTo(1));
|
|
Assert.That(envelopes[0].Kind, Is.EqualTo(ContinuationPointKind.Browse));
|
|
Assert.That(envelopes[0].Index, Is.EqualTo(5));
|
|
}
|
|
|
|
[Test]
|
|
public async Task HistoryContinuationPointEnvelopeReplicatesAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore primary = CreateStore(kv);
|
|
await using SharedKeyValueSubscriptionStore backup = CreateStore(kv);
|
|
var sessionId = new NodeId(Guid.NewGuid(), 1);
|
|
var continuationPointId = Guid.NewGuid();
|
|
|
|
primary.StoreContinuationPoint(new ContinuationPointEnvelope
|
|
{
|
|
Id = continuationPointId,
|
|
OwnerSessionId = sessionId,
|
|
Kind = ContinuationPointKind.History,
|
|
BrowseNodeId = new NodeId("HistoryVar", 2)
|
|
});
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await backup.LoadContinuationPointsAsync(sessionId).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Has.Count.EqualTo(1));
|
|
Assert.That(envelopes[0].Kind, Is.EqualTo(ContinuationPointKind.History));
|
|
Assert.That(envelopes[0].BrowseNodeId, Is.EqualTo(new NodeId("HistoryVar", 2)));
|
|
}
|
|
|
|
[Test]
|
|
public async Task MultipleContinuationPointsForSameSessionReplicateAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore primary = CreateStore(kv);
|
|
await using SharedKeyValueSubscriptionStore backup = CreateStore(kv);
|
|
var sessionId = new NodeId(Guid.NewGuid(), 1);
|
|
|
|
primary.StoreContinuationPoint(CreateBrowseEnvelope(sessionId, Guid.NewGuid()));
|
|
primary.StoreContinuationPoint(new ContinuationPointEnvelope
|
|
{
|
|
Id = Guid.NewGuid(),
|
|
OwnerSessionId = sessionId,
|
|
Kind = ContinuationPointKind.History
|
|
});
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await backup.LoadContinuationPointsAsync(sessionId).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Has.Count.EqualTo(2));
|
|
}
|
|
|
|
[Test]
|
|
public async Task ContinuationPointForDifferentSessionDoesNotLoadAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore primary = CreateStore(kv);
|
|
await using SharedKeyValueSubscriptionStore backup = CreateStore(kv);
|
|
var sessionA = new NodeId(Guid.NewGuid(), 1);
|
|
var sessionB = new NodeId(Guid.NewGuid(), 1);
|
|
|
|
primary.StoreContinuationPoint(CreateBrowseEnvelope(sessionA, Guid.NewGuid()));
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await backup.LoadContinuationPointsAsync(sessionB).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task FlushBeforeStoreCausesNoReplicationAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
await using SharedKeyValueSubscriptionStore primary = CreateStore(kv);
|
|
await using SharedKeyValueSubscriptionStore backup = CreateStore(kv);
|
|
var sessionId = new NodeId(Guid.NewGuid(), 1);
|
|
|
|
await primary.FlushAsync().ConfigureAwait(false);
|
|
primary.StoreContinuationPoint(CreateBrowseEnvelope(sessionId, Guid.NewGuid()));
|
|
|
|
ArrayOf<ContinuationPointEnvelope> envelopes =
|
|
await backup.LoadContinuationPointsAsync(sessionId).ConfigureAwait(false);
|
|
|
|
Assert.That(envelopes, Is.Empty);
|
|
}
|
|
|
|
private static SharedKeyValueSubscriptionStore CreateStore(InMemorySharedKeyValueStore kv)
|
|
{
|
|
return new SharedKeyValueSubscriptionStore(
|
|
kv,
|
|
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create()));
|
|
}
|
|
|
|
private static ContinuationPointEnvelope CreateBrowseEnvelope(NodeId sessionId, Guid id)
|
|
{
|
|
return new ContinuationPointEnvelope
|
|
{
|
|
Id = id,
|
|
OwnerSessionId = sessionId,
|
|
Kind = ContinuationPointKind.Browse,
|
|
BrowseNodeId = new NodeId("Demo", 2),
|
|
View = new ViewDescription { ViewId = ObjectIds.ViewsFolder },
|
|
MaxResultsToReturn = 10,
|
|
BrowseDirection = BrowseDirection.Forward,
|
|
ReferenceTypeId = ReferenceTypeIds.HierarchicalReferences,
|
|
IncludeSubtypes = true,
|
|
NodeClassMask = (uint)NodeClass.Variable,
|
|
ResultMask = BrowseResultMask.All,
|
|
Index = 3
|
|
};
|
|
}
|
|
|
|
private static MasterNodeManager CreateMasterNodeManager()
|
|
{
|
|
var server = new Mock<IServerInternal>();
|
|
server.Setup(s => s.Telemetry).Returns(NUnitTelemetryContext.Create());
|
|
server.Setup(s => s.NamespaceUris).Returns(new NamespaceTable());
|
|
var nodeManagerFactory = new Mock<IMainNodeManagerFactory>();
|
|
var configurationNodeManager = new Mock<IConfigurationNodeManager>();
|
|
configurationNodeManager.Setup(n => n.NamespaceUris).Returns([]);
|
|
var coreNodeManager = new Mock<ICoreNodeManager>();
|
|
nodeManagerFactory
|
|
.Setup(f => f.CreateConfigurationNodeManager())
|
|
.Returns(configurationNodeManager.Object);
|
|
nodeManagerFactory
|
|
.Setup(f => f.CreateCoreNodeManager(It.IsAny<ushort>()))
|
|
.Returns(coreNodeManager.Object);
|
|
server.Setup(s => s.MainNodeManagerFactory).Returns(nodeManagerFactory.Object);
|
|
return new MasterNodeManager(
|
|
server.Object,
|
|
new ApplicationConfiguration
|
|
{
|
|
ServerConfiguration = new ServerConfiguration
|
|
{
|
|
MaxBrowseContinuationPoints = 10
|
|
}
|
|
},
|
|
null,
|
|
Array.Empty<IAsyncNodeManager>());
|
|
}
|
|
}
|
|
}
|