Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/Values/DistributedValueParticipationTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

329 lines
16 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// CA2000: system-under-test disposables are created per test and released at teardown;
// there is no cross-test resource leak. Suppressed file-level for the suite.
#pragma warning disable CA2000 // Dispose objects before losing scope
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
// adds noise without a behavioural benefit. Disabled file-level for the suite.
#pragma warning disable CA2007
using System;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Time.Testing;
using NUnit.Framework;
using Opc.Ua.Redundancy;
using Opc.Ua.Redundancy.Server;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Redundancy
{
/// <summary>
/// Unit tests for <see cref="DistributedValueParticipation"/>.
/// </summary>
[TestFixture]
[Category("Distributed")]
[Parallelizable(ParallelScope.All)]
public class DistributedValueParticipationTests
{
private const ushort NamespaceIndex = 1;
private static readonly int[] s_initial = [1, 2, 3, 4];
private static readonly int[] s_slice = [20, 30];
private static readonly int[] s_merged = [1, 20, 30, 4];
private static readonly int[] s_rangeRead = [30];
private static readonly int[] s_first = [20];
private static readonly int[] s_second = [30];
private static readonly int[] s_bothSlices = [1, 20, 30, 4];
private IServiceMessageContext m_messageContext = null!;
private SystemContext m_systemContext = null!;
[OneTimeSetUp]
public void OneTimeSetUp()
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
var messageContext = ServiceMessageContext.CreateEmpty(telemetry);
messageContext.NamespaceUris.GetIndexOrAppend("urn:test:participation");
m_messageContext = messageContext;
m_systemContext = new SystemContext(telemetry)
{
NamespaceUris = messageContext.NamespaceUris,
ServerUris = messageContext.ServerUris,
EncodeableFactory = messageContext.Factory
};
}
[Test]
public async Task ReadThroughServesFreshCacheWithoutLiveReadAsync()
{
var time = new FakeTimeProvider();
using var kv = new InMemorySharedKeyValueStore();
var cache = new DistributedValueCache(new InMemoryNodeStateStore(kv, m_messageContext), time);
var nodeId = new NodeId("v", NamespaceIndex);
await cache.CacheAsync(nodeId, new DataValue(new Variant(2.0), StatusCodes.Good, time.GetUtcNow())).ConfigureAwait(false);
int liveCalls = 0;
DataValue result = await DistributedValueParticipation.ReadThroughAsync(
cache, nodeId, TimeSpan.FromMinutes(1), LiveRead).ConfigureAwait(false);
Assert.That(liveCalls, Is.Zero, "fresh cached value must be served without a live read");
Assert.That(result.WrappedValue, Is.EqualTo(new Variant(2.0)));
ValueTask<DataValue> LiveRead(CancellationToken ct)
{
liveCalls++;
return new ValueTask<DataValue>(new DataValue(new Variant(99.0), StatusCodes.Good, time.GetUtcNow()));
}
}
[Test]
public async Task ReadThroughReadsLiveWhenStaleAndCachesAsync()
{
var time = new FakeTimeProvider();
using var kv = new InMemorySharedKeyValueStore();
var cache = new DistributedValueCache(new InMemoryNodeStateStore(kv, m_messageContext), time);
var nodeId = new NodeId("v", NamespaceIndex);
int liveCalls = 0;
DataValue result = await DistributedValueParticipation.ReadThroughAsync(
cache, nodeId, TimeSpan.FromMinutes(1), LiveRead).ConfigureAwait(false);
Assert.That(liveCalls, Is.EqualTo(1));
Assert.That(result.WrappedValue, Is.EqualTo(new Variant(7.0)));
(bool fresh, DataValue cached) = await cache.TryGetAsync(nodeId, TimeSpan.FromMinutes(1)).ConfigureAwait(false);
Assert.That(fresh, Is.True, "the live value should now be cached and fresh");
Assert.That(cached.WrappedValue, Is.EqualTo(new Variant(7.0)));
ValueTask<DataValue> LiveRead(CancellationToken ct)
{
liveCalls++;
return new ValueTask<DataValue>(new DataValue(new Variant(7.0), StatusCodes.Good, time.GetUtcNow()));
}
}
[Test]
public async Task EnableParticipationWiresWriteThroughAndCachedReadAsync()
{
using var kv = new InMemorySharedKeyValueStore();
var cache = new DistributedValueCache(new InMemoryNodeStateStore(kv, m_messageContext));
var nodeId = new NodeId("wired", NamespaceIndex);
var variable = new BaseDataVariableState(null)
{
NodeId = nodeId,
BrowseName = new QualifiedName("Wired", NamespaceIndex),
DisplayName = new LocalizedText("Wired"),
DataType = DataTypeIds.Double,
ValueRank = ValueRanks.Scalar,
Value = new Variant(0.0)
};
int liveCalls = 0;
variable.EnableDistributedValueParticipation(cache, TimeSpan.FromMinutes(1), LiveRead);
AttributeWriteResult writeResult = await variable.OnWriteValueAsync!(
m_systemContext, variable, default, new Variant(8.0), default).ConfigureAwait(false);
Assert.That(ServiceResult.IsGood(writeResult.Result), Is.True);
AttributeReadResult readResult = await variable.OnReadValueAsync!(
m_systemContext, variable, default, new QualifiedName(), default).ConfigureAwait(false);
Assert.That(readResult.Value, Is.EqualTo(new Variant(8.0)), "the written value is served from the cache");
Assert.That(liveCalls, Is.Zero, "a fresh written value must be served without a live read");
ValueTask<DataValue> LiveRead(CancellationToken ct)
{
liveCalls++;
return new ValueTask<DataValue>(new DataValue(new Variant(123.0), StatusCodes.Good, DateTimeUtc.Now));
}
}
[Test]
public async Task EnableParticipationMergesIndexRangeWriteAndAppliesIndexRangeOnReadAsync()
{
using var kv = new InMemorySharedKeyValueStore();
var cache = new DistributedValueCache(new InMemoryNodeStateStore(kv, m_messageContext));
var nodeId = new NodeId("array", NamespaceIndex);
var variable = new BaseDataVariableState(null)
{
NodeId = nodeId,
BrowseName = new QualifiedName("Array", NamespaceIndex),
DisplayName = new LocalizedText("Array"),
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.OneDimension
};
variable.EnableDistributedValueParticipation(cache, TimeSpan.FromMinutes(1), LiveRead);
AttributeWriteResult writeResult = await variable.OnWriteValueAsync!(
m_systemContext, variable, NumericRange.Parse("1:2"), Variant.From(s_slice), default)
.ConfigureAwait(false);
Assert.That(ServiceResult.IsGood(writeResult.Result), Is.True);
AttributeReadResult fullRead = await variable.OnReadValueAsync!(
m_systemContext, variable, default, new QualifiedName(), default).ConfigureAwait(false);
Assert.That(fullRead.Value.GetInt32Array(), Is.EqualTo(s_merged.ToArrayOf()),
"only the addressed elements may change; the slice must not become the whole value");
AttributeReadResult rangeRead = await variable.OnReadValueAsync!(
m_systemContext, variable, NumericRange.Parse("2"), new QualifiedName(), default)
.ConfigureAwait(false);
Assert.That(ServiceResult.IsGood(rangeRead.Result), Is.True);
Assert.That(rangeRead.Value.GetInt32Array(), Is.EqualTo(s_rangeRead.ToArrayOf()));
AttributeWriteResult outOfRange = await variable.OnWriteValueAsync!(
m_systemContext, variable, NumericRange.Parse("10:11"), Variant.From(s_slice), default)
.ConfigureAwait(false);
Assert.That(ServiceResult.IsBad(outOfRange.Result), Is.True);
static ValueTask<DataValue> LiveRead(CancellationToken ct)
{
return new ValueTask<DataValue>(
new DataValue(Variant.From(s_initial), StatusCodes.Good, DateTimeUtc.Now));
}
}
[Test]
public async Task ConcurrentIndexRangeWritesDoNotLoseASliceAsync()
{
// Both writes used to read the same current value and the later
// cache write overwrote the earlier slice.
using var kv = new InMemorySharedKeyValueStore();
var cache = new DistributedValueCache(new InMemoryNodeStateStore(kv, m_messageContext));
var nodeId = new NodeId("concurrent", NamespaceIndex);
var variable = new BaseDataVariableState(null)
{
NodeId = nodeId,
BrowseName = new QualifiedName("Concurrent", NamespaceIndex),
DisplayName = new LocalizedText("Concurrent"),
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.OneDimension
};
var firstReadGate = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
int liveReads = 0;
variable.EnableDistributedValueParticipation(cache, TimeSpan.FromMinutes(1), LiveRead);
Task<AttributeWriteResult> first = variable.OnWriteValueAsync!(
m_systemContext, variable, NumericRange.Parse("1"), Variant.From(s_first), default).AsTask();
Task<AttributeWriteResult> second = variable.OnWriteValueAsync!(
m_systemContext, variable, NumericRange.Parse("2"), Variant.From(s_second), default).AsTask();
firstReadGate.SetResult(true);
AttributeWriteResult[] results = await Task.WhenAll(first, second);
Assert.That(results.All(r => ServiceResult.IsGood(r.Result)), Is.True);
AttributeReadResult read = await variable.OnReadValueAsync!(
m_systemContext, variable, default, new QualifiedName(), default);
Assert.That(read.Value.GetInt32Array(), Is.EqualTo(s_bothSlices.ToArrayOf()));
async ValueTask<DataValue> LiveRead(CancellationToken ct)
{
if (Interlocked.Increment(ref liveReads) == 1)
{
// hold the first write inside its read-modify-write.
await firstReadGate.Task;
}
return new DataValue(Variant.From(s_initial), StatusCodes.Good, DateTimeUtc.Now);
}
}
[Test]
public async Task CachedValuePropagatesAcrossReplicasSharingOneStoreAsync()
{
// Two replicas backed by the SAME shared key/value store: what the
// active replica caches, a promoted replica reads back. This is the
// mechanism behind "the Counter continues across failover" - the new
// leader seeds from the last value written by the former leader.
using var kv = new InMemorySharedKeyValueStore();
var leader = new DistributedValueCache(new InMemoryNodeStateStore(kv, m_messageContext));
var promoted = new DistributedValueCache(new InMemoryNodeStateStore(kv, m_messageContext));
var nodeId = new NodeId("counter", NamespaceIndex);
await leader
.CacheAsync(nodeId, new DataValue(new Variant(41), StatusCodes.Good, DateTimeUtc.Now))
.ConfigureAwait(false);
await leader
.CacheAsync(nodeId, new DataValue(new Variant(42), StatusCodes.Good, DateTimeUtc.Now))
.ConfigureAwait(false);
(bool fresh, DataValue value) = await promoted
.TryGetAsync(nodeId, TimeSpan.FromMinutes(1))
.ConfigureAwait(false);
Assert.That(fresh, Is.True, "the promoted replica must observe the shared value as fresh");
Assert.That(value.WrappedValue.TryGetValue(out int counter), Is.True);
Assert.That(counter, Is.EqualTo(42), "the last value written by the former leader is served");
}
[Test]
public async Task ReadOnlyParticipationSkipsCacheWritesAsync()
{
using var kv = new InMemorySharedKeyValueStore();
using var store = new InMemoryNodeStateStore(kv, m_messageContext);
var cache = new DistributedValueCache(store, isWriter: () => false);
var nodeId = new NodeId("readonly", NamespaceIndex);
var variable = new BaseDataVariableState(null)
{
NodeId = nodeId,
BrowseName = new QualifiedName("ReadOnly", NamespaceIndex),
DisplayName = new LocalizedText("ReadOnly"),
DataType = DataTypeIds.Double,
ValueRank = ValueRanks.Scalar,
Value = new Variant(0.0)
};
int liveCalls = 0;
variable.EnableDistributedValueParticipation(cache, TimeSpan.FromMinutes(1), LiveRead);
AttributeReadResult firstRead = await variable.OnReadValueAsync!(
m_systemContext, variable, default, new QualifiedName(), default).ConfigureAwait(false);
AttributeReadResult secondRead = await variable.OnReadValueAsync!(
m_systemContext, variable, default, new QualifiedName(), default).ConfigureAwait(false);
AttributeWriteResult writeResult = await variable.OnWriteValueAsync!(
m_systemContext, variable, default, new Variant(8.0), default).ConfigureAwait(false);
Assert.That(firstRead.Value, Is.EqualTo(new Variant(5.0)));
Assert.That(secondRead.Value, Is.EqualTo(new Variant(5.0)));
Assert.That(liveCalls, Is.EqualTo(2), "a read-only replica should not cache read-through refreshes");
Assert.That(ServiceResult.IsGood(writeResult.Result), Is.True);
(bool found, _) = await store.TryReadValueAsync(nodeId).ConfigureAwait(false);
Assert.That(found, Is.False, "a read-only replica should not persist write-through updates");
ValueTask<DataValue> LiveRead(CancellationToken ct)
{
liveCalls++;
return new ValueTask<DataValue>(new DataValue(new Variant(5.0), StatusCodes.Good, DateTimeUtc.Now));
}
}
}
}