Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/Fluent/ReferenceBuilderExtensionsTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

521 lines
20 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using Moq;
using NUnit.Framework;
using Opc.Ua.Server.Fluent;
#pragma warning disable CA2000
namespace Opc.Ua.Server.Tests.Fluent
{
/// <summary>
/// Tests for <see cref="ReferenceBuilderExtensions"/> — fluent
/// <c>Organizes</c> / <c>HasComponent</c> / <c>AddReference</c> /
/// <c>AddObject</c> helpers.
/// </summary>
[TestFixture]
[Category("Fluent")]
public class ReferenceBuilderExtensionsTests
{
private const ushort kNs = 2;
private static SystemContext CreateContext()
{
var ns = new NamespaceTable();
ns.Append(Ua.Namespaces.OpcUa);
return new SystemContext(telemetry: null!)
{
NamespaceUris = ns
};
}
private static (NodeManagerBuilder Builder, BaseObjectState Root,
BaseDataVariableState Target1, BaseDataVariableState Target2)
CreateBuilder()
{
SystemContext ctx = CreateContext();
var root = new BaseObjectState(parent: null)
{
NodeId = new NodeId("Root", kNs),
BrowseName = new QualifiedName("Root", kNs),
DisplayName = new LocalizedText("Root")
};
var target1 = new BaseDataVariableState(parent: null)
{
NodeId = new NodeId("Target1", kNs),
BrowseName = new QualifiedName("Target1", kNs),
DisplayName = new LocalizedText("Target1"),
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.Scalar
};
var target2 = new BaseDataVariableState(parent: null)
{
NodeId = new NodeId("Target2", kNs),
BrowseName = new QualifiedName("Target2", kNs),
DisplayName = new LocalizedText("Target2"),
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.Scalar
};
var roots = new Dictionary<QualifiedName, NodeState> { [root.BrowseName] = root };
var byId = new Dictionary<NodeId, NodeState>
{
[root.NodeId] = root,
[target1.NodeId] = target1,
[target2.NodeId] = target2
};
var builder = new NodeManagerBuilder(
ctx,
nodeManager: FluentTestNodeManager.Create(kNs),
defaultNamespaceIndex: kNs,
rootResolver: q => roots.TryGetValue(q, out NodeState? n) ? n! : null!,
nodeIdResolver: id => byId.TryGetValue(id, out NodeState? n) ? n! : null!,
typeIdResolver: _ => []);
return (builder, root, target1, target2);
}
[Test]
public void OrganizesAddsForwardReference()
{
(NodeManagerBuilder b, BaseObjectState root, BaseDataVariableState t1, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
nb.Organizes(t1.NodeId);
Assert.That(
root.ReferenceExists(ReferenceTypeIds.Organizes, isInverse: false, t1.NodeId),
Is.True);
}
[Test]
public void OrganizesNodeStateOverloadAddsReference()
{
(NodeManagerBuilder b, BaseObjectState root, BaseDataVariableState t1, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
nb.Organizes(t1);
Assert.That(
root.ReferenceExists(ReferenceTypeIds.Organizes, isInverse: false, t1.NodeId),
Is.True);
}
[Test]
public void OrganizedByAddsInverseReference()
{
(NodeManagerBuilder b, BaseObjectState root, BaseDataVariableState t1, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder chained = nb.OrganizedBy(t1.NodeId);
Assert.That(chained, Is.SameAs(nb));
Assert.That(
root.ReferenceExists(ReferenceTypeIds.Organizes, isInverse: true, t1.NodeId),
Is.True);
}
[Test]
public void UnderObjectsFolderAddsInverseOrganizesToObjectsFolder()
{
(NodeManagerBuilder b, BaseObjectState root, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder chained = nb.UnderObjectsFolder();
Assert.That(chained, Is.SameAs(nb));
Assert.That(
root.ReferenceExists(
ReferenceTypeIds.Organizes,
isInverse: true,
ObjectIds.ObjectsFolder),
Is.True);
}
[Test]
public void HasComponentAddsForwardReference()
{
(NodeManagerBuilder b, BaseObjectState root, BaseDataVariableState t1, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
nb.HasComponent(t1.NodeId);
Assert.That(
root.ReferenceExists(ReferenceTypeIds.HasComponent, isInverse: false, t1.NodeId),
Is.True);
}
[Test]
public void HasPropertyAddsForwardReference()
{
(NodeManagerBuilder b, BaseObjectState root, BaseDataVariableState t1, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
nb.HasProperty(t1.NodeId);
Assert.That(
root.ReferenceExists(ReferenceTypeIds.HasProperty, isInverse: false, t1.NodeId),
Is.True);
}
[Test]
public void AddReferenceChainsMultipleTargets()
{
(NodeManagerBuilder b, BaseObjectState root,
BaseDataVariableState t1, BaseDataVariableState t2) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
nb.Organizes(t1.NodeId).Organizes(t2.NodeId);
Assert.That(root.ReferenceExists(ReferenceTypeIds.Organizes, false, t1.NodeId), Is.True);
Assert.That(root.ReferenceExists(ReferenceTypeIds.Organizes, false, t2.NodeId), Is.True);
}
[Test]
public void AddReferenceInverseFlagIsRespected()
{
(NodeManagerBuilder b, BaseObjectState root, BaseDataVariableState t1, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
nb.AddReference(ReferenceTypeIds.HasNotifier, isInverse: true, t1.NodeId);
Assert.That(
root.ReferenceExists(ReferenceTypeIds.HasNotifier, isInverse: true, t1.NodeId),
Is.True);
Assert.That(
root.ReferenceExists(ReferenceTypeIds.HasNotifier, isInverse: false, t1.NodeId),
Is.False);
}
[Test]
public void OrganizesNullTargetThrowsArgumentNullException()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
Assert.Throws<ArgumentNullException>(() => nb.Organizes(NodeId.Null));
Assert.Throws<ArgumentNullException>(() => nb.Organizes(null!));
}
[Test]
public void AddObjectCreatesAndAttachesChild()
{
(NodeManagerBuilder b, BaseObjectState root, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
Assert.That(child.Node, Is.Not.Null);
Assert.That(child.Node.BrowseName, Is.EqualTo(new QualifiedName("Group1", kNs)));
Assert.That(child.Node.Parent, Is.SameAs(root));
Assert.That(child.Node.NodeId.IdentifierAsString,
Does.Contain("Root").And.Contain("Group1"),
"The NodeId is minted from the parent and the browse name.");
Assert.That(child.Node.TypeDefinitionId, Is.EqualTo(ObjectTypeIds.BaseObjectType));
var children = new List<BaseInstanceState>();
root.GetChildren(null!, children);
Assert.That(children, Has.Member(child.Node));
}
[Test]
public void AddObjectWithCustomTypeDefinition()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
var customType = new NodeId(1234u, kNs);
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("CustomGroup", kNs),
customType);
Assert.That(child.Node.TypeDefinitionId, Is.EqualTo(customType));
}
[Test]
public void AddObjectThenOrganizesWiresFunctionalGroup()
{
(NodeManagerBuilder b, _, BaseDataVariableState t1, BaseDataVariableState t2) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> group = nb.AddObject(
new QualifiedName("Operational", kNs));
group.Organizes(t1).Organizes(t2);
Assert.That(group.Node.ReferenceExists(
ReferenceTypeIds.Organizes, false, t1.NodeId), Is.True);
Assert.That(group.Node.ReferenceExists(
ReferenceTypeIds.Organizes, false, t2.NodeId), Is.True);
}
[Test]
public void AddObjectRejectsABrowseNameItCannotAuthorWith()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
Assert.Multiple(() =>
{
// a browse name failure is reported the same way here as on
// the builder's own Add methods, rather than as an argument
// exception from this one helper.
ServiceResultException missing = Assert.Throws<ServiceResultException>(
() => nb.AddObject(QualifiedName.Null))!;
Assert.That(missing.StatusCode, Is.EqualTo(StatusCodes.BadBrowseNameInvalid));
ServiceResultException namespaceZero = Assert.Throws<ServiceResultException>(
() => nb.AddObject(new QualifiedName("Press")))!;
Assert.That(
namespaceZero.StatusCode,
Is.EqualTo(StatusCodes.BadBrowseNameInvalid));
});
}
[Test]
public void AddReferenceNullArgsThrow()
{
(NodeManagerBuilder b, _, BaseDataVariableState t1, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
Assert.Throws<ArgumentNullException>(
() => nb.AddReference(NodeId.Null, false, t1.NodeId));
Assert.Throws<ArgumentNullException>(
() => nb.AddReference(ReferenceTypeIds.Organizes, false, NodeId.Null));
}
[Test]
public void AddReferenceNullBuilderThrowsArgumentNullException()
{
(_, _, BaseDataVariableState t1, _) = CreateBuilder();
Assert.Throws<ArgumentNullException>(
() => ((INodeBuilder)null!).AddReference(
ReferenceTypeIds.Organizes, false, t1.NodeId));
}
[Test]
public void AddObjectNullParentThrowsArgumentNullException()
{
Assert.Throws<ArgumentNullException>(
() => ((INodeBuilder)null!).AddObject(new QualifiedName("X", kNs)));
}
[Test]
public void AddObjectReturnedBuilderExposesNodeAndOwnerBuilder()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
Assert.That(child.Builder, Is.SameAs(b));
Assert.That(((INodeBuilder)child).Node, Is.SameAs(child.Node));
}
[Test]
public void AddObjectAsCastsToBaseType()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
INodeBuilder<NodeState> upcast = child.As<NodeState>();
Assert.That(upcast.Node, Is.SameAs(child.Node));
}
[Test]
public void AddObjectAsThrowsOnTypeMismatch()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => child.As<BaseDataVariableState>())!;
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadTypeMismatch));
}
[Test]
public void AddObjectOnReadOnNonVariableThrowsBadInvalidArgument()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => child.OnRead((c, n, ref v) => ServiceResult.Good))!;
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadInvalidArgument));
}
[Test]
public void AddObjectOnCallOnNonMethodThrowsBadInvalidArgument()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => child.OnCall((_, _, _, _, _) => ServiceResult.Good))!;
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadInvalidArgument));
}
[Test]
public void AddObjectChildMissingThrowsBadNodeIdUnknown()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => child.Child(new QualifiedName("DoesNotExist", kNs)))!;
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadNodeIdUnknown));
}
[Test]
public void AddObjectVariableOnNonVariableChildThrowsBadTypeMismatch()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> parent = nb.AddObject(
new QualifiedName("Group1", kNs));
// Attach a non-variable child.
parent.AddObject(new QualifiedName("SubObj", kNs));
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => parent.Variable<int>(new QualifiedName("SubObj", kNs)))!;
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadTypeMismatch));
}
[Test]
public void AddObjectOnNodeAddedInvokesHandlerSynchronously()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> child = nb.AddObject(
new QualifiedName("Group1", kNs));
NodeState? captured = null;
child.OnNodeAdded((_, n) => captured = n);
Assert.That(captured, Is.SameAs(child.Node));
}
[Test]
public void AddObjectAdHocChildBuildersWireCallbacksAndNoOpManagerHooks()
{
(NodeManagerBuilder b, _, _, _) = CreateBuilder();
INodeBuilder nb = b.Node(new NodeId("Root", kNs));
INodeBuilder<BaseObjectState> parent = nb.AddObject(new QualifiedName("Group1", kNs));
var variable = new BaseDataVariableState(parent.Node)
{
NodeId = new NodeId("Group1.Variable", kNs),
BrowseName = new QualifiedName("Variable", kNs),
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.Scalar
};
var method = new MethodState(parent.Node)
{
NodeId = new NodeId("Group1.Method", kNs),
BrowseName = new QualifiedName("Method", kNs)
};
parent.Node.AddChild(variable);
parent.Node.AddChild(method);
INodeBuilder<BaseDataVariableState> variableBuilder =
parent.Child<BaseDataVariableState>(variable.BrowseName);
INodeBuilder<MethodState> methodBuilder = parent.Child<MethodState>(method.BrowseName);
static ServiceResult read(
ISystemContext c,
NodeState n,
NumericRange range,
QualifiedName encoding,
ref Variant value,
ref StatusCode statusCode,
ref DateTimeUtc timestamp) =>
ServiceResult.Good;
static ValueTask<AttributeWriteResult> writeAsync(
ISystemContext c,
NodeState n,
Variant value,
CancellationToken ct) =>
new(new AttributeWriteResult(ServiceResult.Good));
static ValueTask<ServiceResult> callAsync(
ISystemContext c,
MethodState m,
NodeId objectId,
ArrayOf<Variant> inputArguments,
List<Variant> outputArguments,
CancellationToken ct) =>
new(ServiceResult.Good);
variableBuilder.OnRead(read)
.OnWrite(writeAsync)
.OnHistoryRead((c, n, d, t, r, ntr, res) => ServiceResult.Good)
.OnHistoryUpdate((c, n, details, result) => ServiceResult.Good)
.OnConditionRefresh((c, n, events) => { })
.OnMonitoredItemCreated((c, n, item) => { })
.OnNodeRemoved((c, n) => { });
methodBuilder.OnCall(callAsync);
parent.OnEvent((c, n, e) => { });
ServiceResultException ex = Assert.Throws<ServiceResultException>(
() => parent.AllowMultipleEventConsumers(enable: false))!;
Assert.That(variable.OnReadValue, Is.SameAs((NodeValueEventHandler)read));
Assert.That(variable.OnSimpleWriteValueAsync, Is.SameAs(
(NodeValueSimpleWriteEventHandlerAsync)writeAsync));
Assert.That(method.OnCallMethod2Async, Is.SameAs((GenericMethodCalledEventHandler2Async)callAsync));
Assert.That(parent.Node.OnReportEvent, Is.Not.Null);
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadConfigurationError));
}
}
}