mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-26 04:19:53 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
227 lines
8.8 KiB
C#
227 lines
8.8 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Time.Testing;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Server.Fluent;
|
|
|
|
namespace Opc.Ua.Server.Tests.Fluent
|
|
{
|
|
/// <summary>
|
|
/// Covers the simulation registry after its release moved onto the behavior
|
|
/// mechanism: loops run on the server clock, and teardown awaits their drain
|
|
/// instead of blocking inside Dispose.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Fluent")]
|
|
// A behavior that fails to start or release parks a thread rather than failing an
|
|
// assertion, so every case here is time-boxed.
|
|
[CancelAfter(30000)]
|
|
public sealed class SimulationLifetimeTests
|
|
{
|
|
[Test]
|
|
public async Task LoopTicksOnTheServerClockAsync()
|
|
{
|
|
var clock = new FakeTimeProvider();
|
|
using var manager = new ClockedManager(clock);
|
|
NodeManagerBuilder builder = manager.NewBuilder();
|
|
|
|
int ticks = 0;
|
|
builder.Simulation(TimeSpan.FromSeconds(1))
|
|
.OnTick((_, _) => Interlocked.Increment(ref ticks));
|
|
|
|
await manager.ActivateAsync().ConfigureAwait(false);
|
|
await builder.SealAsync().ConfigureAwait(false);
|
|
|
|
Assert.That(ticks, Is.Zero, "no tick before the clock advances");
|
|
|
|
await AdvanceAndSettleAsync(clock, TimeSpan.FromSeconds(1))
|
|
.ConfigureAwait(false);
|
|
Assert.That(ticks, Is.EqualTo(1));
|
|
|
|
await AdvanceAndSettleAsync(clock, TimeSpan.FromSeconds(1))
|
|
.ConfigureAwait(false);
|
|
Assert.That(ticks, Is.EqualTo(2));
|
|
|
|
await manager.DeleteAddressSpaceAsync().ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public async Task TeardownAwaitsTheRunningLoopAsync()
|
|
{
|
|
var clock = new FakeTimeProvider();
|
|
using var manager = new ClockedManager(clock);
|
|
NodeManagerBuilder builder = manager.NewBuilder();
|
|
|
|
var entered = new TaskCompletionSource<bool>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var release = new TaskCompletionSource<bool>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
bool handlerFinished = false;
|
|
|
|
builder.Simulation(TimeSpan.FromSeconds(1))
|
|
.OnTick(async (_, _, _) =>
|
|
{
|
|
entered.TrySetResult(true);
|
|
await release.Task.ConfigureAwait(false);
|
|
handlerFinished = true;
|
|
});
|
|
|
|
await manager.ActivateAsync().ConfigureAwait(false);
|
|
await builder.SealAsync().ConfigureAwait(false);
|
|
|
|
clock.Advance(TimeSpan.FromSeconds(1));
|
|
await entered.Task.ConfigureAwait(false);
|
|
|
|
// Teardown must not complete while the handler is still inside its tick.
|
|
ValueTask teardown = manager.DeleteAddressSpaceAsync();
|
|
Assert.That(handlerFinished, Is.False);
|
|
|
|
release.TrySetResult(true);
|
|
await teardown.ConfigureAwait(false);
|
|
|
|
Assert.That(
|
|
handlerFinished,
|
|
Is.True,
|
|
"teardown must await the in-flight tick, not abandon it");
|
|
}
|
|
|
|
[Test]
|
|
public async Task SynchronousDisposeDoesNotBlockOnARunningLoopAsync()
|
|
{
|
|
var clock = new FakeTimeProvider();
|
|
var manager = new ClockedManager(clock);
|
|
NodeManagerBuilder builder = manager.NewBuilder();
|
|
|
|
var release = new TaskCompletionSource<bool>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
builder.Simulation(TimeSpan.FromSeconds(1))
|
|
.OnTick(async (_, _, _) => await release.Task.ConfigureAwait(false));
|
|
|
|
await builder.SealAsync().ConfigureAwait(false);
|
|
clock.Advance(TimeSpan.FromSeconds(1));
|
|
|
|
// Dispose is signal-only: it must return promptly even though a handler is
|
|
// parked, because it can be reached from a synchronous shutdown path.
|
|
var disposed = Task.Run(manager.Dispose);
|
|
Assert.That(
|
|
disposed.Wait(TimeSpan.FromSeconds(5)),
|
|
Is.True,
|
|
"Dispose must not block on an in-flight tick");
|
|
|
|
release.TrySetResult(true);
|
|
}
|
|
|
|
[Test]
|
|
public async Task LateHandlerAfterStartIsRejectedAsync()
|
|
{
|
|
var clock = new FakeTimeProvider();
|
|
using var manager = new ClockedManager(clock);
|
|
NodeManagerBuilder builder = manager.NewBuilder();
|
|
|
|
ISimulationBuilder simulation = builder
|
|
.Simulation(TimeSpan.FromSeconds(1))
|
|
.OnTick((_, _) => { });
|
|
|
|
await builder.SealAsync().ConfigureAwait(false);
|
|
|
|
// The running loop enumerates a snapshot, so a late handler would never be
|
|
// invoked. Rejecting it beats silently dropping it.
|
|
ServiceResultException ex = Assert.Throws<ServiceResultException>(
|
|
() => simulation.OnTick((_, _) => { }))!;
|
|
Assert.That(ex.StatusCode, Is.EqualTo((uint)StatusCodes.BadInvalidState));
|
|
}
|
|
|
|
private static async Task AdvanceAndSettleAsync(
|
|
FakeTimeProvider clock,
|
|
TimeSpan delta)
|
|
{
|
|
clock.Advance(delta);
|
|
|
|
// The loop body runs on the thread pool, so give it a bounded window to
|
|
// observe the tick rather than asserting on a race.
|
|
for (int i = 0; i < 100; i++)
|
|
{
|
|
await Task.Yield();
|
|
await Task.Delay(1).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
private sealed class ClockedManager : FluentNodeManagerBase
|
|
{
|
|
public ClockedManager(TimeProvider clock)
|
|
: base(CreateMockServer(clock), TestNamespaceUri)
|
|
{
|
|
}
|
|
|
|
public NodeManagerBuilder NewBuilder()
|
|
{
|
|
return CreateFluentBuilder(1);
|
|
}
|
|
|
|
public ValueTask ActivateAsync()
|
|
{
|
|
return ActivateNodeBehaviorsAsync(CancellationToken.None);
|
|
}
|
|
|
|
private const string TestNamespaceUri = "urn:test:simulation-lifetime";
|
|
|
|
private static IServerInternal CreateMockServer(TimeProvider clock)
|
|
{
|
|
var ns = new NamespaceTable();
|
|
ns.Append(Ua.Namespaces.OpcUa);
|
|
ns.Append(TestNamespaceUri);
|
|
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var mock = new Mock<IServerInternal>();
|
|
mock.SetupGet(m => m.NamespaceUris).Returns(ns);
|
|
mock.SetupGet(m => m.TypeTree).Returns(new TypeTable(ns));
|
|
mock.SetupGet(m => m.Telemetry).Returns(mockTelemetry.Object);
|
|
IServiceMessageContext msgCtx = ServiceMessageContext.Create(
|
|
mockTelemetry.Object);
|
|
mock.SetupGet(m => m.MessageContext).Returns(msgCtx);
|
|
|
|
// The manager reads its clock through this optional interface. Moq
|
|
// requires every As<T>() before the first Object access.
|
|
mock.As<ITimeProviderProvider>()
|
|
.SetupGet(m => m.TimeProvider)
|
|
.Returns(clock);
|
|
|
|
mock.SetupGet(m => m.DefaultSystemContext).Returns(
|
|
new ServerSystemContext(mock.Object));
|
|
return mock.Object;
|
|
}
|
|
}
|
|
}
|
|
}
|