mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 00:56:28 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
246 lines
9.9 KiB
C#
246 lines
9.9 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Configuration;
|
|
using Opc.Ua.Server.Hosting;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Server.Tests.Hosting
|
|
{
|
|
/// <summary>
|
|
/// Directly exercises the internal static
|
|
/// <see cref="OpcUaServerApplicationConfigurationFeature.Configure"/>
|
|
/// projection for the <see cref="OpcUaServerOptions"/> knobs that are
|
|
/// not otherwise exercised by the hosted-service integration tests
|
|
/// (transport quotas, ECC policies, operation limits, reverse connect,
|
|
/// and the LDS/GDS registration endpoint).
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Server")]
|
|
[Category("Hosting")]
|
|
[Parallelizable]
|
|
public sealed class OpcUaServerApplicationConfigurationFeatureTests
|
|
{
|
|
[Test]
|
|
public void ConfigureAppliesMaxMessageSizeAndOperationTimeoutWhenSet()
|
|
{
|
|
var options = new OpcUaServerOptions
|
|
{
|
|
MaxMessageSize = 123456,
|
|
OperationTimeoutMs = 7890
|
|
};
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/MaxMessageSize");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(configuration.TransportQuotas!.MaxMessageSize, Is.EqualTo(123456));
|
|
Assert.That(configuration.TransportQuotas!.OperationTimeout, Is.EqualTo(7890));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureAppliesMaxStringLengthWhenSet()
|
|
{
|
|
var options = new OpcUaServerOptions
|
|
{
|
|
MaxStringLength = 2 * 1024 * 1024
|
|
};
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/MaxStringLength");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(configuration.TransportQuotas!.MaxStringLength, Is.EqualTo(2 * 1024 * 1024));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureKeepsMaxStringLengthDefaultWhenNotSet()
|
|
{
|
|
var options = new OpcUaServerOptions();
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/DefaultStringLength");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(
|
|
configuration.TransportQuotas!.MaxStringLength,
|
|
Is.EqualTo(DefaultEncodingLimits.MaxStringLength));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureAppliesMaxStringLengthIndependentlyOfByteStringLength()
|
|
{
|
|
// The two are separate quotas: raising the ByteString ceiling does nothing
|
|
// for a long String, which is the trap that made this option's absence hard
|
|
// to diagnose.
|
|
var options = new OpcUaServerOptions
|
|
{
|
|
MaxByteStringLength = 8 * 1024 * 1024,
|
|
MaxStringLength = 1024
|
|
};
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/IndependentQuotas");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(configuration.TransportQuotas!.MaxByteStringLength, Is.EqualTo(8 * 1024 * 1024));
|
|
Assert.That(configuration.TransportQuotas!.MaxStringLength, Is.EqualTo(1024));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureLeavesTransportQuotaDefaultsWhenNotSet()
|
|
{
|
|
var options = new OpcUaServerOptions();
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/DefaultQuotas");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
// The stack default (not the sentinel values used above) is kept.
|
|
Assert.That(configuration.TransportQuotas!.MaxMessageSize, Is.Not.EqualTo(123456));
|
|
Assert.That(configuration.TransportQuotas!.OperationTimeout, Is.Not.EqualTo(7890));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureAddsEccPoliciesWhenRequested()
|
|
{
|
|
var options = new OpcUaServerOptions { IncludeEccPolicies = true };
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/Ecc");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(configuration.ServerConfiguration!.SecurityPolicies, Is.Not.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureAppliesOperationLimitsWhenSet()
|
|
{
|
|
var options = new OpcUaServerOptions
|
|
{
|
|
OperationLimits = new OperationLimitsOptions
|
|
{
|
|
MaxNodesPerRead = 111,
|
|
MaxNodesPerBrowse = 222,
|
|
MaxMonitoredItemsPerCall = 333
|
|
}
|
|
};
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/OperationLimits");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(configuration.ServerConfiguration!.OperationLimits, Is.Not.Null);
|
|
Assert.That(
|
|
configuration.ServerConfiguration!.OperationLimits.MaxNodesPerRead,
|
|
Is.EqualTo(111u));
|
|
Assert.That(
|
|
configuration.ServerConfiguration!.OperationLimits.MaxNodesPerBrowse,
|
|
Is.EqualTo(222u));
|
|
Assert.That(
|
|
configuration.ServerConfiguration!.OperationLimits.MaxMonitoredItemsPerCall,
|
|
Is.EqualTo(333u));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureAppliesReverseConnectWhenSet()
|
|
{
|
|
var options = new OpcUaServerOptions
|
|
{
|
|
ReverseConnect = new ServerReverseConnectOptions
|
|
{
|
|
ConnectIntervalMs = 1000,
|
|
ConnectTimeoutMs = 2000,
|
|
RejectTimeoutMs = 3000
|
|
}
|
|
};
|
|
options.ReverseConnect.Clients.Add(new ServerReverseConnectClientOptions
|
|
{
|
|
EndpointUrl = "opc.tcp://reverse-client:4841",
|
|
Timeout = 500,
|
|
MaxSessionCount = 2,
|
|
Enabled = true
|
|
});
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/ReverseConnect");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
ReverseConnectServerConfiguration? maybeReverseConnect =
|
|
configuration.ServerConfiguration!.ReverseConnect;
|
|
Assert.That(maybeReverseConnect, Is.Not.Null);
|
|
ReverseConnectServerConfiguration reverseConnect = maybeReverseConnect!;
|
|
Assert.That(reverseConnect.ConnectInterval, Is.EqualTo(1000));
|
|
Assert.That(reverseConnect.ConnectTimeout, Is.EqualTo(2000));
|
|
Assert.That(reverseConnect.RejectTimeout, Is.EqualTo(3000));
|
|
Assert.That(reverseConnect.Clients.Count, Is.EqualTo(1));
|
|
Assert.That(reverseConnect.Clients[0].EndpointUrl, Is.EqualTo("opc.tcp://reverse-client:4841"));
|
|
Assert.That(reverseConnect.Clients[0].Timeout, Is.EqualTo(500));
|
|
Assert.That(reverseConnect.Clients[0].MaxSessionCount, Is.EqualTo(2));
|
|
Assert.That(reverseConnect.Clients[0].Enabled, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureAppliesRegistrationEndpointUrlWhenSet()
|
|
{
|
|
var options = new OpcUaServerOptions
|
|
{
|
|
RegistrationEndpointUrl = "opc.tcp://lds.example.com:4840"
|
|
};
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/Registration");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(
|
|
configuration.ServerConfiguration!.RegistrationEndpoint?.EndpointUrl,
|
|
Is.EqualTo("opc.tcp://lds.example.com:4840"));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureLeavesRegistrationEndpointNullWhenNotSet()
|
|
{
|
|
var options = new OpcUaServerOptions();
|
|
options.EndpointUrls.Add("opc.tcp://localhost:0/NoRegistration");
|
|
|
|
ApplicationConfiguration configuration = Configure(options);
|
|
|
|
Assert.That(configuration.ServerConfiguration!.RegistrationEndpoint, Is.Null);
|
|
}
|
|
|
|
private static ApplicationConfiguration Configure(OpcUaServerOptions options)
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create(isServer: true);
|
|
var appInstance = new ApplicationInstance(telemetry)
|
|
{
|
|
ApplicationName = options.ApplicationName
|
|
};
|
|
IApplicationConfigurationBuilderTypes builder = appInstance.Build(
|
|
"urn:localhost:OpcUaServerApplicationConfigurationFeatureTests",
|
|
"uri:opcfoundation.org:OpcUaServerApplicationConfigurationFeatureTests");
|
|
|
|
OpcUaServerApplicationConfigurationFeature.Configure(builder, options);
|
|
|
|
return appInstance.ApplicationConfiguration!;
|
|
}
|
|
}
|
|
}
|