Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/Identity/JwtAuthenticatorRejectionTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

398 lines
17 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Security.Cryptography;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Identity;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Identity
{
[TestFixture]
[Category("Identity")]
public class JwtAuthenticatorRejectionTests
{
private const string Issuer = "https://issuer.example.test";
private const string Audience = "urn:opcua:test-server";
[Test]
public async Task AuthenticateAsyncAnonymousTokenReturnsNotHandled()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
var authenticator = new JwtAuthenticator(new StubResolver(Issuer, key), Audience, TimeSpan.Zero);
AuthenticationResult result = await authenticator
.AuthenticateAsync(new AuthenticationContext(
new AnonymousIdentityTokenHandler(),
new UserTokenPolicy(UserTokenType.Anonymous),
new EndpointDescription { SecurityMode = MessageSecurityMode.None },
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create())))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.NotHandled));
}
[Test]
public async Task AuthenticateAsyncSamlIssuedTokenReturnsNotHandled()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
var authenticator = new JwtAuthenticator(new StubResolver(Issuer, key), Audience, TimeSpan.Zero);
AuthenticationResult result = await authenticator
.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(
"http://opcfoundation.org/UA/UserToken#SAML",
[1, 2, 3])))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.NotHandled));
}
[Test]
public async Task AuthenticateAsyncEmptyTokenDataRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
AuthenticationResult result = await Authenticate(string.Empty, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncTokenWithBadBase64UrlRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
AuthenticationResult result = await Authenticate("!@#.!@#.!@#", key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncTokenWithHeaderNotJsonRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string header = Base64UrlEncode(Encoding.UTF8.GetBytes("not-json"));
string payload = Base64UrlEncode(Encoding.UTF8.GetBytes("{}"));
string signature = Base64UrlEncode([1, 2, 3]);
AuthenticationResult result = await Authenticate(header + "." + payload + "." + signature, key)
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncTokenWithoutAlgRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string header = Base64UrlEncode(Encoding.UTF8.GetBytes(/*lang=json,strict*/ "{\"typ\":\"JWT\"}"));
string payload = Base64UrlEncode(Encoding.UTF8.GetBytes("{}"));
string signature = Base64UrlEncode([1, 2, 3]);
AuthenticationResult result = await Authenticate(header + "." + payload + "." + signature, key)
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncPayloadNotJsonRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
const string header = /*lang=json,strict*/ "{\"alg\":\"RS256\",\"kid\":\"kid-rsa\",\"typ\":\"JWT\"}";
string headerEncoded = Base64UrlEncode(Encoding.UTF8.GetBytes(header));
string payloadEncoded = Base64UrlEncode(Encoding.UTF8.GetBytes("not-json"));
string signingInput = headerEncoded + "." + payloadEncoded;
byte[] signature = rsa.SignData(
Encoding.ASCII.GetBytes(signingInput),
HashAlgorithmName.SHA256,
RSASignaturePadding.Pkcs1);
AuthenticationResult result = await Authenticate(
signingInput + "." + Base64UrlEncode(signature),
key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncMissingExpClaimRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
const string payload = "{\"iss\":\"" + Issuer + "\",\"sub\":\"x\",\"aud\":\"" + Audience + "\"}";
string jwt = SignRsa(rsa, "RS256", "kid-rsa", payload);
AuthenticationResult result = await Authenticate(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncNotBeforeInFutureRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
long now = DateTimeOffset.UtcNow.ToUnixTimeSeconds();
string payload = "{\"iss\":\"" +
Issuer +
"\",\"sub\":\"x\",\"aud\":\"" +
Audience +
"\",\"exp\":" +
(now + 3600) +
",\"nbf\":" +
(now + 3600) +
"}";
string jwt = SignRsa(rsa, "RS256", "kid-rsa", payload);
AuthenticationResult result = await Authenticate(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task AuthenticateAsyncIssuedAtInFutureRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
long now = DateTimeOffset.UtcNow.ToUnixTimeSeconds();
string payload = "{\"iss\":\"" +
Issuer +
"\",\"sub\":\"x\",\"aud\":\"" +
Audience +
"\",\"exp\":" +
(now + 7200) +
",\"iat\":" +
(now + 3600) +
"}";
string jwt = SignRsa(rsa, "RS256", "kid-rsa", payload);
AuthenticationResult result = await Authenticate(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task AuthenticateAsyncTokenWithMismatchedKidRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
long now = DateTimeOffset.UtcNow.ToUnixTimeSeconds();
string payload = "{\"iss\":\"" +
Issuer +
"\",\"sub\":\"x\",\"aud\":\"" +
Audience +
"\",\"exp\":" +
(now + 3600) +
"}";
string jwt = SignRsa(rsa, "RS256", "kid-other", payload);
AuthenticationResult result = await Authenticate(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public void AuthenticateAsyncResolverExceptionPropagates()
{
var resolver = new ThrowingResolver(Issuer, new InvalidOperationException("kaboom"));
var authenticator = new JwtAuthenticator(resolver, Audience, TimeSpan.Zero);
byte[] tokenData = Encoding.UTF8.GetBytes(
Base64UrlEncode(Encoding.UTF8.GetBytes(/*lang=json,strict*/ "{\"alg\":\"RS256\",\"kid\":\"x\"}")) +
"." +
Base64UrlEncode(Encoding.UTF8.GetBytes("{\"iss\":\"" + Issuer + "\"}")) +
"." +
Base64UrlEncode([1]));
InvalidOperationException ex = Assert.ThrowsAsync<InvalidOperationException>(
async () => await authenticator.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, tokenData))).ConfigureAwait(false));
Assert.That(ex.Message, Is.EqualTo("kaboom"));
}
[Test]
public async Task DelegateConstructorReturningNullRejects()
{
var authenticator = new JwtAuthenticator(
(handler, ct) => new ValueTask<IUserIdentity?>((IUserIdentity)null!));
AuthenticationResult result = await authenticator
.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, [1])))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task DelegateConstructorThrowingServiceResultExceptionRejects()
{
var authenticator = new JwtAuthenticator((handler, ct) =>
throw ServiceResultException.Create(StatusCodes.BadIdentityTokenInvalid, "bad"));
AuthenticationResult result = await authenticator
.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, [1])))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public void ConstructorRejectsNullKeyResolver()
{
ArgumentNullException ex = Assert.Throws<ArgumentNullException>(
() => new JwtAuthenticator(null!, Audience));
Assert.That(ex.ParamName, Is.EqualTo("keyResolver"));
}
[Test]
public void ConstructorRejectsEmptyAudience()
{
ArgumentException ex = Assert.Throws<ArgumentException>(
() => new JwtAuthenticator(new StubResolver(Issuer), string.Empty));
Assert.That(ex.ParamName, Is.EqualTo("expectedAudience"));
}
private static Task<AuthenticationResult> Authenticate(string jwt, IssuerVerificationKey key)
{
var resolver = new StubResolver(Issuer, key);
var authenticator = new JwtAuthenticator(resolver, Audience, TimeSpan.Zero);
return authenticator.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, Encoding.UTF8.GetBytes(jwt))))
.AsTask();
}
private static AuthenticationContext CreateContext(IUserIdentityTokenHandler handler)
{
return new AuthenticationContext(
handler,
new UserTokenPolicy
{
TokenType = UserTokenType.IssuedToken,
PolicyId = "jwt",
IssuedTokenType = Profiles.JwtUserToken
},
new EndpointDescription { SecurityMode = MessageSecurityMode.SignAndEncrypt },
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create()));
}
private static IssuerVerificationKey CreateRsaVerificationKey(RSA rsa, string keyId)
{
RSA? publicKey = null;
try
{
publicKey = RSA.Create();
publicKey.ImportParameters(rsa.ExportParameters(false));
var key = new IssuerVerificationKey(keyId, publicKey, "RS256");
publicKey = null!;
return key;
}
finally
{
publicKey?.Dispose();
}
}
private static string SignRsa(RSA rsa, string algorithm, string kid, string payload)
{
string header = "{\"alg\":\"" + algorithm + "\",\"kid\":\"" + kid + "\",\"typ\":\"JWT\"}";
string headerEncoded = Base64UrlEncode(Encoding.UTF8.GetBytes(header));
string payloadEncoded = Base64UrlEncode(Encoding.UTF8.GetBytes(payload));
string signingInput = headerEncoded + "." + payloadEncoded;
byte[] signature = rsa.SignData(
Encoding.ASCII.GetBytes(signingInput),
HashAlgorithmName.SHA256,
RSASignaturePadding.Pkcs1);
return signingInput + "." + Base64UrlEncode(signature);
}
private static string Base64UrlEncode(byte[] bytes)
{
return Convert.ToBase64String(bytes)
.TrimEnd('=')
.Replace('+', '-')
.Replace('/', '_');
}
private sealed class StubResolver : IIssuerKeyResolver
{
private readonly IReadOnlyList<IssuerVerificationKey> m_keys;
public StubResolver(string issuerUri, params IssuerVerificationKey[] keys)
{
IssuerUri = issuerUri;
m_keys = keys ?? [];
}
public string IssuerUri { get; }
public ValueTask<IReadOnlyList<IIssuerVerificationKey>> GetKeysAsync(
string? keyId,
CancellationToken ct = default)
{
return new ValueTask<IReadOnlyList<IIssuerVerificationKey>>(m_keys);
}
}
private sealed class ThrowingResolver : IIssuerKeyResolver
{
private readonly Exception m_exception;
public ThrowingResolver(string issuerUri, Exception exception)
{
IssuerUri = issuerUri;
m_exception = exception;
}
public string IssuerUri { get; }
public ValueTask<IReadOnlyList<IIssuerVerificationKey>> GetKeysAsync(
string? keyId,
CancellationToken ct = default)
{
throw m_exception;
}
}
}
}