Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/Identity/JwtAuthenticatorTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

372 lines
16 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Security.Cryptography;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Identity;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Identity
{
[TestFixture]
[Category("Identity")]
public class JwtAuthenticatorTests
{
private const string Issuer = "https://issuer.example.test";
private const string Audience = "urn:opcua:test-server";
[Test]
public async Task AuthenticateAsyncRs256TokenAcceptedAndClaimsExtracted()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
Issuer,
Quote(Audience),
expiresInSeconds: 3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
var claims = result.Identity as IIdentityClaims;
Assert.That(claims, Is.Not.Null);
Assert.That(claims.Issuer, Is.EqualTo(Issuer));
Assert.That(claims.Subject, Is.EqualTo("subject-1"));
Assert.That(claims.Groups, Does.Contain("engineering"));
Assert.That(claims.Roles, Does.Contain("operator"));
}
[Test]
public async Task AuthenticateAsyncEs256TokenAccepted()
{
using var ecdsa = ECDsa.Create(ECCurve.NamedCurves.nistP256);
using IssuerVerificationKey key = CreateEcdsaVerificationKey(ecdsa, "kid-ec");
string jwt = CreateJwt(
"ES256",
"kid-ec",
Issuer,
"[" + Quote("other") + "," + Quote(Audience) + "]",
expiresInSeconds: 3600,
signingInput => ecdsa.SignData(signingInput, HashAlgorithmName.SHA256));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
Assert.That(result.Identity, Is.TypeOf<JwtUserIdentity>());
}
[Test]
public async Task AuthenticateAsyncExpiredTokenRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
Issuer,
Quote(Audience),
expiresInSeconds: -3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task AuthenticateAsyncWrongAudienceRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
Issuer,
Quote("urn:opcua:other-server"),
expiresInSeconds: 3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
}
[Test]
public async Task AuthenticateAsyncWrongIssuerIsNotHandled()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
"https://wrong-issuer.example.test",
Quote(Audience),
expiresInSeconds: 3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.NotHandled));
}
[Test]
public async Task AuthenticateAsyncMalformedTokenRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
AuthenticationResult result = await AuthenticateAsync("not-a-jwt", key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task RegistryAuthenticatesBothIssuersAndNeverUsesAnotherIssuersKeyAsync()
{
const string OtherIssuer = "https://other-issuer.example.test";
using var first = RSA.Create(2048);
using var second = RSA.Create(2048);
using IssuerVerificationKey firstKey = CreateRsaVerificationKey(first, "shared-kid");
using IssuerVerificationKey secondKey = CreateRsaVerificationKey(second, "shared-kid");
var registry = new ServerIdentityRegistry(
new JwtAuthenticator(new StaticKeyResolver(Issuer, firstKey), Audience),
new JwtAuthenticator(new StaticKeyResolver(OtherIssuer, secondKey), Audience));
foreach ((string issuer, RSA signer) in new[] { (Issuer, first), (OtherIssuer, second) })
{
string jwt = CreateJwt(
"RS256", "shared-kid", issuer, Quote(Audience), 3600,
data => signer.SignData(data, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult accepted = await registry.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, Encoding.UTF8.GetBytes(jwt))))
.ConfigureAwait(false);
Assert.That(accepted.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
Assert.That(((IIdentityClaims)accepted.Identity!).Issuer, Is.EqualTo(issuer));
}
string forged = CreateJwt(
"RS256", "shared-kid", Issuer, Quote(Audience), 3600,
data => second.SignData(data, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult rejected = await registry.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, Encoding.UTF8.GetBytes(forged))))
.ConfigureAwait(false);
Assert.That(rejected.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(rejected.Error!.StatusCode, Is.EqualTo(StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task RegistryReplacesTheSameIssuerRatherThanKeepingAnOldSigningKeyAsync()
{
using var oldSigner = RSA.Create(2048);
using var newSigner = RSA.Create(2048);
using IssuerVerificationKey oldKey = CreateRsaVerificationKey(oldSigner, "shared-kid");
using IssuerVerificationKey newKey = CreateRsaVerificationKey(newSigner, "shared-kid");
var registry = new ServerIdentityRegistry(
new JwtAuthenticator(new StaticKeyResolver(Issuer, oldKey), Audience),
new JwtAuthenticator(new StaticKeyResolver(Issuer, newKey), Audience));
string jwt = CreateJwt(
"RS256", "shared-kid", Issuer, Quote(Audience), 3600,
data => oldSigner.SignData(data, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await registry.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, Encoding.UTF8.GetBytes(jwt))))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.StatusCode, Is.EqualTo(StatusCodes.BadIdentityTokenRejected));
string replacement = CreateJwt(
"RS256", "shared-kid", Issuer, Quote(Audience), 3600,
data => newSigner.SignData(data, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult accepted = await registry.AuthenticateAsync(CreateContext(
new IssuedIdentityTokenHandler(Profiles.JwtUserToken, Encoding.UTF8.GetBytes(replacement))))
.ConfigureAwait(false);
Assert.That(accepted.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
Assert.That(((IIdentityClaims)accepted.Identity!).Issuer, Is.EqualTo(Issuer));
}
[Test]
public void JwtUserIdentityExposesTokenAndClaimProperties()
{
var tokenHandler = new IssuedIdentityTokenHandler(
Profiles.JwtUserToken,
Encoding.UTF8.GetBytes("token"));
var identity = new JwtUserIdentity(
tokenHandler,
new Dictionary<string, object?> { ["sub"] = "subject-1" },
["engineering"],
["operator"],
Issuer,
"subject-1");
Assert.That(identity.DisplayName, Is.EqualTo("subject-1"));
Assert.That(identity.PolicyId, Is.EqualTo(tokenHandler.Token.PolicyId ?? string.Empty));
Assert.That(identity.TokenType, Is.EqualTo(UserTokenType.IssuedToken));
Assert.That(identity.IssuedTokenType.Namespace, Is.EqualTo(Profiles.JwtUserToken));
Assert.That(identity.SupportsSignatures, Is.False);
Assert.That(identity.GrantedRoleIds, Is.Empty);
Assert.That(((IUserIdentity)identity).TokenHandler, Is.SameAs(tokenHandler));
}
private static async Task<AuthenticationResult> AuthenticateAsync(
string jwt,
IssuerVerificationKey key)
{
var resolver = new StaticKeyResolver(Issuer, key);
var authenticator = new JwtAuthenticator(resolver, Audience, TimeSpan.Zero);
return await authenticator.AuthenticateAsync(
CreateContext(new IssuedIdentityTokenHandler(
Profiles.JwtUserToken,
Encoding.UTF8.GetBytes(jwt))))
.ConfigureAwait(false);
}
private static AuthenticationContext CreateContext(IUserIdentityTokenHandler handler)
{
return new AuthenticationContext(
handler,
new UserTokenPolicy
{
TokenType = UserTokenType.IssuedToken,
PolicyId = "jwt",
IssuedTokenType = Profiles.JwtUserToken
},
new EndpointDescription { SecurityMode = MessageSecurityMode.SignAndEncrypt },
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create()));
}
private static string CreateJwt(
string algorithm,
string keyId,
string issuer,
string audienceJson,
int expiresInSeconds,
Func<byte[], byte[]> sign)
{
long now = DateTimeOffset.UtcNow.ToUnixTimeSeconds();
string header = "{\"alg\":\"" + algorithm + "\",\"kid\":\"" + keyId + "\",\"typ\":\"JWT\"}";
string payload =
"{\"iss\":\"" +
issuer +
"\",\"sub\":\"subject-1\",\"aud\":" +
audienceJson +
",\"exp\":" +
(now + expiresInSeconds) +
",\"nbf\":" +
(now - 60) +
",\"iat\":" +
(now - 1) +
",\"groups\":[\"engineering\"],\"roles\":[\"operator\"]}";
string signingInput = Base64UrlEncode(Encoding.UTF8.GetBytes(header)) +
"." +
Base64UrlEncode(Encoding.UTF8.GetBytes(payload));
byte[] signature = sign(Encoding.ASCII.GetBytes(signingInput));
return signingInput + "." + Base64UrlEncode(signature);
}
private static string Quote(string value)
{
return "\"" + value + "\"";
}
private static IssuerVerificationKey CreateRsaVerificationKey(RSA rsa, string keyId)
{
RSA? publicKey = null;
try
{
publicKey = RSA.Create();
publicKey.ImportParameters(rsa.ExportParameters(false));
var key = new IssuerVerificationKey(keyId, publicKey, "RS256");
publicKey = null!;
return key;
}
finally
{
publicKey?.Dispose();
}
}
private static IssuerVerificationKey CreateEcdsaVerificationKey(ECDsa ecdsa, string keyId)
{
ECDsa? publicKey = null;
try
{
publicKey = ECDsa.Create(ecdsa.ExportParameters(false));
var key = new IssuerVerificationKey(keyId, publicKey, "ES256");
publicKey = null!;
return key;
}
finally
{
publicKey?.Dispose();
}
}
private static string Base64UrlEncode(byte[] bytes)
{
return Convert.ToBase64String(bytes)
.TrimEnd('=')
.Replace('+', '-')
.Replace('/', '_');
}
private sealed class StaticKeyResolver : IIssuerKeyResolver
{
private readonly IReadOnlyList<IssuerVerificationKey> m_keys;
public StaticKeyResolver(string issuerUri, IssuerVerificationKey key)
{
IssuerUri = issuerUri;
m_keys = [key];
}
public string IssuerUri { get; }
public ValueTask<IReadOnlyList<IIssuerVerificationKey>> GetKeysAsync(
string? keyId,
CancellationToken ct = default)
{
return new ValueTask<IReadOnlyList<IIssuerVerificationKey>>(m_keys);
}
}
}
}