Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/Identity/X509AuthenticatorTests.cs
romanettandClaude Opus 5.5 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

238 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Identity;
using Opc.Ua.Security.Certificates;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Identity
{
[TestFixture]
[Category("Identity")]
public class X509AuthenticatorTests
{
[Test]
public async Task AuthenticateAsyncTrustedCertificateAccepted()
{
using Certificate certificate = CreateCertificate("CN=TrustedUser");
var validator = new TestCertificateValidator(CertificateValidationResult.Success);
var authenticator = new X509Authenticator(validator);
AuthenticationResult result = await authenticator.AuthenticateAsync(
CreateContext(CreateHandler(certificate)))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
Assert.That(result.Identity, Is.Not.Null);
Assert.That(result.Identity.TokenType, Is.EqualTo(UserTokenType.Certificate));
Assert.That(validator.LastTrustList, Is.EqualTo(TrustListIdentifier.Users));
}
[Test]
public async Task AuthenticateAsyncUntrustedCertificateRejected()
{
using Certificate certificate = CreateCertificate("CN=UntrustedUser");
var validationResult = new CertificateValidationResult(
false,
StatusCodes.BadCertificateUntrusted,
[],
false);
var authenticator = new X509Authenticator(new TestCertificateValidator(validationResult));
AuthenticationResult result = await authenticator.AuthenticateAsync(
CreateContext(CreateHandler(certificate)))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task AuthenticateAsyncSubjectExtractedIntoClaims()
{
using Certificate certificate = CreateCertificate("CN=ClaimUser");
var authenticator = new X509Authenticator(
new TestCertificateValidator(CertificateValidationResult.Success));
AuthenticationResult result = await authenticator.AuthenticateAsync(
CreateContext(CreateHandler(certificate)))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
var claims = result.Identity as IIdentityClaims;
Assert.That(claims, Is.Not.Null);
Assert.That(claims.Subject, Is.EqualTo(certificate.Subject));
Assert.That(claims.Claims["x509.subject"], Is.EqualTo(certificate.Subject));
}
[Test]
public async Task AuthenticateAsyncNonX509TokenIsNotHandled()
{
var authenticator = new X509Authenticator(
new TestCertificateValidator(CertificateValidationResult.Success));
var context = new AuthenticationContext(
new AnonymousIdentityTokenHandler(),
new UserTokenPolicy { TokenType = UserTokenType.Anonymous },
new EndpointDescription { SecurityMode = MessageSecurityMode.SignAndEncrypt },
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create()));
AuthenticationResult result = await authenticator.AuthenticateAsync(context)
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.NotHandled));
}
[Test]
public async Task AuthenticateAsyncEmptyCertificateRejectedAsInvalid()
{
var authenticator = new X509Authenticator(
new TestCertificateValidator(CertificateValidationResult.Success));
var handler = new X509IdentityTokenHandler(new X509IdentityToken
{
PolicyId = "x509",
CertificateData = ByteString.Empty
});
AuthenticationResult result = await authenticator.AuthenticateAsync(CreateContext(handler))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncUseNotAllowedMapsToInvalidIdentityToken()
{
using Certificate certificate = CreateCertificate("CN=WrongUse");
var validationResult = new CertificateValidationResult(
false,
StatusCodes.BadCertificateUseNotAllowed,
[],
false);
var authenticator = new X509Authenticator(new TestCertificateValidator(validationResult));
AuthenticationResult result = await authenticator.AuthenticateAsync(
CreateContext(CreateHandler(certificate)))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncDelegateVerifierAcceptsRejectsAndMapsServiceResultException()
{
using Certificate certificate = CreateCertificate("CN=DelegateUser");
X509IdentityTokenHandler handler = CreateHandler(certificate);
var acceptedIdentity = new UserIdentity("delegate", []);
var accepting = new X509Authenticator(
(h, ct) => new ValueTask<IUserIdentity>(acceptedIdentity));
var nullVerifier = new X509Authenticator(
(h, ct) => new ValueTask<IUserIdentity>((IUserIdentity)null!));
var throwing = new X509Authenticator(
(h, ct) => throw new ServiceResultException(StatusCodes.BadIdentityTokenInvalid));
AuthenticationResult accepted = await accepting.AuthenticateAsync(CreateContext(handler))
.ConfigureAwait(false);
AuthenticationResult rejected = await nullVerifier.AuthenticateAsync(CreateContext(handler))
.ConfigureAwait(false);
AuthenticationResult mapped = await throwing.AuthenticateAsync(CreateContext(handler))
.ConfigureAwait(false);
Assert.That(accepted.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
Assert.That(accepted.Identity, Is.SameAs(acceptedIdentity));
Assert.That(rejected.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(mapped.Error!.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
private static Certificate CreateCertificate(string subject)
{
return CertificateBuilder.Create(subject)
.SetRSAKeySize(CertificateFactory.DefaultKeySize)
.CreateForRSA();
}
private static X509IdentityTokenHandler CreateHandler(Certificate certificate)
{
return new X509IdentityTokenHandler(new X509IdentityToken
{
PolicyId = "x509",
CertificateData = certificate.RawData.ToByteString()
});
}
private static AuthenticationContext CreateContext(X509IdentityTokenHandler handler)
{
return new AuthenticationContext(
handler,
new UserTokenPolicy { TokenType = handler.TokenType, PolicyId = "x509" },
new EndpointDescription { SecurityMode = MessageSecurityMode.SignAndEncrypt },
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create()));
}
private sealed class TestCertificateValidator : ICertificateValidatorEx
{
private readonly CertificateValidationResult m_result;
public TestCertificateValidator(CertificateValidationResult result)
{
m_result = result;
}
public TrustListIdentifier? LastTrustList { get; private set; }
public Func<Certificate, ServiceResult, bool>? AcceptError { get; set; }
public Task<CertificateValidationResult> ValidateAsync(
CertificateCollection chain,
TrustListIdentifier? trustList = null,
Security.Certificates.CertificateValidationOptions? options = null,
CancellationToken ct = default)
{
LastTrustList = trustList;
return Task.FromResult(m_result);
}
public Task<CertificateValidationResult> ValidateAsync(
Certificate certificate,
TrustListIdentifier? trustList = null,
CancellationToken ct = default)
{
LastTrustList = trustList;
return Task.FromResult(m_result);
}
}
}
}