mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-27 04:59:55 +08:00
romanettandClaude Opus 5.5
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
963 lines
45 KiB
C#
963 lines
45 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Collections.Generic;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
[TestFixture]
|
|
[Category("Aggregators")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public class MinMaxAggregateCalculatorTests
|
|
{
|
|
private static readonly DateTimeUtc s_baseTime = new(2024, 1, 1, 0, 0, 0);
|
|
private ITelemetryContext m_telemetry;
|
|
private AggregateConfiguration m_configuration;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_telemetry = NUnitTelemetryContext.Create();
|
|
m_configuration = new AggregateConfiguration
|
|
{
|
|
TreatUncertainAsBad = false,
|
|
PercentDataBad = 100,
|
|
PercentDataGood = 100,
|
|
UseSlopedExtrapolation = false
|
|
};
|
|
}
|
|
|
|
private static List<DataValue> CreateDataValues(
|
|
DateTimeUtc startTime, double[] values, double intervalMs = 1000)
|
|
{
|
|
var dataValues = new List<DataValue>();
|
|
for (int i = 0; i < values.Length; i++)
|
|
{
|
|
dataValues.Add(new DataValue(
|
|
new Variant(values[i]),
|
|
StatusCodes.Good,
|
|
startTime.AddMilliseconds(i * intervalMs),
|
|
startTime.AddMilliseconds(i * intervalMs)));
|
|
}
|
|
return dataValues;
|
|
}
|
|
|
|
private DataValue ComputeAggregate(
|
|
NodeId aggregateId,
|
|
List<DataValue> values,
|
|
DateTimeUtc startTime,
|
|
DateTimeUtc endTime,
|
|
double processingInterval)
|
|
{
|
|
IAggregateCalculator calculator = Aggregators.CreateStandardCalculator(
|
|
aggregateId, startTime, endTime, processingInterval, false, m_configuration, m_telemetry)!;
|
|
|
|
foreach (DataValue value in values)
|
|
{
|
|
calculator!.QueueRawValue(value);
|
|
}
|
|
|
|
var results = new List<DataValue>();
|
|
bool hasData = true;
|
|
while (hasData)
|
|
{
|
|
bool _hasresult = calculator!.TryGetProcessedValue(true, out DataValue result);
|
|
if (_hasresult)
|
|
{
|
|
results.Add(result);
|
|
}
|
|
else
|
|
{
|
|
hasData = false;
|
|
}
|
|
}
|
|
|
|
return results.Count > 0 ? results[0] : default;
|
|
}
|
|
|
|
private static DataValue RawValue(DateTimeUtc timestamp, double value)
|
|
{
|
|
return new DataValue(new Variant(value), StatusCodes.Good, timestamp, timestamp);
|
|
}
|
|
|
|
private DataValue ComputeSingleInterval(
|
|
NodeId aggregateId,
|
|
List<DataValue> ascendingValues,
|
|
DateTimeUtc startTime,
|
|
DateTimeUtc endTime,
|
|
double processingInterval)
|
|
{
|
|
IAggregateCalculator calculator = Aggregators.CreateStandardCalculator(
|
|
aggregateId, startTime, endTime, processingInterval, false, m_configuration, m_telemetry)!;
|
|
|
|
// Reverse reads (endTime earlier than startTime) require the raw stream to be
|
|
// queued latest-first; forward reads require earliest-first.
|
|
if (endTime < startTime)
|
|
{
|
|
for (int index = ascendingValues.Count - 1; index >= 0; index--)
|
|
{
|
|
calculator!.QueueRawValue(ascendingValues[index]);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
foreach (DataValue value in ascendingValues)
|
|
{
|
|
calculator!.QueueRawValue(value);
|
|
}
|
|
}
|
|
|
|
var results = new List<DataValue>();
|
|
while (calculator!.TryGetProcessedValue(true, out DataValue result))
|
|
{
|
|
results.Add(result);
|
|
}
|
|
|
|
Assert.That(results, Has.Count.EqualTo(1));
|
|
return results[0];
|
|
}
|
|
|
|
[Test]
|
|
public void Minimum_ReturnsSmallestValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 5, 20, 3, 15, 3];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Minimum,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void Maximum_ReturnsLargestValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 50];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Maximum,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void Range_ReturnsMaxMinusMIn()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 50];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Range,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(40.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumActualTime_ReturnsTimestampOfMin()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 5, 20, 3, 15, 3];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MinimumActualTime,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumActualTime_ReturnsTimestampOfMax()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 50];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MaximumActualTime,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void Minimum_SingleValue_ReturnsThatValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [42, 42];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(4000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Minimum,
|
|
dataValues, startTime, endTime, 4000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(42.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void Maximum_NegativeValues_ReturnsLargest()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [-10, -5, -20, -3, -15, -3];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Maximum,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(-3.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void Range_AllSameValue_ReturnsZero()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [7, 7, 7, 7];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(8000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Range,
|
|
dataValues, startTime, endTime, 8000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.Zero.Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void Minimum2_ReturnsSmallestValueIncludingSimpleBounds()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [50, 3, 20, 40, 15, 15];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Minimum2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void Maximum2_ReturnsLargestValueIncludingSimpleBounds()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 15];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Maximum2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void Range2_ReturnsMaximum2MinusMinimum2()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 3, 15, 15];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Range2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(47.0).Within(0.0001));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Part 13 Tables 62 and 67: Range and Range2 return the source data
|
|
/// type; Double only when the range overflows it.
|
|
/// </summary>
|
|
[TestCase("Range")]
|
|
[TestCase("Range2")]
|
|
public void Range_ReturnsSourceDataType(string aggregateName)
|
|
{
|
|
NodeId aggregateId = aggregateName == "Range"
|
|
? ObjectIds.AggregateFunction_Range
|
|
: ObjectIds.AggregateFunction_Range2;
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
var ints = new List<DataValue>();
|
|
var sbytes = new List<DataValue>();
|
|
int[] values = [10, 50, 20, 3, 15, 15];
|
|
for (int i = 0; i < values.Length; i++)
|
|
{
|
|
DateTimeUtc timestamp = startTime.AddMilliseconds(500 + (i * 2000));
|
|
ints.Add(new DataValue(new Variant(values[i]), StatusCodes.Good, timestamp, timestamp));
|
|
sbytes.Add(new DataValue(
|
|
new Variant((sbyte)(i % 2 == 0 ? -100 : 100)),
|
|
StatusCodes.Good,
|
|
timestamp,
|
|
timestamp));
|
|
}
|
|
|
|
DataValue intResult = ComputeAggregate(aggregateId, ints, startTime, endTime, 12000);
|
|
DataValue sbyteResult = ComputeAggregate(aggregateId, sbytes, startTime, endTime, 12000);
|
|
|
|
Assert.That(intResult.WrappedValue.TypeInfo.BuiltInType, Is.EqualTo(BuiltInType.Int32));
|
|
Assert.That(intResult.WrappedValue.TryGetValue(out int range), Is.True);
|
|
Assert.That(range, Is.EqualTo(47));
|
|
// 200 does not fit into SByte.
|
|
Assert.That(sbyteResult.WrappedValue.TypeInfo.BuiltInType, Is.EqualTo(BuiltInType.Double));
|
|
Assert.That((double)sbyteResult.WrappedValue.ConvertToDouble(), Is.EqualTo(200.0).Within(0.0001));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumActualTime2_ReturnsMinimumValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [50, 3, 20, 40, 15, 15];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MinimumActualTime2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
// Part 13 §5.4.3.17: timestamp is the actual time of the minimum value (within the range).
|
|
Assert.That(result.SourceTimestamp, Is.GreaterThanOrEqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.LessThanOrEqualTo(endTime));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumActualTime2_ReturnsMaximumValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 15];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MaximumActualTime2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That(result.WrappedValue.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.GreaterThanOrEqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.LessThanOrEqualTo(endTime));
|
|
}
|
|
|
|
// Regression tests for the timestamp provenance of ComputeMinMax and ComputeMinMax2.
|
|
// Commit a711c4b28 removed the `else` clauses that returned the region timestamp,
|
|
// relying only on the `if (returnActualTime)` branch returning early. The following
|
|
// tests pin down both sides of that control flow so a future control-flow cleanup
|
|
// cannot silently swap which timestamp is reported: the *ActualTime variants must
|
|
// keep reporting the timestamp of the raw sample that was selected as the minimum or
|
|
// maximum, while the plain variants must keep reporting the processing region's own
|
|
// timestamp, never the raw sample's timestamp.
|
|
|
|
[Test]
|
|
public void MinimumActualTimeSourceTimestampMatchesSelectedMinimumValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 5, 20, 3, 15, 3];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc expectedMinimumTimestamp = firstValueTime.AddMilliseconds(3 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MinimumActualTime,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
// The timestamp must come from the raw sample that produced the minimum,
|
|
// not from the processing region's own start/end timestamp.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(expectedMinimumTimestamp));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(expectedMinimumTimestamp));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(endTime));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumActualTimeSourceTimestampMatchesSelectedMaximumValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 50];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc expectedMaximumTimestamp = firstValueTime.AddMilliseconds(1 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MaximumActualTime,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
// The timestamp must come from the raw sample that produced the maximum,
|
|
// not from the processing region's own start/end timestamp.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(expectedMaximumTimestamp));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(expectedMaximumTimestamp));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(endTime));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumSourceTimestampMatchesSliceStartNotSelectedValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 5, 20, 3, 15, 3];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc rawMinimumTimestamp = firstValueTime.AddMilliseconds(3 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Minimum,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
// The plain Minimum aggregate reports the processing region's own timestamp
|
|
// (the slice start), never the timestamp of the raw sample that was selected.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(rawMinimumTimestamp));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumSourceTimestampMatchesSliceStartNotSelectedValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 50];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc rawMaximumTimestamp = firstValueTime.AddMilliseconds(1 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Maximum,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
// The plain Maximum aggregate reports the processing region's own timestamp
|
|
// (the slice start), never the timestamp of the raw sample that was selected.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(rawMaximumTimestamp));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumActualTime2SourceTimestampMatchesSelectedMinimumValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 5, 20, 3, 15, 3];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc expectedMinimumTimestamp = firstValueTime.AddMilliseconds(3 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MinimumActualTime2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
// Same provenance guarantee as MinimumActualTime, but exercised through
|
|
// ComputeMinMax2's simple-bounds code path.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(expectedMinimumTimestamp));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(expectedMinimumTimestamp));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(endTime));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumActualTime2SourceTimestampMatchesSelectedMaximumValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 50];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc expectedMaximumTimestamp = firstValueTime.AddMilliseconds(1 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_MaximumActualTime2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
// Same provenance guarantee as MaximumActualTime, but exercised through
|
|
// ComputeMinMax2's simple-bounds code path.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(expectedMaximumTimestamp));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(expectedMaximumTimestamp));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(endTime));
|
|
}
|
|
|
|
[Test]
|
|
public void Minimum2SourceTimestampMatchesSliceStartNotSelectedValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 5, 20, 3, 15, 3];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc rawMinimumTimestamp = firstValueTime.AddMilliseconds(3 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Minimum2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
// The plain Minimum2 aggregate reports the processing region's own timestamp
|
|
// (the slice start), never the timestamp of the raw sample that was selected.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(rawMinimumTimestamp));
|
|
}
|
|
|
|
[Test]
|
|
public void Maximum2SourceTimestampMatchesSliceStartNotSelectedValue()
|
|
{
|
|
var startTime = new DateTimeUtc(2024, 1, 1, 0, 0, 0);
|
|
DateTimeUtc firstValueTime = startTime.AddMilliseconds(500);
|
|
double[] values = [10, 50, 20, 30, 15, 50];
|
|
List<DataValue> dataValues = CreateDataValues(firstValueTime, values, 2000);
|
|
DateTimeUtc endTime = startTime.AddMilliseconds(12000);
|
|
DateTimeUtc rawMaximumTimestamp = firstValueTime.AddMilliseconds(1 * 2000);
|
|
|
|
DataValue result = ComputeAggregate(
|
|
ObjectIds.AggregateFunction_Maximum2,
|
|
dataValues, startTime, endTime, 12000);
|
|
|
|
Assert.That(result.IsNull, Is.False);
|
|
Assert.That((double)result.WrappedValue.ConvertToDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
// The plain Maximum2 aggregate reports the processing region's own timestamp
|
|
// (the slice start), never the timestamp of the raw sample that was selected.
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(rawMaximumTimestamp));
|
|
}
|
|
|
|
// Raw-versus-Calculated provenance tests for the Minimum/Maximum family.
|
|
// Part 13 §5.4.3.10/§5.4.3.11 return the min/max sample stamped at the start of the
|
|
// interval and mark it Good, Raw when the selected sample sits on that start timestamp,
|
|
// otherwise Good, Calculated. Part 11/Part 13 §5.4.2.2 define the interval start for a
|
|
// reverse read (startTime later than endTime) as the later timestamp, so the request
|
|
// direction - not the chronological lower bound - decides Raw versus Calculated.
|
|
// Each dataset spans the full interval so the Partial bit is never set, letting the
|
|
// tests assert the exact aggregate info bits.
|
|
|
|
[Test]
|
|
public void MaximumForwardWithMaximumAtIntervalStartIsRaw()
|
|
{
|
|
DateTimeUtc endTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 50),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 10),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 30),
|
|
RawValue(endTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Maximum, values, s_baseTime, endTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(s_baseTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(s_baseTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumForwardWithMaximumNotAtIntervalStartIsCalculated()
|
|
{
|
|
DateTimeUtc endTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 50),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 30),
|
|
RawValue(endTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Maximum, values, s_baseTime, endTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(s_baseTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Calculated));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumReverseWithMaximumAtRequestIntervalStartIsRaw()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 40),
|
|
RawValue(startTime, 50)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Maximum, values, startTime, s_baseTime, 12000);
|
|
|
|
// The maximum sits on the later timestamp, which is the reverse interval start,
|
|
// so it must be reported Good, Raw (not Calculated) and stamped at that timestamp.
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumReverseWithMaximumNotAtRequestIntervalStartIsCalculated()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 50),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 20),
|
|
RawValue(startTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Maximum, values, startTime, s_baseTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Calculated));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumForwardWithMinimumAtIntervalStartIsRaw()
|
|
{
|
|
DateTimeUtc endTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 3),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 10),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 30),
|
|
RawValue(endTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Minimum, values, s_baseTime, endTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(s_baseTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(s_baseTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumForwardWithMinimumNotAtIntervalStartIsCalculated()
|
|
{
|
|
DateTimeUtc endTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 3),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 30),
|
|
RawValue(endTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Minimum, values, s_baseTime, endTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(s_baseTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Calculated));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumReverseWithMinimumAtRequestIntervalStartIsRaw()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 40),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 20),
|
|
RawValue(startTime, 3)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Minimum, values, startTime, s_baseTime, 12000);
|
|
|
|
// The minimum sits on the later timestamp (the reverse interval start), so it must
|
|
// be reported Good, Raw and stamped at that timestamp.
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumReverseWithMinimumNotAtRequestIntervalStartIsCalculated()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 3),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 30),
|
|
RawValue(startTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Minimum, values, startTime, s_baseTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Calculated));
|
|
}
|
|
|
|
[Test]
|
|
public void MaximumActualTimeReverseReportsActualSampleTimeAsRaw()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
DateTimeUtc expectedMaximumTimestamp = s_baseTime.AddMilliseconds(3000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(expectedMaximumTimestamp, 50),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 20),
|
|
RawValue(startTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_MaximumActualTime, values, startTime, s_baseTime, 12000);
|
|
|
|
// The ActualTime variant reports the timestamp of the raw sample, not the interval
|
|
// timestamp, and the raw sample is Good, Raw regardless of read direction.
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(expectedMaximumTimestamp));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(expectedMaximumTimestamp));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void MinimumActualTimeReverseReportsActualSampleTimeAsRaw()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
DateTimeUtc expectedMinimumTimestamp = s_baseTime.AddMilliseconds(3000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(expectedMinimumTimestamp, 3),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 30),
|
|
RawValue(startTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_MinimumActualTime, values, startTime, s_baseTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(expectedMinimumTimestamp));
|
|
Assert.That(result.ServerTimestamp, Is.EqualTo(expectedMinimumTimestamp));
|
|
Assert.That(result.SourceTimestamp, Is.Not.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void Maximum2ForwardWithMaximumAtIntervalStartIsRaw()
|
|
{
|
|
DateTimeUtc endTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 50),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 40),
|
|
RawValue(endTime, 45)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Maximum2, values, s_baseTime, endTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(s_baseTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void Maximum2ReverseWithMaximumAtRequestIntervalStartIsRaw()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 40),
|
|
RawValue(startTime, 50)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Maximum2, values, startTime, s_baseTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void Maximum2ReverseWithMaximumNotAtRequestIntervalStartIsCalculated()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 10),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 50),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 20),
|
|
RawValue(startTime, 40)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Maximum2, values, startTime, s_baseTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(50.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Calculated));
|
|
}
|
|
|
|
[Test]
|
|
public void Minimum2ReverseWithMinimumAtRequestIntervalStartIsRaw()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 40),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 30),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 15),
|
|
RawValue(startTime, 3)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Minimum2, values, startTime, s_baseTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Raw));
|
|
}
|
|
|
|
[Test]
|
|
public void Minimum2ReverseWithMinimumNotAtRequestIntervalStartIsCalculated()
|
|
{
|
|
DateTimeUtc startTime = s_baseTime.AddMilliseconds(12000);
|
|
var values = new List<DataValue>
|
|
{
|
|
RawValue(s_baseTime, 40),
|
|
RawValue(s_baseTime.AddMilliseconds(3000), 3),
|
|
RawValue(s_baseTime.AddMilliseconds(6000), 20),
|
|
RawValue(s_baseTime.AddMilliseconds(9000), 30),
|
|
RawValue(startTime, 35)
|
|
};
|
|
|
|
DataValue result = ComputeSingleInterval(
|
|
ObjectIds.AggregateFunction_Minimum2, values, startTime, s_baseTime, 12000);
|
|
|
|
Assert.That(result.WrappedValue.ConvertToDouble().GetDouble(), Is.EqualTo(3.0).Within(0.0001));
|
|
Assert.That(result.SourceTimestamp, Is.EqualTo(startTime));
|
|
Assert.That(result.StatusCode.AggregateBits, Is.EqualTo(AggregateBits.Calculated));
|
|
}
|
|
}
|
|
}
|