mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 08:41:51 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
401 lines
16 KiB
C#
401 lines
16 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
|
|
// CA2000: test code; the manager and any monitored items it owns are torn down
|
|
// with the fixture.
|
|
#pragma warning disable CA2000
|
|
|
|
namespace Opc.Ua.Server.Tests.NodeManager
|
|
{
|
|
/// <summary>
|
|
/// Deterministic, offline unit tests for <see cref="SamplingGroupManager"/>
|
|
/// covering construction, the event-filter creation path and the lifecycle
|
|
/// helpers, without starting the background sampling loop.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("NodeManager")]
|
|
[Category("SamplingGroupManager")]
|
|
[Parallelizable(ParallelScope.All)]
|
|
public class SamplingGroupManagerTests
|
|
{
|
|
private static SamplingGroupManager CreateManager(
|
|
out Mock<IServerInternal> mockServer,
|
|
IEnumerable<SamplingRateGroup>? samplingRates = null)
|
|
{
|
|
mockServer = DeterministicServerMock.Create(out _);
|
|
var mockNodeManager = new Mock<IAsyncNodeManager>();
|
|
return new SamplingGroupManager(
|
|
mockServer.Object,
|
|
mockNodeManager.Object,
|
|
100,
|
|
200,
|
|
samplingRates ?? []);
|
|
}
|
|
|
|
private static OperationContext SessionlessContext()
|
|
{
|
|
return new OperationContext(
|
|
new RequestHeader(), null, RequestType.CreateMonitoredItems, RequestLifetime.None);
|
|
}
|
|
|
|
private static OperationContext SessionContext()
|
|
{
|
|
return new OperationContext(
|
|
new RequestHeader(),
|
|
null!,
|
|
RequestType.CreateMonitoredItems,
|
|
RequestLifetime.None,
|
|
new Mock<ISession>().Object);
|
|
}
|
|
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public void ModifyingAnUnregisteredItemDoesNotRestartSampling(bool previouslyRegistered)
|
|
{
|
|
var item = new Mock<ISampledDataChangeMonitoredItem>();
|
|
item.SetupGet(value => value.MonitoredItemType).Returns(MonitoredItemTypeMask.DataChange);
|
|
item.SetupGet(value => value.MonitoringMode).Returns(MonitoringMode.Reporting);
|
|
item.SetupGet(value => value.MinimumSamplingInterval).Returns(1);
|
|
item.SetupGet(value => value.SamplingInterval).Returns(1000);
|
|
using OperationContext context = SessionContext();
|
|
using (SamplingGroupManager manager = CreateManager(out _))
|
|
{
|
|
if (previouslyRegistered)
|
|
{
|
|
manager.StartMonitoring(context, item.Object);
|
|
manager.StopMonitoring(item.Object);
|
|
}
|
|
|
|
manager.ModifyMonitoring(context, item.Object);
|
|
}
|
|
|
|
item.Verify(
|
|
value => value.SetSamplingInterval(It.IsAny<double>()),
|
|
Times.Exactly(previouslyRegistered ? 1 : 0));
|
|
item.Verify(value => value.Dispose(), Times.Never);
|
|
}
|
|
|
|
[Test]
|
|
public void ModifyingARegisteredDisabledItemStartsSampling()
|
|
{
|
|
var item = new Mock<ISampledDataChangeMonitoredItem>();
|
|
MonitoringMode mode = MonitoringMode.Disabled;
|
|
item.SetupGet(value => value.MonitoredItemType).Returns(MonitoredItemTypeMask.DataChange);
|
|
item.SetupGet(value => value.MonitoringMode).Returns(() => mode);
|
|
item.SetupGet(value => value.MinimumSamplingInterval).Returns(1);
|
|
item.SetupGet(value => value.SamplingInterval).Returns(1000);
|
|
using OperationContext context = SessionContext();
|
|
using (SamplingGroupManager manager = CreateManager(out _))
|
|
{
|
|
manager.StartMonitoring(context, item.Object);
|
|
item.Verify(value => value.SetSamplingInterval(It.IsAny<double>()), Times.Never);
|
|
|
|
mode = MonitoringMode.Reporting;
|
|
manager.ModifyMonitoring(context, item.Object);
|
|
item.Verify(value => value.SetSamplingInterval(1000), Times.Once);
|
|
}
|
|
|
|
item.Verify(value => value.Dispose(), Times.Once);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that sampling-group manager construction rejects a null server.
|
|
/// </summary>
|
|
[Test]
|
|
public void ConstructorWithNullServerThrows()
|
|
{
|
|
var nm = new Mock<IAsyncNodeManager>();
|
|
Assert.That(
|
|
() => new SamplingGroupManager(
|
|
null!, nm.Object, 100, 200, []),
|
|
Throws.TypeOf<ArgumentNullException>());
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that sampling-group manager construction rejects a null node manager.
|
|
/// </summary>
|
|
[Test]
|
|
public void ConstructorWithNullNodeManagerThrows()
|
|
{
|
|
Mock<IServerInternal> mockServer = DeterministicServerMock.Create(out _);
|
|
Assert.That(
|
|
() => new SamplingGroupManager(
|
|
mockServer.Object, null!, 100, 200, []),
|
|
Throws.TypeOf<ArgumentNullException>());
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that an empty sampling-rate collection selects the default rates.
|
|
/// </summary>
|
|
[Test]
|
|
public void ConstructorWithEmptySamplingRatesUsesDefaults()
|
|
{
|
|
using SamplingGroupManager manager = CreateManager(
|
|
out _, []);
|
|
|
|
Assert.That(manager, Is.Not.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a null sampling-rate collection selects the default rates.
|
|
/// </summary>
|
|
[Test]
|
|
public void ConstructorWithNullSamplingRatesUsesDefaults()
|
|
{
|
|
Mock<IServerInternal> mockServer = DeterministicServerMock.Create(out _);
|
|
var nm = new Mock<IAsyncNodeManager>();
|
|
|
|
using var manager = new SamplingGroupManager(
|
|
mockServer.Object, nm.Object, 100, 200, null!);
|
|
|
|
Assert.That(manager, Is.Not.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that creating a monitored item with an event filter creates an exception-based item.
|
|
/// </summary>
|
|
[Test]
|
|
public void CreateMonitoredItemWithEventFilterCreatesExceptionBasedItem()
|
|
{
|
|
using SamplingGroupManager manager = CreateManager(out _);
|
|
var filter = new EventFilter();
|
|
|
|
var itemToCreate = new MonitoredItemCreateRequest
|
|
{
|
|
ItemToMonitor = new ReadValueId(),
|
|
MonitoringMode = MonitoringMode.Reporting,
|
|
RequestedParameters = new MonitoringParameters
|
|
{
|
|
ClientHandle = 1,
|
|
SamplingInterval = 1000,
|
|
QueueSize = 5,
|
|
DiscardOldest = true,
|
|
Filter = new ExtensionObject(filter)
|
|
}
|
|
};
|
|
ISampledDataChangeMonitoredItem item = manager.CreateMonitoredItem(
|
|
SessionlessContext(),
|
|
1,
|
|
1000.0,
|
|
TimestampsToReturn.Both,
|
|
7,
|
|
null!,
|
|
itemToCreate,
|
|
filter,
|
|
new Range(),
|
|
0,
|
|
false);
|
|
|
|
Assert.That(item, Is.Not.Null);
|
|
Assert.That(item, Is.InstanceOf<MonitoredItem>());
|
|
Assert.That(item.SamplingInterval, Is.Zero);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that stopping monitoring removes an exception-based item.
|
|
/// </summary>
|
|
[Test]
|
|
public void StopMonitoringRemovesExceptionBasedItem()
|
|
{
|
|
using SamplingGroupManager manager = CreateManager(out _);
|
|
var filter = new EventFilter();
|
|
|
|
var itemToCreate = new MonitoredItemCreateRequest
|
|
{
|
|
ItemToMonitor = new ReadValueId(),
|
|
MonitoringMode = MonitoringMode.Reporting,
|
|
RequestedParameters = new MonitoringParameters
|
|
{
|
|
ClientHandle = 1,
|
|
SamplingInterval = 1000,
|
|
QueueSize = 5,
|
|
DiscardOldest = true,
|
|
Filter = new ExtensionObject(filter)
|
|
}
|
|
};
|
|
ISampledDataChangeMonitoredItem item = manager.CreateMonitoredItem(
|
|
SessionlessContext(),
|
|
1,
|
|
1000.0,
|
|
TimestampsToReturn.Both,
|
|
8,
|
|
null!,
|
|
itemToCreate,
|
|
filter,
|
|
new Range(),
|
|
0,
|
|
false);
|
|
|
|
Assert.That(() => manager.StopMonitoring(item), Throws.Nothing);
|
|
// second stop is a no-op because the item is no longer tracked.
|
|
Assert.That(() => manager.StopMonitoring(item), Throws.Nothing);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that shutting down a manager without sampling groups is safe.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShutdownWithoutGroupsIsSafe()
|
|
{
|
|
using SamplingGroupManager manager = CreateManager(out _);
|
|
|
|
Assert.DoesNotThrow(manager.Shutdown);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that applying changes without sampling groups is safe.
|
|
/// </summary>
|
|
[Test]
|
|
public void ApplyChangesWithoutGroupsIsSafe()
|
|
{
|
|
using SamplingGroupManager manager = CreateManager(out _);
|
|
|
|
Assert.DoesNotThrow(manager.ApplyChanges);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that create and modify retain original filters and request objects separately from revised filters.
|
|
/// </summary>
|
|
[Test]
|
|
public void RevisedFiltersPreserveOriginalFiltersAndRequests()
|
|
{
|
|
using SamplingGroupManager manager = CreateManager(out _);
|
|
var originalCreateFilter = new DataChangeFilter
|
|
{
|
|
DeadbandType = (uint)DeadbandType.Absolute,
|
|
DeadbandValue = 1
|
|
};
|
|
var revisedCreateFilter = new DataChangeFilter
|
|
{
|
|
DeadbandType = (uint)DeadbandType.Absolute,
|
|
DeadbandValue = 2
|
|
};
|
|
var itemToCreate = new MonitoredItemCreateRequest
|
|
{
|
|
ItemToMonitor = new ReadValueId
|
|
{
|
|
NodeId = new NodeId("V", 1),
|
|
AttributeId = Attributes.Value
|
|
},
|
|
MonitoringMode = MonitoringMode.Reporting,
|
|
RequestedParameters = new MonitoringParameters
|
|
{
|
|
ClientHandle = 1,
|
|
SamplingInterval = 1000,
|
|
QueueSize = 5,
|
|
DiscardOldest = true,
|
|
Filter = new ExtensionObject(originalCreateFilter)
|
|
}
|
|
};
|
|
MonitoringParameters createParameters = itemToCreate.RequestedParameters;
|
|
using OperationContext context = SessionContext();
|
|
|
|
ISampledDataChangeMonitoredItem item = manager.CreateMonitoredItem(
|
|
context,
|
|
1,
|
|
1000,
|
|
TimestampsToReturn.Both,
|
|
9,
|
|
null!,
|
|
itemToCreate,
|
|
revisedCreateFilter,
|
|
new Range(),
|
|
0,
|
|
false);
|
|
|
|
IStoredMonitoredItem stored = item.ToStorableMonitoredItem();
|
|
Assert.That(stored.OriginalFilter, Is.SameAs(originalCreateFilter));
|
|
Assert.That(stored.FilterToUse, Is.SameAs(revisedCreateFilter));
|
|
Assert.That(itemToCreate.RequestedParameters, Is.SameAs(createParameters));
|
|
Assert.That(
|
|
createParameters.Filter.TryGetValue(out MonitoringFilter? createRequestFilter),
|
|
Is.True);
|
|
Assert.That(createRequestFilter, Is.SameAs(originalCreateFilter));
|
|
Assert.That(originalCreateFilter.DeadbandType, Is.EqualTo((uint)DeadbandType.Absolute));
|
|
Assert.That(originalCreateFilter.DeadbandValue, Is.EqualTo(1));
|
|
Assert.That(createParameters.ClientHandle, Is.EqualTo(1));
|
|
Assert.That(createParameters.SamplingInterval, Is.EqualTo(1000));
|
|
Assert.That(createParameters.QueueSize, Is.EqualTo(5));
|
|
Assert.That(createParameters.DiscardOldest, Is.True);
|
|
|
|
var originalModifyFilter = new DataChangeFilter
|
|
{
|
|
DeadbandType = (uint)DeadbandType.Absolute,
|
|
DeadbandValue = 3
|
|
};
|
|
var revisedModifyFilter = new DataChangeFilter
|
|
{
|
|
DeadbandType = (uint)DeadbandType.Absolute,
|
|
DeadbandValue = 4
|
|
};
|
|
var itemToModify = new MonitoredItemModifyRequest
|
|
{
|
|
RequestedParameters = new MonitoringParameters
|
|
{
|
|
ClientHandle = 2,
|
|
SamplingInterval = 1000,
|
|
QueueSize = 5,
|
|
DiscardOldest = true,
|
|
Filter = new ExtensionObject(originalModifyFilter)
|
|
}
|
|
};
|
|
MonitoringParameters modifyParameters = itemToModify.RequestedParameters;
|
|
|
|
ServiceResult result = manager.ModifyMonitoredItem(
|
|
context,
|
|
TimestampsToReturn.Both,
|
|
item,
|
|
itemToModify,
|
|
revisedModifyFilter,
|
|
new Range())!;
|
|
|
|
Assert.That(ServiceResult.IsGood(result), Is.True);
|
|
stored = item.ToStorableMonitoredItem();
|
|
Assert.That(stored.OriginalFilter, Is.SameAs(originalModifyFilter));
|
|
Assert.That(stored.FilterToUse, Is.SameAs(revisedModifyFilter));
|
|
Assert.That(itemToModify.RequestedParameters, Is.SameAs(modifyParameters));
|
|
Assert.That(
|
|
modifyParameters.Filter.TryGetValue(out MonitoringFilter? modifyRequestFilter),
|
|
Is.True);
|
|
Assert.That(modifyRequestFilter, Is.SameAs(originalModifyFilter));
|
|
Assert.That(originalModifyFilter.DeadbandType, Is.EqualTo((uint)DeadbandType.Absolute));
|
|
Assert.That(originalModifyFilter.DeadbandValue, Is.EqualTo(3));
|
|
Assert.That(modifyParameters.ClientHandle, Is.EqualTo(2));
|
|
Assert.That(modifyParameters.SamplingInterval, Is.EqualTo(1000));
|
|
Assert.That(modifyParameters.QueueSize, Is.EqualTo(5));
|
|
Assert.That(modifyParameters.DiscardOldest, Is.True);
|
|
}
|
|
}
|
|
}
|