Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/NodeManager/SamplingRateOwnershipRegressionTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

155 lines
6.9 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Collections.Generic;
using Moq;
using NUnit.Framework;
namespace Opc.Ua.Server.Tests.NodeManager
{
/// <summary>
/// Verifies that sampling-group disposal does not mutate rate tables borrowed by other groups or their manager.
/// </summary>
[TestFixture]
[Category("NodeManager")]
public sealed class SamplingRateOwnershipRegressionTests
{
/// <summary>
/// Verifies that disposing one group preserves shared rate definitions for surviving and newly created groups.
/// </summary>
[Test]
public void DisposingSamplingGroupPreservesBorrowedRatesForOtherGroups()
{
Mock<IServerInternal> server = DeterministicServerMock.Create(
out MonitoredItemQueueFactory queueFactory);
using (queueFactory)
{
var nodeManager = new Mock<IAsyncNodeManager>();
using OperationContext context = CreateContext();
var rates = new List<SamplingRateGroup> { new(100, 100, 9) };
using var surviving = new SamplingGroup(server.Object, nodeManager.Object, rates, context, 125);
using (var retired = new SamplingGroup(server.Object, nodeManager.Object, rates, context, 225))
{
Assert.That(retired.ApplyChanges(), Is.True);
}
using MonitoredItem first = CreateItem(server.Object, nodeManager.Object, 1, 125);
Assert.That(surviving.StartMonitoring(context, first), Is.True);
Assert.That(first.SamplingInterval, Is.EqualTo(200));
using var later = new SamplingGroup(server.Object, nodeManager.Object, rates, context, 225);
using MonitoredItem second = CreateItem(server.Object, nodeManager.Object, 2, 225);
Assert.That(later.StartMonitoring(context, second), Is.True);
Assert.Multiple(() =>
{
Assert.That(second.SamplingInterval, Is.EqualTo(300));
Assert.That(rates, Has.Count.EqualTo(1));
Assert.That(rates[0].Start, Is.EqualTo(100));
Assert.That(rates[0].Increment, Is.EqualTo(100));
});
}
}
/// <summary>
/// Verifies that retiring a sampling group leaves the manager able to revise later items to the same rate.
/// </summary>
[Test]
public void DisposingSamplingGroupPreservesManagerRateRevision()
{
Mock<IServerInternal> server = DeterministicServerMock.Create(
out MonitoredItemQueueFactory queueFactory);
using (queueFactory)
{
var nodeManager = new Mock<IAsyncNodeManager>();
using OperationContext context = CreateContext();
using var manager = new SamplingGroupManager(
server.Object, nodeManager.Object, 10, 10, [new SamplingRateGroup(100, 100, 9)]);
using MonitoredItem first = CreateItem(server.Object, nodeManager.Object, 1, 125);
manager.StartMonitoring(context, first);
Assert.That(first.SamplingInterval, Is.EqualTo(200));
manager.StopMonitoring(first);
manager.ApplyChanges();
using MonitoredItem second = CreateItem(server.Object, nodeManager.Object, 2, 125);
using MonitoredItem third = CreateItem(server.Object, nodeManager.Object, 3, 175);
manager.StartMonitoring(context, second);
manager.StartMonitoring(context, third);
Assert.Multiple(() =>
{
Assert.That(second.SamplingInterval, Is.EqualTo(200));
Assert.That(third.SamplingInterval, Is.EqualTo(200));
});
manager.StopMonitoring(second);
manager.StopMonitoring(third);
manager.ApplyChanges();
}
}
/// <summary>
/// Creates a session-backed monitored-item context for sampling-group ownership checks.
/// </summary>
private static OperationContext CreateContext()
{
var session = new Mock<ISession>();
session.SetupGet(value => value.Id).Returns(new NodeId(1));
return new OperationContext(
new RequestHeader(), null!, RequestType.CreateMonitoredItems, RequestLifetime.None, session.Object);
}
/// <summary>
/// Creates a reporting data-change item with the requested sampling interval for rate revision.
/// </summary>
private static MonitoredItem CreateItem(
IServerInternal server,
IAsyncNodeManager nodeManager,
uint id,
double samplingInterval)
{
return new MonitoredItem(
server,
nodeManager,
new NodeHandle(),
subscriptionId: 1,
id,
new ReadValueId { NodeId = new NodeId(id, 1), AttributeId = Attributes.Value },
DiagnosticsMasks.None,
TimestampsToReturn.Both,
MonitoringMode.Reporting,
clientHandle: id,
originalFilter: null,
filterToUse: null,
range: null,
samplingInterval,
queueSize: 1,
discardOldest: true,
sourceSamplingInterval: 1);
}
}
}