Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/NodeStateMonitoringOccupancyTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

283 lines
12 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using Moq;
using NUnit.Framework;
using NUnit.Framework.Interfaces;
namespace Opc.Ua.Server.Tests
{
/// <summary>
/// Checks callback occupancy while the real <see cref="MonitoredNode2"/> adds and removes items.
/// </summary>
/// <remarks>
/// Server and node-manager dependencies are mocked; no server is started.
/// Failure-only CSV rows report the two monitoring callbacks and the total occupied behavior callbacks.
/// </remarks>
[TestFixture]
[Category("NodeStateOccupancy")]
[Category("MonitoredNode")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public sealed class NodeStateMonitoringOccupancyTests
{
/// <summary>
/// Clears the diagnostic rows before each test.
/// </summary>
[SetUp]
public void ClearRows()
{
m_rows.Clear();
}
/// <summary>
/// Outputs buffered CSV rows only when the test does not pass.
/// </summary>
[TearDown]
public void PrintRowsOnFailure()
{
if (TestContext.CurrentContext.Result.Outcome.Status != TestStatus.Passed)
{
TestContext.Out.WriteLine(
k_csvHeader +
Environment.NewLine +
string.Join(Environment.NewLine, m_rows));
}
}
/// <summary>
/// Tracks the callback assignment lifecycle for a data-change monitored variable.
/// </summary>
[Test]
public void DataChangeMonitoredItemCallbackLifecycle()
{
var nodeId = new NodeId("occupancyVar", 1);
var node = new BaseDataVariableState(null)
{
NodeId = nodeId,
BrowseName = new QualifiedName("occupancyVar", 1),
DataType = DataTypeIds.Int32
};
(Mock<IAsyncNodeManager> nodeManagerMock, Mock<IServerInternal> serverMock) = CreateMinimalMocks();
Mock<IDataChangeMonitoredItem2> itemMock = CreateDataChangeItemMock(10u);
m_rows.Add(BuildRow("Before", node));
Assert.That(node.OnStateChangedAsync, Is.Null, "OnStateChangedAsync must be null before monitoring.");
Assert.That(TotalBehaviorNonNull(node), Is.Zero);
using var monitoredNode = new MonitoredNode2(nodeManagerMock.Object, serverMock.Object, node);
monitoredNode.Add(itemMock.Object);
m_rows.Add(BuildRow("DataChangeAdded", node));
Assert.That(TotalBehaviorNonNull(node), Is.EqualTo(1));
Assert.That(node.OnStateChangedAsync, Is.Not.Null,
"MonitoredNode2.Add(IDataChangeMonitoredItem2) must install OnStateChangedAsync.");
Assert.That(node.OnReportEventAsync, Is.Null,
"OnReportEventAsync must remain null for data-change-only monitoring.");
monitoredNode.Remove(itemMock.Object);
m_rows.Add(BuildRow("DataChangeRemoved", node));
Assert.That(TotalBehaviorNonNull(node), Is.Zero);
Assert.That(node.OnStateChangedAsync, Is.Null,
"OnStateChangedAsync must be cleared after last data-change item removed.");
}
/// <summary>
/// Tracks the callback assignment lifecycle for an event monitored item.
/// </summary>
[Test]
public void EventMonitoredItemCallbackLifecycle()
{
var node = new BaseObjectState(null)
{
NodeId = new NodeId("occupancyObj", 1),
BrowseName = new QualifiedName("occupancyObj", 1)
};
(Mock<IAsyncNodeManager> nodeManagerMock, Mock<IServerInternal> serverMock) = CreateMinimalMocks();
Mock<IEventMonitoredItem> eventItemMock = CreateEventItemMock(20u);
m_rows.Add(BuildRow("EventBefore", node));
Assert.That(node.OnReportEventAsync, Is.Null, "OnReportEventAsync must be null before event monitoring.");
Assert.That(TotalBehaviorNonNull(node), Is.Zero);
using var monitoredNode = new MonitoredNode2(nodeManagerMock.Object, serverMock.Object, node);
monitoredNode.Add(eventItemMock.Object);
m_rows.Add(BuildRow("EventAdded", node));
Assert.That(TotalBehaviorNonNull(node), Is.EqualTo(1));
Assert.That(node.OnReportEventAsync, Is.Not.Null,
"MonitoredNode2.Add(IEventMonitoredItem) must install OnReportEventAsync.");
Assert.That(node.OnStateChangedAsync, Is.Null,
"OnStateChangedAsync must remain null for event-only monitoring.");
monitoredNode.Remove(eventItemMock.Object);
m_rows.Add(BuildRow("EventRemoved", node));
Assert.That(TotalBehaviorNonNull(node), Is.Zero);
Assert.That(node.OnReportEventAsync, Is.Null,
"OnReportEventAsync must be cleared after last event item removed.");
}
/// <summary>
/// Tracks co-occurrence when both a data-change item and an event item are
/// present simultaneously: both callbacks are installed.
/// </summary>
[Test]
public void DataChangeAndEventCoOccurrenceBothCallbacksPresent()
{
var node = new BaseObjectState(null)
{
NodeId = new NodeId("occupancyBoth", 1),
BrowseName = new QualifiedName("occupancyBoth", 1)
};
(Mock<IAsyncNodeManager> nodeManagerMock, Mock<IServerInternal> serverMock) = CreateMinimalMocks();
Mock<IDataChangeMonitoredItem2> dataItemMock = CreateDataChangeItemMock(30u);
Mock<IEventMonitoredItem> eventItemMock = CreateEventItemMock(31u);
using var monitoredNode = new MonitoredNode2(nodeManagerMock.Object, serverMock.Object, node);
monitoredNode.Add(dataItemMock.Object);
monitoredNode.Add(eventItemMock.Object);
m_rows.Add(BuildRow("BothCallbacks", node));
Assert.That(node.OnStateChangedAsync, Is.Not.Null,
"OnStateChangedAsync must be set when data-change item is added.");
Assert.That(node.OnReportEventAsync, Is.Not.Null,
"OnReportEventAsync must be set when event item is added.");
Assert.That(TotalBehaviorNonNull(node), Is.EqualTo(2),
"Exactly 2 behavior callbacks must be occupied for combined monitoring.");
monitoredNode.Remove(dataItemMock.Object);
Assert.That(node.OnStateChangedAsync, Is.Null);
Assert.That(node.OnReportEventAsync, Is.Not.Null);
Assert.That(TotalBehaviorNonNull(node), Is.EqualTo(1));
monitoredNode.Remove(eventItemMock.Object);
Assert.That(node.OnReportEventAsync, Is.Null);
Assert.That(TotalBehaviorNonNull(node), Is.Zero);
m_rows.Add(BuildRow("BothRemoved", node));
}
/// <summary>
/// Verifies that Description and RolePermissions are not modified by
/// <see cref="MonitoredNode2"/> machinery.
/// </summary>
[Test]
public void DescriptionAndRolePermissionsNotModifiedByMonitoring()
{
var node = new BaseDataVariableState(null)
{
NodeId = new NodeId("occupancyMeta", 1),
BrowseName = new QualifiedName("occupancyMeta", 1),
DataType = DataTypeIds.Int32,
Description = new LocalizedText("Described variable"),
RolePermissions = ArrayOf.Wrapped(
new RolePermissionType { RoleId = new NodeId(1u, 0), Permissions = 0xFF })
};
LocalizedText descriptionBefore = node.Description;
(Mock<IAsyncNodeManager> nodeManagerMock, Mock<IServerInternal> serverMock) = CreateMinimalMocks();
Mock<IDataChangeMonitoredItem2> itemMock = CreateDataChangeItemMock(40u);
using var monitoredNode = new MonitoredNode2(nodeManagerMock.Object, serverMock.Object, node);
monitoredNode.Add(itemMock.Object);
m_rows.Add(BuildRow("DescriptionAndPermissionsUnchanged", node));
Assert.That(node.Description, Is.EqualTo(descriptionBefore),
"MonitoredNode2 must not modify Description.");
Assert.That(node.RolePermissions.IsNull, Is.False);
Assert.That(node.RolePermissions.Count, Is.EqualTo(1));
Assert.That(node.RolePermissions[0].RoleId, Is.EqualTo(new NodeId(1u, 0)));
Assert.That(node.RolePermissions[0].Permissions, Is.EqualTo(0xFFu),
"MonitoredNode2 must not mutate the permission payload.");
}
private static string BuildRow(string phase, NodeState node)
{
return $"{phase}," +
$"{node.OnStateChangedAsync is not null}," +
$"{node.OnReportEventAsync is not null}," +
$"{TotalBehaviorNonNull(node)}";
}
private static int TotalBehaviorNonNull(NodeState n)
{
return B(n.OnValidate) +
B(n.OnStateChanged) +
B(n.OnStateChangedAsync) +
B(n.OnReferenceAdded) +
B(n.OnReferenceRemoved) +
B(n.OnReportEvent) +
B(n.OnReportEventAsync) +
B(n.OnConditionRefresh) +
B(n.OnCreateBrowser) +
B(n.OnPopulateBrowser);
}
private static int B(Delegate? d)
{
return d is null ? 0 : 1;
}
private static (Mock<IAsyncNodeManager> nodeManagerMock, Mock<IServerInternal> serverMock)
CreateMinimalMocks()
{
return (new Mock<IAsyncNodeManager>(), new Mock<IServerInternal>());
}
private static Mock<IDataChangeMonitoredItem2> CreateDataChangeItemMock(uint id)
{
var mock = new Mock<IDataChangeMonitoredItem2>();
mock.Setup(m => m.Id).Returns(id);
return mock;
}
private static Mock<IEventMonitoredItem> CreateEventItemMock(uint id)
{
var mock = new Mock<IEventMonitoredItem>();
mock.Setup(m => m.Id).Returns(id);
return mock;
}
private const string k_csvHeader =
"Phase," +
"OnStateChangedAsync," +
"OnReportEventAsync," +
"TotalBehaviorNonNull";
private readonly List<string> m_rows = [];
}
}