mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 09:06:37 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
257 lines
9.7 KiB
C#
257 lines
9.7 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Net;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
/// <summary>
|
|
/// Tests for the server admission-control rate limiters.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("RateLimiting")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public class ServerRateLimiterTests
|
|
{
|
|
/// <summary>
|
|
/// Verifies that the token-bucket connection limiter admits up to the burst
|
|
/// capacity and then rejects further connections.
|
|
/// </summary>
|
|
[Test]
|
|
public void ConnectionRateLimiterAdmitsUpToBurstThenRejects()
|
|
{
|
|
using var limiter = new TokenBucketConnectionRateLimiter(
|
|
connectionsPerSecond: 1,
|
|
burst: 5);
|
|
|
|
var remote = new IPEndPoint(IPAddress.Loopback, 4840);
|
|
|
|
int admitted = 0;
|
|
for (int i = 0; i < 5; i++)
|
|
{
|
|
if (limiter.TryAdmitConnection(remote, out _))
|
|
{
|
|
admitted++;
|
|
}
|
|
}
|
|
|
|
Assert.That(admitted, Is.EqualTo(5), "the full burst should be admitted");
|
|
|
|
bool sixth = limiter.TryAdmitConnection(remote, out TimeSpan? retryAfter);
|
|
Assert.That(sixth, Is.False, "the connection beyond the burst must be rejected");
|
|
Assert.That(retryAfter, Is.Not.Null, "a rejected connection should carry a retry-after hint");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a null remote endpoint is handled without throwing.
|
|
/// </summary>
|
|
[Test]
|
|
public void ConnectionRateLimiterHandlesNullRemoteEndPoint()
|
|
{
|
|
using var limiter = new TokenBucketConnectionRateLimiter(1, 2);
|
|
|
|
Assert.That(limiter.TryAdmitConnection(null, out _), Is.True);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that the connection limiter rejects invalid limits.
|
|
/// </summary>
|
|
[Test]
|
|
public void ConnectionRateLimiterRejectsInvalidLimits()
|
|
{
|
|
Assert.That(
|
|
() => new TokenBucketConnectionRateLimiter(0, 1),
|
|
Throws.TypeOf<ArgumentOutOfRangeException>());
|
|
Assert.That(
|
|
() => new TokenBucketConnectionRateLimiter(1, 0),
|
|
Throws.TypeOf<ArgumentOutOfRangeException>());
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that when rate limiting is disabled the provider applies no
|
|
/// limits: no connection limiter and session establishment always proceeds.
|
|
/// </summary>
|
|
[Test]
|
|
public void DisabledProviderAppliesNoLimits()
|
|
{
|
|
var options = new ServerRateLimitOptions { Enabled = false };
|
|
using var provider = new DefaultServerRateLimiterProvider(options);
|
|
|
|
Assert.That(provider.ConnectionRateLimiter, Is.Null);
|
|
Assert.That(
|
|
provider.TryAcquireSessionEstablishment(out IDisposable? lease, out _),
|
|
Is.True);
|
|
Assert.That(lease, Is.Null);
|
|
// The backlog default is still applied even when limiting is disabled.
|
|
Assert.That(provider.ListenBacklog, Is.EqualTo(ServerRateLimitOptions.DefaultListenBacklog));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that the default (enabled) provider exposes a connection limiter
|
|
/// and the configured listener backlog.
|
|
/// </summary>
|
|
[Test]
|
|
public void EnabledProviderExposesConnectionLimiterAndBacklog()
|
|
{
|
|
var options = new ServerRateLimitOptions { ListenBacklog = 777 };
|
|
using var provider = new DefaultServerRateLimiterProvider(options);
|
|
|
|
Assert.That(provider.ConnectionRateLimiter, Is.Not.Null);
|
|
Assert.That(provider.ListenBacklog, Is.EqualTo(777));
|
|
}
|
|
|
|
[TestCase(0, 0)]
|
|
[TestCase(-1, -1)]
|
|
[TestCase(0, 1)]
|
|
[TestCase(1, 0)]
|
|
public void ProviderUsesDefaultsForNonPositiveConnectionLimits(
|
|
int connectionsPerSecond,
|
|
int connectionBurst)
|
|
{
|
|
var options = new ServerRateLimitOptions
|
|
{
|
|
ConnectionsPerSecond = connectionsPerSecond,
|
|
ConnectionBurst = connectionBurst
|
|
};
|
|
|
|
using var provider = new DefaultServerRateLimiterProvider(options);
|
|
|
|
Assert.That(provider.ConnectionRateLimiter, Is.Not.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that the session-establishment concurrency limiter admits up to
|
|
/// the permit limit and rejects the next operation while permits are held,
|
|
/// then admits again after a lease is released.
|
|
/// </summary>
|
|
[Test]
|
|
public void SessionEstablishmentLimiterBoundsConcurrency()
|
|
{
|
|
var options = new ServerRateLimitOptions
|
|
{
|
|
MaxConcurrentSessionEstablishment = 2,
|
|
SessionEstablishmentQueueLimit = 0
|
|
};
|
|
using var provider = new DefaultServerRateLimiterProvider(options);
|
|
|
|
var leases = new List<IDisposable?>();
|
|
|
|
Assert.That(
|
|
provider.TryAcquireSessionEstablishment(out IDisposable? first, out _),
|
|
Is.True);
|
|
leases.Add(first);
|
|
|
|
Assert.That(
|
|
provider.TryAcquireSessionEstablishment(out IDisposable? second, out _),
|
|
Is.True);
|
|
leases.Add(second);
|
|
|
|
// Both permits are held: the third establishment must be rejected.
|
|
Assert.That(
|
|
provider.TryAcquireSessionEstablishment(out IDisposable? third, out _),
|
|
Is.False);
|
|
Assert.That(third, Is.Null);
|
|
|
|
// Release one permit; a new establishment can now proceed.
|
|
first!.Dispose();
|
|
Assert.That(
|
|
provider.TryAcquireSessionEstablishment(out IDisposable? fourth, out _),
|
|
Is.True);
|
|
leases.Add(fourth);
|
|
|
|
foreach (IDisposable? lease in leases)
|
|
{
|
|
lease?.Dispose();
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a session establishment waits in the configured queue for a
|
|
/// permit instead of being rejected, and that a full queue still rejects.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task SessionEstablishmentQueueLimitQueuesUntilPermitIsFreeAsync()
|
|
{
|
|
var options = new ServerRateLimitOptions
|
|
{
|
|
MaxConcurrentSessionEstablishment = 1,
|
|
SessionEstablishmentQueueLimit = 1
|
|
};
|
|
using var provider = new DefaultServerRateLimiterProvider(options);
|
|
|
|
(bool acquired, IDisposable? first, _) =
|
|
await provider.AcquireSessionEstablishmentAsync().ConfigureAwait(false);
|
|
Assert.That(acquired, Is.True);
|
|
|
|
Task<(bool Acquired, IDisposable? Lease, TimeSpan? RetryAfter)> queued =
|
|
provider.AcquireSessionEstablishmentAsync().AsTask();
|
|
Assert.That(queued.IsCompleted, Is.False);
|
|
|
|
(bool overflowAcquired, IDisposable? overflow, _) =
|
|
await provider.AcquireSessionEstablishmentAsync().ConfigureAwait(false);
|
|
Assert.That(overflowAcquired, Is.False);
|
|
Assert.That(overflow, Is.Null);
|
|
|
|
first!.Dispose();
|
|
(bool queuedAcquired, IDisposable? second, _) =
|
|
await queued.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
Assert.That(queuedAcquired, Is.True);
|
|
second!.Dispose();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that disposing the provider is idempotent.
|
|
/// </summary>
|
|
[Test]
|
|
public void ProviderDisposeIsIdempotent()
|
|
{
|
|
var provider = new DefaultServerRateLimiterProvider(new ServerRateLimitOptions());
|
|
provider.Dispose();
|
|
Assert.That(provider.Dispose, Throws.Nothing);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a null options argument is rejected.
|
|
/// </summary>
|
|
[Test]
|
|
public void ProviderRejectsNullOptions()
|
|
{
|
|
Assert.That(
|
|
() => new DefaultServerRateLimiterProvider(null!),
|
|
Throws.TypeOf<ArgumentNullException>());
|
|
}
|
|
}
|
|
}
|