mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 00:31:32 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
530 lines
20 KiB
C#
530 lines
20 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Collections.Generic;
|
|
using Microsoft.Extensions.Logging;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
/// <summary>
|
|
/// Deterministic, offline unit tests for <see cref="ServerUtils"/>. The fixture is
|
|
/// non-parallelizable and resets the static <see cref="ServerUtils.EventsEnabled"/>
|
|
/// flag (and its private event queue) after every test so the shared mutable state
|
|
/// never leaks between tests.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("ServerUtilsDeterministic")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[NonParallelizable]
|
|
public sealed class ServerUtilsDeterministicTests
|
|
{
|
|
private ILogger m_logger = null!;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_logger = NUnitTelemetryContext.Create().CreateLogger("ServerUtilsDeterministicTests");
|
|
}
|
|
|
|
[TearDown]
|
|
public void TearDown()
|
|
{
|
|
// ServerUtils holds static mutable state (EventsEnabled plus a private event
|
|
// queue). Setting the flag back to false clears the queue and keeps tests isolated.
|
|
ServerUtils.EventsEnabled = false;
|
|
}
|
|
|
|
private static OperationContext CreateContext(DiagnosticsMasks mask)
|
|
{
|
|
var header = new RequestHeader
|
|
{
|
|
ReturnDiagnostics = (uint)mask
|
|
};
|
|
return new OperationContext(header, null, RequestType.Read, RequestLifetime.None);
|
|
}
|
|
|
|
private static List<DiagnosticInfo> CreateDiagnosticSlots(int count)
|
|
{
|
|
return [.. new DiagnosticInfo[count]];
|
|
}
|
|
|
|
[Test]
|
|
public void EventsEnabledDefaultsToFalse()
|
|
{
|
|
Assert.That(ServerUtils.EventsEnabled, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void EventsEnabledSetTrueReturnsTrue()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
|
|
Assert.That(ServerUtils.EventsEnabled, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void EventsEnabledSetTrueThenFalseReturnsFalse()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
Assert.That(ServerUtils.EventsEnabled, Is.True);
|
|
|
|
ServerUtils.EventsEnabled = false;
|
|
Assert.That(ServerUtils.EventsEnabled, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void EventsEnabledTransitionToFalseWithQueuedEventDoesNotThrow()
|
|
{
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
ServerUtils.EventsEnabled = true;
|
|
ServerUtils.ReportQueuedValue(nodeId, 7u, value);
|
|
|
|
Assert.That(() => ServerUtils.EventsEnabled = false, Throws.Nothing);
|
|
Assert.That(ServerUtils.EventsEnabled, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportWriteValueWhenEventsDisabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = false;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(
|
|
() => ServerUtils.ReportWriteValue(nodeId, value, StatusCodes.Good),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportWriteValueWhenEventsEnabledWithGoodStatusDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(
|
|
() => ServerUtils.ReportWriteValue(nodeId, value, StatusCodes.Good),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportWriteValueWhenEventsEnabledWithBadStatusDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
// A bad status forces the branch that rewraps the value in a new DataValue.
|
|
Assert.That(
|
|
() => ServerUtils.ReportWriteValue(nodeId, value, StatusCodes.BadNodeIdUnknown),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportQueuedValueWhenEventsDisabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = false;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportQueuedValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportQueuedValueWhenEventsEnabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportQueuedValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportFilteredValueWhenEventsDisabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = false;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportFilteredValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportFilteredValueWhenEventsEnabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportFilteredValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportDiscardedValueWhenEventsDisabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = false;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportDiscardedValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportDiscardedValueWhenEventsEnabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportDiscardedValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportPublishValueWhenEventsDisabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = false;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportPublishValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportPublishValueWhenEventsEnabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
var value = new DataValue(new Variant(42));
|
|
|
|
Assert.That(() => ServerUtils.ReportPublishValue(nodeId, 7u, value), Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportCreateMonitoredItemWhenEventsDisabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = false;
|
|
var nodeId = new NodeId(1234u);
|
|
|
|
Assert.That(
|
|
() => ServerUtils.ReportCreateMonitoredItem(
|
|
nodeId, 7u, 100.0, 10u, true, new DataChangeFilter(), MonitoringMode.Reporting),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportCreateMonitoredItemWhenEventsEnabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
|
|
Assert.That(
|
|
() => ServerUtils.ReportCreateMonitoredItem(
|
|
nodeId, 7u, 100.0, 10u, true, new DataChangeFilter(), MonitoringMode.Reporting),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportModifyMonitoredItemWhenEventsDisabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = false;
|
|
var nodeId = new NodeId(1234u);
|
|
|
|
Assert.That(
|
|
() => ServerUtils.ReportModifyMonitoredItem(
|
|
nodeId, 7u, 250.0, 5u, false, new DataChangeFilter(), MonitoringMode.Sampling),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ReportModifyMonitoredItemWhenEventsEnabledDoesNotThrow()
|
|
{
|
|
ServerUtils.EventsEnabled = true;
|
|
var nodeId = new NodeId(1234u);
|
|
|
|
Assert.That(
|
|
() => ServerUtils.ReportModifyMonitoredItem(
|
|
nodeId, 7u, 250.0, 5u, false, new DataChangeFilter(), MonitoringMode.Sampling),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateErrorByIndexWithOperationAllSetsDiagnosticInfo()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
List<DiagnosticInfo> diagnosticInfos = CreateDiagnosticSlots(2);
|
|
|
|
uint code = ServerUtils.CreateError(
|
|
StatusCodes.BadNodeIdUnknown.Code, context, diagnosticInfos, 0, m_logger);
|
|
|
|
Assert.That(code, Is.EqualTo(StatusCodes.BadNodeIdUnknown.Code));
|
|
Assert.That(diagnosticInfos[0], Is.Not.Null);
|
|
Assert.That(diagnosticInfos[1], Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateErrorByIndexWithNoneLeavesNull()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.None);
|
|
List<DiagnosticInfo> diagnosticInfos = CreateDiagnosticSlots(1);
|
|
|
|
uint code = ServerUtils.CreateError(
|
|
StatusCodes.BadNodeIdUnknown.Code, context, diagnosticInfos, 0, m_logger);
|
|
|
|
Assert.That(code, Is.EqualTo(StatusCodes.BadNodeIdUnknown.Code));
|
|
Assert.That(diagnosticInfos[0], Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateErrorAppendWithOperationAllReturnsTrue()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
var results = new List<StatusCode>();
|
|
var diagnosticInfos = new List<DiagnosticInfo>();
|
|
|
|
bool hasDiagnostic = ServerUtils.CreateError(
|
|
StatusCodes.BadTypeMismatch.Code, results, diagnosticInfos, context, m_logger);
|
|
|
|
Assert.That(hasDiagnostic, Is.True);
|
|
Assert.That(results, Has.Count.EqualTo(1));
|
|
Assert.That(results[0], Is.EqualTo(StatusCodes.BadTypeMismatch));
|
|
Assert.That(diagnosticInfos, Has.Count.EqualTo(1));
|
|
Assert.That(diagnosticInfos[0], Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateErrorAppendWithNoneReturnsFalse()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.None);
|
|
var results = new List<StatusCode>();
|
|
var diagnosticInfos = new List<DiagnosticInfo>();
|
|
|
|
bool hasDiagnostic = ServerUtils.CreateError(
|
|
StatusCodes.BadTypeMismatch.Code, results, diagnosticInfos, context, m_logger);
|
|
|
|
Assert.That(hasDiagnostic, Is.False);
|
|
Assert.That(results, Has.Count.EqualTo(1));
|
|
Assert.That(results[0], Is.EqualTo(StatusCodes.BadTypeMismatch));
|
|
Assert.That(diagnosticInfos, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateErrorAtIndexWithOperationAllReturnsTrue()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
var results = new List<StatusCode> { StatusCodes.Good, StatusCodes.Good };
|
|
List<DiagnosticInfo> diagnosticInfos = CreateDiagnosticSlots(2);
|
|
|
|
bool hasDiagnostic = ServerUtils.CreateError(
|
|
StatusCodes.BadAttributeIdInvalid.Code, results, diagnosticInfos, 1, context, m_logger);
|
|
|
|
Assert.That(hasDiagnostic, Is.True);
|
|
Assert.That(results[0], Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(results[1], Is.EqualTo(StatusCodes.BadAttributeIdInvalid));
|
|
Assert.That(diagnosticInfos[0], Is.Null);
|
|
Assert.That(diagnosticInfos[1], Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateErrorAtIndexWithNoneReturnsFalse()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.None);
|
|
var results = new List<StatusCode> { StatusCodes.Good };
|
|
List<DiagnosticInfo> diagnosticInfos = CreateDiagnosticSlots(1);
|
|
|
|
bool hasDiagnostic = ServerUtils.CreateError(
|
|
StatusCodes.BadAttributeIdInvalid.Code, results, diagnosticInfos, 0, context, m_logger);
|
|
|
|
Assert.That(hasDiagnostic, Is.False);
|
|
Assert.That(results[0], Is.EqualTo(StatusCodes.BadAttributeIdInvalid));
|
|
Assert.That(diagnosticInfos[0], Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateSuccessWithOperationAllAddsGoodAndNullPlaceholder()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
var results = new List<StatusCode>();
|
|
var diagnosticInfos = new List<DiagnosticInfo>();
|
|
|
|
ServerUtils.CreateSuccess(results, diagnosticInfos, context);
|
|
|
|
Assert.That(results, Has.Count.EqualTo(1));
|
|
Assert.That(results[0], Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(diagnosticInfos, Has.Count.EqualTo(1));
|
|
Assert.That(diagnosticInfos[0], Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateSuccessWithNoneAddsGoodOnly()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.None);
|
|
var results = new List<StatusCode>();
|
|
var diagnosticInfos = new List<DiagnosticInfo>();
|
|
|
|
ServerUtils.CreateSuccess(results, diagnosticInfos, context);
|
|
|
|
Assert.That(results, Has.Count.EqualTo(1));
|
|
Assert.That(results[0], Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(diagnosticInfos, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateDiagnosticInfoCollectionWithNoneReturnsNull()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.None);
|
|
var errors = new List<ServiceResult> { new(StatusCodes.BadNodeIdUnknown) };
|
|
|
|
List<DiagnosticInfo>? result =
|
|
ServerUtils.CreateDiagnosticInfoCollection(context, errors, m_logger);
|
|
|
|
Assert.That(result, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateDiagnosticInfoCollectionWithOperationAllMapsBadAndGood()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
var errors = new List<ServiceResult>
|
|
{
|
|
new(StatusCodes.BadNodeIdUnknown),
|
|
ServiceResult.Good
|
|
};
|
|
|
|
List<DiagnosticInfo> result =
|
|
ServerUtils.CreateDiagnosticInfoCollection(context, errors, m_logger)!;
|
|
|
|
Assert.That(result, Has.Count.EqualTo(errors.Count));
|
|
Assert.That(result[0], Is.Not.Null);
|
|
Assert.That(result[1], Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateStatusCodeCollectionMapsBadAndGoodCodes()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.None);
|
|
var errors = new List<ServiceResult>
|
|
{
|
|
ServiceResult.Good,
|
|
new(StatusCodes.BadNodeIdUnknown)
|
|
};
|
|
|
|
List<StatusCode> result =
|
|
ServerUtils.CreateStatusCodeCollection(context, errors, out _, m_logger);
|
|
|
|
Assert.That(result, Has.Count.EqualTo(2));
|
|
Assert.That(result[0], Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(result[1], Is.EqualTo(StatusCodes.BadNodeIdUnknown));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateStatusCodeCollectionAllGoodWithOperationAllLeavesDiagnosticsNull()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
var errors = new List<ServiceResult> { ServiceResult.Good, ServiceResult.Good };
|
|
|
|
List<StatusCode> result = ServerUtils.CreateStatusCodeCollection(
|
|
context, errors, out List<DiagnosticInfo> diagnosticInfos, m_logger);
|
|
|
|
Assert.That(result[0], Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(result[1], Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(diagnosticInfos, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateStatusCodeCollectionWithBadErrorIncludesOperationDiagnostics()
|
|
{
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
var errors = new List<ServiceResult>
|
|
{
|
|
ServiceResult.Good,
|
|
new(StatusCodes.BadNodeIdUnknown)
|
|
};
|
|
|
|
List<StatusCode> result = ServerUtils.CreateStatusCodeCollection(
|
|
context, errors, out List<DiagnosticInfo> diagnosticInfos, m_logger);
|
|
|
|
Assert.That(result[1], Is.EqualTo(StatusCodes.BadNodeIdUnknown));
|
|
Assert.That(diagnosticInfos, Is.Not.Null);
|
|
Assert.That(diagnosticInfos, Has.Count.EqualTo(errors.Count));
|
|
Assert.That(diagnosticInfos[0], Is.Null);
|
|
Assert.That(diagnosticInfos[1], Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateDiagnosticInfoWithNullErrorReturnsNull()
|
|
{
|
|
var serverMock = new Mock<IServerInternal>();
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationAll);
|
|
|
|
DiagnosticInfo? result = ServerUtils.CreateDiagnosticInfo(
|
|
serverMock.Object, context, null!, m_logger);
|
|
|
|
Assert.That(result, Is.Null);
|
|
serverMock.VerifyNoOtherCalls();
|
|
}
|
|
|
|
[Test]
|
|
public void CreateDiagnosticInfoWithoutOperationLocalizedTextSkipsResourceManager()
|
|
{
|
|
var serverMock = new Mock<IServerInternal>();
|
|
OperationContext context = CreateContext(
|
|
DiagnosticsMasks.ServiceAll | DiagnosticsMasks.OperationSymbolicId);
|
|
var error = new ServiceResult(StatusCodes.BadNodeIdUnknown);
|
|
|
|
DiagnosticInfo? result = ServerUtils.CreateDiagnosticInfo(
|
|
serverMock.Object, context, error, m_logger);
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
serverMock.Verify(s => s.ResourceManager, Times.Never);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateDiagnosticInfoWithOperationLocalizedTextAccessesResourceManager()
|
|
{
|
|
using var resourceManager = new ResourceManager(new ApplicationConfiguration());
|
|
var serverMock = new Mock<IServerInternal>();
|
|
serverMock.Setup(s => s.ResourceManager).Returns(resourceManager);
|
|
OperationContext context = CreateContext(DiagnosticsMasks.OperationLocalizedText);
|
|
var error = new ServiceResult(StatusCodes.BadNodeIdUnknown);
|
|
|
|
DiagnosticInfo? result = ServerUtils.CreateDiagnosticInfo(
|
|
serverMock.Object, context, error, m_logger);
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
serverMock.Verify(s => s.ResourceManager, Times.Once);
|
|
}
|
|
}
|
|
}
|