mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-22 09:37:12 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
276 lines
12 KiB
C#
276 lines
12 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Reflection;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Security.Certificates;
|
|
using Opc.Ua.Tests;
|
|
using ServerSession = Opc.Ua.Server.Session;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
/// <summary>
|
|
/// Regression tests for the identity token and signature checks that
|
|
/// ActivateSession runs in <see cref="ServerSession.ValidateBeforeActivateAsync"/>
|
|
/// and for the security diagnostics it records (OPC 10000-4 5.7.3, OPC 10000-5 12.12).
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Session")]
|
|
[Parallelizable]
|
|
public sealed class ActivateSessionValidationRegressionTests
|
|
{
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_telemetry = NUnitTelemetryContext.Create();
|
|
m_serverMock = new Mock<IServerInternal>();
|
|
m_serverMock.Setup(s => s.Telemetry).Returns(m_telemetry);
|
|
m_serverMock.Setup(s => s.NamespaceUris).Returns(new NamespaceTable());
|
|
m_serverMock.Setup(s => s.SessionManager).Returns(new Mock<ISessionManager>().Object);
|
|
m_serverCertificate = CertificateBuilder.Create("CN=ActivateSessionValidationServer").CreateForRSA();
|
|
}
|
|
|
|
[TearDown]
|
|
public void TearDown()
|
|
{
|
|
m_serverCertificate?.Dispose();
|
|
}
|
|
|
|
/// <summary>
|
|
/// AS-4: an AnonymousIdentityToken that names a policy must conform to an
|
|
/// anonymous UserTokenPolicy of the endpoint (Part 4 7.40.3); an unknown or
|
|
/// non-anonymous PolicyId is Bad_IdentityTokenInvalid. Only a token without
|
|
/// PolicyId falls back to the first anonymous policy.
|
|
/// </summary>
|
|
[TestCase("does-not-exist", null)]
|
|
[TestCase("user", null)]
|
|
[TestCase("anon-2", "anon-2")]
|
|
[TestCase("", "anon-1")]
|
|
[TestCase(null, "anon-1")]
|
|
public async Task AnonymousTokenPolicyIdMustNameAnAnonymousPolicyAsync(
|
|
string? policyId,
|
|
string? expectedPolicyId)
|
|
{
|
|
EndpointDescription endpoint = CreateEndpoint(
|
|
tokens:
|
|
[
|
|
new UserTokenPolicy { PolicyId = "anon-1", TokenType = UserTokenType.Anonymous },
|
|
new UserTokenPolicy
|
|
{
|
|
PolicyId = "user",
|
|
TokenType = UserTokenType.UserName,
|
|
SecurityPolicyUri = SecurityPolicies.None
|
|
},
|
|
new UserTokenPolicy { PolicyId = "anon-2", TokenType = UserTokenType.Anonymous }
|
|
]);
|
|
using ServerSession session = CreateSession(endpoint);
|
|
using OperationContext context = CreateContext(endpoint);
|
|
var token = new ExtensionObject(new AnonymousIdentityToken { PolicyId = policyId! });
|
|
|
|
if (expectedPolicyId == null)
|
|
{
|
|
ServiceResultException? ex = Assert.ThrowsAsync<ServiceResultException>(
|
|
async () => await session.ValidateBeforeActivateAsync(
|
|
context, new SignatureData(), token, new SignatureData(),
|
|
CancellationToken.None).ConfigureAwait(false));
|
|
Assert.That(ex!.StatusCode, Is.EqualTo(StatusCodes.BadIdentityTokenInvalid));
|
|
return;
|
|
}
|
|
|
|
(IUserIdentityTokenHandler handler, UserTokenPolicy? policy) =
|
|
await session.ValidateBeforeActivateAsync(
|
|
context, new SignatureData(), token, new SignatureData(),
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
Assert.That(handler.TokenType, Is.EqualTo(UserTokenType.Anonymous));
|
|
Assert.That(policy!.PolicyId, Is.EqualTo(expectedPolicyId));
|
|
}
|
|
|
|
/// <summary>
|
|
/// AS-5: a client signature with an unexpected algorithm is a missing or
|
|
/// invalid client signature, Bad_ApplicationSignatureInvalid (Part 4 5.7.3.3),
|
|
/// not the channel-level Bad_SecurityChecksFailed of the shared check.
|
|
/// </summary>
|
|
[Test]
|
|
public void ClientSignatureWithUnexpectedAlgorithmIsApplicationSignatureInvalid()
|
|
{
|
|
using Certificate clientCertificate =
|
|
CertificateBuilder.Create("CN=ActivateSessionValidationClient").CreateForRSA();
|
|
EndpointDescription endpoint = CreateEndpoint(
|
|
SecurityPolicies.Basic256Sha256, MessageSecurityMode.Sign);
|
|
using ServerSession session = CreateSession(endpoint, clientCertificate);
|
|
using OperationContext context = CreateContext(endpoint);
|
|
var clientSignature = new SignatureData
|
|
{
|
|
Algorithm = SecurityAlgorithms.RsaSha1,
|
|
Signature = new byte[] { 1, 2, 3, 4 }.ToByteString()
|
|
};
|
|
|
|
ServiceResultException? ex = Assert.ThrowsAsync<ServiceResultException>(
|
|
async () => await session.ValidateBeforeActivateAsync(
|
|
context, clientSignature, default, new SignatureData(),
|
|
CancellationToken.None).ConfigureAwait(false));
|
|
Assert.That(ex!.StatusCode, Is.EqualTo(StatusCodes.BadApplicationSignatureInvalid));
|
|
}
|
|
|
|
/// <summary>
|
|
/// AS-5: an identity token that is not a UserIdentityToken is
|
|
/// Bad_IdentityTokenInvalid (Part 4 5.7.3.3), as on the regular path, rather
|
|
/// than Bad_UserAccessDenied.
|
|
/// </summary>
|
|
[Test]
|
|
public void UndecodableIdentityTokenIsIdentityTokenInvalid()
|
|
{
|
|
EndpointDescription endpoint = CreateEndpoint(
|
|
tokens: [new UserTokenPolicy { PolicyId = "anon", TokenType = UserTokenType.Anonymous }]);
|
|
using ServerSession session = CreateSession(endpoint);
|
|
using OperationContext context = CreateContext(endpoint);
|
|
var token = new ExtensionObject(new ExpandedNodeId(9999u, 1), "{}");
|
|
|
|
ServiceResultException? ex = Assert.ThrowsAsync<ServiceResultException>(
|
|
async () => await session.ValidateBeforeActivateAsync(
|
|
context, new SignatureData(), token, new SignatureData(),
|
|
CancellationToken.None).ConfigureAwait(false));
|
|
Assert.That(ex!.StatusCode, Is.EqualTo(StatusCodes.BadIdentityTokenInvalid));
|
|
}
|
|
|
|
/// <summary>
|
|
/// AS-6: ClientUserIdOfSession names the user authenticated when the session
|
|
/// was created (Part 5 12.12); a later identity change only extends
|
|
/// ClientUserIdHistory.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task ClientUserIdOfSessionKeepsTheFirstActivatedUserAsync()
|
|
{
|
|
EndpointDescription endpoint = CreateEndpoint(
|
|
tokens:
|
|
[
|
|
new UserTokenPolicy
|
|
{
|
|
PolicyId = "user",
|
|
TokenType = UserTokenType.UserName,
|
|
SecurityPolicyUri = SecurityPolicies.None
|
|
}
|
|
]);
|
|
using ServerSession session = CreateSession(endpoint);
|
|
using OperationContext context = CreateContext(endpoint);
|
|
|
|
await ActivateAsUserAsync(session, context, "alice").ConfigureAwait(false);
|
|
await ActivateAsUserAsync(session, context, "bob").ConfigureAwait(false);
|
|
|
|
SessionSecurityDiagnosticsDataType diagnostics = GetSecurityDiagnostics(session);
|
|
Assert.That(diagnostics.ClientUserIdOfSession, Is.EqualTo("alice"));
|
|
Assert.That((string[])[.. diagnostics.ClientUserIdHistory], Is.EqualTo(s_aliceThenBob));
|
|
}
|
|
|
|
private static async Task ActivateAsUserAsync(
|
|
ServerSession session,
|
|
OperationContext context,
|
|
string userName)
|
|
{
|
|
var token = new UserNameIdentityToken
|
|
{
|
|
PolicyId = "user",
|
|
UserName = userName,
|
|
Password = new ByteString(new byte[] { 1, 2, 3 })
|
|
};
|
|
(IUserIdentityTokenHandler handler, UserTokenPolicy? _) =
|
|
await session.ValidateBeforeActivateAsync(
|
|
context, new SignatureData(), new ExtensionObject(token), new SignatureData(),
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
var identity = new UserIdentity(handler);
|
|
session.Activate(
|
|
context,
|
|
handler,
|
|
identity,
|
|
identity,
|
|
default,
|
|
Nonce.CreateNonce(SecurityPolicies.None));
|
|
}
|
|
|
|
private static SessionSecurityDiagnosticsDataType GetSecurityDiagnostics(ServerSession session)
|
|
{
|
|
return (SessionSecurityDiagnosticsDataType)typeof(ServerSession)
|
|
.GetField("m_securityDiagnostics", BindingFlags.Instance | BindingFlags.NonPublic)!
|
|
.GetValue(session)!;
|
|
}
|
|
|
|
private static EndpointDescription CreateEndpoint(
|
|
string securityPolicyUri = SecurityPolicies.None,
|
|
MessageSecurityMode securityMode = MessageSecurityMode.None,
|
|
UserTokenPolicy[]? tokens = null)
|
|
{
|
|
return new EndpointDescription
|
|
{
|
|
EndpointUrl = "opc.tcp://localhost:4840/ActivateSessionValidation",
|
|
SecurityMode = securityMode,
|
|
SecurityPolicyUri = securityPolicyUri,
|
|
UserIdentityTokens = tokens != null ? new ArrayOf<UserTokenPolicy>(tokens) : default
|
|
};
|
|
}
|
|
|
|
private static OperationContext CreateContext(EndpointDescription endpoint)
|
|
{
|
|
var channelContext = new SecureChannelContext("channel-1", endpoint, RequestEncoding.Binary);
|
|
return new OperationContext(
|
|
new RequestHeader(), channelContext, RequestType.ActivateSession, RequestLifetime.None);
|
|
}
|
|
|
|
private ServerSession CreateSession(
|
|
EndpointDescription endpoint,
|
|
Certificate? clientCertificate = null)
|
|
{
|
|
using OperationContext context = CreateContext(endpoint);
|
|
return new ServerSession(
|
|
context,
|
|
m_serverMock.Object,
|
|
m_serverCertificate,
|
|
new NodeId(Guid.NewGuid()),
|
|
ByteString.Empty,
|
|
Nonce.CreateNonce(SecurityPolicies.None),
|
|
"ActivateSessionValidation",
|
|
new ApplicationDescription { ApplicationUri = "urn:activate-session-validation:client" },
|
|
endpoint.EndpointUrl!,
|
|
clientCertificate?.AddRef()!,
|
|
[],
|
|
60_000,
|
|
10,
|
|
10);
|
|
}
|
|
|
|
private static readonly string[] s_aliceThenBob = ["alice", "bob"];
|
|
private ITelemetryContext m_telemetry = null!;
|
|
private Mock<IServerInternal> m_serverMock = null!;
|
|
private Certificate m_serverCertificate = null!;
|
|
}
|
|
}
|