mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 08:41:51 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
689 lines
30 KiB
C#
689 lines
30 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Time.Testing;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Server.StateMachines;
|
|
using Opc.Ua.Server.Tests.NodeManager;
|
|
|
|
namespace Opc.Ua.Server.Tests.StateMachines
|
|
{
|
|
/// <summary>
|
|
/// Unit tests for <see cref="StateMachineBuilder{TState}.WithSubStateMachine"/>
|
|
/// — the hierarchical state-machine builder sugar. Verifies the
|
|
/// HasSubStateMachine wiring, parent-state-entry activation, the
|
|
/// suspend-on-exit semantics, and the per-parent-state reset
|
|
/// behavior (with the <c>preserveOnReentry</c> opt-out).
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Server")]
|
|
[Category("StateMachines")]
|
|
[Parallelizable]
|
|
public sealed class StateMachineBuilderSubStateTests
|
|
{
|
|
private ServerSystemContext m_context = null!;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_context = StateMachineTestFixtures.CreateContext();
|
|
}
|
|
|
|
[Test]
|
|
public async Task ParentEnterHookSeesReadyChildAndDoesNotLoseItsTransitionAsync(
|
|
[Values] bool asynchronous,
|
|
[Values] bool reenter)
|
|
{
|
|
var clock = new TimerCreationGateClock();
|
|
Mock<IServerInternal> server = DeterministicServerMock.Create(out MonitoredItemQueueFactory queues, clock);
|
|
using MonitoredItemQueueFactory queueFactory = queues;
|
|
using var releaseTimer = new ManualResetEventSlim();
|
|
m_context = server.Object.DefaultSystemContext;
|
|
var observed = new TaskCompletionSource<(bool Suspended, uint State, StatusCode Result)>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
StateMachineBuilder<FluentFiniteStateMachineState> builder = BuildParent()
|
|
.AddTransition(11, "ReenterA", 1, 1)
|
|
.WithInitialState(reenter ? 1u : 2u)
|
|
.WithSubStateMachine(1, new QualifiedName("ChildSm", 1), child => child
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddState(11, "ChildRunning")
|
|
.AddTransition(100, "Start", 10, 11)
|
|
.OnCause(1000, 10, 100))
|
|
.WithTimedTransition(1, TimeSpan.FromHours(1), 12);
|
|
FluentFiniteStateMachineState parent = builder.StateMachine;
|
|
var child = (FluentFiniteStateMachineState)GetChild(parent, "ChildSm");
|
|
(bool Suspended, uint State, StatusCode Result) DriveChild(ISystemContext context)
|
|
{
|
|
bool suspended = child.IsSuspended;
|
|
uint initial = CurrentStateId(child);
|
|
ServiceResult result = child.DoCause(context, null, 1000, default, []);
|
|
return (suspended, initial, result.StatusCode);
|
|
}
|
|
if (asynchronous)
|
|
{
|
|
builder.OnEnterStateAsync(1, async (context, _, _) =>
|
|
{
|
|
(bool Suspended, uint State, StatusCode Result) result = DriveChild(context);
|
|
await Task.Yield();
|
|
observed.TrySetResult(result);
|
|
});
|
|
clock.BeforeTimerCreation = () =>
|
|
{
|
|
// Hold the end of parent dispatch until its queued async enter hook has run.
|
|
if (!releaseTimer.Wait(TimeSpan.FromSeconds(10)))
|
|
{
|
|
throw new TimeoutException("The async enter hook did not release timer creation.");
|
|
}
|
|
};
|
|
}
|
|
else
|
|
{
|
|
builder.OnEnterState(1, (context, _) => observed.TrySetResult(DriveChild(context)));
|
|
}
|
|
Task<ServiceResult> transition = Task.Run(
|
|
() => parent.DoTransition(m_context, reenter ? 11u : 21u, 0, default, []));
|
|
try
|
|
{
|
|
(bool observedSuspended, uint observedState, StatusCode observedResult) =
|
|
await observed.Task.WaitAsync(TimeSpan.FromSeconds(5)).ConfigureAwait(false);
|
|
releaseTimer.Set();
|
|
ServiceResult parentResult = await transition.WaitAsync(TimeSpan.FromSeconds(5)).ConfigureAwait(false);
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(parentResult.StatusCode, Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(observedSuspended, Is.False);
|
|
Assert.That(observedState, Is.EqualTo(10));
|
|
Assert.That(observedResult, Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(CurrentStateId(parent), Is.EqualTo(1));
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(11),
|
|
"Child synchronization must not reset a successful transition performed by the parent hook.");
|
|
});
|
|
}
|
|
finally
|
|
{
|
|
releaseTimer.Set();
|
|
await transition.WaitAsync(TimeSpan.FromSeconds(5)).ConfigureAwait(false);
|
|
builder.StopTimedTransitions();
|
|
}
|
|
}
|
|
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public async Task ConcurrentParentAndChildTransitionsDoNotDeadlockAsync(bool useCause)
|
|
{
|
|
var childEntered = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var parentEntered = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
using var releaseChild = new ManualResetEventSlim();
|
|
using var releaseParent = new ManualResetEventSlim();
|
|
ServiceResult nestedResult = StatusCodes.BadUnexpectedError;
|
|
FluentFiniteStateMachineState? parent = null;
|
|
parent = BuildParent()
|
|
.AddTransition(11, "ReenterA", 1, 1)
|
|
.OnCause(110, 1, 11)
|
|
.OnCause(120, 1, 12)
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(1, new QualifiedName("ChildSm", 1), child => child
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddState(11, "ChildDone")
|
|
.AddTransition(100, "Finish", 10, 11)
|
|
.OnEnterState(11, (context, _) =>
|
|
{
|
|
childEntered.TrySetResult(true);
|
|
if (!releaseChild.Wait(TimeSpan.FromSeconds(10)))
|
|
{
|
|
throw new TimeoutException("The child callback was not released.");
|
|
}
|
|
nestedResult = useCause
|
|
? parent!.DoCause(context, null, 120, default, [])
|
|
: parent!.DoTransition(context, 12, 0, default, []);
|
|
}))
|
|
.StateMachine;
|
|
var child = (FluentFiniteStateMachineState)GetChild(parent, "ChildSm");
|
|
parent.OnBeforeTransition = (_, _, transition, _, _, _) =>
|
|
{
|
|
if (transition == 11)
|
|
{
|
|
parentEntered.TrySetResult(true);
|
|
if (!releaseParent.Wait(TimeSpan.FromSeconds(10)))
|
|
{
|
|
throw new TimeoutException("The parent transition was not released.");
|
|
}
|
|
}
|
|
return ServiceResult.Good;
|
|
};
|
|
|
|
Task<ServiceResult> childTransition = Task.Run(() =>
|
|
child.DoTransition(m_context, 100, 0, default, []));
|
|
try
|
|
{
|
|
await childEntered.Task.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
Task<ServiceResult> parentTransition = Task.Run(() => useCause
|
|
? parent.DoCause(m_context, null, 110, default, [])
|
|
: parent.DoTransition(m_context, 11, 0, default, []));
|
|
await parentEntered.Task.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
releaseParent.Set();
|
|
releaseChild.Set();
|
|
|
|
ServiceResult[] results = await Task.WhenAll(childTransition, parentTransition)
|
|
.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
Assert.That(results, Has.All.Property(nameof(ServiceResult.StatusCode)).EqualTo(StatusCodes.Good));
|
|
Assert.That(nestedResult.StatusCode, Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(CurrentStateId(parent), Is.EqualTo(2));
|
|
Assert.That(child.IsSuspended, Is.True);
|
|
|
|
Assert.That(parent.DoTransition(m_context, 21, 0, default, []).StatusCode,
|
|
Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(10));
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
}
|
|
finally
|
|
{
|
|
releaseParent.Set();
|
|
releaseChild.Set();
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void WithSubStateMachineAddsHasComponentChild()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddState(11, "ChildRunning")
|
|
.AddTransition(100, "IdleToRunning", from: 10, to: 11))
|
|
.StateMachine;
|
|
|
|
var children = new List<BaseInstanceState>();
|
|
parent.GetChildren(m_context, children);
|
|
BaseInstanceState child = children.Find(c => c.BrowseName.Name == "ChildSm")!;
|
|
|
|
Assert.That(child, Is.Not.Null);
|
|
// HasSubStateMachine is non-hierarchical, so the parent /
|
|
// child relationship uses HasComponent — matching the
|
|
// standard NodeSets.
|
|
Assert.That(child.ReferenceTypeId,
|
|
Is.EqualTo(ReferenceTypeIds.HasComponent));
|
|
Assert.That(child, Is.InstanceOf<FluentFiniteStateMachineState>());
|
|
}
|
|
|
|
[Test]
|
|
public void WithSubStateMachineReferencesSubMachineFromParentStateNode()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddTransition(100, "Loop", from: 10, to: 10))
|
|
.StateMachine;
|
|
|
|
BaseInstanceState child = GetChild(parent, "ChildSm");
|
|
BaseInstanceState stateNode = GetChild(parent, "ParentA");
|
|
|
|
// Part 16 §4.4.16: the reference hangs off the parent STATE
|
|
// node, not the state machine root.
|
|
var forward = new List<IReference>();
|
|
stateNode.GetReferences(
|
|
m_context, forward, ReferenceTypeIds.HasSubStateMachine, false);
|
|
Assert.That(forward, Has.Count.EqualTo(1));
|
|
Assert.That(forward[0].TargetId, Is.EqualTo((ExpandedNodeId)child.NodeId));
|
|
|
|
// ... and the inverse (SubStateMachineOf) browses back.
|
|
var inverse = new List<IReference>();
|
|
child.GetReferences(
|
|
m_context, inverse, ReferenceTypeIds.HasSubStateMachine, true);
|
|
Assert.That(inverse, Has.Count.EqualTo(1));
|
|
Assert.That(inverse[0].TargetId, Is.EqualTo((ExpandedNodeId)stateNode.NodeId));
|
|
|
|
// The state machine root must NOT carry the reference.
|
|
var fromRoot = new List<IReference>();
|
|
parent.GetReferences(
|
|
m_context, fromRoot, ReferenceTypeIds.HasSubStateMachine, false);
|
|
Assert.That(fromRoot, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public void SubStateMachineIsDiscoverableThroughTheNodeBrowser()
|
|
{
|
|
// Drives the real NodeBrowser along the exact path a client
|
|
// takes: hierarchical browse of the machine to reach the
|
|
// state node and the sub-SM, then HasSubStateMachine from
|
|
// the state node. HasSubStateMachine is non-hierarchical,
|
|
// so using it as the parent/child reference would leave the
|
|
// sub-SM invisible to the first of those browses.
|
|
//
|
|
// NodeState.PopulateBrowser only walks children when the
|
|
// TypeTable can tell it the browsed reference type is
|
|
// hierarchical, so the bare test table needs that one fact.
|
|
var typeTable = (TypeTable)m_context.TypeTable;
|
|
typeTable.AddReferenceSubtype(
|
|
ReferenceTypeIds.HierarchicalReferences,
|
|
NodeId.Null,
|
|
new QualifiedName(BrowseNames.HierarchicalReferences));
|
|
typeTable.AddReferenceSubtype(
|
|
ReferenceTypeIds.HasComponent,
|
|
ReferenceTypeIds.HierarchicalReferences,
|
|
new QualifiedName(BrowseNames.HasComponent));
|
|
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddTransition(100, "Loop", from: 10, to: 10))
|
|
.StateMachine;
|
|
|
|
List<NodeId> components = BrowseTargets(
|
|
parent, ReferenceTypeIds.HasComponent, BrowseDirection.Forward);
|
|
NodeId stateNodeId = GetChild(parent, "ParentA").NodeId;
|
|
NodeId childNodeId = GetChild(parent, "ChildSm").NodeId;
|
|
|
|
Assert.That(components, Does.Contain(stateNodeId));
|
|
Assert.That(components, Does.Contain(childNodeId));
|
|
|
|
List<NodeId> subMachines = BrowseTargets(
|
|
GetChild(parent, "ParentA"),
|
|
ReferenceTypeIds.HasSubStateMachine,
|
|
BrowseDirection.Forward);
|
|
|
|
Assert.That(subMachines, Is.EqualTo([childNodeId]));
|
|
}
|
|
|
|
private List<NodeId> BrowseTargets(
|
|
NodeState node,
|
|
NodeId referenceTypeId,
|
|
BrowseDirection direction)
|
|
{
|
|
var targets = new List<NodeId>();
|
|
using INodeBrowser browser = node.CreateBrowser(
|
|
m_context,
|
|
null,
|
|
referenceTypeId,
|
|
false,
|
|
direction,
|
|
default,
|
|
null,
|
|
false);
|
|
for (IReference reference = browser.Next()!;
|
|
reference != null;
|
|
reference = browser.Next()!)
|
|
{
|
|
targets.Add(ExpandedNodeId.ToNodeId(
|
|
reference.TargetId, m_context.NamespaceUris));
|
|
}
|
|
return targets;
|
|
}
|
|
|
|
[Test]
|
|
public void WithSubStateMachineRejectsBrowseNameCollidingWithState()
|
|
{
|
|
StateMachineBuilder<FluentFiniteStateMachineState> builder =
|
|
BuildParent().WithInitialState(1);
|
|
|
|
// The sub-SM NodeId is composed like the element NodeIds,
|
|
// so a browse name shared with a state would collide.
|
|
Assert.Throws<ArgumentException>(() =>
|
|
builder.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ParentA", 1),
|
|
configure: c => c.AddState(10, "ChildIdle", isInitial: true)));
|
|
}
|
|
|
|
[Test]
|
|
public void WithSubStateMachineRejectsUnknownParentState()
|
|
{
|
|
StateMachineBuilder<FluentFiniteStateMachineState> builder =
|
|
BuildParent().WithInitialState(1);
|
|
|
|
Assert.Throws<InvalidOperationException>(() =>
|
|
builder.WithSubStateMachine(
|
|
parentStateId: 99,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c.AddState(10, "ChildIdle", isInitial: true)));
|
|
}
|
|
|
|
[Test]
|
|
public void SubStateMachineActivatesWhenInitialStateIsSetAfterwards()
|
|
{
|
|
// WithInitialState goes through SetState, which fires no
|
|
// enter handler — the sub-SM must still activate, so this
|
|
// call order behaves the same as the reverse one.
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddState(11, "ChildRunning")
|
|
.AddTransition(100, "IdleToRunning", from: 10, to: 11))
|
|
.WithInitialState(1)
|
|
.StateMachine;
|
|
|
|
var child = (FluentFiniteStateMachineState)GetChild(parent, "ChildSm");
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(10u));
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void SubStateMachineStaysSuspendedWhenInitialStateIsElsewhere()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddTransition(100, "Loop", from: 10, to: 10))
|
|
.WithInitialState(2)
|
|
.StateMachine;
|
|
|
|
var child = (FluentFiniteStateMachineState)GetChild(parent, "ChildSm");
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(child.IsSuspended, Is.True);
|
|
// Part 16: an inactive sub-state machine publishes no
|
|
// current state — its declared initial state is only
|
|
// applied once the parent enters the attached state.
|
|
Assert.That(child.CurrentState!.Value.IsNullOrEmpty, Is.True);
|
|
// ... and OPC 10000-16 §4.4.6: CurrentState and
|
|
// LastTransition of an inactive sub-SM read with
|
|
// Bad_StateNotActive.
|
|
Assert.That(child.CurrentState.StatusCode,
|
|
Is.EqualTo(StatusCodes.BadStateNotActive));
|
|
Assert.That(child.LastTransition!.StatusCode,
|
|
Is.EqualTo(StatusCodes.BadStateNotActive));
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void ResumedSubStateMachineReadsGoodAgain()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddTransition(100, "Loop", from: 10, to: 10))
|
|
.WithInitialState(2)
|
|
.StateMachine;
|
|
var child = (FluentFiniteStateMachineState)GetChild(parent, "ChildSm");
|
|
Assert.That(child.CurrentState!.StatusCode,
|
|
Is.EqualTo(StatusCodes.BadStateNotActive));
|
|
|
|
// Parent enters the attached state → the sub-SM activates
|
|
// and its state variables read Good with the seeded state.
|
|
parent.DoTransition(m_context, 21, 0, default, []);
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
Assert.That(child.CurrentState.StatusCode,
|
|
Is.EqualTo(StatusCodes.Good));
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(10u));
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void PreserveOnReentryChildSurvivesALaterWithInitialState()
|
|
{
|
|
StateMachineBuilder<FluentFiniteStateMachineState> builder =
|
|
BuildParent()
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddState(11, "ChildRunning")
|
|
.AddTransition(100, "IdleToRunning", from: 10, to: 11),
|
|
preserveOnReentry: true);
|
|
FluentFiniteStateMachineState parent = builder.StateMachine;
|
|
var child = (FluentFiniteStateMachineState)GetChild(parent, "ChildSm");
|
|
|
|
// Move the child off its initial state, then re-apply the
|
|
// parent's initial state — a preserveOnReentry child must
|
|
// keep its state instead of being reset.
|
|
child.DoTransition(m_context, 100, 0, default, []);
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(11u));
|
|
|
|
builder.WithInitialState(1);
|
|
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(11u));
|
|
}
|
|
|
|
[Test]
|
|
public void WithSubStateMachineActivatesOnParentStateEntry()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(2) // parent starts in state 2 (sub-SM is NOT attached here)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddTransition(100, "Loop", from: 10, to: 10))
|
|
.StateMachine;
|
|
|
|
var child = (FluentFiniteStateMachineState)
|
|
GetChild(parent, "ChildSm");
|
|
|
|
// Sub-SM starts suspended (parent is in state 2, not 1).
|
|
Assert.That(child.IsSuspended, Is.True);
|
|
|
|
// Move parent to state 1 → sub-SM activates.
|
|
parent.DoTransition(m_context, 21, 0, default, []);
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void WithSubStateMachineSuspendsOnParentStateExit()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddTransition(100, "Loop", from: 10, to: 10))
|
|
.StateMachine;
|
|
|
|
var child = (FluentFiniteStateMachineState)
|
|
GetChild(parent, "ChildSm");
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
|
|
// Move parent OFF state 1 → sub-SM suspended.
|
|
parent.DoTransition(m_context, 12, 0, default, []);
|
|
Assert.That(child.IsSuspended, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void SuspendedSubStateMachineRejectsTransitionsWithBadStateNotActive()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(2) // parent in state 2, sub-SM suspended
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddTransition(100, "Loop", from: 10, to: 10))
|
|
.StateMachine;
|
|
|
|
var child = (FluentFiniteStateMachineState)
|
|
GetChild(parent, "ChildSm");
|
|
|
|
ServiceResult result = child.DoTransition(m_context, 100, 0, default, []);
|
|
|
|
Assert.That(ServiceResult.IsBad(result), Is.True);
|
|
Assert.That(result.Code, Is.EqualTo(StatusCodes.BadStateNotActive));
|
|
}
|
|
|
|
[Test]
|
|
public void ResetOnReentryRestoresInitialState()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddState(11, "ChildRunning")
|
|
.AddTransition(100, "IdleToRunning", from: 10, to: 11)
|
|
.OnCause(1000, from: 10, transition: 100))
|
|
.StateMachine;
|
|
|
|
var child = (FluentFiniteStateMachineState)
|
|
GetChild(parent, "ChildSm");
|
|
|
|
// Move child to "Running" state.
|
|
child.DoTransition(m_context, 100, 1000, default, []);
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(11u));
|
|
|
|
// Move parent off state 1 and back.
|
|
parent.DoTransition(m_context, 12, 0, default, []);
|
|
parent.DoTransition(m_context, 21, 0, default, []);
|
|
|
|
// Child should have reset to its initial state.
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(10u));
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void PreserveOnReentryRetainsChildState()
|
|
{
|
|
FluentFiniteStateMachineState parent = BuildParent()
|
|
.WithInitialState(1)
|
|
.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c
|
|
.AddState(10, "ChildIdle", isInitial: true)
|
|
.AddState(11, "ChildRunning")
|
|
.AddTransition(100, "IdleToRunning", from: 10, to: 11)
|
|
.OnCause(1000, from: 10, transition: 100),
|
|
preserveOnReentry: true)
|
|
.StateMachine;
|
|
|
|
var child = (FluentFiniteStateMachineState)
|
|
GetChild(parent, "ChildSm");
|
|
|
|
child.DoTransition(m_context, 100, 1000, default, []);
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(11u));
|
|
|
|
parent.DoTransition(m_context, 12, 0, default, []);
|
|
parent.DoTransition(m_context, 21, 0, default, []);
|
|
|
|
// Child retained its "Running" state across the
|
|
// parent-exit / re-entry cycle.
|
|
Assert.That(CurrentStateId(child), Is.EqualTo(11u));
|
|
Assert.That(child.IsSuspended, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void WithSubStateMachineThrowsInLifecycleMode()
|
|
{
|
|
FluentFiniteStateMachineState sm = BuildParent().StateMachine;
|
|
var lifecycle =
|
|
StateMachineBuilder.For(sm, m_context);
|
|
|
|
Assert.That(() => lifecycle.WithSubStateMachine(
|
|
parentStateId: 1,
|
|
browseName: new QualifiedName("ChildSm", 1),
|
|
configure: c => c.AddState(10, "X", isInitial: true)),
|
|
Throws.InvalidOperationException);
|
|
}
|
|
|
|
private StateMachineBuilder<FluentFiniteStateMachineState> BuildParent()
|
|
{
|
|
return StateMachineTestFixtures.NewBuilder(m_context)
|
|
.AddState(1, "ParentA", isInitial: true)
|
|
.AddState(2, "ParentB")
|
|
.AddTransition(12, "AToB", from: 1, to: 2)
|
|
.AddTransition(21, "BToA", from: 2, to: 1);
|
|
}
|
|
|
|
private static BaseInstanceState GetChild(FluentFiniteStateMachineState parent, string browseName)
|
|
{
|
|
var children = new List<BaseInstanceState>();
|
|
parent.GetChildren(null!, children);
|
|
return children.Find(c => c.BrowseName.Name == browseName)!;
|
|
}
|
|
|
|
private static uint CurrentStateId(FluentFiniteStateMachineState sm)
|
|
{
|
|
if (sm.CurrentState?.Id?.Value is { } id && !id.IsNull)
|
|
{
|
|
// Resolve through the machine's own mapping so
|
|
// materialized state NodeIds are understood too.
|
|
return sm.GetStateId(id);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
private sealed class TimerCreationGateClock : TimeProvider
|
|
{
|
|
public Action BeforeTimerCreation { get; set; } = null!;
|
|
|
|
public override ITimer CreateTimer(
|
|
TimerCallback callback,
|
|
object? state,
|
|
TimeSpan dueTime,
|
|
TimeSpan period)
|
|
{
|
|
BeforeTimerCreation?.Invoke();
|
|
return m_clock.CreateTimer(callback, state, dueTime, period);
|
|
}
|
|
|
|
private readonly FakeTimeProvider m_clock = new();
|
|
}
|
|
}
|
|
}
|