mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 16:52:07 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
174 lines
8.2 KiB
C#
174 lines
8.2 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
/// <summary>
|
|
/// Verifies that returned and mirrored notifications retain their payloads independently of queue recycling.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Subscription")]
|
|
[NonParallelizable]
|
|
public sealed class NotificationEncodingLifetimeRegressionTests
|
|
{
|
|
/// <summary>
|
|
/// Verifies that delayed encoding preserves notifications after acknowledgement, eviction, clearing, and pool
|
|
/// reuse.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task ReturnedNotificationSurvivesPoolReuseUntilEncodingCompletesAsync(
|
|
[Values("publish", "queued", "republish", "fullMirror", "deltaMirror")] string surface,
|
|
[Values("acknowledge", "evict", "clear")] string mutation,
|
|
[Values(false, true)] bool events)
|
|
{
|
|
NotificationMessage? mirrored = null;
|
|
var fullStore = new Mock<ISubscriptionRetransmissionStore>();
|
|
fullStore.Setup(store => store.StoreRetransmissionState(
|
|
1, It.IsAny<uint>(), It.IsAny<ArrayOf<NotificationMessage>>()))
|
|
.Callback<uint, uint, ArrayOf<NotificationMessage>>((_, _, values) => mirrored ??= values[0]);
|
|
var deltaStore = new Mock<ISubscriptionRetransmissionDeltaStore>();
|
|
deltaStore.Setup(store => store.StoreRetransmissionStateDelta(
|
|
1, It.IsAny<uint>(), It.IsAny<ArrayOf<NotificationMessage>>(), It.IsAny<ArrayOf<uint>>()))
|
|
.Callback<uint, uint, ArrayOf<NotificationMessage>, ArrayOf<uint>>(
|
|
(_, _, values, _) => mirrored ??= values[0]);
|
|
ISubscriptionRetransmissionStore? store = surface switch
|
|
{
|
|
"fullMirror" => fullStore.Object,
|
|
"deltaMirror" => deltaStore.Object,
|
|
_ => null
|
|
};
|
|
var queue = new SentMessageQueue(() => 1, 2, store, NullLogger.Instance);
|
|
var source = (NotificationMessage)NotificationMessageActivator.Instance.CreateInstance();
|
|
source.SequenceNumber = surface == "queued" ? 2u : 1u;
|
|
var item = (MonitoredItemNotification)MonitoredItemNotificationActivator.Instance.CreateInstance();
|
|
item.ClientHandle = 77;
|
|
item.Value = new DataValue(42);
|
|
var eventItem = (EventFieldList)EventFieldListActivator.Instance.CreateInstance();
|
|
eventItem.ClientHandle = 77;
|
|
eventItem.EventFields = [42];
|
|
var data = new DataChangeNotification { MonitoredItems = [item] };
|
|
var eventList = new EventNotificationList { Events = [eventItem] };
|
|
source.NotificationData = [new ExtensionObject(events ? eventList : data)];
|
|
List<NotificationMessage> messages = surface == "queued"
|
|
? [new NotificationMessage { SequenceNumber = 1 }, source]
|
|
: [source];
|
|
NotificationMessage published = queue.Enqueue(messages, [], out _, out _);
|
|
NotificationMessage selected = surface switch
|
|
{
|
|
"queued" => queue.TryDequeueQueued([], false, out _)!,
|
|
"republish" => queue.FindForRepublish(source.SequenceNumber)!,
|
|
"fullMirror" or "deltaMirror" => mirrored!,
|
|
_ => published
|
|
};
|
|
uint expectedSequence = source.SequenceNumber;
|
|
var releaseEncoder = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var response = new PublishResponse { NotificationMessage = selected };
|
|
Task<PublishResponse> encoding = EncodeAfterReleaseAsync(response, releaseEncoder.Task);
|
|
try
|
|
{
|
|
if (mutation == "acknowledge")
|
|
{
|
|
Assert.That(queue.TryAcknowledge(expectedSequence), Is.True);
|
|
}
|
|
else if (mutation == "evict")
|
|
{
|
|
queue.Enqueue(
|
|
[new NotificationMessage { SequenceNumber = 3 }, new NotificationMessage { SequenceNumber = 4 }],
|
|
[], out _, out _);
|
|
}
|
|
else
|
|
{
|
|
queue.Clear();
|
|
}
|
|
Assert.That(source.IsEmpty, Is.True);
|
|
}
|
|
finally
|
|
{
|
|
releaseEncoder.TrySetResult(true);
|
|
}
|
|
var reused = (NotificationMessage)NotificationMessageActivator.Instance.CreateInstance();
|
|
reused.SequenceNumber = 999;
|
|
PublishResponse decoded;
|
|
try
|
|
{
|
|
decoded = await encoding.ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
reused.Reuse();
|
|
}
|
|
Assert.That(decoded.NotificationMessage.SequenceNumber, Is.EqualTo(expectedSequence));
|
|
Assert.That(decoded.NotificationMessage.NotificationData, Has.Count.EqualTo(1));
|
|
if (events)
|
|
{
|
|
Assert.That(decoded.NotificationMessage.NotificationData[0].TryGetValue(out EventNotificationList? value),
|
|
Is.True);
|
|
Assert.That(value!.Events[0].ClientHandle, Is.EqualTo(77u));
|
|
Assert.That(value.Events[0].EventFields[0].GetInt32(), Is.EqualTo(42));
|
|
Assert.That(eventItem.ClientHandle, Is.Zero);
|
|
item.Reuse();
|
|
}
|
|
else
|
|
{
|
|
Assert.That(decoded.NotificationMessage.NotificationData[0].TryGetValue(out DataChangeNotification? value),
|
|
Is.True);
|
|
Assert.That(value!.MonitoredItems[0].ClientHandle, Is.EqualTo(77u));
|
|
Assert.That(value.MonitoredItems[0].Value.WrappedValue.GetInt32(), Is.EqualTo(42));
|
|
Assert.That(item.ClientHandle, Is.Zero);
|
|
eventItem.Reuse();
|
|
}
|
|
queue.Clear();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Waits for queue mutation before round-tripping the retained publish response through binary encoding.
|
|
/// </summary>
|
|
private static async Task<PublishResponse> EncodeAfterReleaseAsync(PublishResponse response, Task release)
|
|
{
|
|
await release.ConfigureAwait(false);
|
|
ServiceMessageContext context = ServiceMessageContext.Create(NUnitTelemetryContext.Create());
|
|
using var encoder = new BinaryEncoder(context);
|
|
response.Encode(encoder);
|
|
using var decoder = new BinaryDecoder(encoder.CloseAndReturnBuffer()!, context);
|
|
var decoded = new PublishResponse();
|
|
decoded.Decode(decoder);
|
|
return decoded;
|
|
}
|
|
|
|
}
|
|
}
|