Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/Subscription/SentMessageQueueEvictionTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

116 lines
5.2 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Collections.Generic;
using System.Linq;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using NUnit.Framework;
namespace Opc.Ua.Server.Tests
{
/// <summary>
/// Verifies bounded retransmission eviction and ordered delivery when an enqueue partially overflows the queue.
/// </summary>
[TestFixture]
[Category("Subscription")]
[Parallelizable]
public sealed class SentMessageQueueEvictionTests
{
/// <summary>
/// Verifies that partial overflow evicts only the excess oldest message and persists the exact queue delta.
/// </summary>
[TestCase(10u, 5, 6)]
[TestCase(5u, 4, 2)]
public void EnqueuePartialOverflowEvictsOnlyExcess(uint capacity, int oldCount, int newCount)
{
var store = new Mock<ISubscriptionRetransmissionDeltaStore>();
List<NotificationMessage> oldMessages = CreateMessages(1, oldCount);
List<NotificationMessage> newMessages = CreateMessages(oldCount + 1, newCount);
var queue = SentMessageQueue.CreateRestored(
() => 9,
capacity,
store.Object,
NullLogger.Instance,
oldMessages,
nextSequenceNumber: 42,
lastSentMessage: oldCount);
var available = new List<uint>();
NotificationMessage published = queue.Enqueue(
newMessages,
available,
out bool moreNotifications,
out uint newlyUnacknowledgedCount);
Assert.Multiple(() =>
{
Assert.That(published.SequenceNumber, Is.EqualTo(oldCount + 1));
Assert.That(queue.SentCount, Is.EqualTo(capacity));
// only the sent messages are retransmittable; the rest of the new batch is
// still queued for Publish responses.
Assert.That(
queue.AvailableSequenceNumbersForRetransmission(),
Is.EqualTo(Enumerable.Range(2, oldCount).Select(i => (uint)i)));
Assert.That(available, Is.EqualTo(Enumerable.Range(2, oldCount).Select(i => (uint)i)));
Assert.That(newlyUnacknowledgedCount, Is.EqualTo(1u));
Assert.That(moreNotifications, Is.True);
Assert.That(queue.FindForRepublish(1), Is.Null);
Assert.That(queue.FindForRepublish(2)?.SequenceNumber, Is.EqualTo(2u));
});
store.Verify(s => s.StoreRetransmissionStateDelta(
9,
42,
It.Is<ArrayOf<NotificationMessage>>(m =>
m.Count == newCount && m[0].SequenceNumber == oldCount + 1),
It.Is<ArrayOf<uint>>(r => r.Count == 1 && r[0] == 1)),
Times.Once);
for (int sequenceNumber = oldCount + 2; sequenceNumber <= oldCount + newCount; sequenceNumber++)
{
available.Clear();
NotificationMessage? next = queue.TryDequeueQueued(available, false, out moreNotifications);
Assert.That(next?.SequenceNumber, Is.EqualTo(sequenceNumber));
Assert.That(moreNotifications, Is.EqualTo(sequenceNumber < oldCount + newCount));
}
Assert.That(queue.TryDequeueQueued(available, false, out _), Is.Null);
}
/// <summary>
/// Creates notifications with consecutive sequence numbers for eviction and dequeue-order assertions.
/// </summary>
private static List<NotificationMessage> CreateMessages(int first, int count)
{
return Enumerable.Range(first, count)
.Select(i => new NotificationMessage { SequenceNumber = (uint)i, NotificationData = [] })
.ToList();
}
}
}