Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/SubscriptionLifecycleTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

885 lines
35 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Reflection;
using Moq;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests
{
/// <summary>
/// Unit tests for Subscription lifecycle operations: Modify, SetPublishingMode,
/// Acknowledge, Republish, PublishTimeout, SessionClosed, SetTriggering, etc.
/// </summary>
[TestFixture]
[Category("Subscription")]
[Parallelizable]
public class SubscriptionLifecycleTests
{
private Mock<IServerInternal> m_serverMock;
private Mock<ISession> m_sessionMock;
private Mock<IDiagnosticsNodeManager> m_diagnosticsNodeManagerMock;
private Mock<IMonitoredItemQueueFactory> m_queueFactoryMock;
private ITelemetryContext m_telemetry;
[SetUp]
public void SetUp()
{
m_telemetry = NUnitTelemetryContext.Create();
m_serverMock = new Mock<IServerInternal>();
m_sessionMock = new Mock<ISession>();
m_diagnosticsNodeManagerMock = new Mock<IDiagnosticsNodeManager>();
m_queueFactoryMock = new Mock<IMonitoredItemQueueFactory>();
m_serverMock.Setup(s => s.Telemetry).Returns(m_telemetry);
m_serverMock.Setup(s => s.DiagnosticsNodeManager).Returns(m_diagnosticsNodeManagerMock.Object);
m_serverMock.Setup(s => s.MonitoredItemQueueFactory).Returns(m_queueFactoryMock.Object);
var namespaceUris = new NamespaceTable();
m_serverMock.Setup(s => s.NamespaceUris).Returns(namespaceUris);
m_serverMock.Setup(s => s.ServerUris).Returns(new StringTable());
m_serverMock.Setup(s => s.TypeTree).Returns(new TypeTable(namespaceUris));
m_serverMock.Setup(s => s.Factory).Returns(new Mock<IEncodeableFactory>().Object);
m_serverMock.Setup(s => s.DefaultSystemContext).Returns(new ServerSystemContext(m_serverMock.Object));
var identity = new UserIdentity(new AnonymousIdentityToken());
m_sessionMock.Setup(s => s.Id).Returns(new NodeId(Guid.NewGuid()));
m_sessionMock.Setup(s => s.Identity).Returns(identity);
m_sessionMock.Setup(s => s.IdentityToken).Returns(identity.TokenHandler);
m_sessionMock.Setup(s => s.ClientApplicationUri).Returns(
"urn:localhost:opcfoundation.org:SubscriptionLifecycleTests");
m_diagnosticsNodeManagerMock
.Setup(d => d.CreateSubscriptionDiagnosticsAsync(
It.IsAny<ServerSystemContext>(),
It.IsAny<SubscriptionDiagnosticsDataType>(),
It.IsAny<NodeValueSimpleEventHandler>()))
.ReturnsAsync(new NodeId(1));
m_diagnosticsNodeManagerMock
.Setup(d => d.DeleteSubscriptionDiagnosticsAsync(
It.IsAny<ServerSystemContext>(),
It.IsAny<NodeId>(),
It.IsAny<System.Threading.CancellationToken>()))
.Returns(default(System.Threading.Tasks.ValueTask));
}
private Subscription CreateSubscription(
double publishingInterval = 1000,
uint maxLifetimeCount = 10,
uint maxKeepAliveCount = 5,
byte priority = 0,
bool publishingEnabled = true)
{
return new Subscription(
m_serverMock.Object,
m_sessionMock.Object,
subscriptionId: 1,
publishingInterval: publishingInterval,
maxLifetimeCount: maxLifetimeCount,
maxKeepAliveCount: maxKeepAliveCount,
maxNotificationsPerPublish: 0,
priority: priority,
publishingEnabled: publishingEnabled,
maxMessageCount: 10);
}
private OperationContext CreateOperationContext()
{
return new OperationContext(m_sessionMock.Object, DiagnosticsMasks.None);
}
[Test]
public void SamplingReportingModeChangesDoNotWrapDisabledDiagnostics()
{
using Subscription subscription = CreateSubscription();
MethodInfo method = typeof(Subscription).GetMethod(
"ModifyItemMonitoringMode",
BindingFlags.Instance | BindingFlags.NonPublic)!;
method.Invoke(
subscription,
[0d, MonitoringMode.Reporting, MonitoringMode.Sampling]);
Assert.That(subscription.Diagnostics.DisabledMonitoredItemCount, Is.Zero);
method.Invoke(
subscription,
[0d, MonitoringMode.Reporting, MonitoringMode.Disabled]);
Assert.That(subscription.Diagnostics.DisabledMonitoredItemCount, Is.EqualTo(1u));
method.Invoke(
subscription,
[0d, MonitoringMode.Disabled, MonitoringMode.Sampling]);
Assert.That(subscription.Diagnostics.DisabledMonitoredItemCount, Is.Zero);
}
private static void InjectSentMessages(Subscription subscription, params NotificationMessage[] messages)
{
FieldInfo queueField = typeof(Subscription).GetField("m_messageQueue",
BindingFlags.NonPublic | BindingFlags.Instance)
?? throw new InvalidOperationException("Field m_messageQueue not found");
object messageQueue = queueField.GetValue(subscription)
?? throw new InvalidOperationException("m_messageQueue is null");
PropertyInfo sentMessagesProperty = messageQueue.GetType().GetProperty("SentMessages",
BindingFlags.Public | BindingFlags.Instance)
?? throw new InvalidOperationException("Property SentMessages not found");
var sentMessages = (List<NotificationMessage>)sentMessagesProperty.GetValue(messageQueue)!;
sentMessages!.AddRange(messages);
// the injected messages were sent (returned by a Publish response).
FieldInfo lastSentField = messageQueue.GetType().GetField("m_lastSentMessage",
BindingFlags.NonPublic | BindingFlags.Instance)
?? throw new InvalidOperationException("Field m_lastSentMessage not found");
lastSentField.SetValue(messageQueue, sentMessages.Count);
}
[Test]
public void ConstructorThrowsArgumentNullExceptionForNullServer()
{
Assert.That(
() => new Subscription(
server: null!,
m_sessionMock.Object,
subscriptionId: 1,
publishingInterval: 1000,
maxLifetimeCount: 10,
maxKeepAliveCount: 5,
maxNotificationsPerPublish: 0,
priority: 0,
publishingEnabled: true,
maxMessageCount: 10),
Throws.TypeOf<ArgumentNullException>());
}
[Test]
public void ConstructorThrowsArgumentNullExceptionForNullSession()
{
Assert.That(
() => new Subscription(
m_serverMock.Object,
session: null!,
subscriptionId: 1,
publishingInterval: 1000,
maxLifetimeCount: 10,
maxKeepAliveCount: 5,
maxNotificationsPerPublish: 0,
priority: 0,
publishingEnabled: true,
maxMessageCount: 10),
Throws.TypeOf<ArgumentNullException>());
}
[Test]
public void NewSubscriptionHasCorrectInitialDiagnostics()
{
const double publishingInterval = 500.0;
const uint maxKeepAlive = 3;
const uint maxLifetime = 9;
const byte priority = 42;
using Subscription subscription = CreateSubscription(
publishingInterval: publishingInterval,
maxLifetimeCount: maxLifetime,
maxKeepAliveCount: maxKeepAlive,
priority: priority);
Assert.That(subscription.Diagnostics.PublishingInterval, Is.EqualTo(publishingInterval));
Assert.That(subscription.Diagnostics.MaxKeepAliveCount, Is.EqualTo(maxKeepAlive));
Assert.That(subscription.Diagnostics.MaxLifetimeCount, Is.EqualTo(maxLifetime));
Assert.That(subscription.Diagnostics.PublishingEnabled, Is.True);
Assert.That(subscription.Diagnostics.ModifyCount, Is.Zero);
Assert.That(subscription.Diagnostics.EnableCount, Is.Zero);
Assert.That(subscription.Diagnostics.DisableCount, Is.Zero);
}
[Test]
public void NewSubscriptionIsDurableIsFalse()
{
using Subscription subscription = CreateSubscription();
Assert.That(subscription.IsDurable, Is.False);
}
[Test]
public void PublishingIntervalReturnsConfiguredValue()
{
const double expected = 750.0;
using Subscription subscription = CreateSubscription(publishingInterval: expected);
Assert.That(subscription.PublishingInterval, Is.EqualTo(expected));
}
[Test]
public void MonitoredItemCountIsZeroForNewSubscription()
{
using Subscription subscription = CreateSubscription();
Assert.That(subscription.MonitoredItemCount, Is.Zero);
}
[Test]
public void GetMonitoredItemsReturnsEmptyForNewSubscription()
{
using Subscription subscription = CreateSubscription();
subscription.GetMonitoredItems(out ArrayOf<uint> serverHandles, out ArrayOf<uint> clientHandles);
Assert.That(serverHandles, Is.Empty);
Assert.That(clientHandles, Is.Empty);
}
[Test]
public void QueueOverflowHandlerIncrementsOverflowCount()
{
using Subscription subscription = CreateSubscription();
Assert.That(subscription.Diagnostics.MonitoringQueueOverflowCount, Is.Zero);
subscription.QueueOverflowHandler();
Assert.That(subscription.Diagnostics.MonitoringQueueOverflowCount, Is.EqualTo(1u));
}
[Test]
public void QueueOverflowHandlerCanBeCalledMultipleTimes()
{
using Subscription subscription = CreateSubscription();
subscription.QueueOverflowHandler();
subscription.QueueOverflowHandler();
subscription.QueueOverflowHandler();
Assert.That(subscription.Diagnostics.MonitoringQueueOverflowCount, Is.EqualTo(3u));
}
[Test]
public void SessionClosedClearsSessionReference()
{
using Subscription subscription = CreateSubscription();
Assert.That(subscription.Session, Is.Not.Null);
subscription.SessionClosed(m_sessionMock.Object);
Assert.That(subscription.Session, Is.Null);
}
[Test]
public void SessionIdReturnsDefaultAfterSessionClosed()
{
using Subscription subscription = CreateSubscription();
subscription.SessionClosed(m_sessionMock.Object);
Assert.That(subscription.SessionId, Is.Default);
}
[Test]
public void SessionIdDiagnosticsIsDefaultAfterSessionClosed()
{
using Subscription subscription = CreateSubscription();
subscription.SessionClosed(m_sessionMock.Object);
Assert.That(subscription.Diagnostics.SessionId, Is.Default);
}
[Test]
public void PublishTimeoutReturnsBadTimeoutMessage()
{
using Subscription subscription = CreateSubscription();
NotificationMessage message = subscription.PublishTimeout();
Assert.That(message, Is.Not.Null);
Assert.That(message.NotificationData, Has.Count.EqualTo(1));
bool hasNotification = message.NotificationData[0]
.TryGetValue(out StatusChangeNotification? notification);
Assert.That(hasNotification, Is.True);
Assert.That(notification, Is.Not.Null);
Assert.That(notification.Status, Is.EqualTo(StatusCodes.BadTimeout));
}
[Test]
public void PublishTimeoutReturnsMessageWithSequenceNumber()
{
using Subscription subscription = CreateSubscription();
NotificationMessage message = subscription.PublishTimeout();
Assert.That(message.SequenceNumber, Is.GreaterThan(0u));
}
[Test]
public void PublishTimeoutMarkSubscriptionAsExpiredCausesPublishToReturnNull()
{
using Subscription subscription = CreateSubscription();
subscription.PublishTimeout();
OperationContext context = CreateOperationContext();
NotificationMessage message = subscription.Publish(
context,
out _,
out _)!;
Assert.That(message, Is.Null);
}
[Test]
public void SubscriptionTransferredReturnsTransferStatusMessage()
{
using Subscription subscription = CreateSubscription();
NotificationMessage message = subscription.SubscriptionTransferred();
Assert.That(message, Is.Not.Null);
Assert.That(message.NotificationData, Has.Count.EqualTo(1));
bool hasNotification = message.NotificationData[0]
.TryGetValue(out StatusChangeNotification? notification);
Assert.That(hasNotification, Is.True);
Assert.That(notification, Is.Not.Null);
Assert.That(notification.Status, Is.EqualTo(StatusCodes.GoodSubscriptionTransferred));
}
[Test]
public void SubscriptionTransferredReturnsMessageWithSequenceNumber()
{
using Subscription subscription = CreateSubscription();
NotificationMessage message = subscription.SubscriptionTransferred();
Assert.That(message.SequenceNumber, Is.GreaterThan(0u));
}
[Test]
public void SetSubscriptionDurableReturnsBadNotSupportedWhenNotSupported()
{
m_queueFactoryMock.Setup(f => f.SupportsDurableQueues).Returns(false);
using Subscription subscription = CreateSubscription();
ServiceResult result = subscription.SetSubscriptionDurable(maxLifetimeCount: 1000);
Assert.That(StatusCode.IsBad(result.StatusCode), Is.True);
Assert.That(result.Code, Is.EqualTo(StatusCodes.BadNotSupported));
}
[Test]
public void SetSubscriptionDurableSetsIsDurableWhenSupported()
{
m_queueFactoryMock.Setup(f => f.SupportsDurableQueues).Returns(true);
using Subscription subscription = CreateSubscription();
Assert.That(subscription.IsDurable, Is.False);
ServiceResult result = subscription.SetSubscriptionDurable(maxLifetimeCount: 1000);
Assert.That(StatusCode.IsGood(result.StatusCode), Is.True);
Assert.That(subscription.IsDurable, Is.True);
}
[Test]
public void SetSubscriptionDurableUpdatesMaxLifetimeCount()
{
const uint newLifetimeCount = 2000u;
m_queueFactoryMock.Setup(f => f.SupportsDurableQueues).Returns(true);
using Subscription subscription = CreateSubscription(maxLifetimeCount: 10);
subscription.SetSubscriptionDurable(maxLifetimeCount: newLifetimeCount);
Assert.That(subscription.Diagnostics.MaxLifetimeCount, Is.EqualTo(newLifetimeCount));
}
/// <summary>
/// Review U9: the durable lifetime is at least three keep-alive intervals, so the
/// subscription cannot expire before its keep-alive is due.
/// </summary>
[Test]
public void SetSubscriptionDurableKeepsTheLifetimeAtLeastThreeKeepAlives()
{
m_queueFactoryMock.Setup(f => f.SupportsDurableQueues).Returns(true);
using Subscription subscription = CreateSubscription(
publishingInterval: 2_000_000,
maxLifetimeCount: 3,
maxKeepAliveCount: 1);
subscription.SetSubscriptionDurable(maxLifetimeCount: 1);
Assert.That(subscription.Diagnostics.MaxLifetimeCount, Is.EqualTo(3u));
}
[Test]
public void ModifyUpdatesPublishingIntervalInDiagnostics()
{
const double newInterval = 2000.0;
using Subscription subscription = CreateSubscription(publishingInterval: 1000);
OperationContext context = CreateOperationContext();
subscription.Modify(context,
publishingInterval: newInterval,
maxLifetimeCount: 10,
maxKeepAliveCount: 5,
maxNotificationsPerPublish: 0,
priority: 0);
Assert.That(subscription.Diagnostics.PublishingInterval, Is.EqualTo(newInterval));
Assert.That(subscription.PublishingInterval, Is.EqualTo(newInterval));
}
[Test]
public void ModifyIncrementsDiagnosticsModifyCount()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
Assert.That(subscription.Diagnostics.ModifyCount, Is.Zero);
subscription.Modify(context, 1000, 10, 5, 0, 0);
Assert.That(subscription.Diagnostics.ModifyCount, Is.EqualTo(1u));
}
[Test]
public void ModifyUpdatesPriority()
{
const byte newPriority = 100;
using Subscription subscription = CreateSubscription(priority: 0);
OperationContext context = CreateOperationContext();
subscription.Modify(context, 1000, 10, 5, 0, priority: newPriority);
Assert.That(subscription.Priority, Is.EqualTo(newPriority));
Assert.That(subscription.Diagnostics.Priority, Is.EqualTo(newPriority));
}
[Test]
public void ModifyUpdatesMaxKeepAliveCount()
{
const uint newKeepAlive = 10u;
using Subscription subscription = CreateSubscription(maxKeepAliveCount: 5);
OperationContext context = CreateOperationContext();
subscription.Modify(context, 1000, 10, maxKeepAliveCount: newKeepAlive, 0, 0);
Assert.That(subscription.Diagnostics.MaxKeepAliveCount, Is.EqualTo(newKeepAlive));
}
[Test]
public void ModifyUpdatesMaxLifetimeCount()
{
const uint newLifetime = 30u;
using Subscription subscription = CreateSubscription(maxLifetimeCount: 10);
OperationContext context = CreateOperationContext();
subscription.Modify(context, 1000, maxLifetimeCount: newLifetime, 5, 0, 0);
Assert.That(subscription.Diagnostics.MaxLifetimeCount, Is.EqualTo(newLifetime));
}
[Test]
public void ModifyCanBeCalledMultipleTimesIncrementingModifyCount()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
subscription.Modify(context, 1000, 10, 5, 0, 0);
subscription.Modify(context, 2000, 10, 5, 0, 0);
Assert.That(subscription.Diagnostics.ModifyCount, Is.EqualTo(2u));
}
[Test]
public void SetPublishingModeDisableIncrementsDisableCount()
{
using Subscription subscription = CreateSubscription(publishingEnabled: true);
OperationContext context = CreateOperationContext();
Assert.That(subscription.Diagnostics.DisableCount, Is.Zero);
subscription.SetPublishingMode(context, publishingEnabled: false);
Assert.That(subscription.Diagnostics.DisableCount, Is.EqualTo(1u));
Assert.That(subscription.Diagnostics.PublishingEnabled, Is.False);
}
[Test]
public void SetPublishingModeEnableIncrementsEnableCount()
{
using Subscription subscription = CreateSubscription(publishingEnabled: false);
OperationContext context = CreateOperationContext();
Assert.That(subscription.Diagnostics.EnableCount, Is.Zero);
subscription.SetPublishingMode(context, publishingEnabled: true);
Assert.That(subscription.Diagnostics.EnableCount, Is.EqualTo(1u));
Assert.That(subscription.Diagnostics.PublishingEnabled, Is.True);
}
[Test]
public void SetPublishingModeNoChangeDoesNotIncrementEnableOrDisableCount()
{
using Subscription subscription = CreateSubscription(publishingEnabled: true);
OperationContext context = CreateOperationContext();
subscription.SetPublishingMode(context, publishingEnabled: true);
Assert.That(subscription.Diagnostics.EnableCount, Is.Zero);
Assert.That(subscription.Diagnostics.DisableCount, Is.Zero);
}
[Test]
public void AcknowledgeReturnsBadSequenceNumberInvalidForSequenceNumberZero()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
ServiceResult result = subscription.Acknowledge(context, sequenceNumber: 0)!;
Assert.That(result, Is.Not.Null);
Assert.That(result.Code, Is.EqualTo(StatusCodes.BadSequenceNumberInvalid));
}
[Test]
public void AcknowledgeReturnsBadSequenceNumberUnknownForUnknownMessage()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
ServiceResult result = subscription.Acknowledge(context, sequenceNumber: 42)!;
Assert.That(result, Is.Not.Null);
Assert.That(result.Code, Is.EqualTo(StatusCodes.BadSequenceNumberUnknown));
}
[Test]
public void AcknowledgeRemovesMessageFromQueue()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
var message = new NotificationMessage { SequenceNumber = 5 };
InjectSentMessages(subscription, message);
Assert.That(subscription.AvailableSequenceNumbersForRetransmission(), Has.Count.EqualTo(1));
ServiceResult? result = subscription.Acknowledge(context, sequenceNumber: 5);
Assert.That(result, Is.Null, "Successful acknowledge returns null ServiceResult");
Assert.That(subscription.AvailableSequenceNumbersForRetransmission(), Is.Empty);
}
[Test]
public void AcknowledgeReturnsNullForSuccessfulRemoval()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
var message = new NotificationMessage { SequenceNumber = 10 };
InjectSentMessages(subscription, message);
ServiceResult? result = subscription.Acknowledge(context, sequenceNumber: 10);
Assert.That(result, Is.Null);
}
[Test]
public void RepublishThrowsBadMessageNotAvailableWhenNoMessages()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
Assert.That(
() => subscription.Republish(context, retransmitSequenceNumber: 99),
Throws.TypeOf<ServiceResultException>()
.With.Property("Code")
.EqualTo(StatusCodes.BadMessageNotAvailable));
}
[Test]
public void RepublishReturnsCachedMessage()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
var message = new NotificationMessage { SequenceNumber = 7 };
InjectSentMessages(subscription, message);
NotificationMessage result = subscription.Republish(context, retransmitSequenceNumber: 7);
Assert.That(result, Is.Not.Null);
Assert.That(result.SequenceNumber, Is.EqualTo(7u));
}
[Test]
public void RepublishIncrementsDiagnosticsRepublishMessageCount()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
var message = new NotificationMessage { SequenceNumber = 3 };
InjectSentMessages(subscription, message);
Assert.That(subscription.Diagnostics.RepublishMessageCount, Is.Zero);
subscription.Republish(context, retransmitSequenceNumber: 3);
Assert.That(subscription.Diagnostics.RepublishMessageCount, Is.EqualTo(1u));
}
[Test]
public void RepublishThrowsForUnknownSequenceNumberEvenWhenMessagesExist()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
var message = new NotificationMessage { SequenceNumber = 3 };
InjectSentMessages(subscription, message);
Assert.That(
() => subscription.Republish(context, retransmitSequenceNumber: 99),
Throws.TypeOf<ServiceResultException>()
.With.Property("Code")
.EqualTo(StatusCodes.BadMessageNotAvailable));
}
[Test]
public void AvailableSequenceNumbersForRetransmissionReturnsEmptyForNewSubscription()
{
using Subscription subscription = CreateSubscription();
ArrayOf<uint> result = subscription.AvailableSequenceNumbersForRetransmission();
Assert.That(result, Is.Empty);
}
[Test]
public void AvailableSequenceNumbersForRetransmissionReturnsAllSentMessageSequenceNumbers()
{
using Subscription subscription = CreateSubscription();
InjectSentMessages(subscription,
new NotificationMessage { SequenceNumber = 1 },
new NotificationMessage { SequenceNumber = 2 },
new NotificationMessage { SequenceNumber = 3 });
ArrayOf<uint> result = subscription.AvailableSequenceNumbersForRetransmission();
Assert.That(result, Has.Count.EqualTo(3));
Assert.That(result.ToArray(), Does.Contain(1u));
Assert.That(result.ToArray(), Does.Contain(2u));
Assert.That(result.ToArray(), Does.Contain(3u));
}
[Test]
public void PublishReturnsKeepaliveMessageWhenNoItems()
{
using Subscription subscription = CreateSubscription(maxKeepAliveCount: 5);
OperationContext context = CreateOperationContext();
NotificationMessage message = subscription.Publish(
context,
out ArrayOf<uint> availableSequenceNumbers,
out bool moreNotifications)!;
Assert.That(message, Is.Not.Null);
Assert.That(message.NotificationData, Is.Empty,
"Keepalive message has no notification data");
Assert.That(moreNotifications, Is.False);
}
[Test]
public void PublishIncrementsDiagnosticsPublishRequestCount()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
Assert.That(subscription.Diagnostics.PublishRequestCount, Is.Zero);
subscription.Publish(context, out _, out _);
Assert.That(subscription.Diagnostics.PublishRequestCount, Is.EqualTo(1u));
}
[Test]
public void PublishThrowsArgumentNullExceptionForNullContext()
{
using Subscription subscription = CreateSubscription();
Assert.That(
() => subscription.Publish(context: null!, out _, out _),
Throws.TypeOf<ArgumentNullException>());
}
[Test]
public void PublishReturnsNullAfterPublishTimeout()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
subscription.PublishTimeout();
NotificationMessage? result = subscription.Publish(context, out _, out _);
Assert.That(result, Is.Null);
}
[Test]
public void SetTriggeringThrowsBadMonitoredItemIdInvalidWhenTriggeringItemNotFound()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
Assert.That(
() => subscription.SetTriggering(
context,
triggeringItemId: 999,
linksToAdd: [1, 2],
linksToRemove: [],
out _,
out _,
out _,
out _),
Throws.TypeOf<ServiceResultException>()
.With.Property("Code")
.EqualTo(StatusCodes.BadMonitoredItemIdInvalid));
}
[Test]
public void SetTriggeringThrowsArgumentNullExceptionForNullContext()
{
using Subscription subscription = CreateSubscription();
Assert.That(
() => subscription.SetTriggering(
context: null!,
triggeringItemId: 1,
linksToAdd: [],
linksToRemove: [],
out _,
out _,
out _,
out _),
Throws.TypeOf<ArgumentNullException>());
}
[Test]
public void RepublishThrowsArgumentNullExceptionForNullContext()
{
using Subscription subscription = CreateSubscription();
Assert.That(
() => subscription.Republish(context: null!, retransmitSequenceNumber: 1),
Throws.TypeOf<ArgumentNullException>());
}
[Test]
public void IsDeletedIsFalseForNewSubscription()
{
using Subscription subscription = CreateSubscription();
Assert.That(subscription.IsDeleted, Is.False);
}
[Test]
public async System.Threading.Tasks.Task DeleteAsyncSetsIsDeleted()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
await subscription.DeleteAsync(context).ConfigureAwait(false);
Assert.That(subscription.IsDeleted, Is.True);
}
[Test]
public async System.Threading.Tasks.Task GatedMethodsThrowBadSubscriptionIdInvalidAfterDelete()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
await subscription.DeleteAsync(context).ConfigureAwait(false);
Assert.Multiple(() =>
{
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.Modify(context, 1000, 10, 5, 0, 0))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.SetPublishingMode(context, publishingEnabled: false))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.ResendData(context))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.Acknowledge(context, sequenceNumber: 1))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.Republish(context, retransmitSequenceNumber: 1))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.GetMonitoredItems(out _, out _))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.SetSubscriptionDurable(maxLifetimeCount: 100))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.ValidateConditionRefresh(context))!);
AssertBadSubscriptionId(Assert.Throws<ServiceResultException>(
() => subscription.SetTriggering(
context, triggeringItemId: 1, linksToAdd: [], linksToRemove: [],
out _, out _, out _, out _))!);
});
}
[Test]
public async System.Threading.Tasks.Task GatedAsyncMethodsThrowBadSubscriptionIdInvalidAfterDelete()
{
using Subscription subscription = CreateSubscription();
OperationContext context = CreateOperationContext();
await subscription.DeleteAsync(context).ConfigureAwait(false);
AssertBadSubscriptionId(Assert.ThrowsAsync<ServiceResultException>(
async () => await subscription.CreateMonitoredItemsAsync(
context, TimestampsToReturn.Both, []).ConfigureAwait(false)));
AssertBadSubscriptionId(Assert.ThrowsAsync<ServiceResultException>(
async () => await subscription.ModifyMonitoredItemsAsync(
context, TimestampsToReturn.Both, []).ConfigureAwait(false)));
AssertBadSubscriptionId(Assert.ThrowsAsync<ServiceResultException>(
async () => await subscription.DeleteMonitoredItemsAsync(context, []).ConfigureAwait(false)));
AssertBadSubscriptionId(Assert.ThrowsAsync<ServiceResultException>(
async () => await subscription.SetMonitoringModeAsync(
context, MonitoringMode.Reporting, []).ConfigureAwait(false)));
AssertBadSubscriptionId(Assert.ThrowsAsync<ServiceResultException>(
async () => await subscription.ConditionRefreshAsync().ConfigureAwait(false)));
}
private static void AssertBadSubscriptionId(ServiceResultException ex)
{
Assert.That(ex, Is.Not.Null);
Assert.That(ex.Code, Is.EqualTo(StatusCodes.BadSubscriptionIdInvalid));
}
}
}