Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/TrustedApplicationRoleTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

322 lines
13 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Threading.Tasks;
using Moq;
using NUnit.Framework;
using Opc.Ua.Security.Certificates;
using Opc.Ua.Server.TestFramework;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests
{
/// <summary>
/// Tests for TrustedApplication role assignment per OPC UA Part 3 §4.9.
/// </summary>
[TestFixture]
[Category("Session")]
[Parallelizable]
public class TrustedApplicationRoleTests
{
private Mock<IServerInternal> m_serverMock;
private ITelemetryContext m_telemetry;
private Certificate m_testCertificate;
private ApplicationConfiguration m_config;
[OneTimeSetUp]
public void OneTimeSetUp()
{
m_testCertificate = CertificateBuilder
.Create("CN=TrustedApplicationRoleTest")
.SetRSAKeySize(CertificateFactory.DefaultKeySize)
.CreateForRSA();
}
[OneTimeTearDown]
public void OneTimeTearDown()
{
m_testCertificate?.Dispose();
}
[SetUp]
public void SetUp()
{
m_telemetry = NUnitTelemetryContext.Create();
m_serverMock = new Mock<IServerInternal>();
m_serverMock.Setup(s => s.Telemetry).Returns(m_telemetry);
m_serverMock.Setup(s => s.NamespaceUris).Returns(new NamespaceTable());
m_config = new ApplicationConfiguration
{
ServerConfiguration = new ServerConfiguration
{
MinSessionTimeout = 1000,
MaxSessionTimeout = 3_600_000,
MaxSessionCount = 100,
MaxRequestAge = 60_000,
MaxBrowseContinuationPoints = 10,
MaxHistoryContinuationPoints = 10
}
};
}
/// <summary>
/// Creates an <see cref="OperationContext"/> whose channel has the given security mode.
/// </summary>
private static OperationContext CreateOperationContext(MessageSecurityMode securityMode)
{
var endpoint = new EndpointDescription { SecurityMode = securityMode };
var channelContext = new SecureChannelContext("test-channel", endpoint, RequestEncoding.Binary);
var requestHeader = new RequestHeader();
return new OperationContext(requestHeader, channelContext, RequestType.ActivateSession, RequestLifetime.None);
}
private TestableSessionManager CreateManager()
{
return new TestableSessionManager(m_serverMock.Object, m_config);
}
private static Mock<ISession> CreateSessionMock(Certificate certificate)
{
var sessionMock = new Mock<ISession>();
sessionMock.Setup(s => s.ClientCertificate).Returns(certificate);
return sessionMock;
}
[Test]
public void AddMandatoryRoles_WithCertAndSignMode_AddsTrustedApplicationRole()
{
using TestableSessionManager manager = CreateManager();
Mock<ISession> sessionMock = CreateSessionMock(m_testCertificate);
OperationContext context = CreateOperationContext(MessageSecurityMode.Sign);
var identity = new UserIdentity();
IUserIdentity result = manager.PublicAddMandatoryRoles(sessionMock.Object, context, identity);
Assert.That(result.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_TrustedApplication), Is.True,
"Session with certificate on a signed channel should have the TrustedApplication role.");
}
[Test]
public void AddMandatoryRoles_WithCertAndSignAndEncryptMode_AddsTrustedApplicationRole()
{
using TestableSessionManager manager = CreateManager();
Mock<ISession> sessionMock = CreateSessionMock(m_testCertificate);
OperationContext context = CreateOperationContext(MessageSecurityMode.SignAndEncrypt);
var identity = new UserIdentity();
IUserIdentity result = manager.PublicAddMandatoryRoles(sessionMock.Object, context, identity);
Assert.That(result.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_TrustedApplication), Is.True,
"Session with certificate on a sign-and-encrypt channel should have the TrustedApplication role.");
}
[Test]
public void AddMandatoryRoles_WithCertAndNoneMode_DoesNotAddTrustedApplicationRole()
{
using TestableSessionManager manager = CreateManager();
Mock<ISession> sessionMock = CreateSessionMock(m_testCertificate);
OperationContext context = CreateOperationContext(MessageSecurityMode.None);
var identity = new UserIdentity();
IUserIdentity result = manager.PublicAddMandatoryRoles(sessionMock.Object, context, identity);
Assert.That(result.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_TrustedApplication), Is.False,
"Session on a None-security channel should not have the TrustedApplication role.");
}
[Test]
public void AddMandatoryRoles_WithNoCertAndSignMode_DoesNotAddTrustedApplicationRole()
{
using TestableSessionManager manager = CreateManager();
Mock<ISession> sessionMock = CreateSessionMock(certificate: null!);
OperationContext context = CreateOperationContext(MessageSecurityMode.Sign);
var identity = new UserIdentity();
IUserIdentity result = manager.PublicAddMandatoryRoles(sessionMock.Object, context, identity);
Assert.That(result.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_TrustedApplication), Is.False,
"Session without a certificate should not have the TrustedApplication role.");
}
[Test]
public void AddMandatoryRoles_WithNoCertAndNoneMode_DoesNotAddTrustedApplicationRole()
{
using TestableSessionManager manager = CreateManager();
Mock<ISession> sessionMock = CreateSessionMock(certificate: null!);
OperationContext context = CreateOperationContext(MessageSecurityMode.None);
var identity = new UserIdentity();
IUserIdentity result = manager.PublicAddMandatoryRoles(sessionMock.Object, context, identity);
Assert.That(result.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_TrustedApplication), Is.False,
"Session without a certificate on a None-security channel should not have the TrustedApplication role.");
}
[Test]
public void AddMandatoryRoles_WithCertAndSignMode_PreservesExistingRoles()
{
using TestableSessionManager manager = CreateManager();
Mock<ISession> sessionMock = CreateSessionMock(m_testCertificate);
OperationContext context = CreateOperationContext(MessageSecurityMode.Sign);
// Identity that already has AuthenticatedUser role
IUserIdentity identity = new RoleBasedIdentity(
new UserIdentity(),
[Role.AuthenticatedUser],
new NamespaceTable());
IUserIdentity result = manager.PublicAddMandatoryRoles(sessionMock.Object, context, identity);
Assert.That(result.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_TrustedApplication), Is.True,
"The TrustedApplication role should be added.");
Assert.That(result.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_AuthenticatedUser), Is.True,
"Pre-existing roles should be preserved.");
}
[Test]
public void AddMandatoryRoles_WithNoCertAndSignMode_ReturnsIdentityUnchanged()
{
using TestableSessionManager manager = CreateManager();
Mock<ISession> sessionMock = CreateSessionMock(certificate: null!);
OperationContext context = CreateOperationContext(MessageSecurityMode.Sign);
var identity = new UserIdentity();
IUserIdentity result = manager.PublicAddMandatoryRoles(sessionMock.Object, context, identity);
Assert.That(result, Is.SameAs(identity),
"When conditions are not met, the original identity object should be returned unchanged.");
}
}
/// <summary>
/// Integration tests for TrustedApplication role using a live server fixture.
/// These tests cover the negative path (no cert / None security) via the full session pipeline.
/// </summary>
[TestFixture]
[Category("Session")]
public class TrustedApplicationRoleIntegrationTests
{
private ServerFixture<StandardServer> m_fixture;
private StandardServer m_server;
[OneTimeSetUp]
public async Task OneTimeSetUpAsync()
{
m_fixture = new ServerFixture<StandardServer>(t => new StandardServer(t));
await m_fixture.StartAsync().ConfigureAwait(false);
m_server = m_fixture.Server;
}
[OneTimeTearDown]
public async Task OneTimeTearDownAsync()
{
await m_fixture.StopAsync().ConfigureAwait(false);
}
[Test]
public async Task SessionWithNoSecurityDoesNotHaveTrustedApplicationRoleAsync()
{
(RequestHeader requestHeader, _) =
await m_server.CreateAndActivateSessionAsync("NoCertNoTrusted", useSecurity: false)
.ConfigureAwait(false);
ISession? session = m_server.CurrentInstance.SessionManager.GetSession(
requestHeader.AuthenticationToken);
Assert.That(session, Is.Not.Null);
Assert.That(session!.EffectiveIdentity.GrantedRoleIds.Contains(ObjectIds.WellKnownRole_TrustedApplication), Is.False,
"Session with no certificate and None security should not have the TrustedApplication role.");
}
}
/// <summary>
/// Exposes the protected <see cref="SessionManager.AddMandatoryRoles"/> method for unit testing.
/// </summary>
internal sealed class TestableSessionManager : SessionManager
{
public TestableSessionManager(IServerInternal server, ApplicationConfiguration config)
: base(server, config)
{
}
/// <summary>
/// Sessions that <see cref="GetSessions"/> should return. When
/// <see langword="null"/>, falls back to the inherited behaviour.
/// </summary>
public System.Collections.Generic.IList<ISession>? InjectedSessions { get; set; }
public override System.Collections.Generic.IList<ISession> GetSessions()
{
return InjectedSessions ?? base.GetSessions();
}
public IUserIdentity PublicAddMandatoryRoles(
ISession session,
OperationContext context,
IUserIdentity effectiveIdentity)
{
return AddMandatoryRoles(session, context, effectiveIdentity);
}
public ServiceResult PublicComputeActivationStatus(IUserIdentity effectiveIdentity)
{
return ComputeActivationStatus(effectiveIdentity);
}
public void PublicReevaluateIdentityIfStale(ISession session, SecureChannelContext channelContext)
{
ReevaluateIdentityIfStale(session, channelContext);
}
public ValueTask<(
IUserIdentity? Identity,
IUserIdentity? EffectiveIdentity,
ServiceResult? Error)> PublicAuthenticateUserIdentityAsync(
ISession session,
IUserIdentityTokenHandler newIdentity,
UserTokenPolicy? userTokenPolicy,
EndpointDescription endpointDescription,
System.Threading.CancellationToken cancellationToken = default)
{
return AuthenticateUserIdentityAsync(
session,
newIdentity,
userTokenPolicy,
endpointDescription,
cancellationToken);
}
public void PublicOnRoleConfigurationChanged(object? sender, RoleConfigurationChangedEventArgs e)
{
OnRoleConfigurationChanged(sender, e);
}
}
}