mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 09:06:37 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
900 lines
42 KiB
C#
900 lines
42 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Server.UserManagement;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
/// <summary>
|
|
/// Unit tests for <see cref="UserManagementBinding"/> covering the static
|
|
/// <c>Bind</c> guard clauses, dispose idempotency, and the
|
|
/// <see cref="IUserManagement.UserDeactivated"/> session-closing logic
|
|
/// (Part 18 §5.2.6 / §5.2.7).
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Roles")]
|
|
public class UserManagementBindingTests
|
|
{
|
|
private Mock<IServerInternal> m_mockServer = null!;
|
|
private ApplicationConfiguration m_configuration = null!;
|
|
private Mock<ILogger> m_mockLogger = null!;
|
|
private MonitoredItemQueueFactory m_monitoredItemQueueFactory = null!;
|
|
private Mock<IUserManagement> m_userManagement = null!;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_mockServer = new Mock<IServerInternal>();
|
|
m_mockLogger = new Mock<ILogger>();
|
|
var mockMasterNodeManager = new Mock<IMasterNodeManager>();
|
|
var mockConfigurationNodeManager = new Mock<IConfigurationNodeManager>();
|
|
|
|
var namespaceTable = new NamespaceTable();
|
|
namespaceTable.Append("http://test.org/UA/UserManagement/");
|
|
|
|
m_mockServer.Setup(s => s.NamespaceUris).Returns(namespaceTable);
|
|
m_mockServer.Setup(s => s.ServerUris).Returns(new StringTable());
|
|
m_mockServer.Setup(s => s.TypeTree).Returns(new TypeTable(namespaceTable));
|
|
m_mockServer.Setup(s => s.Factory).Returns(EncodeableFactory.Create());
|
|
m_mockServer.Setup(s => s.NodeManager).Returns(mockMasterNodeManager.Object);
|
|
mockMasterNodeManager.Setup(m => m.ConfigurationNodeManager)
|
|
.Returns(mockConfigurationNodeManager.Object);
|
|
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
m_mockServer.Setup(s => s.Telemetry).Returns(mockTelemetry.Object);
|
|
|
|
m_monitoredItemQueueFactory = new MonitoredItemQueueFactory(mockTelemetry.Object);
|
|
m_mockServer.Setup(s => s.MonitoredItemQueueFactory).Returns(m_monitoredItemQueueFactory);
|
|
|
|
var serverSystemContext = new ServerSystemContext(m_mockServer.Object);
|
|
m_mockServer.Setup(s => s.DefaultSystemContext).Returns(serverSystemContext);
|
|
|
|
m_configuration = new ApplicationConfiguration
|
|
{
|
|
ServerConfiguration = new ServerConfiguration
|
|
{
|
|
MaxNotificationQueueSize = 100,
|
|
MaxDurableNotificationQueueSize = 200
|
|
}
|
|
};
|
|
|
|
m_userManagement = new Mock<IUserManagement>();
|
|
m_userManagement.Setup(m => m.PasswordLength).Returns(new Range { Low = 8, High = 64 });
|
|
m_userManagement.Setup(m => m.PasswordOptions).Returns(PasswordOptionsMask.None);
|
|
m_userManagement.Setup(m => m.PasswordRestrictions).Returns(new LocalizedText("restrictions"));
|
|
m_userManagement.Setup(m => m.SnapshotUsers()).Returns([]);
|
|
}
|
|
|
|
[TearDown]
|
|
public void TearDown()
|
|
{
|
|
m_monitoredItemQueueFactory?.Dispose();
|
|
}
|
|
|
|
private TestableAsyncCustomNodeManager CreateNodeManager()
|
|
{
|
|
return new TestableAsyncCustomNodeManager(
|
|
m_mockServer.Object,
|
|
m_configuration,
|
|
m_mockLogger.Object,
|
|
"http://test.org/UA/UserManagement/");
|
|
}
|
|
|
|
private TestableAsyncCustomNodeManager CreateNodeManagerWithUserManagementNode()
|
|
{
|
|
TestableAsyncCustomNodeManager manager = CreateNodeManager();
|
|
var state = new UserManagementState(null)
|
|
{
|
|
NodeId = new NodeId(Objects.UserManagement)
|
|
};
|
|
manager.PredefinedNodes[state.NodeId] = state;
|
|
return manager;
|
|
}
|
|
|
|
private (TestableAsyncCustomNodeManager Manager, UserManagementState State)
|
|
CreateNodeManagerWithCreatedUserManagementNode()
|
|
{
|
|
TestableAsyncCustomNodeManager manager = CreateNodeManager();
|
|
var state = new UserManagementState(null);
|
|
state.Create(
|
|
manager.SystemContext,
|
|
new NodeId(Objects.UserManagement),
|
|
new QualifiedName(BrowseNames.UserManagement),
|
|
new LocalizedText(BrowseNames.UserManagement),
|
|
false);
|
|
manager.PredefinedNodes[state.NodeId] = state;
|
|
return (manager, state);
|
|
}
|
|
|
|
private static Mock<ISession> CreateSessionWithUser(
|
|
string? userName,
|
|
UserTokenType tokenType = UserTokenType.UserName)
|
|
{
|
|
var identity = new Mock<IUserIdentity>();
|
|
identity.Setup(i => i.DisplayName).Returns(userName!);
|
|
identity.Setup(i => i.TokenType).Returns(tokenType);
|
|
|
|
var session = new Mock<ISession>();
|
|
session.Setup(s => s.Identity).Returns(identity.Object);
|
|
session.Setup(s => s.Id).Returns(new NodeId(Guid.NewGuid()));
|
|
return session;
|
|
}
|
|
|
|
private static SessionSystemContext BuildContext(
|
|
MessageSecurityMode securityMode,
|
|
IUserIdentity identity)
|
|
{
|
|
var endpoint = new EndpointDescription { SecurityMode = securityMode };
|
|
var channelContext = new SecureChannelContext("test-channel", endpoint, RequestEncoding.Binary);
|
|
var operationContext = new OperationContext(
|
|
new RequestHeader(),
|
|
channelContext,
|
|
RequestType.Call,
|
|
RequestLifetime.None,
|
|
identity);
|
|
return new SessionSystemContext(operationContext, NUnitTelemetryContext.Create())
|
|
{
|
|
NamespaceUris = new NamespaceTable(),
|
|
ServerUris = new StringTable()
|
|
};
|
|
}
|
|
|
|
private static IUserIdentity BuildIdentity(
|
|
UserTokenType tokenType,
|
|
string displayName,
|
|
params NodeId[] grantedRoles)
|
|
{
|
|
var identity = new Mock<IUserIdentity>();
|
|
identity.Setup(i => i.TokenType).Returns(tokenType);
|
|
identity.Setup(i => i.DisplayName).Returns(displayName);
|
|
identity.Setup(i => i.GrantedRoleIds).Returns(ArrayOf.Wrapped(grantedRoles));
|
|
return identity.Object;
|
|
}
|
|
|
|
private static SessionSystemContext BuildAdminContext()
|
|
{
|
|
return BuildContext(
|
|
MessageSecurityMode.SignAndEncrypt,
|
|
BuildIdentity(
|
|
UserTokenType.UserName,
|
|
"admin",
|
|
ObjectIds.WellKnownRole_SecurityAdmin));
|
|
}
|
|
|
|
[Test]
|
|
public void BindRejectsNullNodeManager()
|
|
{
|
|
ArgumentNullException ex = Assert.Throws<ArgumentNullException>(
|
|
() => UserManagementBinding.Bind(null!, m_userManagement.Object, null));
|
|
Assert.That(ex.ParamName, Is.EqualTo("nodeManager"));
|
|
}
|
|
|
|
[Test]
|
|
public void BindRejectsNullUserManagement()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManager();
|
|
ArgumentNullException ex = Assert.Throws<ArgumentNullException>(
|
|
() => UserManagementBinding.Bind(manager, null!, null));
|
|
Assert.That(ex.ParamName, Is.EqualTo("userManagement"));
|
|
}
|
|
|
|
[Test]
|
|
public void BindReturnsNullWhenUserManagementNodeMissing()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManager();
|
|
var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null);
|
|
Assert.That(binding, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void BindReturnsBindingWhenUserManagementNodePresent()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null);
|
|
Assert.That(binding, Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task AddUserRejectsNonAdminAndDoesNotDelegateAsync()
|
|
{
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
using (manager)
|
|
using (var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null))
|
|
{
|
|
Assert.That(binding, Is.Not.Null);
|
|
SessionSystemContext context = BuildContext(
|
|
MessageSecurityMode.SignAndEncrypt,
|
|
BuildIdentity(UserTokenType.UserName, "operator", ObjectIds.WellKnownRole_Operator));
|
|
|
|
AddUserMethodStateResult result = await state.AddUser!.OnCallAsync!(
|
|
context,
|
|
state.AddUser,
|
|
state.NodeId,
|
|
"alice",
|
|
"password",
|
|
(uint)UserConfigurationMask.None,
|
|
"Alice",
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(result.ServiceResult.StatusCode, Is.EqualTo(StatusCodes.BadUserAccessDenied));
|
|
m_userManagement.Verify(
|
|
m => m.AddUser(
|
|
It.IsAny<string>(),
|
|
It.IsAny<string>(),
|
|
It.IsAny<UserConfigurationMask>(),
|
|
It.IsAny<string>()),
|
|
Times.Never);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task AdminMethodsDelegateToUserManagementAndRefreshPropertiesAsync()
|
|
{
|
|
UserManagementDataType[] initialUsers = [];
|
|
UserManagementDataType[] addedUsers =
|
|
[
|
|
new UserManagementDataType
|
|
{
|
|
UserName = "alice",
|
|
UserConfiguration = (uint)UserConfigurationMask.None,
|
|
Description = "Alice"
|
|
}
|
|
];
|
|
UserManagementDataType[] modifiedUsers =
|
|
[
|
|
new UserManagementDataType
|
|
{
|
|
UserName = "alice",
|
|
UserConfiguration = (uint)UserConfigurationMask.Disabled,
|
|
Description = "Disabled"
|
|
}
|
|
];
|
|
UserManagementDataType[] removedUsers = [];
|
|
m_userManagement
|
|
.SetupSequence(m => m.SnapshotUsers())
|
|
.Returns(initialUsers)
|
|
.Returns(addedUsers)
|
|
.Returns(modifiedUsers)
|
|
.Returns(removedUsers);
|
|
m_userManagement.Setup(m => m.AddUser("alice", "password", UserConfigurationMask.None, "Alice"))
|
|
.Returns(ServiceResult.Good);
|
|
m_userManagement
|
|
.Setup(m => m.ModifyUser(
|
|
"alice", true, "new", true, UserConfigurationMask.Disabled, true, "Disabled", "admin"))
|
|
.Returns(ServiceResult.Good);
|
|
m_userManagement.Setup(m => m.RemoveUser("alice", "admin")).Returns(ServiceResult.Good);
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
|
|
using (manager)
|
|
using (var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null))
|
|
{
|
|
Assert.That(binding, Is.Not.Null);
|
|
SessionSystemContext context = BuildAdminContext();
|
|
|
|
AddUserMethodStateResult addResult = await state.AddUser!.OnCallAsync!(
|
|
context,
|
|
state.AddUser,
|
|
state.NodeId,
|
|
"alice",
|
|
"password",
|
|
(uint)UserConfigurationMask.None,
|
|
"Alice",
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(ServiceResult.IsGood(addResult.ServiceResult), Is.True);
|
|
Assert.That(state.Users!.Value, Has.Count.EqualTo(1));
|
|
Assert.That(state.Users.Value[0].UserName, Is.EqualTo("alice"));
|
|
Assert.That(state.Users.Value[0].UserConfiguration, Is.EqualTo((uint)UserConfigurationMask.None));
|
|
Assert.That(state.Users.Value[0].Description, Is.EqualTo("Alice"));
|
|
|
|
ModifyUserMethodStateResult modifyResult = await state.ModifyUser!.OnCallAsync!(
|
|
context,
|
|
state.ModifyUser,
|
|
state.NodeId,
|
|
"alice",
|
|
true,
|
|
"new",
|
|
true,
|
|
(uint)UserConfigurationMask.Disabled,
|
|
true,
|
|
"Disabled",
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(ServiceResult.IsGood(modifyResult.ServiceResult), Is.True);
|
|
Assert.That(state.Users!.Value, Has.Count.EqualTo(1));
|
|
Assert.That(state.Users.Value[0].UserName, Is.EqualTo("alice"));
|
|
Assert.That(
|
|
state.Users.Value[0].UserConfiguration,
|
|
Is.EqualTo((uint)UserConfigurationMask.Disabled));
|
|
Assert.That(state.Users.Value[0].Description, Is.EqualTo("Disabled"));
|
|
|
|
RemoveUserMethodStateResult removeResult = await state.RemoveUser!.OnCallAsync!(
|
|
context,
|
|
state.RemoveUser,
|
|
state.NodeId,
|
|
"alice",
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(ServiceResult.IsGood(removeResult.ServiceResult), Is.True);
|
|
Assert.That(state.Users!.Value, Is.Empty);
|
|
Assert.That(state.PasswordLength!.Value.High, Is.EqualTo(64));
|
|
|
|
m_userManagement.Verify(
|
|
m => m.AddUser("alice", "password", UserConfigurationMask.None, "Alice"),
|
|
Times.Once);
|
|
m_userManagement.Verify(
|
|
m => m.ModifyUser(
|
|
"alice",
|
|
true,
|
|
"new",
|
|
true,
|
|
UserConfigurationMask.Disabled,
|
|
true,
|
|
"Disabled",
|
|
"admin"),
|
|
Times.Once);
|
|
m_userManagement.Verify(m => m.RemoveUser("alice", "admin"), Times.Once);
|
|
m_userManagement.Verify(m => m.SnapshotUsers(), Times.Exactly(4));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task ChangePasswordRequiresUserNameIdentityAsync()
|
|
{
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
|
|
using (manager)
|
|
using (var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null))
|
|
{
|
|
Assert.That(binding, Is.Not.Null);
|
|
SessionSystemContext context = BuildContext(
|
|
MessageSecurityMode.SignAndEncrypt,
|
|
BuildIdentity(UserTokenType.IssuedToken, "alice", ObjectIds.WellKnownRole_SecurityAdmin));
|
|
|
|
ChangePasswordMethodStateResult result = await state.ChangePassword!.OnCallAsync!(
|
|
context,
|
|
state.ChangePassword,
|
|
state.NodeId,
|
|
"old",
|
|
"new",
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(result.ServiceResult.StatusCode, Is.EqualTo(StatusCodes.BadInvalidState));
|
|
m_userManagement.Verify(
|
|
m => m.ChangePassword(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()),
|
|
Times.Never);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task ChangePasswordDelegatesForSelfUserNameAsync()
|
|
{
|
|
m_userManagement.Setup(m => m.ChangePassword("alice", "old", "new"))
|
|
.Returns(ServiceResult.Good);
|
|
m_userManagement.SetupSequence(m => m.SnapshotUsers())
|
|
.Returns(
|
|
[
|
|
new UserManagementDataType
|
|
{
|
|
UserName = "alice",
|
|
UserConfiguration = (uint)UserConfigurationMask.MustChangePassword
|
|
}
|
|
])
|
|
.Returns(
|
|
[
|
|
new UserManagementDataType
|
|
{
|
|
UserName = "alice",
|
|
UserConfiguration = (uint)UserConfigurationMask.None
|
|
}
|
|
]);
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
|
|
using (manager)
|
|
using (var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null))
|
|
{
|
|
Assert.That(binding, Is.Not.Null);
|
|
SessionSystemContext context = BuildContext(
|
|
MessageSecurityMode.SignAndEncrypt,
|
|
BuildIdentity(UserTokenType.UserName, "alice", ObjectIds.WellKnownRole_Observer));
|
|
|
|
ChangePasswordMethodStateResult result = await state.ChangePassword!.OnCallAsync!(
|
|
context,
|
|
state.ChangePassword,
|
|
state.NodeId,
|
|
"old",
|
|
"new",
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(ServiceResult.IsGood(result.ServiceResult), Is.True);
|
|
m_userManagement.Verify(m => m.ChangePassword("alice", "old", "new"), Times.Once);
|
|
Assert.That(state.Users!.Value[0].UserConfiguration,
|
|
Is.EqualTo((uint)UserConfigurationMask.None));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void DisposeIsIdempotent()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null);
|
|
Assert.That(binding, Is.Not.Null);
|
|
|
|
binding!.Dispose();
|
|
Assert.DoesNotThrow(binding.Dispose);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that removing a user closes only matching sessions through coordinated server teardown.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task UserDeactivatedClosesMatchingSession()
|
|
{
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
using TestableAsyncCustomNodeManager managerLifetime = manager;
|
|
Mock<ISession> session = CreateSessionWithUser("bob");
|
|
Mock<ISession> unrelated = CreateSessionWithUser("alice");
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions()).Returns([session.Object, unrelated.Object]);
|
|
m_userManagement.Setup(m => m.RemoveUser("bob", "admin"))
|
|
.Callback(() => m_userManagement.Raise(
|
|
u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob")))
|
|
.Returns(ServiceResult.Good);
|
|
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
Assert.That(binding, Is.Not.Null);
|
|
|
|
RemoveUserMethodStateResult result = await state.RemoveUser!.OnCallAsync!(
|
|
BuildAdminContext(),
|
|
state.RemoveUser,
|
|
state.NodeId,
|
|
"bob",
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(ServiceResult.IsGood(result.ServiceResult), Is.True);
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), session.Object.Id, true, CancellationToken.None), Times.Once);
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), unrelated.Object.Id, It.IsAny<bool>(), It.IsAny<CancellationToken>()),
|
|
Times.Never);
|
|
session.Verify(s => s.Dispose(), Times.Never);
|
|
sessionManager.Verify(m => m.CloseSessionAsync(It.IsAny<NodeId>(), It.IsAny<CancellationToken>()),
|
|
Times.Never);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that deactivating a UserManagement user leaves sessions of other token types with the
|
|
/// same display name (issued tokens, certificates) open, and closes a USERNAME session identified
|
|
/// by its token even when the identity display name differs.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task UserDeactivatedClosesOnlyUserNameTokenSessionsAsync()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
Mock<ISession> issued = CreateSessionWithUser("bob", UserTokenType.IssuedToken);
|
|
Mock<ISession> certificate = CreateSessionWithUser("bob", UserTokenType.Certificate);
|
|
Mock<ISession> renamed = CreateSessionWithUser("Bob Builder");
|
|
renamed.Setup(s => s.IdentityToken).Returns(new UserNameIdentityTokenHandler("bob", [1, 2, 3]));
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions())
|
|
.Returns([issued.Object, certificate.Object, renamed.Object]);
|
|
await using UserManagementBinding binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object)!;
|
|
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob"));
|
|
await binding.DisposeAsync().ConfigureAwait(false);
|
|
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), renamed.Object.Id, true, CancellationToken.None), Times.Once);
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), issued.Object.Id, It.IsAny<bool>(), It.IsAny<CancellationToken>()),
|
|
Times.Never);
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), certificate.Object.Id, It.IsAny<bool>(), It.IsAny<CancellationToken>()),
|
|
Times.Never);
|
|
}
|
|
|
|
[Test]
|
|
public void UserDeactivatedIgnoresNonMatchingSession()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
Mock<ISession> session = CreateSessionWithUser("alice");
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions()).Returns([session.Object]);
|
|
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob"));
|
|
|
|
session.Verify(s => s.Dispose(), Times.Never);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a session-close failure is logged without undoing a committed user change or skipping other
|
|
/// sessions.
|
|
/// </summary>
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public async Task CommittedUserChangeKeepsResultAndPublishedUsersWhenCloseFailsAsync(bool remove)
|
|
{
|
|
var loggerFactory = new Mock<ILoggerFactory>();
|
|
loggerFactory.Setup(f => f.CreateLogger(It.IsAny<string>())).Returns(m_mockLogger.Object);
|
|
Mock.Get(m_mockServer.Object.Telemetry).Setup(t => t.LoggerFactory).Returns(loggerFactory.Object);
|
|
m_mockLogger.Setup(l => l.IsEnabled(It.IsAny<LogLevel>())).Returns(true);
|
|
m_userManagement.SetupSequence(m => m.SnapshotUsers())
|
|
.Returns([new UserManagementDataType { UserName = "bob" }])
|
|
.Returns(remove
|
|
? []
|
|
: [new UserManagementDataType
|
|
{
|
|
UserName = "bob",
|
|
UserConfiguration = (uint)UserConfigurationMask.Disabled
|
|
}]);
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
using TestableAsyncCustomNodeManager managerLifetime = manager;
|
|
Mock<ISession> session = CreateSessionWithUser("bob");
|
|
Mock<ISession> anotherSession = CreateSessionWithUser("bob");
|
|
var failure = new InvalidOperationException("close failed");
|
|
m_mockServer.Setup(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), session.Object.Id, true, It.IsAny<CancellationToken>()))
|
|
.Throws(failure);
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions()).Returns([session.Object, anotherSession.Object]);
|
|
SetupUserDeactivation();
|
|
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
|
|
ServiceResult result = await InvokeUserChangeAsync(
|
|
state, BuildAdminContext(), remove, CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(state.Users!.Value, Has.Count.EqualTo(remove ? 0 : 1));
|
|
if (!remove)
|
|
{
|
|
Assert.That(state.Users.Value[0].UserName, Is.EqualTo("bob"));
|
|
Assert.That(state.Users.Value[0].UserConfiguration,
|
|
Is.EqualTo((uint)UserConfigurationMask.Disabled));
|
|
}
|
|
m_userManagement.Verify(m => m.SnapshotUsers(), Times.Exactly(2));
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), anotherSession.Object.Id, true, CancellationToken.None), Times.Once);
|
|
m_mockLogger.Verify(l => l.Log(
|
|
LogLevel.Warning,
|
|
It.Is<EventId>(id => id.Name == "FailedToCloseSessionSessionIdForDeactivated"),
|
|
It.IsAny<It.IsAnyType>(),
|
|
failure,
|
|
It.IsAny<Func<It.IsAnyType, Exception?, string>>()), Times.Once);
|
|
session.Verify(s => s.Dispose(), Times.Never);
|
|
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.Good),
|
|
"A logged session-close failure must not report the committed user change as failed.");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a failed user mutation leaves published users unchanged and does not initiate session
|
|
/// teardown.
|
|
/// </summary>
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public async Task FailedUserChangeKeepsPublishedUsersAndDoesNotCloseSessionsAsync(bool remove)
|
|
{
|
|
m_userManagement.Setup(m => m.SnapshotUsers())
|
|
.Returns([new UserManagementDataType { UserName = "alice" }]);
|
|
m_userManagement.Setup(m => m.RemoveUser("bob", "admin"))
|
|
.Returns(new ServiceResult(StatusCodes.BadNotFound));
|
|
m_userManagement.Setup(m => m.ModifyUser(
|
|
"bob", false, string.Empty, true, UserConfigurationMask.Disabled, false, string.Empty, "admin"))
|
|
.Returns(new ServiceResult(StatusCodes.BadNotFound));
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
using TestableAsyncCustomNodeManager managerLifetime = manager;
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
|
|
ServiceResult result = await InvokeUserChangeAsync(
|
|
state, BuildAdminContext(), remove, CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadNotFound));
|
|
Assert.That(state.Users!.Value, Has.Count.EqualTo(1));
|
|
Assert.That(state.Users.Value[0].UserName, Is.EqualTo("alice"));
|
|
Assert.That(state.Users.Value[0].UserConfiguration, Is.Zero);
|
|
m_userManagement.Verify(m => m.SnapshotUsers(), Times.Once);
|
|
sessionManager.Verify(m => m.GetSessions(), Times.Never);
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), It.IsAny<NodeId>(), It.IsAny<bool>(), It.IsAny<CancellationToken>()),
|
|
Times.Never);
|
|
}
|
|
|
|
[Test]
|
|
public void UserDeactivatedSwallowsGetSessionsException()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions()).Throws(new InvalidOperationException("boom"));
|
|
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
|
|
Assert.DoesNotThrow(() =>
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob")));
|
|
}
|
|
|
|
[Test]
|
|
public void UserDeactivatedWithEmptyUserNameDoesNothing()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs(string.Empty));
|
|
|
|
sessionManager.Verify(m => m.GetSessions(), Times.Never);
|
|
}
|
|
|
|
[Test]
|
|
public void UserDeactivatedWithoutSessionManagerDoesNothing()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
|
|
using var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null);
|
|
|
|
Assert.DoesNotThrow(() =>
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob")));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that deactivation resolves a session manager installed after the binding was created.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task LateBoundServerSessionManagerIsResolvedAtDeactivationAsync()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
Mock<ISession> session = CreateSessionWithUser("bob");
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(value => value.GetSessions()).Returns([session.Object]);
|
|
await using UserManagementBinding binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, null)!;
|
|
m_mockServer.SetupGet(value => value.SessionManager).Returns(sessionManager.Object);
|
|
|
|
m_userManagement.Raise(value => value.UserDeactivated += null, new UserDeactivatedEventArgs("bob"));
|
|
await binding.DisposeAsync().ConfigureAwait(false);
|
|
|
|
m_mockServer.Verify(value => value.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), session.Object.Id, true, CancellationToken.None), Times.Once);
|
|
session.Verify(value => value.Dispose(), Times.Never);
|
|
}
|
|
|
|
[Test]
|
|
public void DisposeUnsubscribesFromUserDeactivated()
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions()).Returns([]);
|
|
|
|
var binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
Assert.That(binding, Is.Not.Null);
|
|
|
|
binding!.Dispose();
|
|
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob"));
|
|
|
|
sessionManager.Verify(m => m.GetSessions(), Times.Never);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a committed user change awaits coordinated session teardown despite request cancellation.
|
|
/// </summary>
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public async Task UserChangeWaitsForCoordinatedTeardownAsync(bool remove)
|
|
{
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
using TestableAsyncCustomNodeManager managerLifetime = manager;
|
|
Mock<ISession> session = CreateSessionWithUser("bob");
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions()).Returns([session.Object]);
|
|
SetupUserDeactivation();
|
|
var entered = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var release = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
m_mockServer.Setup(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), session.Object.Id, true, CancellationToken.None))
|
|
.Callback(() => entered.SetResult(true))
|
|
.Returns(new ValueTask(release.Task));
|
|
using var binding = UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
using var cancellation = new CancellationTokenSource();
|
|
Task<ServiceResult> change = InvokeUserChangeAsync(state, BuildAdminContext(), remove, cancellation.Token);
|
|
|
|
try
|
|
{
|
|
Task first = await Task.WhenAny(entered.Task, change).WaitAsync(TimeSpan.FromSeconds(10))
|
|
.ConfigureAwait(false);
|
|
Assert.That(first, Is.SameAs(entered.Task), "Revocation must enter the full server teardown.");
|
|
cancellation.Cancel();
|
|
Assert.That(change.IsCompleted, Is.False,
|
|
"Cancelling the request after the user is revoked must not abandon its teardown.");
|
|
}
|
|
finally
|
|
{
|
|
release.TrySetResult(true);
|
|
}
|
|
|
|
Assert.That(ServiceResult.IsGood(await change.ConfigureAwait(false)), Is.True);
|
|
session.Verify(s => s.Dispose(), Times.Never);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that asynchronous disposal drains external deactivation once, including after synchronous disposal.
|
|
/// </summary>
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public async Task DisposeAsyncDrainsExternalDeactivationAsync(bool disposeFirst)
|
|
{
|
|
using TestableAsyncCustomNodeManager manager = CreateNodeManagerWithUserManagementNode();
|
|
Mock<ISession> session = CreateSessionWithUser("bob");
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
sessionManager.Setup(m => m.GetSessions()).Returns([session.Object]);
|
|
var entered = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var release = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
m_mockServer.Setup(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), session.Object.Id, true, CancellationToken.None))
|
|
.Callback(() => entered.SetResult(true))
|
|
.Returns(new ValueTask(release.Task));
|
|
using UserManagementBinding binding =
|
|
UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object)!;
|
|
|
|
try
|
|
{
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob"));
|
|
if (disposeFirst)
|
|
{
|
|
binding.Dispose();
|
|
}
|
|
Assert.That(binding, Is.InstanceOf<IAsyncDisposable>());
|
|
Task disposal = binding.DisposeAsync().AsTask();
|
|
Task first = await Task.WhenAny(entered.Task, disposal).WaitAsync(TimeSpan.FromSeconds(10))
|
|
.ConfigureAwait(false);
|
|
Assert.That(first, Is.SameAs(entered.Task));
|
|
Assert.That(disposal.IsCompleted, Is.False, "Disposal must drain an external notification.");
|
|
m_userManagement.Raise(u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob"));
|
|
release.SetResult(true);
|
|
await disposal.ConfigureAwait(false);
|
|
await binding.DisposeAsync().ConfigureAwait(false);
|
|
sessionManager.Verify(m => m.GetSessions(), Times.Once);
|
|
m_mockServer.Verify(s => s.CloseSessionAsync(
|
|
It.IsAny<OperationContext>(), session.Object.Id, true, CancellationToken.None), Times.Once);
|
|
}
|
|
finally
|
|
{
|
|
release.TrySetResult(true);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that insufficient channel security or role privileges reject user changes before mutation or
|
|
/// teardown.
|
|
/// </summary>
|
|
[TestCase(false, MessageSecurityMode.None, true)]
|
|
[TestCase(true, MessageSecurityMode.None, true)]
|
|
[TestCase(false, MessageSecurityMode.SignAndEncrypt, false)]
|
|
[TestCase(true, MessageSecurityMode.SignAndEncrypt, false)]
|
|
public async Task UserChangeAuthorizationPrecedesMutationAsync(
|
|
bool remove,
|
|
MessageSecurityMode securityMode,
|
|
bool isAdmin)
|
|
{
|
|
(TestableAsyncCustomNodeManager manager, UserManagementState state) =
|
|
CreateNodeManagerWithCreatedUserManagementNode();
|
|
using TestableAsyncCustomNodeManager managerLifetime = manager;
|
|
var sessionManager = new Mock<ISessionManager>();
|
|
using var binding = UserManagementBinding.Bind(manager, m_userManagement.Object, sessionManager.Object);
|
|
SessionSystemContext context = BuildContext(
|
|
securityMode,
|
|
BuildIdentity(UserTokenType.UserName, "admin",
|
|
isAdmin ? ObjectIds.WellKnownRole_SecurityAdmin : ObjectIds.WellKnownRole_Observer));
|
|
|
|
ServiceResult result = await InvokeUserChangeAsync(state, context, remove, CancellationToken.None)
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(result.StatusCode, Is.EqualTo(
|
|
isAdmin ? StatusCodes.BadSecurityModeInsufficient : StatusCodes.BadUserAccessDenied));
|
|
m_userManagement.Verify(m => m.RemoveUser(It.IsAny<string>(), It.IsAny<string>()), Times.Never);
|
|
m_userManagement.Verify(m => m.ModifyUser(
|
|
It.IsAny<string>(), It.IsAny<bool>(), It.IsAny<string>(), It.IsAny<bool>(),
|
|
It.IsAny<UserConfigurationMask>(), It.IsAny<bool>(), It.IsAny<string>(), It.IsAny<string>()),
|
|
Times.Never);
|
|
sessionManager.Verify(m => m.GetSessions(), Times.Never);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Configures successful removal and disabling of the target user to raise a deactivation event.
|
|
/// </summary>
|
|
private void SetupUserDeactivation()
|
|
{
|
|
m_userManagement.Setup(m => m.RemoveUser("bob", "admin"))
|
|
.Callback(() => m_userManagement.Raise(
|
|
u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob")))
|
|
.Returns(ServiceResult.Good);
|
|
m_userManagement.Setup(m => m.ModifyUser(
|
|
"bob", false, string.Empty, true, UserConfigurationMask.Disabled, false, string.Empty, "admin"))
|
|
.Callback(() => m_userManagement.Raise(
|
|
u => u.UserDeactivated += null, new UserDeactivatedEventArgs("bob")))
|
|
.Returns(ServiceResult.Good);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Invokes either removal or disabling of the target user through the bound method callback.
|
|
/// </summary>
|
|
private static async Task<ServiceResult> InvokeUserChangeAsync(
|
|
UserManagementState state,
|
|
SessionSystemContext context,
|
|
bool remove,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
if (remove)
|
|
{
|
|
RemoveUserMethodStateResult result = await state.RemoveUser!.OnCallAsync!(
|
|
context, state.RemoveUser, state.NodeId, "bob", cancellationToken).ConfigureAwait(false);
|
|
return result.ServiceResult;
|
|
}
|
|
ModifyUserMethodStateResult modified = await state.ModifyUser!.OnCallAsync!(
|
|
context, state.ModifyUser, state.NodeId, "bob", false, string.Empty, true,
|
|
(uint)UserConfigurationMask.Disabled, false, string.Empty, cancellationToken).ConfigureAwait(false);
|
|
return modified.ServiceResult;
|
|
}
|
|
}
|
|
}
|