Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/UserManagementTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

631 lines
27 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using NUnit.Framework;
using Opc.Ua.Server.UserDatabase;
using Opc.Ua.Tests;
using UserManagementImpl = Opc.Ua.Server.UserManagement.UserManagement;
namespace Opc.Ua.Server.Tests
{
/// <summary>
/// Unit tests for <see cref="UserManagement.UserManagement"/>
/// covering OPC UA Part 18 §5 compliance: spec result codes, password
/// validation, self-modify rejection, MustChangePassword bit handling,
/// and the UserDeactivated event.
/// </summary>
[TestFixture]
[Category("Roles")]
[Parallelizable]
public class UserManagementTests
{
private static readonly string[] s_defaultUserNames = ["alice", "bob"];
private static UserManagementImpl CreateManager()
{
return new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 });
}
[Test]
public void AddUser_HappyPath_Succeeds()
{
using UserManagementImpl um = CreateManager();
ServiceResult result = um.AddUser("alice", "secret", UserConfigurationMask.None, "Tester");
Assert.That(ServiceResult.IsGood(result), Is.True);
IReadOnlyList<UserManagementDataType> users = um.SnapshotUsers();
Assert.That(users, Has.Count.EqualTo(1));
Assert.That(users[0].UserName, Is.EqualTo("alice"));
Assert.That(users[0].Description, Is.EqualTo("Tester"));
}
[Test]
public void SnapshotUsers_StartsWithAllDatabaseUsers()
{
var database = new LinqUserDatabase();
Assert.That(database.CreateUser("alice", "secret"u8, [Role.AuthenticatedUser]), Is.True);
Assert.That(database.CreateUser("bob", "secret2"u8, [Role.AuthenticatedUser]), Is.True);
using var um = new UserManagementImpl(database, passwordLength: new Range { Low = 4, High = 64 });
IReadOnlyList<UserManagementDataType> users = um.SnapshotUsers();
Assert.That(users.Select(u => u.UserName), Is.EquivalentTo(s_defaultUserNames));
Assert.That(users.All(u => u.UserConfiguration == (uint)UserConfigurationMask.None), Is.True);
}
[Test]
public void SnapshotUsers_StartsWithAllCustomDatabaseUsers()
{
var database = new TestUserDatabase(
[
new UserManagementDataType
{
UserName = "alice",
UserConfiguration = (uint)UserConfigurationMask.MustChangePassword,
Description = "Alice Description"
},
new UserManagementDataType
{
UserName = "bob",
UserConfiguration = (uint)UserConfigurationMask.Disabled,
Description = "Bob Description"
}
]);
using var um = new UserManagementImpl(database, passwordLength: new Range { Low = 4, High = 64 });
IReadOnlyList<UserManagementDataType> users = um.SnapshotUsers();
UserManagementDataType alice = users.Single(u => u.UserName == "alice");
UserManagementDataType bob = users.Single(u => u.UserName == "bob");
Assert.That(users.Select(u => u.UserName), Is.EquivalentTo(s_defaultUserNames));
Assert.That(alice.UserConfiguration, Is.EqualTo((uint)UserConfigurationMask.MustChangePassword));
Assert.That(alice.Description, Is.EqualTo("Alice Description"));
Assert.That(bob.UserConfiguration, Is.EqualTo((uint)UserConfigurationMask.Disabled));
Assert.That(bob.Description, Is.EqualTo("Bob Description"));
}
[Test]
public void AddUser_DuplicateUserName_ReturnsBadAlreadyExists()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
ServiceResult duplicate = um.AddUser("alice", "secret2", UserConfigurationMask.None, string.Empty);
Assert.That(duplicate.StatusCode, Is.EqualTo(StatusCodes.BadAlreadyExists));
}
[Test]
public void AddUser_PasswordTooShort_ReturnsBadOutOfRange()
{
using UserManagementImpl um = CreateManager();
ServiceResult result = um.AddUser("alice", "ab", UserConfigurationMask.None, string.Empty);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadOutOfRange));
}
[Test]
public void AddUser_PasswordTooLong_ReturnsBadOutOfRange()
{
using UserManagementImpl um = CreateManager();
ServiceResult result = um.AddUser("alice", new string('a', 200),
UserConfigurationMask.None, string.Empty);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadOutOfRange));
}
[Test]
public void AddUser_MustChangePasswordPlusNoChangeByUser_ReturnsBadConfigurationError()
{
using UserManagementImpl um = CreateManager();
ServiceResult result = um.AddUser("alice", "secret",
UserConfigurationMask.MustChangePassword | UserConfigurationMask.NoChangeByUser,
string.Empty);
Assert.That(result.StatusCode,
Is.EqualTo(StatusCodes.BadConfigurationError));
}
[Test]
public void RemoveUser_NonExistent_ReturnsBadNotFound()
{
using UserManagementImpl um = CreateManager();
ServiceResult result = um.RemoveUser("ghost", callingUserName: null);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadNotFound));
}
[Test]
public void RemoveUser_SelfReference_ReturnsBadInvalidSelfReference()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
ServiceResult result = um.RemoveUser("alice", callingUserName: "alice");
Assert.That(result.StatusCode,
Is.EqualTo(StatusCodes.BadInvalidSelfReference));
}
[Test]
public void ModifyUser_DisableSelfReference_ReturnsBadInvalidSelfReference()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
ServiceResult result = um.ModifyUser(
"alice",
modifyPassword: false,
password: string.Empty,
modifyUserConfiguration: true,
userConfiguration: UserConfigurationMask.Disabled,
modifyDescription: false,
description: string.Empty,
callingUserName: "alice");
Assert.That(result.StatusCode,
Is.EqualTo(StatusCodes.BadInvalidSelfReference));
}
[Test]
public void ModifyUser_DisableOther_RaisesUserDeactivatedEvent()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
string? deactivated = null;
um.UserDeactivated += (_, e) => deactivated = e.UserName;
ServiceResult result = um.ModifyUser(
"alice",
modifyPassword: false,
password: string.Empty,
modifyUserConfiguration: true,
userConfiguration: UserConfigurationMask.Disabled,
modifyDescription: false,
description: string.Empty,
callingUserName: "admin");
Assert.That(ServiceResult.IsGood(result), Is.True);
Assert.That(deactivated, Is.EqualTo("alice"));
Assert.That(um.IsUserActive("alice"), Is.False);
}
[Test]
public void RemoveUser_RaisesUserDeactivatedEvent()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
string? deactivated = null;
um.UserDeactivated += (_, e) => deactivated = e.UserName;
ServiceResult result = um.RemoveUser("alice", callingUserName: "admin");
Assert.That(ServiceResult.IsGood(result), Is.True);
Assert.That(deactivated, Is.EqualTo("alice"));
}
[Test]
public void RemoveUser_NoDeleteFlag_ReturnsBadNotSupported()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.SupportDisableUser |
PasswordOptionsMask.SupportDisableDeleteForUser |
PasswordOptionsMask.SupportInitialPasswordChange);
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.NoDelete, string.Empty)), Is.True);
ServiceResult result = um.RemoveUser("alice", callingUserName: "admin");
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadNotSupported));
}
[Test]
public void ModifyUser_AdminPasswordReset_PreservesUserRoles()
{
// Regression for the password-reset path that previously dropped
// the user's roles by calling CreateUser with []. The fix
// snapshots roles via IUserDatabase.GetUserRoles before delete
// and re-applies them on recreate.
var db = new LinqUserDatabase();
db.CreateUser("alice", "secret"u8, [Role.SecurityAdmin, Role.AuthenticatedUser]);
using var um = new UserManagementImpl(
db, passwordLength: new Range { Low = 4, High = 64 });
Assert.That(ServiceResult.IsGood(
um.AddUser("bob", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
// Bob exists in the manager metadata as well as in the db (added
// by AddUser); now layer in admin-assigned roles directly on the
// db (typical pattern for integrators).
db.DeleteUser("bob");
db.CreateUser("bob", "secret"u8, [Role.Engineer]);
ServiceResult result = um.ModifyUser(
"bob",
modifyPassword: true,
password: "newsecret",
modifyUserConfiguration: false,
userConfiguration: UserConfigurationMask.None,
modifyDescription: false,
description: string.Empty,
callingUserName: "admin");
Assert.That(ServiceResult.IsGood(result), Is.True);
// The Engineer role assignment must have survived the reset.
ICollection<Role> rolesAfter = db.GetUserRoles("bob");
Assert.That(rolesAfter, Has.Member(Role.Engineer),
"Admin password reset should preserve previously assigned roles.");
Assert.That(db.CheckCredentials("bob", "newsecret"u8), Is.True,
"New password must be active after the reset.");
}
[Test]
public void ChangePassword_HappyPath_Succeeds()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "oldpass", UserConfigurationMask.None, string.Empty)), Is.True);
ServiceResult result = um.ChangePassword("alice", "oldpass", "newpass");
Assert.That(ServiceResult.IsGood(result), Is.True);
}
[Test]
public void JsonDatabasePersistsUserConfigurationAndDescriptionAcrossReload()
{
string fileName = Path.Combine(
Path.GetTempPath(),
"opcua-user-metadata-" + Guid.NewGuid().ToString("N") + ".json");
try
{
using (var initial = new UserManagementImpl(
new JsonUserDatabase(fileName),
passwordLength: new Range { Low = 4, High = 64 }))
{
ServiceResult result = initial.AddUser(
"alice",
"secret",
UserConfigurationMask.Disabled | UserConfigurationMask.MustChangePassword,
"Disabled until verified");
Assert.That(ServiceResult.IsGood(result), Is.True);
}
IUserDatabase loadedDatabase = JsonUserDatabase.Load(
fileName,
NUnitTelemetryContext.Create());
using var reloaded = new UserManagementImpl(
loadedDatabase,
passwordLength: new Range { Low = 4, High = 64 });
UserManagementDataType alice = reloaded.SnapshotUsers()
.Single(user => user.UserName == "alice");
Assert.That(
(UserConfigurationMask)alice.UserConfiguration,
Is.EqualTo(UserConfigurationMask.Disabled | UserConfigurationMask.MustChangePassword));
Assert.That(alice.Description, Is.EqualTo("Disabled until verified"));
}
finally
{
if (File.Exists(fileName))
{
File.Delete(fileName);
}
}
}
[Test]
public void ChangePassword_SameAsOld_ReturnsBadAlreadyExists()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
ServiceResult result = um.ChangePassword("alice", "secret", "secret");
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadAlreadyExists));
}
[Test]
public void ChangePassword_WrongOldPassword_ReturnsBadIdentityTokenInvalid()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
ServiceResult result = um.ChangePassword("alice", "wrong", "newpass");
Assert.That(result.StatusCode,
Is.EqualTo(StatusCodes.BadIdentityTokenInvalid));
}
[TestCase("")]
[TestCase(null)]
public void ChangePassword_EmptyOldPassword_ReturnsBadIdentityTokenInvalid(string? oldPassword)
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(
um.AddUser("alice", "secret", UserConfigurationMask.None, string.Empty)), Is.True);
ServiceResult result = um.ChangePassword("alice", oldPassword!, "newpass");
Assert.That(result.StatusCode,
Is.EqualTo(StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public void ChangePassword_ClearsMustChangePasswordBit()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(um.AddUser("alice", "secret",
UserConfigurationMask.MustChangePassword, string.Empty)), Is.True);
Assert.That(um.MustChangePassword("alice"), Is.True);
Assert.That(ServiceResult.IsGood(um.ChangePassword("alice", "secret", "newpass")), Is.True);
Assert.That(um.MustChangePassword("alice"), Is.False);
}
[Test]
public void ChangePassword_NoChangeByUser_ReturnsBadNotSupported()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.SupportDisableUser |
PasswordOptionsMask.SupportNoChangeForUser |
PasswordOptionsMask.SupportInitialPasswordChange);
Assert.That(ServiceResult.IsGood(um.AddUser("alice", "secret",
UserConfigurationMask.NoChangeByUser, string.Empty)), Is.True);
ServiceResult result = um.ChangePassword("alice", "secret", "newpass");
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadNotSupported));
}
[Test]
public void IsUserActive_DisabledUser_ReturnsFalse()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(um.AddUser("alice", "secret",
UserConfigurationMask.Disabled, string.Empty)), Is.True);
Assert.That(um.IsUserActive("alice"), Is.False);
}
[Test]
public void IsUserActive_ActiveUser_ReturnsTrue()
{
using UserManagementImpl um = CreateManager();
Assert.That(ServiceResult.IsGood(um.AddUser("alice", "secret",
UserConfigurationMask.None, string.Empty)), Is.True);
Assert.That(um.IsUserActive("alice"), Is.True);
}
// ----------------------------------------------------------------
// Gap 11: Password length exact boundaries
// ----------------------------------------------------------------
[TestCase(3, ExpectedResult = false, TestName = "Password just below min length is rejected")]
[TestCase(4, ExpectedResult = true, TestName = "Password exactly at min length is accepted")]
[TestCase(5, ExpectedResult = true, TestName = "Password just above min length is accepted")]
public bool AddUser_PasswordLengthAtLowerBoundary_RespectsRange(int length)
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 });
ServiceResult result = um.AddUser("alice", new string('a', length),
UserConfigurationMask.None, string.Empty);
return ServiceResult.IsGood(result);
}
[TestCase(63, ExpectedResult = true, TestName = "Password just below max length is accepted")]
[TestCase(64, ExpectedResult = true, TestName = "Password exactly at max length is accepted")]
[TestCase(65, ExpectedResult = false, TestName = "Password just above max length is rejected")]
public bool AddUser_PasswordLengthAtUpperBoundary_RespectsRange(int length)
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 });
ServiceResult result = um.AddUser("alice", new string('a', length),
UserConfigurationMask.None, string.Empty);
return ServiceResult.IsGood(result);
}
// ----------------------------------------------------------------
// Gap 10: Password complexity (Upper / Lower / Digit / Special)
// ----------------------------------------------------------------
[Test]
public void AddUser_RequiresUpperCase_PasswordWithoutUpper_ReturnsBadOutOfRange()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresUpperCaseCharacters);
ServiceResult result = um.AddUser("alice", "alllower1!",
UserConfigurationMask.None, string.Empty);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadOutOfRange));
}
[Test]
public void AddUser_RequiresUpperCase_PasswordWithUpper_Succeeds()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresUpperCaseCharacters);
ServiceResult result = um.AddUser("alice", "HasUpper",
UserConfigurationMask.None, string.Empty);
Assert.That(ServiceResult.IsGood(result), Is.True);
}
[Test]
public void AddUser_RequiresLowerCase_PasswordWithoutLower_ReturnsBadOutOfRange()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresLowerCaseCharacters);
ServiceResult result = um.AddUser("alice", "ALLUPPER1!",
UserConfigurationMask.None, string.Empty);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadOutOfRange));
}
[Test]
public void AddUser_RequiresLowerCase_PasswordWithLower_Succeeds()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresLowerCaseCharacters);
ServiceResult result = um.AddUser("alice", "haslower",
UserConfigurationMask.None, string.Empty);
Assert.That(ServiceResult.IsGood(result), Is.True);
}
[Test]
public void AddUser_RequiresDigit_PasswordWithoutDigit_ReturnsBadOutOfRange()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresDigitCharacters);
ServiceResult result = um.AddUser("alice", "NoDigits",
UserConfigurationMask.None, string.Empty);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadOutOfRange));
}
[Test]
public void AddUser_RequiresDigit_PasswordWithDigit_Succeeds()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresDigitCharacters);
ServiceResult result = um.AddUser("alice", "HasDigit1",
UserConfigurationMask.None, string.Empty);
Assert.That(ServiceResult.IsGood(result), Is.True);
}
[Test]
public void AddUser_RequiresSpecial_PasswordWithoutSpecial_ReturnsBadOutOfRange()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresSpecialCharacters);
ServiceResult result = um.AddUser("alice", "OnlyAlphaNumeric1",
UserConfigurationMask.None, string.Empty);
Assert.That(result.StatusCode, Is.EqualTo(StatusCodes.BadOutOfRange));
}
[Test]
public void AddUser_RequiresSpecial_PasswordWithSpecial_Succeeds()
{
using var um = new UserManagementImpl(
new LinqUserDatabase(),
passwordLength: new Range { Low = 4, High = 64 },
passwordOptions: PasswordOptionsMask.RequiresSpecialCharacters);
ServiceResult result = um.AddUser("alice", "Has!Special",
UserConfigurationMask.None, string.Empty);
Assert.That(ServiceResult.IsGood(result), Is.True);
}
private sealed class TestUserDatabase : IUserDatabase
{
private readonly IReadOnlyList<UserManagementDataType> m_users;
public TestUserDatabase(IReadOnlyList<UserManagementDataType> users)
{
m_users = users;
}
/// <inheritdoc/>
public bool CreateUser(string userName, ReadOnlySpan<byte> password, ICollection<Role> roles)
{
throw new NotSupportedException();
}
/// <inheritdoc/>
public bool DeleteUser(string userName)
{
throw new NotSupportedException();
}
/// <inheritdoc/>
public bool CheckCredentials(string userName, ReadOnlySpan<byte> password)
{
throw new NotSupportedException();
}
/// <inheritdoc/>
public ICollection<Role> GetUserRoles(string userName)
{
throw new NotSupportedException();
}
/// <inheritdoc/>
public IReadOnlyList<UserManagementDataType> GetUsers()
{
return m_users;
}
/// <inheritdoc/>
public bool ChangePassword(
string userName,
ReadOnlySpan<byte> oldPassword,
ReadOnlySpan<byte> newPassword)
{
throw new NotSupportedException();
}
/// <inheritdoc/>
public bool CreateUser(
string userName,
ReadOnlySpan<byte> password,
ArrayOf<Role> roles,
UserConfigurationMask userConfiguration,
string description)
{
throw new NotSupportedException();
}
/// <inheritdoc/>
public bool ResetPassword(
string userName,
ReadOnlySpan<byte> newPassword,
UserConfigurationMask userConfiguration,
string description)
{
throw new NotSupportedException();
}
/// <inheritdoc/>
public bool UpdateUserMetadata(
string userName,
UserConfigurationMask userConfiguration,
string description)
{
throw new NotSupportedException();
}
}
}
}