mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-26 04:19:53 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
419 lines
18 KiB
C#
419 lines
18 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Concurrent;
|
|
using System.Linq;
|
|
using System.Net.Sockets;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Client;
|
|
using Opc.Ua.Client.TestFramework;
|
|
using ManagedSessionType = Opc.Ua.Client.ManagedSession;
|
|
|
|
// CA2000: integration-test disposables are released by helper cleanup paths.
|
|
// CA2016: cleanup intentionally ignores the test cancellation token so it can run after timeouts.
|
|
#pragma warning disable CA2000, CA2007, CA2016
|
|
|
|
namespace Opc.Ua.Sessions.Tests
|
|
{
|
|
/// <summary>
|
|
/// Live-server tests for transparent channel-manager reconnect behavior.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Client")]
|
|
[Category("ManagedSession")]
|
|
[Category("ChannelManager")]
|
|
[Category("Reconnect")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
public sealed class ChannelManagerTransparentReconnectIntegrationTests
|
|
: ChannelManagerIntegrationTestBase
|
|
{
|
|
private static readonly StatusCode[] s_reactivationSecurityFailureStatusCodes =
|
|
[
|
|
StatusCodes.BadApplicationSignatureInvalid,
|
|
StatusCodes.BadSecurityChecksFailed,
|
|
StatusCodes.BadIdentityChangeNotSupported,
|
|
StatusCodes.BadSecureChannelIdInvalid
|
|
];
|
|
|
|
[Test]
|
|
[Order(100)]
|
|
[CancelAfter(120_000)]
|
|
public async Task ChannelManagerReconnectDoesNotChurnOuterManagedSessionStateAsync(
|
|
CancellationToken ct)
|
|
{
|
|
await using ClientChannelManager manager = CreateChannelManager(
|
|
new ExponentialBackoffChannelReconnectPolicy
|
|
{
|
|
MinDelay = TimeSpan.Zero,
|
|
MaxDelay = TimeSpan.Zero,
|
|
MaxAttempts = 3
|
|
});
|
|
ConfiguredEndpoint endpoint = await GetEndpointAsync(SecurityPolicies.None)
|
|
.ConfigureAwait(false);
|
|
ManagedSessionType? session = null;
|
|
|
|
try
|
|
{
|
|
session = await ConnectManagedSessionAsync(
|
|
endpoint,
|
|
manager,
|
|
nameof(ChannelManagerReconnectDoesNotChurnOuterManagedSessionStateAsync),
|
|
ct).ConfigureAwait(false);
|
|
|
|
NodeId originalSessionId = session.SessionId;
|
|
IManagedTransportChannel channel = GetManagedChannel(session);
|
|
var outerStates = new ConcurrentQueue<ConnectionState>();
|
|
var channelStates = new ConcurrentQueue<ChannelState>();
|
|
session.ConnectionStateChanged += (_, e) => outerStates.Enqueue(e.NewState);
|
|
session.ChannelStateChanged += (_, e) => channelStates.Enqueue(e.NewState);
|
|
|
|
await manager.ReconnectAsync(channel, ct).ConfigureAwait(false);
|
|
|
|
Assert.That(
|
|
await WaitForAsync(
|
|
() => channelStates.Contains(ChannelState.Ready),
|
|
DefaultWait,
|
|
ct).ConfigureAwait(false),
|
|
Is.True,
|
|
"ManagedSession.ChannelStateChanged should report the manager reconnect cycle.");
|
|
|
|
Assert.That(channelStates, Has.Member(ChannelState.TransportReconnecting));
|
|
Assert.That(channelStates, Has.Member(ChannelState.TransportConnectedSessionReactivating));
|
|
Assert.That(channelStates, Has.Member(ChannelState.Ready));
|
|
Assert.That(outerStates, Has.No.Member(ConnectionState.Reconnecting));
|
|
Assert.That(outerStates, Has.No.Member(ConnectionState.Connected));
|
|
Assert.That(session.StateMachine.State, Is.EqualTo(ConnectionState.Connected));
|
|
Assert.That(session.SessionId, Is.EqualTo(originalSessionId));
|
|
|
|
await AssertReadServerStatusAsync(session, ct).ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
await CloseAndDisposeAsync(session).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
[Order(150)]
|
|
[CancelAfter(120_000)]
|
|
public async Task AnonymousSignChannelManagerReconnectRecreatesSessionAsync(
|
|
CancellationToken ct)
|
|
{
|
|
await using ClientChannelManager manager = CreateChannelManager(
|
|
new ExponentialBackoffChannelReconnectPolicy
|
|
{
|
|
MinDelay = TimeSpan.Zero,
|
|
MaxDelay = TimeSpan.Zero,
|
|
MaxAttempts = 3
|
|
});
|
|
ConfiguredEndpoint endpoint = await GetEndpointAsync(SecurityPolicies.Basic256Sha256)
|
|
.ConfigureAwait(false);
|
|
endpoint.Description.SecurityMode = MessageSecurityMode.Sign;
|
|
ManagedSessionType? session = null;
|
|
|
|
try
|
|
{
|
|
session = await ConnectManagedSessionAsync(
|
|
endpoint,
|
|
manager,
|
|
nameof(AnonymousSignChannelManagerReconnectRecreatesSessionAsync),
|
|
ct).ConfigureAwait(false);
|
|
NodeId originalSessionId = session.SessionId;
|
|
IManagedTransportChannel channel = GetManagedChannel(session);
|
|
|
|
await manager.ReconnectAsync(channel, ct).ConfigureAwait(false);
|
|
|
|
Assert.That(session.SessionId, Is.Not.EqualTo(originalSessionId));
|
|
Assert.That(channel.State, Is.EqualTo(ChannelState.Ready));
|
|
await AssertReadServerStatusAsync(session, ct).ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
await CloseAndDisposeAsync(session).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
[TestCaseSource(nameof(s_reactivationSecurityFailureStatusCodes))]
|
|
[Order(175)]
|
|
[CancelAfter(120_000)]
|
|
public async Task ReactivationSecurityFailureRecreatesSessionAsync(
|
|
StatusCode statusCode,
|
|
CancellationToken ct)
|
|
{
|
|
await using ClientChannelManager manager = CreateChannelManager(
|
|
new ExponentialBackoffChannelReconnectPolicy
|
|
{
|
|
MinDelay = TimeSpan.Zero,
|
|
MaxDelay = TimeSpan.Zero,
|
|
MaxAttempts = 3
|
|
});
|
|
ConfiguredEndpoint endpoint = await GetEndpointAsync(SecurityPolicies.None)
|
|
.ConfigureAwait(false);
|
|
ManagedSessionType? session = null;
|
|
IServiceResponseMutator? originalResponseMutator = ReferenceServer.ResponseMutator;
|
|
var mockController = new MockResponseController();
|
|
|
|
try
|
|
{
|
|
session = await ConnectManagedSessionAsync(
|
|
endpoint,
|
|
manager,
|
|
nameof(ReactivationSecurityFailureRecreatesSessionAsync),
|
|
ct).ConfigureAwait(false);
|
|
NodeId originalSessionId = session.SessionId;
|
|
IManagedTransportChannel channel = GetManagedChannel(session);
|
|
ReferenceServer.ResponseMutator = mockController;
|
|
using IDisposable expectation = mockController
|
|
.ExpectNextResponse<ActivateSessionResponse>(
|
|
response => response.ResponseHeader.ServiceResult = statusCode);
|
|
|
|
await manager.ReconnectAsync(channel, ct).ConfigureAwait(false);
|
|
|
|
Assert.That(session.SessionId, Is.Not.EqualTo(originalSessionId));
|
|
Assert.That(channel.State, Is.EqualTo(ChannelState.Ready));
|
|
await AssertReadServerStatusAsync(session, ct).ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
ReferenceServer.ResponseMutator = originalResponseMutator;
|
|
await CloseAndDisposeAsync(session).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
[Order(200)]
|
|
[CancelAfter(120_000)]
|
|
public async Task ChannelManagerExhaustionEscalatesAndRecoversWhenServerReturns(
|
|
CancellationToken ct)
|
|
{
|
|
await using ClientChannelManager manager = CreateChannelManager(
|
|
new ExponentialBackoffChannelReconnectPolicy
|
|
{
|
|
MinDelay = TimeSpan.Zero,
|
|
MaxDelay = TimeSpan.Zero,
|
|
MaxAttempts = 1
|
|
});
|
|
ConfiguredEndpoint endpoint = await GetEndpointAsync(SecurityPolicies.None)
|
|
.ConfigureAwait(false);
|
|
ManagedSessionType? session = null;
|
|
int serverPort = ServerFixture.Port;
|
|
bool serverStopped = false;
|
|
|
|
try
|
|
{
|
|
session = await ConnectManagedSessionAsync(
|
|
endpoint,
|
|
manager,
|
|
nameof(ChannelManagerExhaustionEscalatesAndRecoversWhenServerReturns),
|
|
ct).ConfigureAwait(false);
|
|
|
|
session.KeepAliveInterval = 60_000;
|
|
IManagedTransportChannel channel = GetManagedChannel(session);
|
|
var channelStates = new ConcurrentQueue<ChannelState>();
|
|
session.ChannelStateChanged += (_, e) => channelStates.Enqueue(e.NewState);
|
|
|
|
await ServerFixture.StopAsync().ConfigureAwait(false);
|
|
serverStopped = true;
|
|
|
|
// The channel's background monitor races StopAsync; by the time
|
|
// we call ReconnectAsync the lease's entry may already be Faulted
|
|
// and SwapFaultedEntryAsync will attempt OpenInitial on a fresh
|
|
// entry — which throws because the server is down. That is the
|
|
// expected exhaustion path; swallow the transport-level
|
|
// SocketException and let the assertions below verify the
|
|
// Faulted state and the manager's eventual recovery.
|
|
try
|
|
{
|
|
await manager.ReconnectAsync(channel, ct).ConfigureAwait(false);
|
|
}
|
|
catch (SocketException)
|
|
{
|
|
}
|
|
catch (ServiceResultException sre) when (sre.InnerException is SocketException)
|
|
{
|
|
}
|
|
|
|
Assert.That(
|
|
await WaitForAsync(
|
|
() => channelStates.Contains(ChannelState.Faulted),
|
|
DefaultWait,
|
|
ct).ConfigureAwait(false),
|
|
Is.True,
|
|
"The exhausted reconnect cycle should transition the entry to Faulted.");
|
|
Assert.That(channel.State, Is.EqualTo(ChannelState.Faulted));
|
|
// GetDiagnostic intentionally omitted: when the swap's
|
|
// OpenInitial fails on a down server the fresh entry's
|
|
// DisposeAsync removes its record from the manager, leaving
|
|
// no diagnostic for the key. The channel.State assertion
|
|
// above already covers the observable Faulted contract.
|
|
|
|
ReferenceServer = await ServerFixture.StartAsync(PkiRoot, serverPort).ConfigureAwait(false);
|
|
ReferenceServer.TokenValidator = TokenValidator;
|
|
serverStopped = false;
|
|
|
|
Assert.That(
|
|
await ReconnectUntilReadyAsync(
|
|
manager,
|
|
channel,
|
|
DefaultWait,
|
|
ct).ConfigureAwait(false),
|
|
Is.True,
|
|
"The manager should recover after the restarted server accepts session services.");
|
|
|
|
Assert.That(
|
|
await WaitForAsync(
|
|
() => channelStates.Contains(ChannelState.Ready),
|
|
DefaultWait,
|
|
ct).ConfigureAwait(false),
|
|
Is.True,
|
|
"The swapped entry should recover to Ready after the server returns.");
|
|
// channel.State is a snapshot of the current state; poll
|
|
// for Ready instead of asserting against the snapshot the
|
|
// first WaitForAsync caught — on a slow Windows net48
|
|
// runner the channel can flap Ready → Faulted → Ready
|
|
// before the snapshot is taken, leaving the assertion
|
|
// reading Faulted. The diagnostic snapshot below uses
|
|
// the same lock-protected manager state so both polls
|
|
// converge on the post-swap Ready entry.
|
|
Assert.That(
|
|
await WaitForAsync(
|
|
() => channel.State == ChannelState.Ready,
|
|
DefaultWait,
|
|
ct).ConfigureAwait(false),
|
|
Is.True,
|
|
"Channel handle should observe Ready after the swap completes.");
|
|
Assert.That(
|
|
await WaitForAsync(
|
|
() => GetDiagnostic(manager, channel.Key).State == ChannelState.Ready,
|
|
DefaultWait,
|
|
ct).ConfigureAwait(false),
|
|
Is.True,
|
|
"Manager diagnostics should observe Ready after the swap completes.");
|
|
|
|
// The participant returned RequiresSessionRecreate from OnReconnectAsync
|
|
// (the server lost the session id while down). The manager awaits
|
|
// Session.RecreateAsync before reporting Ready; retain the retry loop
|
|
// here for transient service startup lag after the server restart.
|
|
Assert.That(
|
|
await WaitForAsync(
|
|
() => TryReadServerStatus(session),
|
|
DefaultWait,
|
|
ct).ConfigureAwait(false),
|
|
Is.True,
|
|
"Session should be recreated and able to read ServerStatus after the channel swap.");
|
|
|
|
await AssertReadServerStatusAsync(session, ct).ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
if (serverStopped)
|
|
{
|
|
ReferenceServer = await ServerFixture.StartAsync(PkiRoot, serverPort)
|
|
.ConfigureAwait(false);
|
|
ReferenceServer.TokenValidator = TokenValidator;
|
|
}
|
|
|
|
await CloseAndDisposeAsync(session).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
private static bool TryReadServerStatus(ManagedSessionType session)
|
|
{
|
|
try
|
|
{
|
|
DataValue value = session
|
|
.ReadValueAsync(VariableIds.Server_ServerStatus_State, CancellationToken.None)
|
|
.GetAwaiter().GetResult();
|
|
return !value.IsNull && StatusCode.IsGood(value.StatusCode);
|
|
}
|
|
catch (ServiceResultException)
|
|
{
|
|
return false;
|
|
}
|
|
catch (Exception)
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
|
|
private static async Task<bool> ReconnectUntilReadyAsync(
|
|
ClientChannelManager manager,
|
|
IManagedTransportChannel channel,
|
|
TimeSpan timeout,
|
|
CancellationToken ct)
|
|
{
|
|
using var timeoutCts = new CancellationTokenSource(timeout);
|
|
using var linkedCts = CancellationTokenSource.CreateLinkedTokenSource(
|
|
timeoutCts.Token,
|
|
ct);
|
|
|
|
while (!linkedCts.IsCancellationRequested)
|
|
{
|
|
try
|
|
{
|
|
await manager.ReconnectAsync(channel, linkedCts.Token).ConfigureAwait(false);
|
|
}
|
|
catch (OperationCanceledException) when (linkedCts.IsCancellationRequested)
|
|
{
|
|
break;
|
|
}
|
|
catch (SocketException)
|
|
{
|
|
}
|
|
catch (ServiceResultException sre) when (
|
|
sre.StatusCode == StatusCodes.BadServerHalted ||
|
|
sre.StatusCode == StatusCodes.BadSecureChannelClosed ||
|
|
sre.InnerException is SocketException)
|
|
{
|
|
}
|
|
|
|
if (channel.State == ChannelState.Ready)
|
|
{
|
|
return true;
|
|
}
|
|
|
|
try
|
|
{
|
|
await Task.Delay(PollInterval, linkedCts.Token).ConfigureAwait(false);
|
|
}
|
|
catch (OperationCanceledException) when (linkedCts.IsCancellationRequested)
|
|
{
|
|
break;
|
|
}
|
|
}
|
|
|
|
return channel.State == ChannelState.Ready;
|
|
}
|
|
}
|
|
}
|