mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 00:56:28 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
314 lines
13 KiB
C#
314 lines
13 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Client.TestFramework;
|
|
using Opc.Ua.Server.TestFramework;
|
|
using Opc.Ua.Tests;
|
|
using Quickstarts.ReferenceServer;
|
|
using ISession = Opc.Ua.Client.ISession;
|
|
|
|
namespace Opc.Ua.Sessions.Tests
|
|
{
|
|
/// <summary>
|
|
/// Integration tests for client lockout functionality after failed authentication attempts.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Client")]
|
|
[Category("Security")]
|
|
[Category("ClientLockout")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
public class ClientLockoutIntegrationTests
|
|
{
|
|
private ServerFixture<ReferenceServer> m_serverFixture;
|
|
private ClientFixture m_clientFixture;
|
|
private ReferenceServer m_server;
|
|
private string m_pkiRoot;
|
|
private Uri m_serverUrl;
|
|
private ArrayOf<EndpointDescription> m_endpoints;
|
|
private ITelemetryContext m_telemetry;
|
|
|
|
// Leave margin for internal ActivateSession retries in reset-counter tests.
|
|
private const int LockoutThreshold = 10;
|
|
private const int PreResetFailedAttempts = 3;
|
|
private const int PostResetFailedAttempts = 4;
|
|
|
|
[SetUp]
|
|
public async Task SetUpAsync()
|
|
{
|
|
//Restart server before every test to reset client lockout
|
|
m_telemetry = NUnitTelemetryContext.Create();
|
|
m_pkiRoot = Path.GetTempPath() + Path.GetRandomFileName();
|
|
|
|
m_serverFixture = new ServerFixture<ReferenceServer>
|
|
(t => new ReferenceServer(t))
|
|
{
|
|
UriScheme = Utils.UriSchemeOpcTcp,
|
|
SecurityNone = true,
|
|
AutoAccept = true,
|
|
AllNodeManagers = false,
|
|
OperationLimits = true
|
|
};
|
|
|
|
await m_serverFixture.LoadConfigurationAsync(m_pkiRoot).ConfigureAwait(false);
|
|
|
|
m_serverFixture.Config.ServerConfiguration!.UserTokenPolicies +=
|
|
new UserTokenPolicy(UserTokenType.UserName);
|
|
m_serverFixture.Config.ServerConfiguration.MaxFailedAuthenticationAttempts = LockoutThreshold;
|
|
|
|
m_server = await m_serverFixture.StartAsync().ConfigureAwait(false);
|
|
m_server.TokenValidator = new TokenValidatorMock();
|
|
|
|
m_clientFixture = new ClientFixture(false, false, m_telemetry);
|
|
await m_clientFixture.LoadClientConfigurationAsync(m_pkiRoot).ConfigureAwait(false);
|
|
|
|
m_serverUrl = new Uri($"{Utils.UriSchemeOpcTcp}://localhost:{m_serverFixture.Port}");
|
|
|
|
var endpointConfiguration = EndpointConfiguration.Create();
|
|
endpointConfiguration.OperationTimeout = 10000;
|
|
|
|
using DiscoveryClient discoveryClient = await DiscoveryClient.CreateAsync(
|
|
m_serverUrl,
|
|
endpointConfiguration,
|
|
m_telemetry).ConfigureAwait(false);
|
|
|
|
m_endpoints = await discoveryClient.GetEndpointsAsync(default).ConfigureAwait(false);
|
|
}
|
|
|
|
[TearDown]
|
|
public async Task OneTimeTearDownAsync()
|
|
{
|
|
if (m_serverFixture != null)
|
|
{
|
|
await m_serverFixture.StopAsync().ConfigureAwait(false);
|
|
}
|
|
|
|
m_clientFixture?.Dispose();
|
|
|
|
try
|
|
{
|
|
if (!string.IsNullOrEmpty(m_pkiRoot) && Directory.Exists(m_pkiRoot))
|
|
{
|
|
Directory.Delete(m_pkiRoot, true);
|
|
}
|
|
}
|
|
catch
|
|
{
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task ClientIsLockedOutAfterMultipleFailedPasswordAttemptsAsync()
|
|
{
|
|
EndpointDescription endpoint = m_endpoints.Find(e => e.SecurityMode == MessageSecurityMode.None);
|
|
Assert.That(endpoint, Is.Not.Null, "No endpoint with SecurityMode.None found");
|
|
|
|
var endpointConfiguration = EndpointConfiguration.Create(m_clientFixture.Config);
|
|
var configuredEndpoint = new ConfiguredEndpoint(null, endpoint, endpointConfiguration);
|
|
|
|
for (int attempt = 0; attempt < LockoutThreshold; attempt++)
|
|
{
|
|
try
|
|
{
|
|
var identity = new UserIdentity("invaliduser", System.Text.Encoding.UTF8.GetBytes("wrongpassword"));
|
|
using ISession session = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
$"LockoutTestSession_{attempt}",
|
|
60000,
|
|
identity,
|
|
default).ConfigureAwait(false);
|
|
|
|
Assert.Fail("Session creation should have failed with invalid credentials");
|
|
}
|
|
catch (ServiceResultException ex)
|
|
{
|
|
Assert.That(
|
|
ex.StatusCode == StatusCodes.BadIdentityTokenInvalid ||
|
|
ex.StatusCode == StatusCodes.BadIdentityTokenRejected ||
|
|
ex.StatusCode == StatusCodes.BadUserAccessDenied,
|
|
Is.True,
|
|
$"Attempt {attempt + 1}: Expected authentication failure, got {ex.StatusCode}");
|
|
}
|
|
}
|
|
|
|
ServiceResultException lockoutException = Assert.ThrowsAsync<ServiceResultException>(async () =>
|
|
{
|
|
using ISession session = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
"LockoutTestSession_Final",
|
|
60000,
|
|
new UserIdentity("user1", System.Text.Encoding.UTF8.GetBytes("password")),
|
|
default).ConfigureAwait(false);
|
|
});
|
|
|
|
Assert.That(lockoutException, Is.Not.Null);
|
|
Assert.That(lockoutException.StatusCode, Is.EqualTo(StatusCodes.BadUserAccessDenied));
|
|
}
|
|
|
|
[Test]
|
|
public async Task SuccessfulLoginAfterFailuresResetsLockoutCounterAsync()
|
|
{
|
|
EndpointDescription endpoint = m_endpoints.Find(e => e.SecurityMode == MessageSecurityMode.None);
|
|
Assert.That(endpoint, Is.Not.Null, "No endpoint with SecurityMode.None found");
|
|
|
|
var endpointConfiguration = EndpointConfiguration.Create(m_clientFixture.Config);
|
|
var configuredEndpoint = new ConfiguredEndpoint(null, endpoint, endpointConfiguration);
|
|
|
|
for (int attempt = 0; attempt < PreResetFailedAttempts; attempt++)
|
|
{
|
|
try
|
|
{
|
|
var identity = new UserIdentity("resetuser", System.Text.Encoding.UTF8.GetBytes("wrongpassword"));
|
|
using ISession session = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
$"ResetTestSession_{attempt}",
|
|
60000,
|
|
identity,
|
|
default).ConfigureAwait(false);
|
|
}
|
|
catch (ServiceResultException)
|
|
{
|
|
}
|
|
}
|
|
|
|
// A successful non-anonymous login resets the lockout counter.
|
|
// Anonymous logins do not reset the counter to prevent lockout bypass.
|
|
{
|
|
var successIdentity = new UserIdentity("user1", System.Text.Encoding.UTF8.GetBytes("password"));
|
|
using ISession successSession = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
"ResetTestSession_Success",
|
|
60000,
|
|
successIdentity,
|
|
default).ConfigureAwait(false);
|
|
Assert.That(successSession, Is.Not.Null);
|
|
Assert.That(successSession.Connected, Is.True);
|
|
}
|
|
|
|
for (int attempt = 0; attempt < PostResetFailedAttempts; attempt++)
|
|
{
|
|
try
|
|
{
|
|
var identity = new UserIdentity("resetuser", System.Text.Encoding.UTF8.GetBytes("wrongpassword"));
|
|
using ISession session = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
$"PostResetTestSession_{attempt}",
|
|
60000,
|
|
identity,
|
|
default).ConfigureAwait(false);
|
|
}
|
|
catch (ServiceResultException)
|
|
{
|
|
}
|
|
}
|
|
|
|
// A successful non-anonymous login after failures proves the counter was reset.
|
|
{
|
|
var successIdentity = new UserIdentity("user1", System.Text.Encoding.UTF8.GetBytes("password"));
|
|
using ISession successSession = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
"ResetTestSession_Success2",
|
|
60000,
|
|
successIdentity,
|
|
default).ConfigureAwait(false);
|
|
Assert.That(successSession, Is.Not.Null);
|
|
Assert.That(successSession.Connected, Is.True);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task AnonymousLoginFailsWhileLockedOutAsync()
|
|
{
|
|
EndpointDescription endpoint = m_endpoints.Find(e => e.SecurityMode == MessageSecurityMode.None);
|
|
Assert.That(endpoint, Is.Not.Null, "No endpoint with SecurityMode.None found");
|
|
|
|
var endpointConfiguration = EndpointConfiguration.Create(m_clientFixture.Config);
|
|
var configuredEndpoint = new ConfiguredEndpoint(null, endpoint, endpointConfiguration);
|
|
|
|
for (int attempt = 0; attempt < LockoutThreshold; attempt++)
|
|
{
|
|
try
|
|
{
|
|
var identity = new UserIdentity("anonlockoutuser", System.Text.Encoding.UTF8.GetBytes("wrongpassword"));
|
|
using ISession session = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
$"AnonLockoutTestSession_{attempt}",
|
|
60000,
|
|
identity,
|
|
default).ConfigureAwait(false);
|
|
}
|
|
catch (ServiceResultException)
|
|
{
|
|
}
|
|
}
|
|
|
|
ServiceResultException lockoutException = Assert.ThrowsAsync<ServiceResultException>(async () =>
|
|
{
|
|
using ISession anonSession = await m_clientFixture.SessionFactory.CreateAsync(
|
|
m_clientFixture.Config,
|
|
configuredEndpoint,
|
|
false,
|
|
false,
|
|
"AnonTestSession",
|
|
60000,
|
|
new UserIdentity(),
|
|
default).ConfigureAwait(false);
|
|
});
|
|
|
|
Assert.That(lockoutException, Is.Not.Null);
|
|
Assert.That(lockoutException.StatusCode, Is.EqualTo(StatusCodes.BadUserAccessDenied));
|
|
}
|
|
}
|
|
}
|