Files
UA-.NETStandard/tests/Opc.Ua.Sessions.Tests/SessionTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

258 lines
9.8 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Client;
using Opc.Ua.Client.TestFramework;
namespace Opc.Ua.Sessions.Tests
{
/// <summary>
/// compliance tests for Session Service Set.
/// </summary>
[TestFixture]
[Category("Conformance")]
[Category("Session")]
public class SessionTests : TestFixture
{
[Description("Verify the shared session is connected.")]
[Test]
public void Session001VerifySessionConnected()
{
Assert.That(Session.Connected, Is.True, "Session should be connected.");
Assert.That(Session.SessionId, Is.Not.Null, "SessionId should not be null.");
}
[Description("Read ServerState via session and verify it is Running.")]
[Test]
public async Task Session002ReadServerStatusAsync()
{
ReadResponse response = await Session.ReadAsync(
null,
0,
TimestampsToReturn.Both,
new ReadValueId[]
{
new() {
NodeId = VariableIds.Server_ServerStatus_State,
AttributeId = Attributes.Value
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True,
"Read of ServerState should return Good.");
int stateValue = response.Results[0].GetValue(0);
Assert.That(stateValue, Is.EqualTo((int)ServerState.Running),
"Server should be in Running state.");
}
[Description("Session.SessionId should not be NodeId.Null.")]
[Test]
public void Session003SessionId()
{
Assert.That(Session.SessionId, Is.Not.EqualTo(NodeId.Null),
"SessionId should not be NodeId.Null.");
}
[Description("Session.SessionName should be set.")]
[Test]
public void Session004SessionName()
{
Assert.That(Session.SessionName, Is.Not.Null.And.Not.Empty,
"SessionName should be set by the client fixture.");
}
[Description("Create an additional session, verify it connects, then close it.")]
[Test]
public async Task Session005CreateAndCloseAdditionalSessionAsync()
{
ISession? additionalSession = null;
try
{
additionalSession = await ClientFixture
.ConnectAsync(ServerUrl, SecurityPolicies.None)
.ConfigureAwait(false);
Assert.That(additionalSession, Is.Not.Null);
Assert.That(additionalSession.Connected, Is.True,
"Additional session should be connected.");
}
finally
{
if (additionalSession != null)
{
await additionalSession.CloseAsync(5000, true).ConfigureAwait(false);
additionalSession.Dispose();
}
}
}
[Description("Create 3 parallel sessions, verify all work, then close them.")]
[Test]
public async Task Session006MultipleParallelSessionsAsync()
{
const int sessionCount = 3;
var sessions = new ISession[sessionCount];
try
{
for (int i = 0; i < sessionCount; i++)
{
sessions[i] = await ClientFixture
.ConnectAsync(ServerUrl, SecurityPolicies.None)
.ConfigureAwait(false);
}
foreach (ISession s in sessions)
{
Assert.That(s.Connected, Is.True);
// Verify each session can read
ReadResponse response = await s.ReadAsync(
null,
0,
TimestampsToReturn.Both,
new ReadValueId[]
{
new() {
NodeId = VariableIds.Server_ServerStatus_State,
AttributeId = Attributes.Value
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True);
}
}
finally
{
foreach (ISession s in sessions)
{
if (s != null)
{
await s.CloseAsync(5000, true).ConfigureAwait(false);
s.Dispose();
}
}
}
}
[Description("Session timeout should be a positive value.")]
[Test]
public void Session007SessionTimeout()
{
Assert.That(Session.SessionTimeout, Is.GreaterThan(0),
"SessionTimeout should be positive.");
}
[Description("Server application URI should be set.")]
[Test]
public void Session008ServerUri()
{
string applicationUri = Session.Endpoint.Server.ApplicationUri!;
Assert.That(applicationUri, Is.Not.Null.And.Not.Empty,
"Server ApplicationUri should be set.");
}
[Description("NamespaceUris should have at least 2 entries.")]
[Test]
public void Session009NamespaceUris()
{
Assert.That(Session.NamespaceUris.Count, Is.GreaterThanOrEqualTo(2),
"NamespaceUris should contain at least ns0 (OPC UA) and ns1 (server).");
}
[Description("Read MaxNodesPerRead from OperationLimits.")]
[Test]
public async Task Session010ReadOperationLimitsAsync()
{
ReadResponse response = await Session.ReadAsync(
null,
0,
TimestampsToReturn.Both,
new ReadValueId[]
{
new() {
NodeId = VariableIds.Server_ServerCapabilities_OperationLimits_MaxNodesPerRead,
AttributeId = Attributes.Value
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True,
"Read of MaxNodesPerRead should return Good.");
uint maxNodes = response.Results[0].GetValue<uint>(0);
Assert.That(maxNodes, Is.GreaterThan((uint)0),
"MaxNodesPerRead should be a positive value.");
}
[Description("Endpoint URL should contain the expected server port.")]
[Test]
public void Session011VerifyEndpointUrl()
{
string endpointUrl = Session.Endpoint.EndpointUrl!;
Assert.That(endpointUrl, Is.Not.Null.And.Not.Empty);
Assert.That(endpointUrl,
Does.Contain(ServerUrl.Port.ToString(System.Globalization.CultureInfo.InvariantCulture)),
"Endpoint URL should contain the expected server port.");
}
[Description("Read ServerDiagnostics EnabledFlag.")]
[Test]
public async Task Session012ServerDiagnosticsAsync()
{
ReadResponse response = await Session.ReadAsync(
null,
0,
TimestampsToReturn.Both,
new ReadValueId[]
{
new() {
NodeId = VariableIds.Server_ServerDiagnostics_EnabledFlag,
AttributeId = Attributes.Value
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True,
"Read of EnabledFlag should return Good.");
bool enabledFlag = response.Results[0].GetValue(false);
Assert.That(enabledFlag, Is.InstanceOf<bool>(),
"EnabledFlag should be a boolean value.");
}
}
}