Files
UA-.NETStandard/tests/Opc.Ua.Subscriptions.Tests/SessionPublishQueueConcurrencyTests.cs
romanett 61edaa1ed0 Remove netstandard2.1 and net472 target frameworks (#4624)
# Description

Drops support for **netstandard2.1** and **.NET Framework 4.7.2**.
Libraries now target `net48`, `net8.0`, `net9.0` and `net10.0`.
`Opc.Ua.Types` and `Opc.Ua.SourceGeneration.Core` still also target
`netstandard2.0`, but only because the Roslyn source generators load
them. There is no general netstandard2.0 support.

**Preprocessor directives** (112 files)
- Every `#if`/`#elif` mentioning `NETSTANDARD2_1*`, `NET472*`,
`NET_STANDARD_TESTS`, `SKIP_ECC_CERTIFICATE_REQUEST_SIGNING` or
`NETSTANDARD*` was evaluated against the remaining TFM set (net48,
net8/9/10, plus netstandard2.0 inside `Opc.Ua.Types`/`tools`) and
simplified. Dead branches were removed.
- Example: `NETSTANDARD2_1 || NET8_0_OR_GREATER` → `NET8_0_OR_GREATER`.
- Example: `NET8_0_OR_GREATER || NET472_OR_GREATER` → removed (always
true).
- Netstandard-only code was removed: `UnixFileModeShim`, the CRDT
reflection path in `ReplicatedGossipOptions.CreateReaderOptions`, and
the netstandard2.1-only test variants.

**Custom test logic**
- `targets.props` drops the `net472`, `netstandard2.0` and
`netstandard2.1` `CustomTestTarget` profiles, `NetStandardTests` and
`SKIP_ECC_CERTIFICATE_REQUEST_SIGNING`. Supported values are now
`net48`, `net8.0`, `net9.0`, `net10.0`.
- The `NET_STANDARD_TESTS` define is removed from 29 test projects.
- The "build netstandard shells as net10.0" overrides are removed from
18 projects.
- `RestrictForLegacyTfm` now only applies to `net48`.
- `tests/customtest.bat` is updated to the new values.

**Build / packaging / CI**
- MSBuild TFM conditions are simplified: Kestrel package choice, MQTTnet
v4 (net48 only), BouncyCastle, Di/OpenUsd/Vision/Stress test excludes,
and `System.IO.FileSystem.AccessControl` (dropped from Core).
- The MigrationAnalyzer nuspec drops its net472/netstandard2.1 lib
groups. The Azure signing lists are updated.
- `get-ci-matrix.ps1` removes the net472/netstandard test profiles
(including the PR-gating `linux-netstandard2.1`) and the matching build
legs.

**Breaking API change (2.0 preview):** removed
`HttpsTransportListener.IsWssTransportSupported` and
`ReplicatedGossipOptions.IsGossipStateDecodingSupported`. They only
returned `false` on netstandard2.1 and are now always `true`. The test
guards that used them were removed as well.

**Docs**
- NuGet READMEs, `README.md`, `DeveloperGuide.md`, `PubSub.md`, the
certificate/ECC/identity docs and the 2.0 migration guide (plus its
`.agents` skill mirror) are updated.
- The migration guide notes that 4.7.2 consumers must move to 4.8 and
netstandard2.1 consumers to net8.0+.

### Reviewer notes
- The `System.IO.FileSystem.AccessControl` `PackageVersion` pin is left
in `Directory.Packages.props`. It has no direct reference any more, but
transitive pinning is on, so it was kept to avoid shifting resolved
versions.
- The `#if` rewrite was done mechanically by a truth-table evaluator.
The diff in the `.cs` files is limited to directive lines, removed dead
branches, and stale-comment updates.

### Verified locally
- `dotnet build UA.slnx -p:CustomTestTarget=net48`: 0 errors.
- `dotnet build UA.slnx -p:CustomTestTarget=net10.0`: 0 errors.
- Default multi-target builds (no `CustomTestTarget`) of Opc.Ua.Types,
Bindings.Https, PubSub.Mqtt and Redundancy.Server succeeded.
- net10.0 tests:
  - Opc.Ua.Redundancy.Server.Tests: 840/840 passed.
  - Opc.Ua.Types.Tests: 11363 passed, 1 skipped.
  - ModelDependencyScanner tests: 20/20 passed.
- The full test suite was **not** run locally.

## Related Issues

- None

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [ ] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-02 17:09:49 +02:00

261 lines
11 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using NUnit.Framework;
using Opc.Ua.Server;
namespace Opc.Ua.Subscriptions.Tests
{
/// <summary>
/// Covers queue races around publish, requeue, expiration and transfer claims.
/// </summary>
[TestFixture]
public class SessionPublishQueueConcurrencyTests
{
[Test]
public async Task ConcurrentPublishRequeueAndExpirationDoesNotDuplicateSubscriptionAsync()
{
SessionPublishQueue queue = CreateQueue(out Mock<ISession> session);
Mock<ISubscriptionPublishPipeline> subscription = CreateSubscription(1, session.Object);
queue.Add(subscription.Object);
IReadOnlyList<SessionPublishQueue.QueuedSubscription> snapshot = queue.CapturePublishTimerSnapshot();
using var start = new Barrier(3);
using var cancellationTokenSource = new CancellationTokenSource();
Task<ISubscriptionPublishPipeline?> publishTask = Task.Run(
async () =>
{
start.SignalAndWait();
try
{
return await queue.PublishAsync(
"secure-channel",
DateTime.MaxValue,
requeue: false,
parkSink: null,
cancellationTokenSource.Token)
.ConfigureAwait(false);
}
catch (OperationCanceledException)
{
return null;
}
catch (ServiceResultException exception)
when (exception.StatusCode == StatusCodes.BadNoSubscription)
{
return null;
}
});
Task requeueTask = Task.Run(
() =>
{
start.SignalAndWait();
queue.Requeue(subscription.Object);
});
Task<bool> expirationTask = Task.Run(
() =>
{
start.SignalAndWait();
return queue.TryRemoveForExpiration(snapshot[0]);
});
await Task.WhenAll(requeueTask, expirationTask).ConfigureAwait(false);
cancellationTokenSource.Cancel();
ISubscriptionPublishPipeline? publishedSubscription = await publishTask.ConfigureAwait(false);
Assert.That(
publishedSubscription == null || ReferenceEquals(publishedSubscription, subscription.Object),
Is.True);
if (queue.ContainsSubscription(subscription.Object))
{
queue.Requeue(subscription.Object);
Task<ISubscriptionPublishPipeline> firstPublish = queue.PublishAsync(
"secure-channel",
DateTime.MaxValue,
requeue: false,
parkSink: null,
CancellationToken.None);
Task<ISubscriptionPublishPipeline> secondPublish = queue.PublishAsync(
"secure-channel",
DateTime.MaxValue,
requeue: false,
parkSink: null,
CancellationToken.None);
// Status == RanToCompletion rather than Task.IsCompletedSuccessfully,
// which is .NET 5+ only and would break the net48 build.
Assert.That(firstPublish.Status, Is.EqualTo(TaskStatus.RanToCompletion));
Assert.That(await firstPublish.ConfigureAwait(false), Is.SameAs(subscription.Object));
Assert.That(secondPublish.Status, Is.Not.EqualTo(TaskStatus.RanToCompletion));
queue.Remove(subscription.Object, removeQueuedRequests: true);
}
else
{
Assert.That(await expirationTask.ConfigureAwait(false), Is.True);
}
}
[Test]
public async Task TransferClaimProtectsClaimedEntryFromExpirationAndPreservesRequeueAsync()
{
SessionPublishQueue queue = CreateQueue(out Mock<ISession> session);
Subscription subscription = CreateConcreteSubscription(2, session.Object);
queue.Add(subscription);
IReadOnlyList<SessionPublishQueue.QueuedSubscription> snapshot = queue.CapturePublishTimerSnapshot();
bool claimed = queue.TryClaimForTransfer(
subscription,
session.Object,
out SessionPublishQueue.SubscriptionTransferClaim? claim);
Assert.That(claimed, Is.True);
Assert.That(claim, Is.Not.Null);
using var start = new Barrier(3);
Task<bool> expirationTask = Task.Run(
() =>
{
start.SignalAndWait();
return queue.TryRemoveForExpiration(snapshot[0]);
});
Task<bool> secondClaimTask = Task.Run(
() =>
{
start.SignalAndWait();
return queue.TryClaimForTransfer(subscription, session.Object, out _);
});
Task requeueTask = Task.Run(
() =>
{
start.SignalAndWait();
queue.Requeue(subscription);
});
await Task.WhenAll(expirationTask, secondClaimTask, requeueTask).ConfigureAwait(false);
Assert.That(await expirationTask.ConfigureAwait(false), Is.False);
Assert.That(await secondClaimTask.ConfigureAwait(false), Is.False);
Assert.That(queue.RestoreTransferClaim(claim!), Is.True);
Task<ISubscriptionPublishPipeline> publishTask = queue.PublishAsync(
"secure-channel",
DateTime.MaxValue,
requeue: false,
parkSink: null,
CancellationToken.None);
Assert.That(publishTask.Status, Is.EqualTo(TaskStatus.RanToCompletion));
Assert.That(await publishTask.ConfigureAwait(false), Is.SameAs(subscription));
}
private static SessionPublishQueue CreateQueue(out Mock<ISession> session)
{
return CreateQueue(out session, out _);
}
private static SessionPublishQueue CreateQueue(
out Mock<ISession> session,
out Mock<IServerInternal> server)
{
var telemetry = new TestTelemetryContext();
server = new Mock<IServerInternal>(MockBehavior.Loose);
server.SetupGet(value => value.Telemetry).Returns(telemetry);
session = new Mock<ISession>(MockBehavior.Loose);
session.SetupGet(value => value.Id).Returns(new NodeId(Guid.NewGuid()));
session.SetupGet(value => value.Identity).Returns(new UserIdentity());
session.SetupGet(value => value.IdentityToken).Returns(CreateIdentityToken().Object);
session.SetupGet(value => value.ClientApplicationUri).Returns("urn:test");
session.Setup(value => value.IsSecureChannelValid(It.IsAny<string>())).Returns(true);
return new SessionPublishQueue(server.Object, session.Object, 10, TimeProvider.System);
}
private static Mock<IUserIdentityTokenHandler> CreateIdentityToken()
{
var identityToken = new Mock<IUserIdentityTokenHandler>(MockBehavior.Loose);
identityToken.SetupGet(value => value.TokenType).Returns(UserTokenType.Anonymous);
identityToken.SetupGet(value => value.Token).Returns(new AnonymousIdentityToken());
return identityToken;
}
private static Mock<ISubscriptionPublishPipeline> CreateSubscription(uint id, ISession session)
{
var subscription = new Mock<ISubscriptionPublishPipeline>(MockBehavior.Loose);
subscription.SetupGet(value => value.Id).Returns(id);
subscription.SetupGet(value => value.Session).Returns(session);
subscription.SetupGet(value => value.SessionId).Returns(session.Id);
subscription.SetupGet(value => value.Priority).Returns(0);
return subscription;
}
private static Subscription CreateConcreteSubscription(uint id, ISession session)
{
// RuntimeHelpers.GetUninitializedObject is .NET 5+ only; net48 has the
// equivalent on FormatterServices, which is obsolete on modern targets.
#if NET5_0_OR_GREATER
var subscription = (Subscription)RuntimeHelpers.GetUninitializedObject(typeof(Subscription));
#else
var subscription = (Subscription)System.Runtime.Serialization.FormatterServices
.GetUninitializedObject(typeof(Subscription));
#endif
SetField(subscription, "m_lock", new Lock());
SetField(subscription, "<Id>k__BackingField", id);
SetField(subscription, "<Session>k__BackingField", session);
SetField(subscription, "<Priority>k__BackingField", (byte)0);
return subscription;
}
private static void SetField<TValue>(Subscription subscription, string fieldName, TValue value)
{
typeof(Subscription)
.GetField(fieldName, BindingFlags.Instance | BindingFlags.NonPublic)!
.SetValue(subscription, value);
}
private sealed class TestTelemetryContext : TelemetryContextBase
{
public TestTelemetryContext()
: base(NullLoggerFactory.Instance)
{
}
}
}
}