Files
UA-.NETStandard/tests/Opc.Ua.Subscriptions.Tests/SubscriptionFailoverTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

293 lines
12 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
#pragma warning disable CA2016
using System;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Client;
using Opc.Ua.Client.Subscriptions;
using Opc.Ua.Client.TestFramework;
namespace Opc.Ua.Subscriptions.Tests
{
/// <summary>
/// V2 failover-style transfer tests. Force a transport channel
/// break and verify the subscription survives — either via
/// <see cref="ISubscriptionManager.TransferSubscriptionsOnRecreate"/>
/// (server kept the subscription) or via the V2 manager's
/// internal recreate fallback (server discarded). Both outcomes
/// must result in the subscription continuing to deliver data.
/// </summary>
[TestFixture]
[Category("Client")]
[Category("V2")]
[Category("Failover")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
public class SubscriptionFailoverTests : ClientTestFramework
{
[OneTimeSetUp]
public override Task OneTimeSetUpAsync()
{
SupportsExternalServerUrl = true;
SingleSession = false;
return OneTimeSetUpCoreAsync(securityNone: true);
}
[OneTimeTearDown]
public override Task OneTimeTearDownAsync()
{
return base.OneTimeTearDownAsync();
}
[SetUp]
public override Task SetUpAsync()
{
return base.SetUpAsync();
}
[TearDown]
public override Task TearDownAsync()
{
return base.TearDownAsync();
}
[Test]
[Order(100)]
[CancelAfter(120_000)]
public async Task FailoverChannelBreakWithTransferOnRecreateV2Async(
CancellationToken ct)
{
ManagedSession session = await ConnectFailoverAsync(
nameof(FailoverChannelBreakWithTransferOnRecreateV2Async),
transferOnRecreate: true, ct).ConfigureAwait(false);
try
{
var handler = new RecordingSubscriptionHandler();
ISubscription sub = session.AddSubscription(handler,
new Client.Subscriptions.SubscriptionOptions
{
PublishingInterval = TimeSpan.FromMilliseconds(500),
KeepAliveCount = 10,
LifetimeCount = 100,
PublishingEnabled = true
});
bool created = await WaitForAsync(() => sub.Created,
TimeSpan.FromSeconds(15), ct).ConfigureAwait(false);
Assert.That(created, Is.True);
Assert.That(sub.TryAddMonitoredItem(
"Time",
VariableIds.Server_ServerStatus_CurrentTime,
o => o with { SamplingInterval = TimeSpan.FromMilliseconds(250) },
out _), Is.True);
bool firstData = await handler.WaitForFirstDataAsync(
TimeSpan.FromSeconds(15), ct).ConfigureAwait(false);
Assert.That(firstData, Is.True);
// Force channel break. The V2 manager + ManagedSession
// reconnect logic must restore the channel and then
// run TransferSubscriptions (with recreate fallback if
// the server has discarded the subscription).
int preCount = handler.DataChangeCount;
ITransportChannel? channel = session.InnerSession?.TransportChannel;
if (channel == null)
{
Assert.Inconclusive(
"InnerSession.TransportChannel is null; cannot force channel break.");
return;
}
TestContext.Out.WriteLine(
"Closing transport channel to force V2 transfer/recreate…");
channel.Dispose();
bool reconnected = await WaitForAsync(
() => session.Connected,
TimeSpan.FromSeconds(60), ct).ConfigureAwait(false);
Assert.That(reconnected, Is.True,
"Session must auto-reconnect after channel loss.");
bool subStillCreated = await WaitForAsync(
() => sub.Created, TimeSpan.FromSeconds(30), ct)
.ConfigureAwait(false);
Assert.That(subStillCreated, Is.True,
"Subscription must remain Created after the V2 " +
"TransferSubscriptions / recreate fallback path.");
// Either transfer succeeded (same ServerId) or the V2
// manager re-created the subscription (possibly with a
// new ServerId). Either way: new data must flow.
bool postData = await WaitForAsync(
() => handler.DataChangeCount > preCount,
TimeSpan.FromSeconds(30), ct).ConfigureAwait(false);
Assert.That(postData, Is.True,
"Subscription must continue to deliver data after the " +
"failover (TransferSubscriptions succeeded or recreate fallback ran).");
await sub.DisposeAsync().ConfigureAwait(false);
}
finally
{
try
{
await session.CloseAsync().ConfigureAwait(false);
}
catch
{ /* best effort */
}
try
{
await session.DisposeAsync().ConfigureAwait(false);
}
catch
{ /* best effort */
}
}
}
[Test]
[Order(200)]
[CancelAfter(120_000)]
public async Task FailoverChannelBreakWithoutTransferOnRecreateV2Async(
CancellationToken ct)
{
// With TransferSubscriptionsOnRecreate=false the V2 manager
// does NOT call TransferSubscriptions after a reconnect.
// The server-side subscription, however, survives the
// transport-level reconnect because the inner Session keeps
// its SessionId. So this configuration must also continue
// to deliver data without the explicit transfer call.
ManagedSession session = await ConnectFailoverAsync(
nameof(FailoverChannelBreakWithoutTransferOnRecreateV2Async),
transferOnRecreate: false, ct).ConfigureAwait(false);
try
{
var handler = new RecordingSubscriptionHandler();
ISubscription sub = session.AddSubscription(handler,
new Client.Subscriptions.SubscriptionOptions
{
PublishingInterval = TimeSpan.FromMilliseconds(500),
KeepAliveCount = 10,
LifetimeCount = 100,
PublishingEnabled = true
});
Assert.That(await WaitForAsync(() => sub.Created,
TimeSpan.FromSeconds(15), ct).ConfigureAwait(false), Is.True);
Assert.That(sub.TryAddMonitoredItem(
"Time",
VariableIds.Server_ServerStatus_CurrentTime,
o => o with { SamplingInterval = TimeSpan.FromMilliseconds(250) },
out _), Is.True);
Assert.That(await handler.WaitForFirstDataAsync(
TimeSpan.FromSeconds(15), ct).ConfigureAwait(false), Is.True);
uint preServerId = ((LogicalSubscription)sub).ServerId;
int preCount = handler.DataChangeCount;
ITransportChannel? channel = session.InnerSession?.TransportChannel;
if (channel == null)
{
Assert.Inconclusive(
"InnerSession.TransportChannel is null; cannot force channel break.");
return;
}
TestContext.Out.WriteLine(
"Closing transport channel — no TransferSubscriptions on recreate…");
channel.Dispose();
Assert.That(await WaitForAsync(() => session.Connected,
TimeSpan.FromSeconds(60), ct).ConfigureAwait(false), Is.True);
Assert.That(await WaitForAsync(() => sub.Created,
TimeSpan.FromSeconds(30), ct).ConfigureAwait(false), Is.True);
Assert.That(await WaitForAsync(
() => handler.DataChangeCount > preCount,
TimeSpan.FromSeconds(30), ct).ConfigureAwait(false), Is.True,
"Subscription must continue to deliver after channel reconnect");
Assert.That(((LogicalSubscription)sub).ServerId, Is.EqualTo(preServerId),
"Without TransferSubscriptions on recreate, the server-side " +
"ServerId should be preserved across a transport-level reconnect.");
await sub.DisposeAsync().ConfigureAwait(false);
}
finally
{
try
{
await session.CloseAsync().ConfigureAwait(false);
}
catch
{ /* best effort */
}
try
{
await session.DisposeAsync().ConfigureAwait(false);
}
catch
{ /* best effort */
}
}
}
private async Task<ManagedSession> ConnectFailoverAsync(
string sessionName, bool transferOnRecreate, CancellationToken ct)
{
ConfiguredEndpoint endpoint = await ClientFixture
.GetEndpointAsync(ServerUrl, SecurityPolicies.None)
.ConfigureAwait(false);
ManagedSessionBuilder builder = new ManagedSessionBuilder(ClientFixture.Config, Telemetry)
.UseEndpoint(endpoint)
.WithSessionName(sessionName)
.WithSessionTimeout(TimeSpan.FromSeconds(120));
if (transferOnRecreate)
{
builder = builder.WithTransferSubscriptionsOnRecreate();
}
return await builder.ConnectAsync(ct).ConfigureAwait(false);
}
private static async Task<bool> WaitForAsync(
Func<bool> predicate, TimeSpan timeout, CancellationToken ct)
{
DateTime deadline = DateTime.UtcNow + timeout;
while (DateTime.UtcNow < deadline)
{
ct.ThrowIfCancellationRequested();
if (predicate())
{
return true;
}
await Task.Delay(50, ct).ConfigureAwait(false);
}
return predicate();
}
}
}