mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 08:41:51 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
197 lines
8.7 KiB
C#
197 lines
8.7 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Collections.Generic;
|
|
using System.Threading;
|
|
|
|
namespace Opc.Ua.SourceGeneration
|
|
{
|
|
/// <summary>
|
|
/// Generator options
|
|
/// </summary>
|
|
public sealed class GeneratorOptions
|
|
{
|
|
/// <summary>
|
|
/// Optimize generated code for compile speed.
|
|
/// </summary>
|
|
public bool OptimizeForCompileSpeed { get; set; }
|
|
|
|
/// <summary>
|
|
/// Exclusions to apply on the input
|
|
/// </summary>
|
|
public IReadOnlyList<string> Exclusions { get; set; } = [];
|
|
|
|
/// <summary>
|
|
/// Generation should be cancelled
|
|
/// </summary>
|
|
public CancellationToken Cancellation { get; set; }
|
|
|
|
/// <summary>
|
|
/// Write utf8 string literals when needed
|
|
/// </summary>
|
|
public bool UseUtf8StringLiterals { get; set; } = true;
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, the
|
|
/// <see cref="ObjectTypeProxyGenerator"/> is suppressed and no
|
|
/// <c>*TypeClient</c> proxy classes are emitted. Off by default —
|
|
/// proxies are emitted for every <c>ObjectType</c> in the model
|
|
/// alongside the standard model output.
|
|
/// </summary>
|
|
public bool OmitObjectTypeProxies { get; set; }
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, the
|
|
/// <see cref="StateMachineIdsGenerator"/> is suppressed and no
|
|
/// <c>{TypeName}Ids</c> classes (nested <c>StateIds</c> /
|
|
/// <c>StateNumbers</c> / <c>TransitionIds</c> /
|
|
/// <c>TransitionNumbers</c>) are emitted. Off by default — IDs
|
|
/// are emitted for every concrete <c>FiniteStateMachineType</c>
|
|
/// subtype declared in the model.
|
|
/// </summary>
|
|
public bool OmitStateMachineIds { get; set; }
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, suppresses emission of the
|
|
/// per-ObjectType <c>IComponentAccessor<TState></c> /
|
|
/// <c>IPropertyAccessor<TState></c> typed-accessor
|
|
/// extension classes by <see cref="FluentBuilderGenerator"/>.
|
|
/// Defaults to <c>false</c> — accessors are emitted unless
|
|
/// explicitly suppressed. Model-only assemblies that don't
|
|
/// reference <c>Opc.Ua.Server</c> must set this to <c>true</c>
|
|
/// because the emitted method bodies call into server-side
|
|
/// fluent builders even though the
|
|
/// <see cref="IComponentAccessor{TState}"/> /
|
|
/// <see cref="IPropertyAccessor{TState}"/> marker interfaces
|
|
/// themselves now live in <c>Opc.Ua.Types</c>.
|
|
/// </summary>
|
|
public bool OmitFluentApi { get; set; }
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, generation is limited to the
|
|
/// per-ObjectType typed fluent accessor extension classes emitted
|
|
/// by <see cref="FluentBuilderGenerator"/>. The target model must
|
|
/// already be supplied by a referenced assembly under the same
|
|
/// model URI and C# prefix so the emitted accessors can reference
|
|
/// that assembly's state types. Its model dependency payload must
|
|
/// explicitly declare that the producer omitted fluent accessors;
|
|
/// missing capability metadata and producers that already emitted
|
|
/// accessors are rejected.
|
|
/// </summary>
|
|
public bool FluentAccessorsOnly { get; set; }
|
|
|
|
/// <summary>
|
|
/// Optional override for the C# namespace used by classes emitted
|
|
/// by the <see cref="ObjectTypeProxyGenerator"/>. When unset,
|
|
/// the model's target namespace prefix is used.
|
|
/// </summary>
|
|
public string? ObjectTypeProxyNamespace { get; set; }
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, the <see cref="NodeStateGenerator"/>
|
|
/// uses the modelling rules from the referenced type definition
|
|
/// unconditionally, rather than the overridden rules on instance
|
|
/// definitions, for all structural code generation decisions
|
|
/// (child inclusion, optional vs mandatory classification),
|
|
/// for factory-method child emission (mandatory list versus
|
|
/// on-demand <c>CreateOrReplace*</c> initialisation) and for
|
|
/// the emitted runtime <c>ModellingRuleId</c>.
|
|
/// <para>
|
|
/// Off by default. When off, the generator still enforces OPC UA
|
|
/// modelling rule promotion semantics — instances may only
|
|
/// <em>promote</em> the type definition's rule:
|
|
/// <c>Optional → Mandatory</c>,
|
|
/// <c>OptionalPlaceholder → Mandatory | MandatoryPlaceholder</c>,
|
|
/// <c>MandatoryPlaceholder → Mandatory</c>.
|
|
/// Any demotion is silently rejected and the type definition's
|
|
/// rule is used instead.
|
|
/// </para>
|
|
/// </summary>
|
|
public bool UseTypeDefinitionModellingRules { get; set; }
|
|
|
|
/// <summary>
|
|
/// Maps an OPC UA namespace URI (key) to the C# namespace (value)
|
|
/// in which the corresponding source-generated <c>*TypeClient</c>
|
|
/// proxies live. Used by the
|
|
/// <see cref="ObjectTypeProxyGenerator"/> when a generated
|
|
/// proxy must derive from a base proxy that is defined in a
|
|
/// different (referenced) assembly.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The standard mapping
|
|
/// <c>http://opcfoundation.org/UA/ -> Opc.Ua.Client</c> is
|
|
/// always added by the generator and does not need to be
|
|
/// configured explicitly.
|
|
/// </remarks>
|
|
public IDictionary<string, string> ObjectTypeProxyExternalNamespaces { get; }
|
|
= new Dictionary<string, string>();
|
|
|
|
/// <summary>
|
|
/// Optional override for the C# namespace used by classes
|
|
/// emitted by the <see cref="EventRecordGenerator"/>. When
|
|
/// unset, the model's target namespace prefix is used.
|
|
/// </summary>
|
|
public string? EventRecordNamespace { get; set; }
|
|
|
|
/// <summary>
|
|
/// Suppresses source-generated event record classes.
|
|
/// </summary>
|
|
public bool OmitEventRecords { get; set; }
|
|
|
|
/// <summary>
|
|
/// Maps an OPC UA namespace URI (key) to the C# namespace
|
|
/// (value) in which the corresponding source-generated
|
|
/// <c>*Record</c> classes live. Used by the
|
|
/// <see cref="EventRecordGenerator"/> when a record must
|
|
/// derive from a parent record defined in a different
|
|
/// (referenced) assembly.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The standard mapping
|
|
/// <c>http://opcfoundation.org/UA/ -> Opc.Ua.Client.Alarms</c>
|
|
/// is always added by the generator and does not need to be
|
|
/// configured explicitly.
|
|
/// </remarks>
|
|
public IDictionary<string, string> EventRecordExternalNamespaces { get; }
|
|
= new Dictionary<string, string>();
|
|
|
|
/// <summary>
|
|
/// When <c>false</c>, suppress the emission of the
|
|
/// <c>{prefix}.ModelDependencies.g.cs</c> and
|
|
/// <c>{prefix}.ModelSnapshot.g.cs</c> files. The consuming
|
|
/// generator decides whether emission is appropriate
|
|
/// (typically only for assemblies that will be referenced as
|
|
/// libraries). Default <c>true</c> preserves existing
|
|
/// behaviour for direct invokers of the Core API (tests, the
|
|
/// model-compiler CLI).
|
|
/// </summary>
|
|
public bool EmitDependencyMetadata { get; set; } = true;
|
|
}
|
|
}
|