Files
UA-.NETStandard/tools/Opc.Ua.SourceGeneration.Core/Schema/IModelDesign.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

214 lines
7.1 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Xml;
using Opc.Ua.Export;
using Opc.Ua.Schema.Types;
namespace Opc.Ua.Schema.Model
{
/// <summary>
/// Model design represents the content of a set of validated design files.
/// This includes access to only nodes that are not excluded per exclusion
/// criteria and to add nodes that are implicit. Also assigns identifiers
/// as per input identifier file or in sequence of the designs.
/// </summary>
public interface IModelDesign
{
/// <summary>
/// Use the true type instead of ExtensionObject when subtypes are allowed.
/// </summary>
bool UseAllowSubtypes { get; }
/// <summary>
/// Get all node designs in the model including declarations etc.
/// </summary>
NodeDesign[] Nodes { get; }
/// <summary>
/// Namespaces used in the model design.
/// </summary>
Namespace[] Namespaces { get; }
/// <summary>
/// Target namespace information
/// </summary>
Namespace TargetNamespace { get; }
/// <summary>
/// Target publication date if specified
/// </summary>
DateTime? TargetPublicationDate { get; }
/// <summary>
/// Target version if specified
/// </summary>
string TargetVersion { get; }
/// <summary>
/// Model depdendencies or null if none
/// </summary>
IEnumerable<ModelTableEntry> Dependencies { get; }
/// <summary>
/// Namespace table
/// </summary>
NamespaceTable NamespaceUris { get; }
/// <summary>
/// Default role permissions to apply to nodes.
/// </summary>
IReadOnlyDictionary<string, RolePermissionSet> RolePermissions { get; }
/// <summary>
/// Default access restrictions to apply to nodes.
/// </summary>
IReadOnlyDictionary<string, AccessRestrictions?> AccessRestrictions { get; }
/// <summary>
/// Returns a list of nodes with nodes excluded per exclusion criteria.
/// </summary>
IEnumerable<NodeDesign> GetNodeDesigns();
/// <summary>
/// Returns a list of services filtered by their service category.
/// </summary>
Service[] GetListOfServices(params ServiceCategory[] serviceCategories);
/// <summary>
/// Determines if a node is excluded.
/// </summary>
bool IsExcluded(NodeDesign node);
/// <summary>
/// Determines if a data type is excluded.
/// </summary>
bool IsExcluded(DataType dataType);
/// <summary>
/// Determines if a field/parameter is excluded.
/// </summary>
bool IsExcluded(Parameter field);
/// <summary>
/// Try to find node design.
/// </summary>
bool TryFindNode(
XmlQualifiedName symbolicId,
string sourceName,
string referenceName,
[NotNullWhen(true)] out NodeDesign? target);
}
/// <summary>
/// Extensions on top of the model design validator
/// </summary>
internal static class ModelDesignValidatorExtensions
{
/// <summary>
/// Find nodedesign of type T
/// </summary>
/// <typeparam name="T"></typeparam>
/// <exception cref="InvalidOperationException"></exception>
public static T FindNode<T>(
this IModelDesign validator,
XmlQualifiedName symbolicId,
string sourceName,
string referenceName) where T : NodeDesign
{
if (!validator.TryFindNode(
symbolicId,
sourceName,
referenceName,
out T? target))
{
throw new InvalidOperationException(CoreUtils.Format(
"The {0} reference for node {1} is not the expected type: {2}.",
referenceName,
sourceName,
typeof(T).Name));
}
return target;
}
/// <summary>
/// Find node design
/// </summary>
/// <exception cref="InvalidOperationException"></exception>
public static NodeDesign FindNode(
this IModelDesign validator,
XmlQualifiedName symbolicId,
string sourceName,
string referenceName)
{
if (!validator.TryFindNode(
symbolicId,
sourceName,
referenceName,
out NodeDesign? target))
{
throw new InvalidOperationException(CoreUtils.Format(
"The {0} reference for node {1} is not valid: {2}.",
referenceName,
sourceName,
symbolicId.Name));
}
return target;
}
/// <summary>
/// Find nodedesign of type T
/// </summary>
/// <typeparam name="T"></typeparam>
public static bool TryFindNode<T>(
this IModelDesign validator,
XmlQualifiedName symbolicId,
string sourceName,
string referenceName,
[NotNullWhen(true)] out T? target) where T : NodeDesign
{
if (!validator.TryFindNode(
symbolicId,
sourceName,
referenceName,
out NodeDesign? node) ||
node is not T design)
{
target = default;
return false;
}
target = design;
return true;
}
}
}