mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-18 22:55:08 +08:00
0357380335
**Stack 2/5** — base #4123. Part of the #4096 split; see #4096 for the overall picture. > Review after #4123. The diff shown against `master` will include #4123 until that merges. ## What this is Source generator only; no runtime library changes. ## Contents - **Typed NodeSet method signatures.** A method imported from a NodeSet now gets a typed signature. Methods that share a declared signature are grouped onto one generated `MethodType`, named after its owner when the plain name would collide, so two unrelated `Execute` methods no longer share a class. - **An override that keeps the signature it inherits keeps the declaration it overrides.** Pointing `MethodDeclarationNode` at the override itself made `MethodDeclarationId` self-referential. OPC 10000-4 lets a caller invoke a method with the NodeId of its declaration in the ObjectType *or any supertype*, and `MethodState.MethodDeclarationId` is what the server matches on, so `Call` stopped resolving and returned `Bad_MethodInvalid` for every alarm subtype. An override that genuinely changes its signature still becomes its own declaration. - **`StateNumbers` / `TransitionNumbers` were emitted empty for every NodeSet-sourced model**, because such children arrive as `VariableDesign` rather than `PropertyDesign` and were filtered out. Any companion model built from a NodeSet was writing `StateNumber = 0` on the wire — a Part 16 defect well beyond the models in this stack. The ModelDesign path is unchanged. - **Referenced models can contribute fluent accessors**, carried by a model dependency payload so a downstream model can extend an upstream one. ## Notes for the reviewer - `tests/Opc.Ua.SourceGeneration.Tests` is left at its `master` content here. Its new vendor-subtype test uses the Robotics NodeSet as its fixture, so it can only land with the Robotics change at the top of the stack (5/5). - `PumpInstanceNodeIdRegressionTests` gains six `InputArguments`/`OutputArguments` entries for argument-less standard condition methods. Typed method signatures materialise those properties from the `ConditionType` declaration even where the method takes none. That is a real deviation, pinned rather than hidden so it stays visible; it is worth a follow-up. ## Validation `dotnet build UA.slnx` — 0 errors. | Suite | Result | | --- | --- | | Opc.Ua.SourceGeneration.Core.Tests | 3739 / 0 | | Opc.Ua.SourceGeneration.Tests | 81 / 0 | | Opc.Ua.Di.Tests | 304 / 0 | | Opc.Ua.History.Tests | 506 / 0 | | Opc.Ua.Gds.Tests | 1095 / 0 | History and GDS are listed because they are what the method-declaration fix above is load-bearing for: without it they fail with 10 and 370 errors respectively. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8cbb8cd0-f0cb-4ab0-bea2-6202fbf69485
248 lines
11 KiB
C#
248 lines
11 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Collections.Generic;
|
|
using Microsoft.CodeAnalysis.Diagnostics;
|
|
|
|
namespace Opc.Ua.SourceGeneration
|
|
{
|
|
/// <summary>
|
|
/// Model compiler options
|
|
/// </summary>
|
|
internal sealed record class ModelCompilationOptions
|
|
{
|
|
/// <summary>
|
|
/// Model options
|
|
/// </summary>
|
|
public DesignFileOptions Options { get; set; }
|
|
|
|
/// <summary>
|
|
/// -useAllowSubtypes
|
|
/// </summary>
|
|
public bool UseAllowSubtypes { get; set; }
|
|
|
|
/// <summary>
|
|
/// -exclude [id;id;id]
|
|
/// </summary>
|
|
public IReadOnlyList<string> Exclude { get; set; }
|
|
|
|
/// <summary>
|
|
/// Opt out of <see cref="ObjectTypeProxyGenerator"/>. By
|
|
/// default the source generator emits a typed asynchronous
|
|
/// client wrapper (<c>{TypeName}Client</c>) for every
|
|
/// <c>ObjectType</c> in the model — including types without
|
|
/// methods, so downstream models can derive from the emitted
|
|
/// proxies. Each generated proxy inherits from the proxy of its
|
|
/// parent ObjectType (forming a chain that mirrors the OPC UA
|
|
/// type hierarchy and ultimately roots at the hand-authored
|
|
/// <c>Opc.Ua.ObjectTypeClient</c> base). Methods that share a
|
|
/// name with an ancestor method are emitted with the C#
|
|
/// <c>new</c> modifier so the derived signature shadows the
|
|
/// ancestor. Set this to <c>true</c> to suppress proxy
|
|
/// emission. Surfaced from MSBuild via the
|
|
/// <c>ModelSourceGeneratorOmitObjectTypeProxies</c> property.
|
|
/// </summary>
|
|
public bool OmitObjectTypeProxies { get; set; }
|
|
|
|
/// <summary>
|
|
/// Optional override for the C# namespace used by classes emitted
|
|
/// by the <see cref="ObjectTypeProxyGenerator"/>. By default
|
|
/// proxies are emitted into the model's own namespace (i.e. the
|
|
/// C# prefix of the model's target namespace) — for example the
|
|
/// standard UA NodeSet emits into <c>Opc.Ua</c>. Set this option
|
|
/// to redirect proxy emission into a different namespace.
|
|
/// Surfaced from MSBuild via the
|
|
/// <c>ModelSourceGeneratorObjectTypeProxyNamespace</c> property.
|
|
/// </summary>
|
|
public string ObjectTypeProxyNamespace { get; set; }
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, the generator uses the modelling rules
|
|
/// from the referenced type definition unconditionally for all
|
|
/// structural code generation decisions and the emitted runtime
|
|
/// <c>ModellingRuleId</c>. When off (default), the generator
|
|
/// enforces OPC UA modelling rule promotion semantics —
|
|
/// instances may only promote, never demote, the type
|
|
/// definition's rule.
|
|
/// Surfaced from MSBuild via the
|
|
/// <c>ModelSourceGeneratorUseTypeDefinitionModellingRules</c> property.
|
|
/// </summary>
|
|
public bool UseTypeDefinitionModellingRules { get; set; }
|
|
|
|
/// <summary>
|
|
/// Override for whether the generator emits the
|
|
/// <c>[assembly: ModelDependencyAttribute]</c> + corresponding
|
|
/// <c>[assembly: ModelSnapshotAttribute]</c> metadata for the
|
|
/// model(s) being generated.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <para>
|
|
/// <c>Auto</c> (default): emit only when the consuming
|
|
/// compilation produces a library
|
|
/// (<see cref="OutputKind.DynamicallyLinkedLibrary"/> /
|
|
/// <see cref="OutputKind.NetModule"/>). Applications never
|
|
/// expose their model metadata to downstream consumers — they
|
|
/// are leaf consumers themselves — so the attribute payload is
|
|
/// silently skipped to save assembly bloat.
|
|
/// </para>
|
|
/// <para>
|
|
/// <c>Always</c>: emit regardless of OutputKind. Useful for
|
|
/// integration-test applications that simulate library
|
|
/// behaviour.
|
|
/// </para>
|
|
/// <para>
|
|
/// <c>Never</c>: do not emit, even from libraries. Useful when
|
|
/// the consumer assembly is sealed and downstream usage is
|
|
/// known impossible.
|
|
/// </para>
|
|
/// <para>
|
|
/// Surfaced from MSBuild via the
|
|
/// <c>ModelSourceGeneratorEmitDependencyMetadata</c> property.
|
|
/// </para>
|
|
/// </remarks>
|
|
public EmitDependencyMetadataMode EmitDependencyMetadata { get; set; }
|
|
= EmitDependencyMetadataMode.Auto;
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, suppresses emission of the
|
|
/// per-ObjectType typed accessor extension classes
|
|
/// (<c>{TypeName}StateComponents</c> +
|
|
/// <c>{TypeName}StateProperties</c>) by the model generator.
|
|
/// Defaults to <c>false</c> — accessors are emitted unless
|
|
/// explicitly suppressed. Model-only libraries that don't
|
|
/// reference <c>Opc.Ua.Server</c> must set this to <c>true</c>
|
|
/// via the
|
|
/// <c>ModelSourceGeneratorOmitFluentApi</c> MSBuild property,
|
|
/// because the emitted accessor method bodies call into
|
|
/// server-side fluent builders even though the
|
|
/// <c>Opc.Ua.IComponentAccessor<TState></c> /
|
|
/// <c>Opc.Ua.IPropertyAccessor<TState></c> marker
|
|
/// interfaces themselves live in <c>Opc.Ua.Types</c>.
|
|
/// </summary>
|
|
public bool OmitFluentApi { get; set; }
|
|
|
|
/// <summary>
|
|
/// When set to <c>true</c>, a local model already supplied by a
|
|
/// referenced assembly under the same model URI and C# prefix is
|
|
/// loaded and validated, but only its per-ObjectType typed fluent
|
|
/// accessor extension classes are emitted. The accessors reference
|
|
/// the state types from the referenced model assembly. The referenced
|
|
/// model metadata must explicitly declare that its producer omitted
|
|
/// fluent accessors.
|
|
/// Surfaced from MSBuild via the
|
|
/// <c>ModelSourceGeneratorFluentAccessorsOnly</c> property.
|
|
/// </summary>
|
|
public bool FluentAccessorsOnly { get; set; }
|
|
|
|
/// <summary>
|
|
/// Suppresses event-record generation.
|
|
/// </summary>
|
|
public bool OmitEventRecords { get; set; }
|
|
|
|
/// <summary>
|
|
/// Get options from options provider
|
|
/// </summary>
|
|
public static ModelCompilationOptions From(AnalyzerConfigOptionsProvider provider)
|
|
{
|
|
return new ModelCompilationOptions
|
|
{
|
|
Options = new DesignFileOptions
|
|
{
|
|
Version = provider.GlobalOptions.GetString(
|
|
nameof(DesignFileOptions.Version)) ??
|
|
"v105",
|
|
StartId = (uint)provider.GlobalOptions.GetInteger(
|
|
nameof(DesignFileOptions.StartId)),
|
|
ModelVersion = provider.GlobalOptions.GetString(
|
|
nameof(DesignFileOptions.ModelVersion)),
|
|
ModelPublicationDate = provider.GlobalOptions.GetString(
|
|
nameof(DesignFileOptions.ModelPublicationDate)),
|
|
ReleaseCandidate = provider.GlobalOptions.GetBool(
|
|
nameof(DesignFileOptions.ReleaseCandidate)),
|
|
GenerateNodeManager = provider.GlobalOptions.GetBool(
|
|
nameof(DesignFileOptions.GenerateNodeManager))
|
|
},
|
|
Exclude = provider.GlobalOptions.GetStrings(nameof(Exclude)),
|
|
UseAllowSubtypes = provider.GlobalOptions.GetBool(nameof(UseAllowSubtypes)),
|
|
OmitObjectTypeProxies = provider.GlobalOptions.GetBool(
|
|
nameof(OmitObjectTypeProxies)),
|
|
ObjectTypeProxyNamespace = provider.GlobalOptions.GetString(
|
|
nameof(ObjectTypeProxyNamespace)),
|
|
UseTypeDefinitionModellingRules = provider.GlobalOptions.GetBool(
|
|
nameof(UseTypeDefinitionModellingRules)),
|
|
EmitDependencyMetadata = ParseEmitMode(provider.GlobalOptions.GetString(
|
|
nameof(EmitDependencyMetadata))),
|
|
OmitFluentApi = provider.GlobalOptions.GetBool(
|
|
nameof(OmitFluentApi)),
|
|
FluentAccessorsOnly = provider.GlobalOptions.GetBool(
|
|
nameof(FluentAccessorsOnly)),
|
|
OmitEventRecords = provider.GlobalOptions.GetBool(
|
|
nameof(OmitEventRecords))
|
|
};
|
|
}
|
|
|
|
private static EmitDependencyMetadataMode ParseEmitMode(string raw)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(raw))
|
|
{
|
|
return EmitDependencyMetadataMode.Auto;
|
|
}
|
|
return raw.Trim().ToLowerInvariant() switch
|
|
{
|
|
"always" or "true" => EmitDependencyMetadataMode.Always,
|
|
"never" or "false" => EmitDependencyMetadataMode.Never,
|
|
_ => EmitDependencyMetadataMode.Auto
|
|
};
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Whether the generator emits cross-assembly model-dependency
|
|
/// metadata attributes (<c>ModelDependencyAttribute</c> +
|
|
/// <c>ModelSnapshotAttribute</c>).
|
|
/// </summary>
|
|
internal enum EmitDependencyMetadataMode
|
|
{
|
|
/// <summary>
|
|
/// Emit only when building a library.
|
|
/// </summary>
|
|
Auto,
|
|
|
|
/// <summary>
|
|
/// Always emit (override).
|
|
/// </summary>
|
|
Always,
|
|
|
|
/// <summary>
|
|
/// Never emit (override).
|
|
/// </summary>
|
|
Never
|
|
}
|
|
}
|