Files
Marc Schier a81d981755 dotnet format sweep (whitespace, IDE, RCS) + code-style enforcer agent fix (#3865)
# Description

Pure code-style sweep across the repo — no behavioral changes. Drives
`dotnet format` info-level diagnostics down on a large slice of the
codebase (Stack, Libraries, Tests, Tools).

Six commits, applied bottom-up in safety order so each batch leaves the
build green:

1. **`style: fix whitespace and final-newline formatting (WHITESPACE,
FINALNEWLINE)`**
   197 hits across ~30 files; pure mechanical cleanup.

2. **`style: apply dotnet format style fixes (IDE rules)`**
IDE-rule batch via `dotnet format style --severity info` —
`var`/explicit type, simplify names, collection expressions, expression
bodies, unused usings, etc.

3. **`style: apply dotnet format analyzers fixes (RCS blank-line
formatting)`**
   Roslynator formatting (RCS0xxx) blank-line and punctuation rules.

4. **`style: convert comments to doc comments and inline local vars
(RCS1181, RCS1124)`**
24 files. RCS1181 promotes `// summary`-style comments above
public/internal members to `/// <summary>` doc comments; RCS1124 inlines
locals used exactly once. Generated `Tools/` files were reverted to keep
the source-generator outputs deterministic.

5. **`docs(agent): correct --diagnostics flag form and verify Roslynator
4.x code fixers`**
Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two
corrections discovered while running this sweep:
- `dotnet format --diagnostics "RULE1 RULE2"` (single quoted,
space-separated) silently fixes nothing on `dotnet format` 10.x — it
parses as one unknown ID and exits 0. The correct form is `--diagnostics
RULE1 --diagnostics RULE2 …`, repeated per rule.
- Roslynator 4.15.0 **does** ship code fixers for
RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer"
list was outdated). RCS1140/1142 default to `Hidden` so need `--severity
info` to surface and fire; RCS1078 requires
`roslynator_empty_string_style = field` (already set in
`.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in
this stack.

6. **`style: format new code from master merge (dotnet format sweep)`**
After merging master into the branch (commit `e3ebc8742`), re-ran the
same three-phase format sweep on the 151 .cs files brought in by the
merge, scoped per project via repeated `--include`. 81 files changed;
same rule families as commits 1–4.
- Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs`
for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer
didn't apply for that specific case.
   - Reverted files that the formatter would break:
- `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM
analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>`
markers.
-
`Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs,
Core/Stack/Types/IUserIdentityTokenHandler.cs,
Client/Session/Session.cs}` — IDE0005 removed `using
Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378
reference fixtures for the analyzer).
- `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified
`OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a
conflicting type.

### What this PR does **not** touch

- No behavioral or semantic logic changes.
- No `.editorconfig` rule promotions (rules stay at their current
severities; this is a backlog-burndown pass, not a rule tightening).
- Generated source under `Tools/` is intentionally excluded.
- Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`,
`RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for
follow-up sweeps because they need per-TFM build verification or
semantic review.

## Related Issues

_No tracking issue — this is a non-functional style sweep and the
agent-doc correction is a follow-up to the same work. Happy to open one
if the maintainers prefer._

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — style-only, no
behavioral change)_
- [x] I have added all necessary documentation. _(agent doc updated with
the two corrections)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. _(verified clean on `net10.0` and `net48`; only
pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(build
verified on net10 and net48 per batch; full test suite not yet run
locally — relying on CI)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

---------

Co-authored-by: agent <agent@local>
2026-06-10 08:35:44 +02:00

183 lines
7.8 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Collections.Generic;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Options;
namespace Opc.Ua.Client.Subscriptions
{
/// <summary>
/// Subscription manager manages all subscription in a session
/// </summary>
public interface ISubscriptionManager
{
/// <summary>
/// Return diagnostics mask to use when sending publish requests.
/// </summary>
DiagnosticsMasks ReturnDiagnostics { get; set; }
/// <summary>
/// Gets and sets the maximum number of publish requests to
/// be used in the session.
/// </summary>
int MaxPublishWorkerCount { get; set; }
/// <summary>
/// Gets and sets the minimum number of publish requests to be
/// used in the session.
/// </summary>
int MinPublishWorkerCount { get; set; }
/// <summary>
/// Get the number of current publishing workers
/// </summary>
int PublishWorkerCount { get; }
/// <summary>
/// Good publish requests
/// </summary>
int GoodPublishRequestCount { get; }
/// <summary>
/// Bad publish requests
/// </summary>
int BadPublishRequestCount { get; }
/// <summary>
/// Total number of missing notification messages detected across
/// all subscriptions managed by this manager (sum of
/// <see cref="ISubscription.MissingMessageCount"/>).
/// </summary>
long MissingMessageCount { get; }
/// <summary>
/// Total number of republish requests issued across all
/// subscriptions managed by this manager (sum of
/// <see cref="ISubscription.RepublishMessageCount"/>).
/// </summary>
long RepublishMessageCount { get; }
/// <summary>
/// Number of subscriptions
/// </summary>
int Count { get; }
/// <summary>
/// <para>
/// When <c>true</c>, the V2 subscription dispatcher calls
/// <see cref="IPooledEncodeable.Reuse"/> on notification payload
/// instances (such as <c>MonitoredItemNotification</c>) after
/// the handler returns, releasing them back to their
/// activator-level pools for reuse.
/// </para>
/// <para>
/// When <c>false</c> (default), instances are simply released
/// to the GC as before.
/// </para>
/// <para>
/// Setting this property takes effect on the next publish
/// dispatch. Handlers that retain notification values past the
/// dispatch call must not enable this option, or must copy the
/// retained values before returning from the handler.
/// </para>
/// </summary>
bool PoolNotifications { get; set; }
/// <summary>
/// Subscriptions
/// </summary>
IEnumerable<ISubscription> Items { get; }
/// <summary>
/// Create new subscriptions inside the session.
/// The subscription will not be created but will
/// be created asynchronously. Disposing the session
/// will remove it from the session but not from
/// the server. The subscription must also explicitly
/// be deleted using DeleteAsync to remove it from
/// the server.
/// </summary>
/// <param name="handler"></param>
/// <param name="options"></param>
/// <returns></returns>
ISubscription Add(ISubscriptionNotificationHandler handler,
IOptionsMonitor<SubscriptionOptions> options);
/// <summary>
/// Snapshot all subscriptions managed by this instance and write
/// them to <paramref name="stream"/> in OPC UA binary encoding.
/// The format starts with the session's namespace and server URI
/// tables so the snapshot is portable across sessions whose
/// tables index the same URIs in different positions.
/// </summary>
/// <param name="stream">The destination stream. Must be writable.</param>
/// <param name="messageContext">The message context that supplies
/// the namespace + server URI tables used by the on-wire encoding.
/// Pass <c>session.MessageContext</c>.</param>
/// <param name="subscriptions">Optional subset of subscriptions to
/// snapshot. When <c>null</c> all managed subscriptions are saved.</param>
/// <param name="ct">Cancellation token.</param>
ValueTask SaveAsync(
Stream stream,
IServiceMessageContext messageContext,
IEnumerable<ISubscription>? subscriptions = null,
CancellationToken ct = default);
/// <summary>
/// Restore subscriptions from a stream previously produced by
/// <see cref="SaveAsync"/>. Each restored subscription is added to the
/// manager via the same path used by <see cref="Add"/>.
/// </summary>
/// <param name="stream">The source stream. Must be readable.</param>
/// <param name="messageContext">Message context that supplies the
/// active session's namespace + server URI tables. Indexes in the
/// saved snapshot are remapped onto these tables.</param>
/// <param name="handlerFactory">Factory invoked once per restored
/// subscription to construct the application's
/// <see cref="ISubscriptionNotificationHandler"/>. The factory
/// receives the per-subscription <c>Name</c> from the snapshot.</param>
/// <param name="transferSubscriptions">When <c>true</c> the
/// server-side subscription and monitored item ids are preserved
/// so the caller can issue a TransferSubscriptions call to take
/// over the existing server-side state. When <c>false</c> the ids
/// are cleared so the V2 manager recreates the subscriptions from
/// scratch on the new session — matching classic
/// <see cref="Session.Load(Stream, bool, IEnumerable{System.Type})"/>.</param>
/// <param name="ct">Cancellation token.</param>
ValueTask<IReadOnlyList<ISubscription>> LoadAsync(Stream stream,
IServiceMessageContext messageContext,
System.Func<string, ISubscriptionNotificationHandler> handlerFactory,
bool transferSubscriptions = false,
CancellationToken ct = default);
}
}