mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-18 22:55:08 +08:00
a81d981755
# Description
Pure code-style sweep across the repo — no behavioral changes. Drives
`dotnet format` info-level diagnostics down on a large slice of the
codebase (Stack, Libraries, Tests, Tools).
Six commits, applied bottom-up in safety order so each batch leaves the
build green:
1. **`style: fix whitespace and final-newline formatting (WHITESPACE,
FINALNEWLINE)`**
197 hits across ~30 files; pure mechanical cleanup.
2. **`style: apply dotnet format style fixes (IDE rules)`**
IDE-rule batch via `dotnet format style --severity info` —
`var`/explicit type, simplify names, collection expressions, expression
bodies, unused usings, etc.
3. **`style: apply dotnet format analyzers fixes (RCS blank-line
formatting)`**
Roslynator formatting (RCS0xxx) blank-line and punctuation rules.
4. **`style: convert comments to doc comments and inline local vars
(RCS1181, RCS1124)`**
24 files. RCS1181 promotes `// summary`-style comments above
public/internal members to `/// <summary>` doc comments; RCS1124 inlines
locals used exactly once. Generated `Tools/` files were reverted to keep
the source-generator outputs deterministic.
5. **`docs(agent): correct --diagnostics flag form and verify Roslynator
4.x code fixers`**
Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two
corrections discovered while running this sweep:
- `dotnet format --diagnostics "RULE1 RULE2"` (single quoted,
space-separated) silently fixes nothing on `dotnet format` 10.x — it
parses as one unknown ID and exits 0. The correct form is `--diagnostics
RULE1 --diagnostics RULE2 …`, repeated per rule.
- Roslynator 4.15.0 **does** ship code fixers for
RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer"
list was outdated). RCS1140/1142 default to `Hidden` so need `--severity
info` to surface and fire; RCS1078 requires
`roslynator_empty_string_style = field` (already set in
`.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in
this stack.
6. **`style: format new code from master merge (dotnet format sweep)`**
After merging master into the branch (commit `e3ebc8742`), re-ran the
same three-phase format sweep on the 151 .cs files brought in by the
merge, scoped per project via repeated `--include`. 81 files changed;
same rule families as commits 1–4.
- Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs`
for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer
didn't apply for that specific case.
- Reverted files that the formatter would break:
- `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM
analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>`
markers.
-
`Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs,
Core/Stack/Types/IUserIdentityTokenHandler.cs,
Client/Session/Session.cs}` — IDE0005 removed `using
Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378
reference fixtures for the analyzer).
- `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified
`OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a
conflicting type.
### What this PR does **not** touch
- No behavioral or semantic logic changes.
- No `.editorconfig` rule promotions (rules stay at their current
severities; this is a backlog-burndown pass, not a rule tightening).
- Generated source under `Tools/` is intentionally excluded.
- Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`,
`RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for
follow-up sweeps because they need per-TFM build verification or
semantic review.
## Related Issues
_No tracking issue — this is a non-functional style sweep and the
agent-doc correction is a follow-up to the same work. Happy to open one
if the maintainers prefer._
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — style-only, no
behavioral change)_
- [x] I have added all necessary documentation. _(agent doc updated with
the two corrections)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. _(verified clean on `net10.0` and `net48`; only
pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(build
verified on net10 and net48 per batch; full test suite not yet run
locally — relying on CI)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
---------
Co-authored-by: agent <agent@local>
617 lines
25 KiB
C#
617 lines
25 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Collections.Immutable;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using System.Threading.Channels;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
namespace Opc.Ua.Client.Subscriptions
|
|
{
|
|
/// <summary>
|
|
/// Processes messages inside a subscription, it is the base class for all
|
|
/// subscription objects but basis to support better testing in isolation.
|
|
/// </summary>
|
|
internal abstract class MessageProcessor : IMessageProcessor, IAsyncDisposable
|
|
{
|
|
/// <inheritdoc/>
|
|
public uint Id { get; internal set; }
|
|
|
|
/// <summary>
|
|
/// Number of notification messages detected as missing during
|
|
/// gap-walking of the SequenceNumber on this subscription.
|
|
/// </summary>
|
|
public long MissingMessageCount => Volatile.Read(ref m_missingCount);
|
|
|
|
/// <summary>
|
|
/// Number of republish requests issued for this subscription
|
|
/// (counts every attempt regardless of outcome).
|
|
/// </summary>
|
|
public long RepublishMessageCount => Volatile.Read(ref m_republishCount);
|
|
|
|
/// <summary>
|
|
/// Observability context
|
|
/// </summary>
|
|
protected ITelemetryContext Observability { get; }
|
|
|
|
/// <summary>
|
|
/// Whether the message processor should release pooled notification
|
|
/// payload instances back to their activator pools after the handler
|
|
/// dispatch completes. Reflects the current
|
|
/// <see cref="IMessageAckQueue.PoolNotifications"/> setting on the
|
|
/// subscription manager; toggling the manager-level setting takes
|
|
/// effect on the next dispatch.
|
|
/// </summary>
|
|
protected bool PoolNotifications => AckQueue.PoolNotifications;
|
|
|
|
/// <summary>
|
|
/// Create subscription
|
|
/// </summary>
|
|
/// <param name="services"></param>
|
|
/// <param name="completion"></param>
|
|
/// <param name="telemetry"></param>
|
|
/// <param name="timeProvider">Optional <see cref="TimeProvider"/>
|
|
/// for elapsed-time and timestamp calculations. Defaults to
|
|
/// <see cref="TimeProvider.System"/> when <c>null</c>.</param>
|
|
protected MessageProcessor(
|
|
ISubscriptionServiceSetClientMethods services,
|
|
IMessageAckQueue completion,
|
|
ITelemetryContext telemetry,
|
|
TimeProvider? timeProvider = null)
|
|
{
|
|
TimeProvider = timeProvider ?? TimeProvider.System;
|
|
Observability = telemetry;
|
|
AvailableInRetransmissionQueue = [];
|
|
Logger = Observability.LoggerFactory.CreateLogger<Subscription>();
|
|
m_services = services;
|
|
AckQueue = completion;
|
|
m_messages = Channel.CreateUnboundedPrioritized(
|
|
new UnboundedPrioritizedChannelOptions<IncomingMessage>
|
|
{
|
|
SingleReader = true,
|
|
Comparer = Comparer<IncomingMessage>.Create(
|
|
IncomingMessage.Compare)
|
|
});
|
|
m_messageWorkerTask = ProcessReceivedMessagesAsync(m_cts.Token);
|
|
}
|
|
|
|
/// <inheritdoc/>
|
|
public ValueTask DisposeAsync()
|
|
{
|
|
GC.SuppressFinalize(this);
|
|
return DisposeAsync(true);
|
|
}
|
|
|
|
/// <inheritdoc/>
|
|
public virtual async ValueTask OnPublishReceivedAsync(
|
|
NotificationMessage message,
|
|
IReadOnlyList<uint>? availableSequenceNumbers,
|
|
IReadOnlyList<string> stringTable)
|
|
{
|
|
if (availableSequenceNumbers != null)
|
|
{
|
|
AvailableInRetransmissionQueue = availableSequenceNumbers;
|
|
}
|
|
LastNotificationTimestamp = TimeProvider.GetTimestamp();
|
|
await m_messages.Writer.WriteAsync(new IncomingMessage(message, stringTable,
|
|
TimeProvider.GetUtcNow())).ConfigureAwait(false);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Dispose subscription
|
|
/// </summary>
|
|
/// <param name="disposing"></param>
|
|
protected virtual async ValueTask DisposeAsync(bool disposing)
|
|
{
|
|
if (disposing && !Disposed)
|
|
{
|
|
try
|
|
{
|
|
m_messages.Writer.TryComplete();
|
|
await m_cts.CancelAsync().ConfigureAwait(false);
|
|
await m_messageWorkerTask.ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
m_cts.Dispose();
|
|
(m_messages as IDisposable)?.Dispose();
|
|
Disposed = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Process status change notification
|
|
/// </summary>
|
|
/// <param name="sequenceNumber"></param>
|
|
/// <param name="publishTime"></param>
|
|
/// <param name="notification"></param>
|
|
/// <param name="publishStateMask"></param>
|
|
/// <param name="stringTable"></param>
|
|
/// <returns></returns>
|
|
protected abstract ValueTask OnStatusChangeNotificationAsync(
|
|
uint sequenceNumber,
|
|
DateTime publishTime,
|
|
StatusChangeNotification notification,
|
|
PublishState publishStateMask,
|
|
IReadOnlyList<string> stringTable);
|
|
|
|
/// <summary>
|
|
/// Process keep alive notification
|
|
/// </summary>
|
|
/// <param name="sequenceNumber"></param>
|
|
/// <param name="publishTime"></param>
|
|
/// <param name="publishStateMask"></param>
|
|
/// <returns></returns>
|
|
protected abstract ValueTask OnKeepAliveNotificationAsync(
|
|
uint sequenceNumber,
|
|
DateTime publishTime,
|
|
PublishState publishStateMask);
|
|
|
|
/// <summary>
|
|
/// Process data change notification
|
|
/// </summary>
|
|
/// <param name="sequenceNumber"></param>
|
|
/// <param name="publishTime"></param>
|
|
/// <param name="notification"></param>
|
|
/// <param name="publishStateMask"></param>
|
|
/// <param name="stringTable"></param>
|
|
/// <returns></returns>
|
|
protected abstract ValueTask OnDataChangeNotificationAsync(
|
|
uint sequenceNumber,
|
|
DateTime publishTime,
|
|
DataChangeNotification notification,
|
|
PublishState publishStateMask,
|
|
IReadOnlyList<string> stringTable);
|
|
|
|
/// <summary>
|
|
/// Process event notification
|
|
/// </summary>
|
|
/// <param name="sequenceNumber"></param>
|
|
/// <param name="publishTime"></param>
|
|
/// <param name="notification"></param>
|
|
/// <param name="publishStateMask"></param>
|
|
/// <param name="stringTable"></param>
|
|
/// <returns></returns>
|
|
protected abstract ValueTask OnEventDataNotificationAsync(
|
|
uint sequenceNumber,
|
|
DateTime publishTime,
|
|
EventNotificationList notification,
|
|
PublishState publishStateMask,
|
|
IReadOnlyList<string> stringTable);
|
|
|
|
/// <summary>
|
|
/// On publish state changed
|
|
/// </summary>
|
|
/// <param name="stateMask"></param>
|
|
/// <returns></returns>
|
|
protected virtual void OnPublishStateChanged(PublishState stateMask)
|
|
{
|
|
if (stateMask.HasFlag(PublishState.Stopped))
|
|
{
|
|
Logger.LogInformation("{Subscription} STOPPED!", this);
|
|
}
|
|
if (stateMask.HasFlag(PublishState.Recovered))
|
|
{
|
|
Logger.LogInformation("{Subscription} RECOVERED!", this);
|
|
}
|
|
if (stateMask.HasFlag(PublishState.Completed))
|
|
{
|
|
Logger.LogInformation("{Subscription} CLOSED!", this);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Processes all incoming messages and dispatch them.
|
|
/// </summary>
|
|
/// <param name="ct"></param>
|
|
private async Task ProcessReceivedMessagesAsync(CancellationToken ct)
|
|
{
|
|
try
|
|
{
|
|
//
|
|
// This can be optimized to peek when missing sequence number
|
|
// and not in available sequence number als to support batching.
|
|
// TODO This also needs to guard against overruns using some
|
|
// form of semaphore to block the publisher.
|
|
// Unless we get https://github.com/dotnet/runtime/issues/101292
|
|
//
|
|
IAsyncEnumerable<IncomingMessage> reader = m_messages.Reader.ReadAllAsync(ct);
|
|
await foreach (IncomingMessage incoming in reader.ConfigureAwait(false))
|
|
{
|
|
await ProcessMessageAsync(incoming, ct).ConfigureAwait(false);
|
|
}
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
Logger.LogCritical(ex,
|
|
"{Subscription}: Error processing messages. Processor is exiting!!!",
|
|
this);
|
|
|
|
// Do not call complete here as we do not want the subscription
|
|
// to be removed
|
|
throw;
|
|
}
|
|
await AckQueue.CompleteAsync(Id, default).ConfigureAwait(false);
|
|
OnPublishStateChanged(PublishState.Completed);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Notify the owning manager/queue that the subscription's
|
|
/// state has changed (e.g. it has just been created on the
|
|
/// server). The manager uses this signal to re-evaluate the
|
|
/// publish worker pool.
|
|
/// </summary>
|
|
protected void NotifyManagerOfCreation()
|
|
{
|
|
AckQueue.Update();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Process message. The logic checks whether any message was missed
|
|
/// and try to republish. Any new messages received that already were
|
|
/// handled are discarded. The message is then dispatched to the appropriate
|
|
/// callbacks that must be overridden by the derived class.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Sequence numbers are circular per OPC UA Part 4 §7.30.5 — they
|
|
/// wrap from <see cref="uint.MaxValue"/> to 1 (skipping 0). The
|
|
/// implementation uses unsigned-difference arithmetic to detect
|
|
/// "older vs newer" across a wraparound, and walks the
|
|
/// missing-message range explicitly wrapping past
|
|
/// <see cref="uint.MaxValue"/> to 1.
|
|
/// </remarks>
|
|
/// <param name="incoming"></param>
|
|
/// <param name="ct"></param>
|
|
/// <returns></returns>
|
|
private async Task ProcessMessageAsync(IncomingMessage incoming, CancellationToken ct)
|
|
{
|
|
uint curSeqNum = incoming.Message.SequenceNumber;
|
|
bool isKeepAlive = incoming.Message.NotificationData.Count == 0;
|
|
const uint kBackwardThreshold = 1u << 31;
|
|
|
|
if (isKeepAlive)
|
|
{
|
|
// Per OPC UA Part 4 §7.30, a keep-alive NotificationMessage
|
|
// carries the SequenceNumber of the next NotificationMessage
|
|
// to be sent. Multiple consecutive keep-alives therefore
|
|
// reuse the same SequenceNumber, and the next real data
|
|
// message reuses it too (the slot is consumed only when data
|
|
// is emitted). Bypass the duplicate-message filter, surface
|
|
// the keep-alive, and DO NOT advance the data-dedup gate
|
|
// (LastDataSequenceNumberProcessed) — otherwise the next real
|
|
// data message would be silently dropped as a duplicate.
|
|
LastSequenceNumberProcessed = curSeqNum;
|
|
await OnNotificationReceivedAsync(
|
|
incoming.Message,
|
|
PublishState.KeepAlive,
|
|
ct).ConfigureAwait(false);
|
|
return;
|
|
}
|
|
|
|
// Data / event message — apply the dedup / gap-walk logic
|
|
// against the highest-consumed data SequenceNumber.
|
|
uint prevDataSeq = LastDataSequenceNumberProcessed;
|
|
if (prevDataSeq != 0)
|
|
{
|
|
uint delta = unchecked(curSeqNum - prevDataSeq);
|
|
if (delta is 0 or >= kBackwardThreshold)
|
|
{
|
|
if (!Logger.IsEnabled(LogLevel.Debug))
|
|
{
|
|
return;
|
|
}
|
|
if (curSeqNum == prevDataSeq)
|
|
{
|
|
Logger.LogDebug(
|
|
"{Subscription}: Received duplicate message " +
|
|
"with sequence number #{SeqNumber}.",
|
|
this,
|
|
curSeqNum);
|
|
}
|
|
else
|
|
{
|
|
Logger.LogDebug(
|
|
"{Subscription}: Received older message with " +
|
|
"sequence number #{SeqNumber} but already processed message with " +
|
|
"sequence number #{Old}.",
|
|
this,
|
|
curSeqNum,
|
|
prevDataSeq);
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Walk the gap (prevDataSeq, curSeqNum) wrapping past
|
|
// uint.MaxValue to 1.
|
|
uint missing = prevDataSeq;
|
|
while (true)
|
|
{
|
|
missing = missing == uint.MaxValue ? 1u : missing + 1u;
|
|
if (missing == curSeqNum)
|
|
{
|
|
break;
|
|
}
|
|
Interlocked.Increment(ref m_missingCount);
|
|
await TryRepublishAsync(missing, curSeqNum, ct).ConfigureAwait(false);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
// First data message after subscription create / recreate /
|
|
// transfer. We don't know what came before, but the
|
|
// server may still hold older retransmissible messages
|
|
// (e.g. on a transferred subscription where the first
|
|
// received SequenceNumber is greater than 1). Walk only
|
|
// the published AvailableInRetransmissionQueue so the
|
|
// cost is bounded by the server's queue size, not the
|
|
// raw gap. Mirrors the V1 fix in PR #3565.
|
|
IReadOnlyList<uint> available = AvailableInRetransmissionQueue;
|
|
for (int i = 0; i < available.Count; i++)
|
|
{
|
|
uint seq = available[i];
|
|
uint delta = unchecked(curSeqNum - seq);
|
|
if (delta is not 0 and < kBackwardThreshold)
|
|
{
|
|
await TryRepublishAsync(seq, curSeqNum, ct).ConfigureAwait(false);
|
|
}
|
|
}
|
|
}
|
|
LastDataSequenceNumberProcessed = curSeqNum;
|
|
LastSequenceNumberProcessed = curSeqNum;
|
|
await OnNotificationReceivedAsync(
|
|
incoming.Message,
|
|
PublishState.None,
|
|
ct).ConfigureAwait(false);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Try republish a missing message
|
|
/// </summary>
|
|
/// <param name="missing"></param>
|
|
/// <param name="curSeqNum"></param>
|
|
/// <param name="ct"></param>
|
|
/// <returns></returns>
|
|
private async ValueTask TryRepublishAsync(uint missing, uint curSeqNum,
|
|
CancellationToken ct)
|
|
{
|
|
Interlocked.Increment(ref m_republishCount);
|
|
if (!AvailableInRetransmissionQueue.Contains(missing))
|
|
{
|
|
Logger.LogWarning(
|
|
"{Subscription}: Message with sequence number " +
|
|
"#{SeqNumber} is not in server retransmission queue and was dropped.",
|
|
this,
|
|
missing);
|
|
return;
|
|
}
|
|
try
|
|
{
|
|
Logger.LogInformation(
|
|
"{Subscription}: Republishing missing message " +
|
|
"with sequence number #{Missing} to catch up to message " +
|
|
"with sequence number #{SeqNumber}...",
|
|
this,
|
|
missing,
|
|
curSeqNum);
|
|
RepublishResponse republish = await m_services.RepublishAsync(
|
|
null,
|
|
Id,
|
|
missing,
|
|
ct).ConfigureAwait(false);
|
|
|
|
if (ServiceResult.IsGood(republish.ResponseHeader.ServiceResult))
|
|
{
|
|
await OnNotificationReceivedAsync(
|
|
republish.NotificationMessage,
|
|
PublishState.Republish,
|
|
ct).ConfigureAwait(false);
|
|
}
|
|
else
|
|
{
|
|
Logger.LogWarning(
|
|
"{Subscription}: Republishing message with " +
|
|
"sequence number #{SeqNumber} failed.",
|
|
this,
|
|
missing);
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
Logger.LogError(
|
|
ex,
|
|
"{Subscription}: Error republishing message with " +
|
|
"sequence number #{SeqNumber}.",
|
|
this,
|
|
missing);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Dispatch notification message
|
|
/// </summary>
|
|
/// <param name="message"></param>
|
|
/// <param name="publishStateMask"></param>
|
|
/// <param name="ct"></param>
|
|
/// <returns></returns>
|
|
private async ValueTask OnNotificationReceivedAsync(
|
|
NotificationMessage message,
|
|
PublishState publishStateMask,
|
|
CancellationToken ct)
|
|
{
|
|
try
|
|
{
|
|
if (message.NotificationData.Count == 0)
|
|
{
|
|
publishStateMask |= PublishState.KeepAlive;
|
|
await OnKeepAliveNotificationAsync(
|
|
message.SequenceNumber,
|
|
(DateTime)message.PublishTime,
|
|
publishStateMask).ConfigureAwait(false);
|
|
}
|
|
else
|
|
{
|
|
for (int i = 0; i < message.NotificationData.Count; i++)
|
|
{
|
|
await DispatchAsync(
|
|
message,
|
|
publishStateMask,
|
|
message.NotificationData[i]).ConfigureAwait(false);
|
|
}
|
|
}
|
|
await AckQueue.QueueAsync(new SubscriptionAcknowledgement
|
|
{
|
|
SequenceNumber = message.SequenceNumber,
|
|
SubscriptionId = Id
|
|
}, ct).ConfigureAwait(false);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
Logger.LogError(ex,
|
|
"{Subscription}: Error dispatching notification data.",
|
|
this);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Dispatch notification
|
|
/// </summary>
|
|
/// <param name="message"></param>
|
|
/// <param name="publishStateMask"></param>
|
|
/// <param name="notificationData"></param>
|
|
/// <returns></returns>
|
|
private async ValueTask DispatchAsync(NotificationMessage message,
|
|
PublishState publishStateMask, ExtensionObject? notificationData)
|
|
{
|
|
if (notificationData == null)
|
|
{
|
|
return;
|
|
}
|
|
if (notificationData.Value.TryGetValue(
|
|
out DataChangeNotification? datachange))
|
|
{
|
|
await OnDataChangeNotificationAsync(
|
|
message.SequenceNumber,
|
|
(DateTime)message.PublishTime,
|
|
datachange,
|
|
publishStateMask,
|
|
message.StringTable.ToArray() ?? []).ConfigureAwait(false);
|
|
}
|
|
else if (notificationData.Value.TryGetValue(
|
|
out EventNotificationList? events))
|
|
{
|
|
await OnEventDataNotificationAsync(
|
|
message.SequenceNumber,
|
|
(DateTime)message.PublishTime,
|
|
events,
|
|
publishStateMask,
|
|
message.StringTable.ToArray() ?? []).ConfigureAwait(false);
|
|
}
|
|
else if (notificationData.Value.TryGetValue(
|
|
out StatusChangeNotification? statusChanged))
|
|
{
|
|
PublishState mask = publishStateMask;
|
|
if (statusChanged.Status == StatusCodes.GoodSubscriptionTransferred)
|
|
{
|
|
// Only happens if we did not initiate the transfer.
|
|
// TODO: Complete this subscription.
|
|
mask |= PublishState.Transferred;
|
|
}
|
|
else if (statusChanged.Status == StatusCodes.BadTimeout)
|
|
{
|
|
// Timeout on the server.
|
|
// TODO: Also complete this subscription
|
|
mask |= PublishState.Timeout;
|
|
}
|
|
await OnStatusChangeNotificationAsync(
|
|
message.SequenceNumber,
|
|
(DateTime)message.PublishTime,
|
|
statusChanged,
|
|
mask,
|
|
message.StringTable.ToArray() ?? []).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// A message received from the server cached until is processed or discarded.
|
|
/// </summary>
|
|
/// <param name="Message"></param>
|
|
/// <param name="StringTable"></param>
|
|
/// <param name="Enqueued"></param>
|
|
private readonly record struct IncomingMessage(
|
|
NotificationMessage Message,
|
|
IReadOnlyList<string> StringTable,
|
|
DateTimeOffset Enqueued)
|
|
{
|
|
public static int Compare(IncomingMessage message, IncomingMessage other)
|
|
{
|
|
// Greater than zero � message follows the
|
|
// other message in sort order.
|
|
return
|
|
(int)message.Message.SequenceNumber -
|
|
(int)other.Message.SequenceNumber;
|
|
}
|
|
}
|
|
|
|
internal bool Disposed;
|
|
internal long LastNotificationTimestamp;
|
|
internal uint LastSequenceNumberProcessed;
|
|
internal uint LastDataSequenceNumberProcessed;
|
|
internal long m_missingCount;
|
|
internal long m_republishCount;
|
|
internal IReadOnlyList<uint> AvailableInRetransmissionQueue;
|
|
internal readonly ILogger Logger;
|
|
protected TimeProvider TimeProvider { get; }
|
|
|
|
/// <summary>
|
|
/// Exposes the ack queue / completion sink supplied to the
|
|
/// processor so derived classes can interact with it without
|
|
/// reaching for a private field — used today by the recovery
|
|
/// path to drop stale acknowledgements before recreating a
|
|
/// subscription that the server has invalidated under us.
|
|
/// </summary>
|
|
protected IMessageAckQueue AckQueue { get; }
|
|
private readonly ISubscriptionServiceSetClientMethods m_services;
|
|
// CA2213: m_cts is disposed in DisposeAsync(bool) — suppressed because
|
|
// the analyzer does not track IAsyncDisposable disposal paths.
|
|
#pragma warning disable CA2213
|
|
private readonly CancellationTokenSource m_cts = new();
|
|
#pragma warning restore CA2213
|
|
private readonly Task m_messageWorkerTask;
|
|
private readonly Channel<IncomingMessage> m_messages;
|
|
}
|
|
}
|