Files
Marc Schier 889572472f Convert DataValue from class to readonly struct for further GC relief (#3796)
Convert `DataValue` from a mutable reference type (`class`) to a `readonly struct` to eliminate per-allocation GC pressure on every attribute read, subscription publish, and history sample.

### Key API changes (user-visible)

| Before | After | Pattern |
|---|---|---|
| `class DataValue` | `readonly struct DataValue : INullable` | Foundation |
| `Equals(DataValue?)` / `operator ==(DataValue?, DataValue?)` | `Equals(DataValue)` / `operator ==(DataValue, DataValue)` | Value semantics |
| `IEncoder.WriteDataValue(string?, DataValue?)` | `IEncoder.WriteDataValue(string?, DataValue)` | Non-nullable wire API |
| `IDecoder.ReadDataValue(...) -> DataValue?` | `IDecoder.ReadDataValue(...) -> DataValue` | Same |
| `IDataChangeMonitoredItemQueue.PeekLast/Oldest()` | `TryPeekLastValue/Oldest(out DataValue)` | TryGet pattern |
| `IAggregateCalculator.GetProcessedValue(bool)` | `TryGetProcessedValue(bool, out DataValue)` | Same |
| `IUaPubSubDataStore.ReadPublishedDataItem(...)` | `TryReadPublishedDataItem(NodeId, uint, out DataValue)` | Same |
| `Dictionary<uint, DataValue?>` (NodeCacheContext) | `Dictionary<uint, DataValue>` | Default + IsNull |
| `IHistoryDataSource.FirstRaw/NextRaw` | `TryFirstRaw/TryNextRaw(out DataValue)` | TryGet pattern |
| `NodeState.ReadAttribute(... DataValue)` | `NodeState.ReadAttribute(... ref DataValue)` | Sync mutation via ref |
| `NodeState.ReadAttributeAsync(... DataValue)` | `NodeState.ReadAttributeAsync(...) -> ValueTask<(ServiceResult, DataValue)>` | Async return tuple |
| `obj as DataValue` (heterogeneous Dictionary<string, object>) | `obj is DataValue dv ? dv : default(DataValue)` | Safe struct cast |
| `Assert.That(dv, Is.Not.Null)` (tests) | `Assert.That(dv.IsNull, Is.False)` | Struct test pattern |
| `[Obsolete] Value` setter, all property setters | Removed; use ctor or `With*()` | Immutability |
| `[DataContract]` + `[DataMember]` | Removed; surrogate via `SerializableDataValue` + `DataValueSurrogateProvider` | Serialization |

### Wire format

Wire format is **byte-identical** to the previous class-based implementation across binary / JSON / XML encoders. Default DataValue (`.IsNull == true`) is treated as the equivalent of the old null reference (writes JSON `null`, binary `byte 0`, XML omitted element).

### Why TryGet pattern (instead of leaving `DataValue?`)

For methods that previously returned `DataValue?` to signal "no value available" (queue peek, aggregate result, data store lookup, history navigation), the conversion to `bool TryGet(out DataValue)` matches BCL conventions (`Dictionary.TryGetValue`, `Queue.TryPeek`, `Int32.TryParse`) and gives the caller an explicit "may be absent" affordance without `Nullable<DataValue>` overhead.

### Breaking changes summary

- `DataValue` is now a `readonly struct` - boxing/unboxing semantics change for callers using `object`-typed APIs.
- `IEncoder.WriteDataValue` / `IDecoder.ReadDataValue` / `ReadDataValueArray` interface signatures lose the `Nullable` wrapper.
- `IDataChangeMonitoredItemQueue.PeekLastValue` / `PeekOldestValue` -> `TryPeekLastValue` / `TryPeekOldestValue` (out parameter).
- `IAggregateCalculator.GetProcessedValue` -> `TryGetProcessedValue` (out parameter).
- `IUaPubSubDataStore.ReadPublishedDataItem` -> `TryReadPublishedDataItem` (out parameter).
- `NodeState.ReadAttribute` takes `ref DataValue`; `ReadAttributeAsync` returns `ValueTask<(ServiceResult, DataValue)>`.
- `DataValue` property setters removed (use constructor + `With*` mutators).
2026-05-23 11:38:49 +02:00

306 lines
8.4 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using Microsoft.Extensions.Logging;
namespace Opc.Ua.Server
{
/// <summary>
/// Provides a queue for data changes.
/// </summary>
public class DataChangeMonitoredItemQueue : IDataChangeMonitoredItemQueue
{
/// <summary>
/// Creates an empty queue.
/// </summary>
public DataChangeMonitoredItemQueue(bool createDurable, uint monitoredItemId, ITelemetryContext telemetry)
{
m_logger = telemetry.CreateLogger<DataChangeMonitoredItemQueue>();
if (createDurable)
{
m_logger.LogError(
"DataChangeMonitoredItemQueue does not support durable queues, please provide full implementation of IDurableMonitoredItemQueue using Server.CreateDurableMonitoredItemQueueFactory to supply own factory");
throw new ArgumentException(
"DataChangeMonitoredItemQueue does not support durable Queues",
nameof(createDurable));
}
MonitoredItemId = monitoredItemId;
m_values = null;
m_errors = null;
m_start = -1;
m_end = -1;
}
/// <inheritdoc/>
public uint MonitoredItemId { get; }
/// <summary>
/// Gets the current queue size.
/// </summary>
public uint QueueSize
{
get
{
if (m_values == null)
{
return 0;
}
return (uint)m_values.Length;
}
}
/// <summary>
/// Gets number of elements actually contained in value queue.
/// </summary>
public int ItemsInQueue
{
get
{
if (m_values == null || m_start == -1)
{
return 0;
}
if (m_start < m_end)
{
return m_end - m_start;
}
return m_values.Length - m_start + m_end;
}
}
/// <inheritdoc/>
public virtual bool IsDurable => false;
/// <summary>
/// Adds the value to the queue.
/// </summary>
/// <param name="value">The value to queue.</param>
/// <param name="error">The error to queue.</param>
/// <exception cref="InvalidOperationException"></exception>
public void Enqueue(DataValue value, ServiceResult error)
{
if (m_values == null || m_values.Length == 0)
{
throw new InvalidOperationException("Cannot enqueue Value. Queue size not set.");
}
//check for full queue
if (ItemsInQueue == m_values.Length)
{
Dequeue(out _, out _);
}
// check for empty queue.
if (m_start < 0)
{
m_start = 0;
m_end = 1;
m_values[m_start] = value;
m_errors?[m_start] = error;
return;
}
int next = m_end;
// check for wrap around.
if (next >= m_values.Length)
{
next = 0;
}
// add value.
m_values[next] = value;
m_errors?[next] = error;
m_end = next + 1;
}
/// <inheritdoc/>
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}
/// <summary>
/// Overridable method to dispose of resources.
/// </summary>
protected virtual void Dispose(bool disposing)
{
//only needed for unmanaged resources
}
/// <inheritdoc/>
public void OverwriteLastValue(DataValue value, ServiceResult error)
{
if (ItemsInQueue == 0)
{
throw new InvalidOperationException("Cannot overwrite Value. Queue is empty.");
}
int last = m_end - 1;
if (last < 0)
{
last = m_values!.Length - 1;
}
// replace last value and error.
m_values![last] = value;
m_errors?[last] = error;
}
/// <inheritdoc/>
public void ResetQueue(uint queueSize, bool queueErrors)
{
int length = (int)queueSize;
// create new queue.
var values = new DataValue[length];
ServiceResult[]? errors = null;
if (queueErrors)
{
errors = new ServiceResult[length];
}
// update internals.
m_values = values;
m_errors = errors;
m_start = -1;
m_end = 0;
}
/// <inheritdoc/>
public bool TryPeekLastValue(out DataValue value)
{
if (m_start < 0)
{
value = default;
return false;
}
int last = m_end - 1;
if (last < 0)
{
last = m_values!.Length - 1;
}
value = m_values![last];
return true;
}
/// <inheritdoc/>
public bool Dequeue(out DataValue value, out ServiceResult error)
{
value = default;
error = null!;
// check for empty queue.
if (m_start < 0)
{
return false;
}
value = m_values![m_start];
m_values[m_start] = default;
if (m_errors != null)
{
error = m_errors[m_start];
m_errors[m_start] = null!;
}
m_start++;
// check if queue has been emptied.
if (m_start == m_end)
{
m_start = -1;
m_end = 0;
}
// check for wrap around.
else if (m_start >= m_values.Length)
{
m_start = 0;
}
return true;
}
/// <inheritdoc/>
public bool TryPeekOldestValue(out DataValue value)
{
// check for empty queue.
if (m_start < 0)
{
value = default;
return false;
}
value = m_values![m_start];
return true;
}
/// <summary>
/// the stored data values
/// </summary>
protected DataValue[]? m_values;
/// <summary>
/// the stored errors
/// </summary>
protected ServiceResult[]? m_errors;
/// <summary>
/// the start of the buffer
/// </summary>
protected int m_start;
/// <summary>
/// the end of the buffer
/// </summary>
protected int m_end;
/// <summary>
/// A logger to use
/// </summary>
protected ILogger m_logger;
}
}