Files
Marc Schier c781514ad5 Refactor pcap diagnostics: decorator binding + rename to Opc.Ua.Bindings.Pcap
Three changes addressing the design feedback on PR #3855:

1. Renamed Stack/Opc.Ua.Diagnostics.Pcap -> Stack/Opc.Ua.Bindings.Pcap (and the corresponding test project). PackageId, AssemblyName and RootNamespace updated to Opc.Ua.Bindings.Pcap; references in McpServer, signlists, slnx files, docs, and the interop-tester agent updated; Opc.Ua.Core's InternalsVisibleTo entries updated.

2. Replaced UaSCUaBinaryChannel.FrameCaptureSink + per-call NotifyFrameCaptureSink null check with a transport-binding decorator. New files in Opc.Ua.Bindings.Pcap/Bindings:
   - IChannelCaptureRegistry / ChannelCaptureRegistry: singleton with a volatile IFrameCaptureSink slot (1 atomic write to switch recording on/off).
   - CapturingMessageSocket / CapturingMessageSocketFactory: IMessageSocket decorator that taps Send/Receive bytes via a single volatile read of CurrentObserver.
   - PcapTransportChannelBinding: ITransportChannelFactory decorator that injects the capturing socket factory into every TcpTransportChannel and wires ISecureChannel.OnTokenActivated through to the active observer.
   - PcapBindings.Install(): non-DI installer for direct TransportBindings.Channels.SetBinding wiring.

   IFrameCaptureSink moved to Opc.Ua.Core/Stack/Bindings and gained an OnTokenActivated method so the binding can publish key material alongside chunks. UaSCUaBinaryChannel.FrameCaptureSink property and all three NotifyFrameCaptureSink call sites removed - hot path returns to original shape with zero indirection when the binding is not installed. IMessageSocketAsyncEventArgs gains Offset + Count getters (additive).

   AddOpcUaDiagnosticsPcap/Formatters/Replay extension methods renamed to AddOpcUaBindingsPcap[Formatters|Replay]; the new AddOpcUaBindingsPcap also installs the binding into TransportBindings.Channels.

   InProcessClientCaptureSource / InProcessServerCaptureSource: dropped reflection-based AttachClientChannel/AttachServerChannel. The source itself implements IFrameCaptureSink and on Start publishes itself as the registry observer; on Stop clears it. McpServer's PacketCaptureTools simplified accordingly (no more per-channel attach loop).

3. Discarded the source-generator suggestion. Confirmed that the dissection path already 100% reuses the source-generated decoders: UaSCUaBinaryChannel.ReadSymmetricMessage for chunk decryption and BinaryDecoder.ReadEncodeable + EncodeableFactory.GlobalFactory (populated by Tools/Opc.Ua.SourceGeneration's DataTypeGenerator) for service-type decoding. Emitting additional dissection code would duplicate what's already there.

Validation:
- Full UA.slnx builds clean: 0 errors, 2 pre-existing unrelated warnings.
- All 53 tests pass on net10.0 (49 existing + 4 new CapturingMessageSocketTests covering hot-path: not-installed/installed-off/installed-on costs, byte equality, exception isolation).
- CI command line (dotnet build/test --framework net10.0 --configuration Release /p:CustomTestTarget=net10.0) reproduces clean locally.
2026-06-07 21:53:53 +02:00

289 lines
9.9 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.IO;
using System.Runtime.CompilerServices;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
using Opc.Ua.Bindings.Pcap.Frame;
using Opc.Ua.Bindings.Pcap.KeyLog;
using Opc.Ua.Bindings.Pcap.Models;
namespace Opc.Ua.Bindings.Pcap.Capture.Sources
{
/// <summary>
/// Replay capture source that projects an existing pcap and optional keylog through ICaptureSource.
/// </summary>
public sealed class ReplayCaptureSource : ICaptureSource
{
private readonly ILogger m_logger;
private string? m_pcapFilePath;
private string? m_keyLogFilePath;
private long m_frameCount;
private long m_byteCount;
private int m_state;
private const int StateNew = 0;
private const int StateRunning = 1;
private const int StateStopped = 2;
/// <summary>
/// Constructs a replay capture source.
/// </summary>
public ReplayCaptureSource(ILoggerFactory? loggerFactory = null)
{
ILoggerFactory factory = loggerFactory ?? NullLoggerFactory.Instance;
m_logger = factory.CreateLogger<ReplayCaptureSource>();
}
/// <inheritdoc/>
public IReadOnlySet<FormatKind> SupportedFormats { get; } = new HashSet<FormatKind>
{
FormatKind.Pcap,
FormatKind.PcapNg,
FormatKind.Json,
FormatKind.Csv,
FormatKind.Text,
FormatKind.ServiceTimeline
};
/// <inheritdoc/>
public long FrameCount => Interlocked.Read(ref m_frameCount);
/// <inheritdoc/>
public long ByteCount => Interlocked.Read(ref m_byteCount);
/// <inheritdoc/>
public ValueTask StartAsync(StartCaptureRequest request, CancellationToken ct)
{
ArgumentNullException.ThrowIfNull(request);
ct.ThrowIfCancellationRequested();
if (string.IsNullOrWhiteSpace(request.PcapFilePath))
{
throw new PcapDiagnosticsException("Replay capture requires 'pcapFilePath'.");
}
if (!File.Exists(request.PcapFilePath))
{
throw new PcapDiagnosticsException($"Replay pcap file '{request.PcapFilePath}' does not exist.");
}
if (Interlocked.CompareExchange(ref m_state, StateRunning, StateNew) != StateNew)
{
throw new PcapDiagnosticsException("ReplayCaptureSource cannot be started twice.");
}
m_pcapFilePath = request.PcapFilePath;
if (!string.IsNullOrWhiteSpace(request.KeyLogFilePath) && File.Exists(request.KeyLogFilePath))
{
m_keyLogFilePath = request.KeyLogFilePath;
}
return ValueTask.CompletedTask;
}
/// <inheritdoc/>
public ValueTask StopAsync(CancellationToken ct)
{
ct.ThrowIfCancellationRequested();
Interlocked.Exchange(ref m_state, StateStopped);
return ValueTask.CompletedTask;
}
/// <inheritdoc/>
public string? GetRawPcapFilePath()
{
return m_pcapFilePath;
}
/// <inheritdoc/>
public string? GetKeyLogFilePath()
{
return m_keyLogFilePath;
}
/// <inheritdoc/>
public async IAsyncEnumerable<ChannelKeyMaterial> ReadKeyMaterialAsync(
[EnumeratorCancellation] CancellationToken ct)
{
string? path = m_keyLogFilePath;
if (path is null)
{
yield break;
}
IKeyLogReader reader = CreateKeyLogReader(path);
await foreach (ChannelKeyMaterial material in reader.ReadAllAsync(path, ct)
.WithCancellation(ct)
.ConfigureAwait(false))
{
yield return material;
}
}
/// <inheritdoc/>
public async IAsyncEnumerable<CaptureFrame> ReadCapturedFramesAsync(
long? maxFrames,
[EnumeratorCancellation] CancellationToken ct)
{
string? path = m_pcapFilePath;
if (path is null)
{
yield break;
}
long count = 0;
long limit = maxFrames ?? long.MaxValue;
await foreach (PcapRecord record in PcapFileReader.ReadAllAsync(path, ct)
.WithCancellation(ct)
.ConfigureAwait(false))
{
if (count >= limit)
{
yield break;
}
count++;
Interlocked.Increment(ref m_frameCount);
Interlocked.Add(ref m_byteCount, record.Data.Length);
yield return new CaptureFrame(
record.Timestamp,
CaptureFrameDirection.Unknown,
string.Empty,
string.Empty,
record.Data);
}
}
/// <inheritdoc/>
public async ValueTask DisposeAsync()
{
try
{
await StopAsync(CancellationToken.None).ConfigureAwait(false);
}
catch
{
// Best effort.
}
GC.SuppressFinalize(this);
}
private IKeyLogReader CreateKeyLogReader(string path)
{
string fileName = Path.GetFileName(path);
if (fileName.EndsWith(".json", StringComparison.OrdinalIgnoreCase) ||
fileName.EndsWith(".uakeys.json", StringComparison.OrdinalIgnoreCase))
{
return new UaKeyLogJsonReader();
}
if (fileName.EndsWith(".txt", StringComparison.OrdinalIgnoreCase) ||
fileName.EndsWith(".uakeys.txt", StringComparison.OrdinalIgnoreCase))
{
return new UaKeyLogTextReader();
}
return new FallbackKeyLogReader(m_logger);
}
private sealed class FallbackKeyLogReader : IKeyLogReader
{
private readonly ILogger m_logger;
public FallbackKeyLogReader(ILogger logger)
{
m_logger = logger;
}
public async IAsyncEnumerable<ChannelKeyMaterial> ReadAllAsync(
string filePath,
[EnumeratorCancellation] CancellationToken ct)
{
ArgumentException.ThrowIfNullOrWhiteSpace(filePath);
List<ChannelKeyMaterial>? jsonMaterials = await TryReadJsonKeyLogAsync(filePath, ct)
.ConfigureAwait(false);
if (jsonMaterials is not null)
{
foreach (ChannelKeyMaterial material in jsonMaterials)
{
yield return material;
}
yield break;
}
await foreach (ChannelKeyMaterial material in new UaKeyLogTextReader().ReadAllAsync(filePath, ct)
.WithCancellation(ct)
.ConfigureAwait(false))
{
yield return material;
}
}
public IAsyncEnumerable<ChannelKeyMaterial> ReadAllAsync(Stream stream, CancellationToken ct)
{
ArgumentNullException.ThrowIfNull(stream);
return new UaKeyLogJsonReader().ReadAllAsync(stream, ct);
}
private async ValueTask<List<ChannelKeyMaterial>?> TryReadJsonKeyLogAsync(
string filePath,
CancellationToken ct)
{
var materials = new List<ChannelKeyMaterial>();
try
{
await foreach (ChannelKeyMaterial material in new UaKeyLogJsonReader().ReadAllAsync(filePath, ct)
.WithCancellation(ct)
.ConfigureAwait(false))
{
materials.Add(material);
}
m_logger.LogTrace("Read keylog {KeyLogFilePath} as JSON.", filePath);
return materials;
}
catch (Exception ex) when (ex is not OperationCanceledException)
{
m_logger.LogTrace(ex, "Unable to read keylog {KeyLogFilePath} as JSON; trying text.", filePath);
return null;
}
}
}
}
}