Files
Marc Schier c781514ad5 Refactor pcap diagnostics: decorator binding + rename to Opc.Ua.Bindings.Pcap
Three changes addressing the design feedback on PR #3855:

1. Renamed Stack/Opc.Ua.Diagnostics.Pcap -> Stack/Opc.Ua.Bindings.Pcap (and the corresponding test project). PackageId, AssemblyName and RootNamespace updated to Opc.Ua.Bindings.Pcap; references in McpServer, signlists, slnx files, docs, and the interop-tester agent updated; Opc.Ua.Core's InternalsVisibleTo entries updated.

2. Replaced UaSCUaBinaryChannel.FrameCaptureSink + per-call NotifyFrameCaptureSink null check with a transport-binding decorator. New files in Opc.Ua.Bindings.Pcap/Bindings:
   - IChannelCaptureRegistry / ChannelCaptureRegistry: singleton with a volatile IFrameCaptureSink slot (1 atomic write to switch recording on/off).
   - CapturingMessageSocket / CapturingMessageSocketFactory: IMessageSocket decorator that taps Send/Receive bytes via a single volatile read of CurrentObserver.
   - PcapTransportChannelBinding: ITransportChannelFactory decorator that injects the capturing socket factory into every TcpTransportChannel and wires ISecureChannel.OnTokenActivated through to the active observer.
   - PcapBindings.Install(): non-DI installer for direct TransportBindings.Channels.SetBinding wiring.

   IFrameCaptureSink moved to Opc.Ua.Core/Stack/Bindings and gained an OnTokenActivated method so the binding can publish key material alongside chunks. UaSCUaBinaryChannel.FrameCaptureSink property and all three NotifyFrameCaptureSink call sites removed - hot path returns to original shape with zero indirection when the binding is not installed. IMessageSocketAsyncEventArgs gains Offset + Count getters (additive).

   AddOpcUaDiagnosticsPcap/Formatters/Replay extension methods renamed to AddOpcUaBindingsPcap[Formatters|Replay]; the new AddOpcUaBindingsPcap also installs the binding into TransportBindings.Channels.

   InProcessClientCaptureSource / InProcessServerCaptureSource: dropped reflection-based AttachClientChannel/AttachServerChannel. The source itself implements IFrameCaptureSink and on Start publishes itself as the registry observer; on Stop clears it. McpServer's PacketCaptureTools simplified accordingly (no more per-channel attach loop).

3. Discarded the source-generator suggestion. Confirmed that the dissection path already 100% reuses the source-generated decoders: UaSCUaBinaryChannel.ReadSymmetricMessage for chunk decryption and BinaryDecoder.ReadEncodeable + EncodeableFactory.GlobalFactory (populated by Tools/Opc.Ua.SourceGeneration's DataTypeGenerator) for service-type decoding. Emitting additional dissection code would duplicate what's already there.

Validation:
- Full UA.slnx builds clean: 0 errors, 2 pre-existing unrelated warnings.
- All 53 tests pass on net10.0 (49 existing + 4 new CapturingMessageSocketTests covering hot-path: not-installed/installed-off/installed-on costs, byte equality, exception isolation).
- CI command line (dotnet build/test --framework net10.0 --configuration Release /p:CustomTestTarget=net10.0) reproduces clean locally.
2026-06-07 21:53:53 +02:00

150 lines
6.3 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Buffers.Binary;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
namespace Opc.Ua.Bindings.Pcap.Frame
{
/// <summary>
/// Writes a minimal little-endian pcapng stream with one interface.
/// </summary>
public sealed class PcapNgFileWriter : IAsyncDisposable
{
/// <summary>
/// Constructs a pcapng writer over the supplied stream.
/// </summary>
public PcapNgFileWriter(Stream stream, uint linkType)
{
ArgumentNullException.ThrowIfNull(stream);
m_stream = stream;
WriteShb(stream);
WriteIdb(stream, linkType);
}
/// <summary>
/// Writes a single Enhanced Packet Block.
/// </summary>
public async ValueTask WriteAsync(
DateTimeOffset timestamp,
ReadOnlyMemory<byte> packetData,
CancellationToken ct)
{
await m_gate.WaitAsync(ct).ConfigureAwait(false);
try
{
ulong timestampMicros = checked((ulong)((timestamp.ToUniversalTime().Ticks - DateTimeOffset.UnixEpoch.Ticks) / 10));
int pad = (4 - (packetData.Length & 3)) & 3;
uint totalLength = checked((uint)(8 + 20 + packetData.Length + pad + 4));
byte[] header = new byte[28];
BinaryPrimitives.WriteUInt32LittleEndian(header, BlockTypeEpb);
BinaryPrimitives.WriteUInt32LittleEndian(header.AsSpan(4), totalLength);
BinaryPrimitives.WriteUInt32LittleEndian(header.AsSpan(8), 0);
BinaryPrimitives.WriteUInt32LittleEndian(header.AsSpan(12), (uint)(timestampMicros >> 32));
BinaryPrimitives.WriteUInt32LittleEndian(header.AsSpan(16), (uint)timestampMicros);
BinaryPrimitives.WriteUInt32LittleEndian(header.AsSpan(20), checked((uint)packetData.Length));
BinaryPrimitives.WriteUInt32LittleEndian(header.AsSpan(24), checked((uint)packetData.Length));
await m_stream.WriteAsync(header, ct).ConfigureAwait(false);
await m_stream.WriteAsync(packetData, ct).ConfigureAwait(false);
if (pad != 0)
{
await m_stream.WriteAsync(s_padding.AsMemory(0, pad), ct).ConfigureAwait(false);
}
byte[] trailer = new byte[4];
BinaryPrimitives.WriteUInt32LittleEndian(trailer, totalLength);
await m_stream.WriteAsync(trailer, ct).ConfigureAwait(false);
}
finally
{
m_gate.Release();
}
}
/// <inheritdoc/>
public async ValueTask DisposeAsync()
{
if (m_disposed)
{
return;
}
await m_gate.WaitAsync(CancellationToken.None).ConfigureAwait(false);
try
{
m_disposed = true;
await m_stream.FlushAsync(CancellationToken.None).ConfigureAwait(false);
await m_stream.DisposeAsync().ConfigureAwait(false);
}
finally
{
m_gate.Release();
m_gate.Dispose();
}
}
private static void WriteShb(Stream stream)
{
Span<byte> block = stackalloc byte[28];
BinaryPrimitives.WriteUInt32LittleEndian(block, BlockTypeShb);
BinaryPrimitives.WriteUInt32LittleEndian(block[4..], 28);
BinaryPrimitives.WriteUInt32LittleEndian(block[8..], ByteOrderMagic);
BinaryPrimitives.WriteUInt16LittleEndian(block[12..], 1);
BinaryPrimitives.WriteUInt16LittleEndian(block[14..], 0);
BinaryPrimitives.WriteInt64LittleEndian(block[16..], -1);
BinaryPrimitives.WriteUInt32LittleEndian(block[24..], 28);
stream.Write(block);
}
private static void WriteIdb(Stream stream, uint linkType)
{
Span<byte> block = stackalloc byte[20];
BinaryPrimitives.WriteUInt32LittleEndian(block, BlockTypeIdb);
BinaryPrimitives.WriteUInt32LittleEndian(block[4..], 20);
BinaryPrimitives.WriteUInt16LittleEndian(block[8..], checked((ushort)linkType));
BinaryPrimitives.WriteUInt16LittleEndian(block[10..], 0);
BinaryPrimitives.WriteUInt32LittleEndian(block[12..], 65535);
BinaryPrimitives.WriteUInt32LittleEndian(block[16..], 20);
stream.Write(block);
}
private const uint BlockTypeShb = 0x0A0D0D0A;
private const uint BlockTypeIdb = 0x00000001;
private const uint BlockTypeEpb = 0x00000006;
private const uint ByteOrderMagic = 0x1A2B3C4D;
private static readonly byte[] s_padding = new byte[3];
private readonly Stream m_stream;
private readonly SemaphoreSlim m_gate = new(1, 1);
private bool m_disposed;
}
}