Files
Marc Schier 49305d9085 V2 subscription engine close gap for test and feature parity with classic engine (#3824)
# Description

V2 subscription engine feature parity round to make the classic engine
eligible for deprecation. Splits the test surface so the classic and V2
engines can evolve independently, ports the gaps the classic-engine
integration tests had been exercising, and lands the public V2 API
additions needed to close them.

- Splits `Tests/Opc.Ua.Subscriptions.Tests` into a classic
(`Opc.Ua.Subscriptions.Classic.Tests`) and a V2
(`Opc.Ua.Subscriptions.Tests`) project to shrink CI time and let the two
engines diverge cleanly.
- Adds the V2 public-surface gaps required by the test ports
(`Subscription.ServerId` on the class, `SetSubscriptionDurableAsync`,
`SendInitialValuesOnTransfer`, unified `OnSubscriptionStateChangedAsync`
handler callback, per-item `ConditionRefreshAsync`, fluent
`LoadSubscriptionsAsync(Stream, …)` and `Subscription.Snapshot()` /
`RestoreAsync()` for save/load + transfer).
- Lands handler-centric design (no `PublishingStopped` property handlers
maintain derived state); always-sequential per-subscription delivery
documented + tested.
- **Adds short and long haul stability tests for the V2 `ManagedSession`
+ subscription engine. Closes #3744** (see "Issue #3744 Haul tests"
below).
- **Migrates SubscriptionStateSnapshot / MonitoredItemStateSnapshot to
`[DataType]` source-generator codecs**.
- `SubscriptionDurableV2Tests.cs` 5 V2 ports of the classic durable test
patterns.
- `V2FollowUpCoverageTests.cs` handler state-change callback, fluent
stream-based `LoadSubscriptionsAsync`, `SendInitialValuesOnTransfer`,
snapshot edge cases (empty / `DataChangeFilter` round-trip / concurrent
  mutation).
- `SubscriptionFailoverV2Tests.cs` forced channel-break with and without
`WithTransferSubscriptionsOnRecreate`.
- `MonitoredItemConditionRefreshLiveV2Tests.cs` ΓÇö live
`ConditionRefresh` against the reference server's event source; asserts
`RefreshStart` / `RefreshEnd` events flow through the handler.

## Fixes

- #3744 Haul tests (V2 ManagedSession + subscription engine)
`Tests/Opc.Ua.Sessions.Tests/ManagedSessionStabilityTest.cs` adds the
short/long haul coverage requested by
[#3744](https://github.com/OPCFoundation/UA-.NETStandard/issues/3744)
plus the bonus fault-injection variant:

| Test | Duration | Category | Purpose |
|---|---|---|---|
| `ShortHaulManagedSessionV2Async` | 2 minutes | `ManagedSessionHaul`
(`[Explicit]`) | Quick local sanity check of the V2 monotonicity
contract. |
| `LongHaulManagedSessionV2Async` | 90 minutes (configurable via
`TEST_DURATION_MINUTES`) | `ManagedSessionHaul` (`[Explicit]`) |
Long-running V2 stability + monotonicity. |
| `LongHaulManagedSessionWithFaultInjectionV2Async` | 90 minutes
(configurable) + fault every `FAULT_INJECTION_INTERVAL_SECONDS` (default
60s) | `ManagedSessionHaul` (`[Explicit]`) | **Bonus** ΓÇö force-closes
the subscriber transport channel periodically; verifies V2 manager
transfers/recreates the subscription and continues monotonic delivery
across reconnects. |

**Pattern.** A writer `ManagedSession` increments a `uint32` counter and
writes it into `Scalar_Static_Mass_UInt32_UInt32_00` every 250ms. A
subscriber `ManagedSession` runs a V2 subscription with a single
monitored item on the same node. `MonotonicCounterHandler` asserts each
received sample is *strictly greater than* the previous one. V2
`ISubscriptionNotificationHandler` per-subscription ordering guarantee.
Skipped values (sampling rate < write rate) are tolerated; duplicates
and reorderings are violations.
2026-06-03 04:39:08 +02:00

157 lines
6.8 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
#nullable enable
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Options;
namespace Opc.Ua.Client.Subscriptions.Fakes
{
/// <summary>
/// Hand-rolled fake for <see cref="ISubscriptionManagerContext"/>.
/// Records every invocation and lets tests override return behaviour
/// via callback fields. Replaces
/// <c>Mock&lt;ISubscriptionManagerContext&gt;</c>.
/// </summary>
internal sealed class FakeSubscriptionManagerContext : ISubscriptionManagerContext
{
/// <summary>Recorded calls to <see cref="CreateSubscription"/>.</summary>
public List<CreateSubscriptionCall> CreateSubscriptionCalls { get; } = [];
/// <summary>Recorded calls to <see cref="PublishAsync"/>.</summary>
public List<PublishCall> PublishCalls { get; } = [];
/// <summary>Recorded calls to <see cref="TransferSubscriptionsAsync"/>.</summary>
public List<TransferCall> TransferCalls { get; } = [];
/// <summary>Recorded calls to <see cref="DeleteSubscriptionsAsync"/>.</summary>
public List<DeleteCall> DeleteCalls { get; } = [];
/// <summary>
/// Required factory for <see cref="CreateSubscription"/>. Tests must
/// assign this before invoking the manager.
/// </summary>
public Func<ISubscriptionNotificationHandler,
IOptionsMonitor<SubscriptionOptions>, IMessageAckQueue,
IManagedSubscription> CreateSubscriptionFactory
{ get; set; }
= (_, _, _) => throw new InvalidOperationException(
"CreateSubscriptionFactory not set on FakeSubscriptionManagerContext.");
/// <summary>
/// Optional override for <see cref="PublishAsync"/>. If null,
/// returns a default <see cref="PublishResponse"/>.
/// </summary>
public Func<RequestHeader?, ArrayOf<SubscriptionAcknowledgement>,
CancellationToken, ValueTask<PublishResponse>>? OnPublishAsync
{ get; set; }
/// <summary>
/// Optional override for <see cref="TransferSubscriptionsAsync"/>.
/// </summary>
public Func<RequestHeader?, ArrayOf<uint>, bool, CancellationToken,
ValueTask<TransferSubscriptionsResponse>>? OnTransferSubscriptionsAsync
{ get; set; }
/// <summary>
/// Optional override for <see cref="DeleteSubscriptionsAsync"/>.
/// </summary>
public Func<RequestHeader?, ArrayOf<uint>, CancellationToken,
ValueTask<DeleteSubscriptionsResponse>>? OnDeleteSubscriptionsAsync
{ get; set; }
public IManagedSubscription CreateSubscription(
ISubscriptionNotificationHandler handler,
IOptionsMonitor<SubscriptionOptions> options,
IMessageAckQueue queue,
SubscriptionLoadState? loadState = null)
{
CreateSubscriptionCalls.Add(
new CreateSubscriptionCall(handler, options, queue, loadState));
return CreateSubscriptionFactory(handler, options, queue);
}
public ValueTask<PublishResponse> PublishAsync(
RequestHeader? requestHeader,
ArrayOf<SubscriptionAcknowledgement> subscriptionAcknowledgements,
CancellationToken ct = default)
{
PublishCalls.Add(new PublishCall(requestHeader,
subscriptionAcknowledgements));
return OnPublishAsync?.Invoke(requestHeader,
subscriptionAcknowledgements, ct)
?? new ValueTask<PublishResponse>(new PublishResponse());
}
public ValueTask<TransferSubscriptionsResponse> TransferSubscriptionsAsync(
RequestHeader? requestHeader, ArrayOf<uint> subscriptionIds,
bool sendInitialValues, CancellationToken ct = default)
{
TransferCalls.Add(new TransferCall(requestHeader, subscriptionIds,
sendInitialValues));
return OnTransferSubscriptionsAsync?.Invoke(requestHeader,
subscriptionIds, sendInitialValues, ct)
?? new ValueTask<TransferSubscriptionsResponse>(
new TransferSubscriptionsResponse());
}
public ValueTask<DeleteSubscriptionsResponse> DeleteSubscriptionsAsync(
RequestHeader? requestHeader, ArrayOf<uint> subscriptionIds,
CancellationToken ct = default)
{
DeleteCalls.Add(new DeleteCall(requestHeader, subscriptionIds));
return OnDeleteSubscriptionsAsync?.Invoke(requestHeader,
subscriptionIds, ct)
?? new ValueTask<DeleteSubscriptionsResponse>(
new DeleteSubscriptionsResponse());
}
internal readonly record struct CreateSubscriptionCall(
ISubscriptionNotificationHandler Handler,
IOptionsMonitor<SubscriptionOptions> Options,
IMessageAckQueue Queue,
SubscriptionLoadState? LoadState);
internal readonly record struct PublishCall(
RequestHeader? RequestHeader,
ArrayOf<SubscriptionAcknowledgement> Acknowledgements);
internal readonly record struct TransferCall(
RequestHeader? RequestHeader, ArrayOf<uint> SubscriptionIds,
bool SendInitialValues);
internal readonly record struct DeleteCall(
RequestHeader? RequestHeader, ArrayOf<uint> SubscriptionIds);
}
}