mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-28 22:55:49 +08:00
# Description Adopt [`System.TimeProvider`](https://learn.microsoft.com/dotnet/api/system.timeprovider) across the stack so that every place that creates timers, runs duration math, or schedules periodic work is mockable, deterministic in tests, and immune to wall-clock changes. The migration touches Core, Core.Types, Server, Client, PubSub, Configuration, Gds (server + client), Lds, and the Quickstarts/Console reference apps. Per-component changes follow the same pattern: 1. Add a `private readonly TimeProvider m_timeProvider;` field. 2. Accept a nullable `TimeProvider? timeProvider = null` as the **last** constructor parameter (new overload; legacy constructor stays for binary compatibility and delegates with `timeProvider: null`). 3. Initialise the field with `m_timeProvider = timeProvider ??= TimeProvider.System;`. 4. Replace `new Timer(...)`, `Stopwatch`, `HiResClock.*`, `DateTime.UtcNow`-based duration math, and `Task.Delay(delay, ct)` in timing loops with the matching `m_timeProvider` API (`CreateTimer`, `GetTimestamp` / `GetElapsedTime`, `GetUtcNow().UtcDateTime`, `Task.Delay(delay, m_timeProvider, ct)`). 5. Wire the provider through DI: `AddOpcUaServerBuilder` / `AddOpcUaClientBuilder` register `TimeProvider.System` via `TryAddSingleton<TimeProvider>()` so tests can swap in `Microsoft.Extensions.Time.Testing.FakeTimeProvider`. `HiResClock` itself is kept (so the `ApplicationConfiguration.DisableHiResClock` schema flag still round-trips), but **every public member** is now `[Obsolete]` with a single shared message pointing to the new migration-guide section. The few internal call sites that still need to set/read `HiResClock` are wrapped with `#pragma warning disable CS0618`. ### Highlights per component - **Core / Stack** — `Opc.Ua.Core`, `Opc.Ua.Core.Types`, channel pipeline (`UaSCBinaryClientChannel`, `ChannelToken`, `UaSCBinaryChannel`), `ApplicationConfiguration`, certificate validators, `JwksIssuerKeyResolver`, `TimeProviderExtensions` polyfills (`GetTimestampMilliseconds`, `GetTickCount`, `CancellationTokenSource(timeout, timeProvider)`, `Task.Delay(delay, provider, ct)` polyfill for older TFMs). - **Server** — session lockout, subscription pipeline (publish/sample/keep-alive/lifetime), `MonitoredItemQueue`, alarm sampling rate, `IntervalRunner`, server diagnostics, configuration state machines, hosted services. - **Client** — `Session`, managed/V2 subscription engines, reconnect handlers, channel keep-alive, periodic publishing, complex-type discovery polling. - **PubSub** — `IntervalRunner` pipeline, message-receive timers, MQTT/UDP keep-alive, publishers/readers. - **Gds / Lds** — `LdsServer`, `LinqApplicationsDatabase` expiry housekeeping, GDS clients (push, pull), `DirectoryCertificateStore`, `ConnectionStateMachine`, classic subscription engine. - **Quickstarts / Console samples** — `SampleNodeManager`, `ReferenceNodeManager`, `AlarmNodeManager`, `BoilerState`, `MemoryBufferState`, `PublishedValuesWrites`. Samples resolve via `(Server as ITimeProviderProvider)?.TimeProvider ?? TimeProvider.System` so existing ctor signatures stay binary-compatible. - **Tests** — `Opc.Ua.PubSub.Tests` adds `IntervalRunnerTests`; existing `SubscriptionTests`, `UaPublisherTests`, and `TestDataSystem` move off `HiResClock`. Added `Microsoft.Extensions.TimeProvider.Testing` package for `FakeTimeProvider` (project-load warning surfaces on net48/net472 only — runtime is .NET 8+). ### Migration guide New section [**Time and Timer abstraction (`TimeProvider`)**](Docs/MigrationGuide.md#time-and-timer-abstraction-timeprovider) documents: - The canonical replacement table (`HiResClock.UtcNow` → `timeProvider.GetUtcNow().UtcDateTime`, `HiResClock.TickCount64` → `timeProvider.GetTimestamp()`, `new Timer` → `timeProvider.CreateTimer`, `Task.Delay(delay, ct)` → `Task.Delay(delay, timeProvider, ct)`, …). - The `TimeProvider? timeProvider = null` + `??=` constructor pattern. - DI wiring and how to swap in `FakeTimeProvider` in tests. - Before/after snippets for `HiResClock.TickCount64`, `HiResClock.UtcNow`, and `new Timer(...)`. ## Related Issues - Fixes #2458 ## Checklist - [x] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received.
205 lines
7.8 KiB
C#
205 lines
7.8 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
// CA2000: test code; many disposables are ownership-transferred to test fixtures or short-lived,
|
|
// making CA2000 noisy without a real leak risk. Disabled file-level for the suite.
|
|
#pragma warning disable CA2000
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.PubSub.Tests.Configuration
|
|
{
|
|
[TestFixture(Description = "Tests for UAPublisher class")]
|
|
[SingleThreaded]
|
|
public class UaPublisherTests
|
|
{
|
|
private static List<long> s_publishTicks = [];
|
|
private static readonly Lock s_lock = new();
|
|
|
|
[Test(Description = "Test that PublishMessage method is called after a UAPublisher is started.")]
|
|
[Combinatorial]
|
|
#if !CUSTOM_TESTS
|
|
[Ignore("This test should be executed locally")]
|
|
#endif
|
|
public void ValidateUaPublisherPublishIntervalDeviation(
|
|
[Values(100, 1000, 2000)] double publishingInterval,
|
|
[Values(30, 40)] double maxDeviation,
|
|
[Values(10)] int publishTimeInSeconds)
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
//Arrange
|
|
s_publishTicks.Clear();
|
|
var mockConnection = new Mock<IUaPubSubConnection>();
|
|
mockConnection.Setup(x => x.CanPublish(It.IsAny<WriterGroupDataType>())).Returns(true);
|
|
|
|
mockConnection
|
|
.Setup(x =>
|
|
x.CreateNetworkMessages(
|
|
It.IsAny<WriterGroupDataType>(),
|
|
It.IsAny<WriterGroupPublishState>()))
|
|
.Callback(() =>
|
|
{
|
|
lock (s_lock)
|
|
{
|
|
s_publishTicks.Add(TimeProvider.System.GetTimestamp());
|
|
}
|
|
});
|
|
|
|
var writerGroupDataType = new WriterGroupDataType
|
|
{
|
|
Enabled = true,
|
|
PublishingInterval = publishingInterval
|
|
};
|
|
|
|
//Act
|
|
var publisher = new UaPublisher(mockConnection.Object, writerGroupDataType, telemetry);
|
|
publisher.Start();
|
|
|
|
//wait so many seconds
|
|
Thread.Sleep(publishTimeInSeconds * 1000);
|
|
publisher.Stop();
|
|
|
|
s_publishTicks = [.. from t in s_publishTicks orderby t select t];
|
|
|
|
//Assert
|
|
AssertPublishTicks(s_publishTicks, publishingInterval, maxDeviation, publishTimeInSeconds);
|
|
}
|
|
|
|
[Test(Description = "Test that PublishMessage method is called after a running UAPublisher is stopped and aftwerwords started.")]
|
|
[Combinatorial]
|
|
#if !CUSTOM_TESTS
|
|
[Ignore("This test should be executed locally")]
|
|
#endif
|
|
public void ValidateRunningUaPublisherRestart(
|
|
[Values(100, 1000, 2000)] double publishingInterval,
|
|
[Values(30, 40)] double maxDeviation,
|
|
[Values(10)] int publishTimeInSeconds)
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
//Arrange
|
|
s_publishTicks.Clear();
|
|
var mockConnection = new Mock<IUaPubSubConnection>();
|
|
mockConnection.Setup(x => x.CanPublish(It.IsAny<WriterGroupDataType>())).Returns(true);
|
|
|
|
mockConnection
|
|
.Setup(x =>
|
|
x.CreateNetworkMessages(
|
|
It.IsAny<WriterGroupDataType>(),
|
|
It.IsAny<WriterGroupPublishState>()))
|
|
.Callback(() =>
|
|
{
|
|
lock (s_lock)
|
|
{
|
|
s_publishTicks.Add(TimeProvider.System.GetTimestamp());
|
|
}
|
|
});
|
|
|
|
var writerGroupDataType = new WriterGroupDataType
|
|
{
|
|
Enabled = true,
|
|
PublishingInterval = publishingInterval
|
|
};
|
|
|
|
//Act
|
|
var publisher = new UaPublisher(mockConnection.Object, writerGroupDataType, telemetry);
|
|
publisher.Start();
|
|
|
|
//wait so many seconds
|
|
Thread.Sleep(publishTimeInSeconds * 1000);
|
|
publisher.Stop();
|
|
|
|
s_publishTicks = [.. from t in s_publishTicks orderby t select t];
|
|
|
|
//Assert
|
|
AssertPublishTicks(s_publishTicks, publishingInterval, maxDeviation, publishTimeInSeconds);
|
|
|
|
s_publishTicks.Clear();
|
|
publisher.Start();
|
|
|
|
//wait so many seconds
|
|
Thread.Sleep(publishTimeInSeconds * 1000);
|
|
publisher.Stop();
|
|
|
|
s_publishTicks = [.. from t in s_publishTicks orderby t select t];
|
|
|
|
//Assert
|
|
AssertPublishTicks(s_publishTicks, publishingInterval, maxDeviation, publishTimeInSeconds);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Assert that the publish time between two consecutive intervals is within
|
|
/// the limit of the accepted maxDeviation
|
|
/// </summary>
|
|
/// <param name="publishTicks"></param>
|
|
/// <param name="publishingInterval"></param>
|
|
/// <param name="maxDeviation"></param>
|
|
/// <param name="publishTimeInSeconds"></param>
|
|
private static void AssertPublishTicks(
|
|
List<long> publishTicks,
|
|
double publishingInterval,
|
|
double maxDeviation,
|
|
int publishTimeInSeconds)
|
|
{
|
|
Assert.That(publishTicks, Is.Not.Empty);
|
|
|
|
int faultIndex = -1;
|
|
double faultDeviation = 0;
|
|
for (int i = 1; i < publishTicks.Count; i++)
|
|
{
|
|
double interval = (publishTicks[i] - publishTicks[i - 1]) /
|
|
(TimeProvider.System.TimestampFrequency / 1000.0);
|
|
if (interval != 0)
|
|
{
|
|
double deviation = -1;
|
|
if (interval != publishingInterval)
|
|
{
|
|
deviation = Math.Abs(publishingInterval - interval);
|
|
}
|
|
if (deviation >= maxDeviation && deviation > faultDeviation)
|
|
{
|
|
faultIndex = i;
|
|
faultDeviation = deviation;
|
|
}
|
|
}
|
|
}
|
|
Assert.That(
|
|
faultIndex,
|
|
Is.LessThan(0),
|
|
$"publishingInterval={publishingInterval}, maxDeviation={maxDeviation}, publishTimeInSecods={publishTimeInSeconds}, deviation[{faultIndex}] = {faultDeviation} as max deviation");
|
|
}
|
|
}
|
|
}
|