mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-27 21:55:54 +08:00
# Description
Pure code-style sweep across the repo — no behavioral changes. Drives
`dotnet format` info-level diagnostics down on a large slice of the
codebase (Stack, Libraries, Tests, Tools).
Six commits, applied bottom-up in safety order so each batch leaves the
build green:
1. **`style: fix whitespace and final-newline formatting (WHITESPACE,
FINALNEWLINE)`**
197 hits across ~30 files; pure mechanical cleanup.
2. **`style: apply dotnet format style fixes (IDE rules)`**
IDE-rule batch via `dotnet format style --severity info` —
`var`/explicit type, simplify names, collection expressions, expression
bodies, unused usings, etc.
3. **`style: apply dotnet format analyzers fixes (RCS blank-line
formatting)`**
Roslynator formatting (RCS0xxx) blank-line and punctuation rules.
4. **`style: convert comments to doc comments and inline local vars
(RCS1181, RCS1124)`**
24 files. RCS1181 promotes `// summary`-style comments above
public/internal members to `/// <summary>` doc comments; RCS1124 inlines
locals used exactly once. Generated `Tools/` files were reverted to keep
the source-generator outputs deterministic.
5. **`docs(agent): correct --diagnostics flag form and verify Roslynator
4.x code fixers`**
Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two
corrections discovered while running this sweep:
- `dotnet format --diagnostics "RULE1 RULE2"` (single quoted,
space-separated) silently fixes nothing on `dotnet format` 10.x — it
parses as one unknown ID and exits 0. The correct form is `--diagnostics
RULE1 --diagnostics RULE2 …`, repeated per rule.
- Roslynator 4.15.0 **does** ship code fixers for
RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer"
list was outdated). RCS1140/1142 default to `Hidden` so need `--severity
info` to surface and fire; RCS1078 requires
`roslynator_empty_string_style = field` (already set in
`.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in
this stack.
6. **`style: format new code from master merge (dotnet format sweep)`**
After merging master into the branch (commit `e3ebc8742`), re-ran the
same three-phase format sweep on the 151 .cs files brought in by the
merge, scoped per project via repeated `--include`. 81 files changed;
same rule families as commits 1–4.
- Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs`
for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer
didn't apply for that specific case.
- Reverted files that the formatter would break:
- `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM
analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>`
markers.
-
`Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs,
Core/Stack/Types/IUserIdentityTokenHandler.cs,
Client/Session/Session.cs}` — IDE0005 removed `using
Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378
reference fixtures for the analyzer).
- `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified
`OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a
conflicting type.
### What this PR does **not** touch
- No behavioral or semantic logic changes.
- No `.editorconfig` rule promotions (rules stay at their current
severities; this is a backlog-burndown pass, not a rule tightening).
- Generated source under `Tools/` is intentionally excluded.
- Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`,
`RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for
follow-up sweeps because they need per-TFM build verification or
semantic review.
## Related Issues
_No tracking issue — this is a non-functional style sweep and the
agent-doc correction is a follow-up to the same work. Happy to open one
if the maintainers prefer._
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — style-only, no
behavioral change)_
- [x] I have added all necessary documentation. _(agent doc updated with
the two corrections)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. _(verified clean on `net10.0` and `net48`; only
pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(build
verified on net10 and net48 per batch; full test suite not yet run
locally — relying on CI)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
---------
Co-authored-by: agent <agent@local>
401 lines
15 KiB
C#
401 lines
15 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Server.Fluent;
|
|
|
|
#nullable enable
|
|
#pragma warning disable CA2000
|
|
|
|
namespace Opc.Ua.Server.Tests.Fluent
|
|
{
|
|
/// <summary>
|
|
/// Tests for the fluent state-machine builder exercising
|
|
/// <see cref="ProgramStateMachineState"/> — a real stack-shipped
|
|
/// subclass with full cause/transition/state tables.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Fluent")]
|
|
public class StateMachineBuilderExtensionsTests
|
|
{
|
|
private const ushort kNs = 2;
|
|
|
|
private static SystemContext CreateContext()
|
|
{
|
|
var ns = new NamespaceTable();
|
|
ns.Append(Ua.Namespaces.OpcUa);
|
|
return new SystemContext(telemetry: null!)
|
|
{
|
|
NamespaceUris = ns
|
|
};
|
|
}
|
|
|
|
private static (NodeManagerBuilder Builder, ProgramStateMachineState Machine,
|
|
MethodState StartMethod)
|
|
CreateBuilder()
|
|
{
|
|
SystemContext ctx = CreateContext();
|
|
|
|
var machine = new ProgramStateMachineState(parent: null)
|
|
{
|
|
NodeId = new NodeId("Machine", kNs),
|
|
BrowseName = new QualifiedName("Machine", kNs),
|
|
DisplayName = new LocalizedText("Machine")
|
|
};
|
|
machine.Create(
|
|
ctx, machine.NodeId, machine.BrowseName,
|
|
displayName: machine.DisplayName,
|
|
assignNodeIds: false);
|
|
|
|
var startMethod = new MethodState(machine)
|
|
{
|
|
NodeId = new NodeId("Machine_Start", kNs),
|
|
BrowseName = new QualifiedName("Start", kNs),
|
|
DisplayName = new LocalizedText("Start")
|
|
};
|
|
machine.AddChild(startMethod);
|
|
|
|
var roots = new Dictionary<QualifiedName, NodeState>
|
|
{
|
|
[machine.BrowseName] = machine
|
|
};
|
|
var byId = new Dictionary<NodeId, NodeState>
|
|
{
|
|
[machine.NodeId] = machine,
|
|
[startMethod.NodeId] = startMethod
|
|
};
|
|
|
|
var builder = new NodeManagerBuilder(
|
|
ctx,
|
|
nodeManager: Mock.Of<IAsyncNodeManager>(),
|
|
defaultNamespaceIndex: kNs,
|
|
rootResolver: q => roots.TryGetValue(q, out NodeState? n) ? n! : null!,
|
|
nodeIdResolver: id => byId.TryGetValue(id, out NodeState? n) ? n! : null!,
|
|
typeIdResolver: _ => []);
|
|
|
|
return (builder, machine, startMethod);
|
|
}
|
|
|
|
private static IStateMachineBuilder<ProgramStateMachineState> ResolveMachine(
|
|
NodeManagerBuilder builder)
|
|
{
|
|
return builder
|
|
.Node<ProgramStateMachineState>(new NodeId("Machine", kNs))
|
|
.AsStateMachine();
|
|
}
|
|
|
|
[Test]
|
|
public void WithInitialStateSetsCurrentStateId()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, _) = CreateBuilder();
|
|
|
|
ResolveMachine(b).WithInitialState(Objects.ProgramStateMachineType_Ready);
|
|
|
|
uint actual = ExtractCurrentStateId(m);
|
|
Assert.That(actual, Is.EqualTo(Objects.ProgramStateMachineType_Ready));
|
|
}
|
|
|
|
[Test]
|
|
public void WithInitialStateZeroThrows()
|
|
{
|
|
(NodeManagerBuilder b, _, _) = CreateBuilder();
|
|
IStateMachineBuilder<ProgramStateMachineState> sb = ResolveMachine(b);
|
|
|
|
Assert.Throws<ArgumentOutOfRangeException>(() => sb.WithInitialState(0));
|
|
}
|
|
|
|
[Test]
|
|
public void OnEnterStateFiresOnArrival()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, _) = CreateBuilder();
|
|
ProgramStateMachineState? observed = null;
|
|
|
|
ResolveMachine(b)
|
|
.WithInitialState(Objects.ProgramStateMachineType_Ready)
|
|
.OnEnterState(Objects.ProgramStateMachineType_Running,
|
|
(ctx, sm) => observed = sm);
|
|
|
|
ServiceResult result = m.DoTransition(
|
|
CreateContext(),
|
|
Objects.ProgramStateMachineType_ReadyToRunning,
|
|
causeId: 0,
|
|
inputArguments: default,
|
|
outputArguments: []);
|
|
|
|
Assert.That(ServiceResult.IsGood(result), $"Transition failed: {result}");
|
|
Assert.That(observed, Is.SameAs(m));
|
|
}
|
|
|
|
[Test]
|
|
public void OnExitStateFiresWhenLeavingState()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, _) = CreateBuilder();
|
|
int exitFires = 0;
|
|
|
|
ResolveMachine(b)
|
|
.WithInitialState(Objects.ProgramStateMachineType_Ready)
|
|
.OnExitState(Objects.ProgramStateMachineType_Ready,
|
|
(ctx, sm) => exitFires++);
|
|
|
|
m.DoTransition(
|
|
CreateContext(),
|
|
Objects.ProgramStateMachineType_ReadyToRunning,
|
|
causeId: 0,
|
|
inputArguments: default,
|
|
outputArguments: []);
|
|
|
|
Assert.That(exitFires, Is.EqualTo(1));
|
|
}
|
|
|
|
[Test]
|
|
public void OnTransitionReceivesFromAndToStateIds()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, _) = CreateBuilder();
|
|
uint observedFrom = 0;
|
|
uint observedTo = 0;
|
|
|
|
ResolveMachine(b)
|
|
.WithInitialState(Objects.ProgramStateMachineType_Ready)
|
|
.OnTransition((ctx, sm, from, to) =>
|
|
{
|
|
observedFrom = from;
|
|
observedTo = to;
|
|
});
|
|
|
|
m.DoTransition(
|
|
CreateContext(),
|
|
Objects.ProgramStateMachineType_ReadyToRunning,
|
|
causeId: 0,
|
|
inputArguments: default,
|
|
outputArguments: []);
|
|
|
|
Assert.That(observedFrom, Is.EqualTo(Objects.ProgramStateMachineType_Ready));
|
|
Assert.That(observedTo, Is.EqualTo(Objects.ProgramStateMachineType_Running));
|
|
}
|
|
|
|
[Test]
|
|
public void OnBeforeTransitionGuardCancelsTransition()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, _) = CreateBuilder();
|
|
|
|
ResolveMachine(b)
|
|
.WithInitialState(Objects.ProgramStateMachineType_Ready)
|
|
.OnBeforeTransition((ctx, sm, fromStateId) =>
|
|
StatusCodes.BadUserAccessDenied);
|
|
|
|
ServiceResult result = m.DoTransition(
|
|
CreateContext(),
|
|
Objects.ProgramStateMachineType_ReadyToRunning,
|
|
causeId: 0,
|
|
inputArguments: default,
|
|
outputArguments: []);
|
|
|
|
Assert.That(ServiceResult.IsBad(result));
|
|
Assert.That(result.StatusCode.Code, Is.EqualTo(StatusCodes.BadUserAccessDenied));
|
|
// Should remain in Ready
|
|
Assert.That(ExtractCurrentStateId(m),
|
|
Is.EqualTo(Objects.ProgramStateMachineType_Ready));
|
|
}
|
|
|
|
[Test]
|
|
public void OnBeforeTransitionComposesWithExistingHandler()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, _) = CreateBuilder();
|
|
int existingCalls = 0;
|
|
m.OnBeforeTransition = (ctx, sm, t, c, i, o) =>
|
|
{
|
|
existingCalls++;
|
|
return ServiceResult.Good;
|
|
};
|
|
|
|
int fluentCalls = 0;
|
|
ResolveMachine(b)
|
|
.WithInitialState(Objects.ProgramStateMachineType_Ready)
|
|
.OnBeforeTransition((ctx, sm, fromStateId) =>
|
|
{
|
|
fluentCalls++;
|
|
return ServiceResult.Good;
|
|
});
|
|
|
|
m.DoTransition(
|
|
CreateContext(),
|
|
Objects.ProgramStateMachineType_ReadyToRunning,
|
|
causeId: 0,
|
|
inputArguments: default,
|
|
outputArguments: []);
|
|
|
|
Assert.That(existingCalls, Is.EqualTo(1),
|
|
"Pre-existing OnBeforeTransition handler must still run.");
|
|
Assert.That(fluentCalls, Is.EqualTo(1),
|
|
"Fluent guard must run after existing handler.");
|
|
}
|
|
|
|
[Test]
|
|
public void WithCauseWiresMethodToDoCause()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, MethodState start) = CreateBuilder();
|
|
|
|
ResolveMachine(b)
|
|
.WithInitialState(Objects.ProgramStateMachineType_Ready)
|
|
.WithCause(
|
|
start.NodeId,
|
|
Methods.ProgramStateMachineType_Start);
|
|
|
|
Assert.That(start.OnCallMethod2, Is.Not.Null);
|
|
|
|
ServiceResult result = start.OnCallMethod2!(
|
|
CreateContext(),
|
|
start,
|
|
objectId: m.NodeId,
|
|
inputArguments: default,
|
|
outputArguments: []);
|
|
|
|
Assert.That(ServiceResult.IsGood(result),
|
|
$"DoCause via wired method must succeed: {result}");
|
|
Assert.That(ExtractCurrentStateId(m),
|
|
Is.EqualTo(Objects.ProgramStateMachineType_Running));
|
|
}
|
|
|
|
[Test]
|
|
public void WithCauseRejectsAlreadyWiredMethod()
|
|
{
|
|
(NodeManagerBuilder b, _, MethodState start) = CreateBuilder();
|
|
start.OnCallMethod2 = (ctx, m, oid, inputs, outputs) => ServiceResult.Good;
|
|
|
|
IStateMachineBuilder<ProgramStateMachineState> sb = ResolveMachine(b)
|
|
.WithInitialState(Objects.ProgramStateMachineType_Ready);
|
|
|
|
ServiceResultException ex = Assert.Throws<ServiceResultException>(
|
|
() => sb.WithCause(start.NodeId, Methods.ProgramStateMachineType_Start))!;
|
|
Assert.That(ex.StatusCode, Is.EqualTo(StatusCodes.BadInvalidState));
|
|
}
|
|
|
|
[Test]
|
|
public void WithCauseUnknownMethodThrows()
|
|
{
|
|
(NodeManagerBuilder b, _, _) = CreateBuilder();
|
|
IStateMachineBuilder<ProgramStateMachineState> sb = ResolveMachine(b);
|
|
|
|
Assert.Throws<ServiceResultException>(
|
|
() => sb.WithCause(new NodeId("UnknownMethod", kNs),
|
|
Methods.ProgramStateMachineType_Start));
|
|
}
|
|
|
|
[Test]
|
|
public void ConfigureStateMachineExposesEscapeHatch()
|
|
{
|
|
(NodeManagerBuilder b, ProgramStateMachineState m, _) = CreateBuilder();
|
|
|
|
ResolveMachine(b)
|
|
.ConfigureStateMachine(sm => sm.SuppressTransitionEvents = true);
|
|
|
|
Assert.That(m.SuppressTransitionEvents, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void DoneReturnsOwningNodeBuilder()
|
|
{
|
|
(NodeManagerBuilder b, _, _) = CreateBuilder();
|
|
INodeBuilder<ProgramStateMachineState> nb = b
|
|
.Node<ProgramStateMachineState>(new NodeId("Machine", kNs));
|
|
|
|
INodeBuilder returned = nb.AsStateMachine().Done();
|
|
Assert.That(returned, Is.SameAs(nb));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateProgramStateMachineMaterialisesUnderParent()
|
|
{
|
|
(NodeManagerBuilder b, _, _) = CreateBuilder();
|
|
INodeBuilder parent = b.Node(new NodeId("Machine", kNs));
|
|
|
|
IStateMachineBuilder<ProgramStateMachineState> sm =
|
|
parent.CreateProgramStateMachine(new QualifiedName("Cycle", kNs));
|
|
|
|
Assert.That(sm.StateMachine, Is.Not.Null);
|
|
Assert.That(sm.StateMachine.BrowseName,
|
|
Is.EqualTo(new QualifiedName("Cycle", kNs)));
|
|
Assert.That(sm.StateMachine.Parent,
|
|
Is.SameAs(parent.Node));
|
|
Assert.That(sm.StateMachine.NodeId.IdentifierAsString,
|
|
Is.EqualTo("Machine_Cycle"));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateShelvedStateMachineMaterialisesUnderParent()
|
|
{
|
|
(NodeManagerBuilder b, _, _) = CreateBuilder();
|
|
INodeBuilder parent = b.Node(new NodeId("Machine", kNs));
|
|
|
|
IStateMachineBuilder<ShelvedStateMachineState> sm =
|
|
parent.CreateShelvedStateMachine(new QualifiedName("Shelv", kNs));
|
|
|
|
Assert.That(sm.StateMachine.BrowseName,
|
|
Is.EqualTo(new QualifiedName("Shelv", kNs)));
|
|
Assert.That(sm.StateMachine.Parent, Is.SameAs(parent.Node));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateExclusiveLimitStateMachineMaterialisesUnderParent()
|
|
{
|
|
(NodeManagerBuilder b, _, _) = CreateBuilder();
|
|
INodeBuilder parent = b.Node(new NodeId("Machine", kNs));
|
|
|
|
IStateMachineBuilder<ExclusiveLimitStateMachineState> sm =
|
|
parent.CreateExclusiveLimitStateMachine(
|
|
new QualifiedName("ExLim", kNs));
|
|
|
|
Assert.That(sm.StateMachine.BrowseName,
|
|
Is.EqualTo(new QualifiedName("ExLim", kNs)));
|
|
Assert.That(sm.StateMachine.Parent, Is.SameAs(parent.Node));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateStateMachineRejectsNullArgs()
|
|
{
|
|
(NodeManagerBuilder b, _, _) = CreateBuilder();
|
|
INodeBuilder parent = b.Node(new NodeId("Machine", kNs));
|
|
|
|
Assert.Throws<ArgumentNullException>(
|
|
() => parent.CreateProgramStateMachine(default));
|
|
}
|
|
|
|
private static uint ExtractCurrentStateId(ProgramStateMachineState m)
|
|
{
|
|
NodeId value = m.CurrentState!.Id!.Value;
|
|
if (value.IsNull)
|
|
{ return 0; }
|
|
return value.TryGetValue(out uint numericId) ? numericId : 0;
|
|
}
|
|
}
|
|
}
|