Files
Marc Schier a81d981755 dotnet format sweep (whitespace, IDE, RCS) + code-style enforcer agent fix (#3865)
# Description

Pure code-style sweep across the repo — no behavioral changes. Drives
`dotnet format` info-level diagnostics down on a large slice of the
codebase (Stack, Libraries, Tests, Tools).

Six commits, applied bottom-up in safety order so each batch leaves the
build green:

1. **`style: fix whitespace and final-newline formatting (WHITESPACE,
FINALNEWLINE)`**
   197 hits across ~30 files; pure mechanical cleanup.

2. **`style: apply dotnet format style fixes (IDE rules)`**
IDE-rule batch via `dotnet format style --severity info` —
`var`/explicit type, simplify names, collection expressions, expression
bodies, unused usings, etc.

3. **`style: apply dotnet format analyzers fixes (RCS blank-line
formatting)`**
   Roslynator formatting (RCS0xxx) blank-line and punctuation rules.

4. **`style: convert comments to doc comments and inline local vars
(RCS1181, RCS1124)`**
24 files. RCS1181 promotes `// summary`-style comments above
public/internal members to `/// <summary>` doc comments; RCS1124 inlines
locals used exactly once. Generated `Tools/` files were reverted to keep
the source-generator outputs deterministic.

5. **`docs(agent): correct --diagnostics flag form and verify Roslynator
4.x code fixers`**
Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two
corrections discovered while running this sweep:
- `dotnet format --diagnostics "RULE1 RULE2"` (single quoted,
space-separated) silently fixes nothing on `dotnet format` 10.x — it
parses as one unknown ID and exits 0. The correct form is `--diagnostics
RULE1 --diagnostics RULE2 …`, repeated per rule.
- Roslynator 4.15.0 **does** ship code fixers for
RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer"
list was outdated). RCS1140/1142 default to `Hidden` so need `--severity
info` to surface and fire; RCS1078 requires
`roslynator_empty_string_style = field` (already set in
`.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in
this stack.

6. **`style: format new code from master merge (dotnet format sweep)`**
After merging master into the branch (commit `e3ebc8742`), re-ran the
same three-phase format sweep on the 151 .cs files brought in by the
merge, scoped per project via repeated `--include`. 81 files changed;
same rule families as commits 1–4.
- Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs`
for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer
didn't apply for that specific case.
   - Reverted files that the formatter would break:
- `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM
analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>`
markers.
-
`Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs,
Core/Stack/Types/IUserIdentityTokenHandler.cs,
Client/Session/Session.cs}` — IDE0005 removed `using
Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378
reference fixtures for the analyzer).
- `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified
`OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a
conflicting type.

### What this PR does **not** touch

- No behavioral or semantic logic changes.
- No `.editorconfig` rule promotions (rules stay at their current
severities; this is a backlog-burndown pass, not a rule tightening).
- Generated source under `Tools/` is intentionally excluded.
- Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`,
`RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for
follow-up sweeps because they need per-TFM build verification or
semantic review.

## Related Issues

_No tracking issue — this is a non-functional style sweep and the
agent-doc correction is a follow-up to the same work. Happy to open one
if the maintainers prefer._

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — style-only, no
behavioral change)_
- [x] I have added all necessary documentation. _(agent doc updated with
the two corrections)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. _(verified clean on `net10.0` and `net48`; only
pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(build
verified on net10 and net48 per batch; full test suite not yet run
locally — relying on CI)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

---------

Co-authored-by: agent <agent@local>
2026-06-10 08:35:44 +02:00

266 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Security.Cryptography;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Identity;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Identity
{
[TestFixture]
[Category("Identity")]
public class JwtAuthenticatorTests
{
private const string Issuer = "https://issuer.example.test";
private const string Audience = "urn:opcua:test-server";
[Test]
public async Task AuthenticateAsyncRs256TokenAcceptedAndClaimsExtracted()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
Issuer,
Quote(Audience),
expiresInSeconds: 3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
var claims = result.Identity as IIdentityClaims;
Assert.That(claims, Is.Not.Null);
Assert.That(claims.Issuer, Is.EqualTo(Issuer));
Assert.That(claims.Subject, Is.EqualTo("subject-1"));
Assert.That(claims.Groups, Does.Contain("engineering"));
Assert.That(claims.Roles, Does.Contain("operator"));
}
[Test]
public async Task AuthenticateAsyncEs256TokenAccepted()
{
using var ecdsa = ECDsa.Create(ECCurve.NamedCurves.nistP256);
using IssuerVerificationKey key = CreateEcdsaVerificationKey(ecdsa, "kid-ec");
string jwt = CreateJwt(
"ES256",
"kid-ec",
Issuer,
"[" + Quote("other") + "," + Quote(Audience) + "]",
expiresInSeconds: 3600,
signingInput => ecdsa.SignData(signingInput, HashAlgorithmName.SHA256));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
Assert.That(result.Identity, Is.TypeOf<JwtUserIdentity>());
}
[Test]
public async Task AuthenticateAsyncExpiredTokenRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
Issuer,
Quote(Audience),
expiresInSeconds: -3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task AuthenticateAsyncWrongAudienceRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
Issuer,
Quote("urn:opcua:other-server"),
expiresInSeconds: 3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
}
[Test]
public async Task AuthenticateAsyncWrongIssuerRejected()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
string jwt = CreateJwt(
"RS256",
"kid-rsa",
"https://wrong-issuer.example.test",
Quote(Audience),
expiresInSeconds: 3600,
signingInput => rsa.SignData(signingInput, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1));
AuthenticationResult result = await AuthenticateAsync(jwt, key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
}
[Test]
public async Task AuthenticateAsyncMalformedTokenRejectedAsInvalid()
{
using var rsa = RSA.Create(2048);
using IssuerVerificationKey key = CreateRsaVerificationKey(rsa, "kid-rsa");
AuthenticationResult result = await AuthenticateAsync("not-a-jwt", key).ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
private static async Task<AuthenticationResult> AuthenticateAsync(
string jwt,
IssuerVerificationKey key)
{
var resolver = new StaticKeyResolver(Issuer, key);
var authenticator = new JwtAuthenticator(resolver, Audience, TimeSpan.Zero);
return await authenticator.AuthenticateAsync(
CreateContext(new IssuedIdentityTokenHandler(
Profiles.JwtUserToken,
Encoding.UTF8.GetBytes(jwt))))
.ConfigureAwait(false);
}
private static AuthenticationContext CreateContext(IUserIdentityTokenHandler handler)
{
return new AuthenticationContext(
handler,
new UserTokenPolicy
{
TokenType = UserTokenType.IssuedToken,
PolicyId = "jwt",
IssuedTokenType = Profiles.JwtUserToken
},
new EndpointDescription { SecurityMode = MessageSecurityMode.SignAndEncrypt },
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create()));
}
private static string CreateJwt(
string algorithm,
string keyId,
string issuer,
string audienceJson,
int expiresInSeconds,
Func<byte[], byte[]> sign)
{
long now = DateTimeOffset.UtcNow.ToUnixTimeSeconds();
string header = "{\"alg\":\"" + algorithm + "\",\"kid\":\"" + keyId + "\",\"typ\":\"JWT\"}";
string payload =
"{\"iss\":\"" +
issuer +
"\",\"sub\":\"subject-1\",\"aud\":" +
audienceJson +
",\"exp\":" +
(now + expiresInSeconds) +
",\"nbf\":" +
(now - 60) +
",\"iat\":" +
(now - 1) +
",\"groups\":[\"engineering\"],\"roles\":[\"operator\"]}";
string signingInput = Base64UrlEncode(Encoding.UTF8.GetBytes(header)) +
"." +
Base64UrlEncode(Encoding.UTF8.GetBytes(payload));
byte[] signature = sign(Encoding.ASCII.GetBytes(signingInput));
return signingInput + "." + Base64UrlEncode(signature);
}
private static string Quote(string value)
{
return "\"" + value + "\"";
}
#pragma warning disable CA2000 // IssuerVerificationKey owns verification keys; TODO: add ownership annotations when available.
private static IssuerVerificationKey CreateRsaVerificationKey(RSA rsa, string keyId)
{
var publicKey = RSA.Create();
publicKey.ImportParameters(rsa.ExportParameters(false));
return new IssuerVerificationKey(keyId, publicKey, "RS256");
}
private static IssuerVerificationKey CreateEcdsaVerificationKey(ECDsa ecdsa, string keyId)
{
var publicKey = ECDsa.Create(ecdsa.ExportParameters(false));
return new IssuerVerificationKey(keyId, publicKey, "ES256");
}
#pragma warning restore CA2000
private static string Base64UrlEncode(byte[] bytes)
{
return Convert.ToBase64String(bytes)
.TrimEnd('=')
.Replace('+', '-')
.Replace('/', '_');
}
private sealed class StaticKeyResolver : IIssuerKeyResolver
{
private readonly IReadOnlyList<IssuerVerificationKey> m_keys;
public StaticKeyResolver(string issuerUri, IssuerVerificationKey key)
{
IssuerUri = issuerUri;
m_keys = [key];
}
public string IssuerUri { get; }
public ValueTask<IReadOnlyList<IssuerVerificationKey>> GetKeysAsync(
string keyId,
CancellationToken ct = default)
{
return new ValueTask<IReadOnlyList<IssuerVerificationKey>>(m_keys);
}
}
}
}