Files
Marc Schierandagent a81d981755 dotnet format sweep (whitespace, IDE, RCS) + code-style enforcer agent fix (#3865)
# Description

Pure code-style sweep across the repo — no behavioral changes. Drives
`dotnet format` info-level diagnostics down on a large slice of the
codebase (Stack, Libraries, Tests, Tools).

Six commits, applied bottom-up in safety order so each batch leaves the
build green:

1. **`style: fix whitespace and final-newline formatting (WHITESPACE,
FINALNEWLINE)`**
   197 hits across ~30 files; pure mechanical cleanup.

2. **`style: apply dotnet format style fixes (IDE rules)`**
IDE-rule batch via `dotnet format style --severity info` —
`var`/explicit type, simplify names, collection expressions, expression
bodies, unused usings, etc.

3. **`style: apply dotnet format analyzers fixes (RCS blank-line
formatting)`**
   Roslynator formatting (RCS0xxx) blank-line and punctuation rules.

4. **`style: convert comments to doc comments and inline local vars
(RCS1181, RCS1124)`**
24 files. RCS1181 promotes `// summary`-style comments above
public/internal members to `/// <summary>` doc comments; RCS1124 inlines
locals used exactly once. Generated `Tools/` files were reverted to keep
the source-generator outputs deterministic.

5. **`docs(agent): correct --diagnostics flag form and verify Roslynator
4.x code fixers`**
Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two
corrections discovered while running this sweep:
- `dotnet format --diagnostics "RULE1 RULE2"` (single quoted,
space-separated) silently fixes nothing on `dotnet format` 10.x — it
parses as one unknown ID and exits 0. The correct form is `--diagnostics
RULE1 --diagnostics RULE2 …`, repeated per rule.
- Roslynator 4.15.0 **does** ship code fixers for
RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer"
list was outdated). RCS1140/1142 default to `Hidden` so need `--severity
info` to surface and fire; RCS1078 requires
`roslynator_empty_string_style = field` (already set in
`.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in
this stack.

6. **`style: format new code from master merge (dotnet format sweep)`**
After merging master into the branch (commit `e3ebc8742`), re-ran the
same three-phase format sweep on the 151 .cs files brought in by the
merge, scoped per project via repeated `--include`. 81 files changed;
same rule families as commits 1–4.
- Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs`
for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer
didn't apply for that specific case.
   - Reverted files that the formatter would break:
- `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM
analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>`
markers.
-
`Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs,
Core/Stack/Types/IUserIdentityTokenHandler.cs,
Client/Session/Session.cs}` — IDE0005 removed `using
Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378
reference fixtures for the analyzer).
- `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified
`OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a
conflicting type.

### What this PR does **not** touch

- No behavioral or semantic logic changes.
- No `.editorconfig` rule promotions (rules stay at their current
severities; this is a backlog-burndown pass, not a rule tightening).
- Generated source under `Tools/` is intentionally excluded.
- Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`,
`RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for
follow-up sweeps because they need per-TFM build verification or
semantic review.

## Related Issues

_No tracking issue — this is a non-functional style sweep and the
agent-doc correction is a follow-up to the same work. Happy to open one
if the maintainers prefer._

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — style-only, no
behavioral change)_
- [x] I have added all necessary documentation. _(agent doc updated with
the two corrections)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. _(verified clean on `net10.0` and `net48`; only
pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(build
verified on net10 and net48 per batch; full test suite not yet run
locally — relying on CI)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

---------

Co-authored-by: agent <agent@local>
2026-06-10 08:35:44 +02:00

236 lines
9.0 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using NUnit.Framework;
using Opc.Ua.Server.StateMachines;
namespace Opc.Ua.Server.Tests.StateMachines
{
/// <summary>
/// Unit tests for the per-trigger guard sugar on
/// <see cref="StateMachineBuilder{TState}"/> — covers
/// <c>WhenTransition</c>, <c>WhenCause</c>, <c>WhenEnter</c>,
/// and <c>WhenExit</c>. Each guard composes with the others
/// through the shared registration-order pipeline.
/// </summary>
[TestFixture]
[Category("Server")]
[Category("StateMachines")]
[Parallelizable]
public sealed class StateMachineBuilderGuardTests
{
private ServerSystemContext m_context = null!;
[SetUp]
public void SetUp()
{
m_context = StateMachineTestFixtures.CreateContext();
}
[Test]
public void WhenTransitionVetoesWhenPredicateReturnsFalse()
{
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(1)
.WhenTransition(10, (ctx, m) => false)
.StateMachine;
ServiceResult result = sm.DoTransition(m_context, 10, 0, default, []);
Assert.That(ServiceResult.IsBad(result), Is.True);
Assert.That(result.Code,
Is.EqualTo(StatusCodes.BadUserAccessDenied));
Assert.That(CurrentStateId(sm), Is.EqualTo(1u));
}
[Test]
public void WhenTransitionAllowsWhenPredicateReturnsTrue()
{
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(1)
.WhenTransition(10, (ctx, m) => true)
.StateMachine;
ServiceResult result = sm.DoTransition(m_context, 10, 0, default, []);
Assert.That(ServiceResult.IsGood(result), Is.True);
Assert.That(CurrentStateId(sm), Is.EqualTo(2u));
}
[Test]
public void WhenTransitionIgnoresOtherTransitions()
{
// A guard scoped to transition 10 must not affect
// transition 20.
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(2)
.WhenTransition(10, (ctx, m) => false)
.StateMachine;
ServiceResult result = sm.DoTransition(m_context, 20, 0, default, []);
Assert.That(ServiceResult.IsGood(result), Is.True);
Assert.That(CurrentStateId(sm), Is.EqualTo(1u));
}
[Test]
public void WhenCauseScopesToCauseId()
{
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(1)
.WhenCause(100, (ctx, m) => false)
.StateMachine;
// Cause 100 → transition 10 (per BuildOnOffMachine).
ServiceResult denied = sm.DoTransition(m_context, 10, 100, default, []);
Assert.That(ServiceResult.IsBad(denied), Is.True);
// causeId=0 means "no cause" (machine-driven transition);
// DoTransition skips the cause-permission check entirely
// for causeId=0 and the When* guard's predicate is bypassed
// because the registered cause id doesn't match.
ServiceResult allowed = sm.DoTransition(m_context, 10, 0, default, []);
Assert.That(ServiceResult.IsGood(allowed), Is.True);
}
[Test]
public void WhenEnterScopesToToState()
{
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(1)
.WhenEnter(2, (ctx, m) => false)
.StateMachine;
// Transition 10 enters state 2 → veto.
ServiceResult denied = sm.DoTransition(m_context, 10, 0, default, []);
Assert.That(ServiceResult.IsBad(denied), Is.True);
Assert.That(CurrentStateId(sm), Is.EqualTo(1u));
}
[Test]
public void WhenEnterIsDefinitionModeOnly()
{
// First produce a definition-mode machine, then adopt it
// via For (lifecycle mode).
FluentFiniteStateMachineState sm = BuildOnOffMachine().StateMachine;
var lifecycle =
StateMachineBuilder.For(sm, m_context);
Assert.That(() => lifecycle.WhenEnter(2, (ctx, m) => true),
Throws.InvalidOperationException);
}
[Test]
public void WhenExitScopesToFromState()
{
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(2)
.WhenExit(2, (ctx, m) => false)
.StateMachine;
// Transition 20 leaves state 2 → veto.
ServiceResult denied = sm.DoTransition(m_context, 20, 0, default, []);
Assert.That(ServiceResult.IsBad(denied), Is.True);
Assert.That(CurrentStateId(sm), Is.EqualTo(2u));
}
[Test]
public void MultipleGuardsComposeWithAnd()
{
int firstCalls = 0;
int secondCalls = 0;
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(1)
.WhenTransition(10, (ctx, m) => { firstCalls++; return true; })
.WhenTransition(10, (ctx, m) => { secondCalls++; return false; })
.StateMachine;
ServiceResult result = sm.DoTransition(m_context, 10, 0, default, []);
Assert.That(ServiceResult.IsBad(result), Is.True);
Assert.That(firstCalls, Is.EqualTo(1),
"first guard runs first (registration order)");
Assert.That(secondCalls, Is.EqualTo(1),
"second guard runs after the first passes");
}
[Test]
public void FirstFailingGuardWinsForDenyStatus()
{
// Specific deny status from the failing guard flows through
// DoTransition's return.
FluentFiniteStateMachineState sm = BuildOnOffMachine()
.WithInitialState(1)
.WhenTransition(10, (ctx, m) => false,
denyStatus: StatusCodes.BadInvalidState)
.StateMachine;
ServiceResult result = sm.DoTransition(m_context, 10, 0, default, []);
Assert.That(result.Code, Is.EqualTo(StatusCodes.BadInvalidState));
}
[Test]
public void GuardsRejectNullPredicate()
{
StateMachineBuilder<FluentFiniteStateMachineState> b = BuildOnOffMachine();
Assert.That(() => b.WhenTransition(10, null!),
Throws.ArgumentNullException);
Assert.That(() => b.WhenCause(100, null!),
Throws.ArgumentNullException);
Assert.That(() => b.WhenEnter(2, null!),
Throws.ArgumentNullException);
Assert.That(() => b.WhenExit(1, null!),
Throws.ArgumentNullException);
}
private StateMachineBuilder<FluentFiniteStateMachineState> BuildOnOffMachine()
{
return StateMachineTestFixtures.NewBuilder(m_context)
.AddState(1, "Off", isInitial: true)
.AddState(2, "On")
.AddTransition(10, "OffToOn", from: 1, to: 2)
.AddTransition(20, "OnToOff", from: 2, to: 1)
.OnCause(100, from: 1, transition: 10)
.OnCause(200, from: 2, transition: 20);
}
private static uint CurrentStateId(FiniteStateMachineState sm)
{
if (sm.CurrentState?.Id?.Value is { } id &&
!id.IsNull &&
id.TryGetValue(out uint stateId))
{
return stateId;
}
return 0;
}
}
}