Files
Marc Schier a81d981755 dotnet format sweep (whitespace, IDE, RCS) + code-style enforcer agent fix (#3865)
# Description

Pure code-style sweep across the repo — no behavioral changes. Drives
`dotnet format` info-level diagnostics down on a large slice of the
codebase (Stack, Libraries, Tests, Tools).

Six commits, applied bottom-up in safety order so each batch leaves the
build green:

1. **`style: fix whitespace and final-newline formatting (WHITESPACE,
FINALNEWLINE)`**
   197 hits across ~30 files; pure mechanical cleanup.

2. **`style: apply dotnet format style fixes (IDE rules)`**
IDE-rule batch via `dotnet format style --severity info` —
`var`/explicit type, simplify names, collection expressions, expression
bodies, unused usings, etc.

3. **`style: apply dotnet format analyzers fixes (RCS blank-line
formatting)`**
   Roslynator formatting (RCS0xxx) blank-line and punctuation rules.

4. **`style: convert comments to doc comments and inline local vars
(RCS1181, RCS1124)`**
24 files. RCS1181 promotes `// summary`-style comments above
public/internal members to `/// <summary>` doc comments; RCS1124 inlines
locals used exactly once. Generated `Tools/` files were reverted to keep
the source-generator outputs deterministic.

5. **`docs(agent): correct --diagnostics flag form and verify Roslynator
4.x code fixers`**
Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two
corrections discovered while running this sweep:
- `dotnet format --diagnostics "RULE1 RULE2"` (single quoted,
space-separated) silently fixes nothing on `dotnet format` 10.x — it
parses as one unknown ID and exits 0. The correct form is `--diagnostics
RULE1 --diagnostics RULE2 …`, repeated per rule.
- Roslynator 4.15.0 **does** ship code fixers for
RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer"
list was outdated). RCS1140/1142 default to `Hidden` so need `--severity
info` to surface and fire; RCS1078 requires
`roslynator_empty_string_style = field` (already set in
`.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in
this stack.

6. **`style: format new code from master merge (dotnet format sweep)`**
After merging master into the branch (commit `e3ebc8742`), re-ran the
same three-phase format sweep on the 151 .cs files brought in by the
merge, scoped per project via repeated `--include`. 81 files changed;
same rule families as commits 1–4.
- Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs`
for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer
didn't apply for that specific case.
   - Reverted files that the formatter would break:
- `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM
analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>`
markers.
-
`Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs,
Core/Stack/Types/IUserIdentityTokenHandler.cs,
Client/Session/Session.cs}` — IDE0005 removed `using
Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378
reference fixtures for the analyzer).
- `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified
`OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a
conflicting type.

### What this PR does **not** touch

- No behavioral or semantic logic changes.
- No `.editorconfig` rule promotions (rules stay at their current
severities; this is a backlog-burndown pass, not a rule tightening).
- Generated source under `Tools/` is intentionally excluded.
- Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`,
`RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for
follow-up sweeps because they need per-TFM build verification or
semantic review.

## Related Issues

_No tracking issue — this is a non-functional style sweep and the
agent-doc correction is a follow-up to the same work. Happy to open one
if the maintainers prefer._

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage. _(N/A — style-only, no
behavioral change)_
- [x] I have added all necessary documentation. _(agent doc updated with
the two corrections)_
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. _(verified clean on `net10.0` and `net48`; only
pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. _(build
verified on net10 and net48 per batch; full test suite not yet run
locally — relying on CI)_
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

---------

Co-authored-by: agent <agent@local>
2026-06-10 08:35:44 +02:00

215 lines
8.6 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Collections.Generic;
using Microsoft.CodeAnalysis;
namespace Opc.Ua.MigrationAnalyzer.Helpers
{
/// <summary>
/// Shared helpers for symbol-shape queries used by multiple analyzers.
/// Lifted out of individual analyzers to keep detection patterns consistent.
/// </summary>
internal static class SymbolExtensions
{
/// <summary>
/// True iff <paramref name="symbol"/> carries an <c>[Obsolete]</c> attribute.
/// </summary>
public static bool IsObsolete(this ISymbol symbol)
{
if (symbol is null)
{
return false;
}
foreach (AttributeData attr in symbol.GetAttributes())
{
INamedTypeSymbol cls = attr.AttributeClass;
if (cls != null && cls.ToDisplayString() == "System.ObsoleteAttribute")
{
return true;
}
}
return false;
}
/// <summary>
/// True iff <paramref name="symbol"/> carries
/// <c>[Opc.Ua.OpcUaShimAttribute(ruleId)]</c> for the given
/// <paramref name="ruleId"/>. For extension methods reduced from a
/// static declaration, also inspects <see cref="IMethodSymbol.ReducedFrom"/>
/// since the attribute lives on the original declaration.
/// </summary>
public static bool IsOpcUaShim(this ISymbol symbol, string ruleId)
{
if (symbol is null)
{
return false;
}
if (HasShimAttribute(symbol, ruleId))
{
return true;
}
if (symbol is IMethodSymbol method && method.ReducedFrom != null)
{
return HasShimAttribute(method.ReducedFrom, ruleId);
}
return false;
}
private static bool HasShimAttribute(ISymbol symbol, string ruleId)
{
foreach (AttributeData attr in symbol.GetAttributes())
{
INamedTypeSymbol cls = attr.AttributeClass;
if (cls is null || cls.ToDisplayString() != "Opc.Ua.OpcUaShimAttribute")
{
continue;
}
if (attr.ConstructorArguments.Length == 1 &&
attr.ConstructorArguments[0].Value is string id &&
id == ruleId)
{
return true;
}
}
return false;
}
/// <summary>
/// True iff <paramref name="member"/> is declared (directly or via override)
/// on the named type referenced by <paramref name="declaringTypeFullName"/>.
/// </summary>
public static bool IsDeclaredOn(this ISymbol member, string declaringTypeFullName)
{
INamedTypeSymbol declaring = member?.ContainingType;
while (declaring != null)
{
if (declaring.ToDisplayString() == declaringTypeFullName)
{
return true;
}
declaring = declaring.BaseType;
}
return false;
}
/// <summary>
/// True iff <paramref name="type"/> is assignable to the named target type
/// (walks <see cref="ITypeSymbol.BaseType"/> and <see cref="ITypeSymbol.AllInterfaces"/>).
/// </summary>
public static bool IsAssignableTo(this ITypeSymbol type, ITypeSymbol target)
{
if (type is null || target is null)
{
return false;
}
SymbolEqualityComparer eq = SymbolEqualityComparer.Default;
ITypeSymbol current = type;
while (current != null)
{
if (eq.Equals(current, target))
{
return true;
}
current = current.BaseType;
}
foreach (INamedTypeSymbol iface in type.AllInterfaces)
{
if (eq.Equals(iface, target))
{
return true;
}
}
return false;
}
/// <summary>
/// Closed list of removed <c>{Type}Collection</c> wrappers that 2.0 dropped
/// in favour of <c>List&lt;T&gt;</c> / <c>ArrayOf&lt;T&gt;</c>. The element
/// type name is the second tuple item.
/// </summary>
public static IReadOnlyList<(string CollectionName, string ElementName)> RemovedCollectionTypes { get; } =
[
("Opc.Ua.BooleanCollection", "bool"),
("Opc.Ua.SByteCollection", "sbyte"),
("Opc.Ua.ByteCollection", "byte"),
("Opc.Ua.Int16Collection", "short"),
("Opc.Ua.UInt16Collection", "ushort"),
("Opc.Ua.Int32Collection", "int"),
("Opc.Ua.UInt32Collection", "uint"),
("Opc.Ua.Int64Collection", "long"),
("Opc.Ua.UInt64Collection", "ulong"),
("Opc.Ua.FloatCollection", "float"),
("Opc.Ua.DoubleCollection", "double"),
("Opc.Ua.StringCollection", "string"),
("Opc.Ua.DateTimeCollection", "Opc.Ua.DateTimeUtc"),
("Opc.Ua.GuidCollection", "Opc.Ua.Uuid"),
("Opc.Ua.ByteStringCollection", "Opc.Ua.ByteString"),
("Opc.Ua.XmlElementCollection", "System.Xml.XmlElement"),
("Opc.Ua.NodeIdCollection", "Opc.Ua.NodeId"),
("Opc.Ua.ExpandedNodeIdCollection", "Opc.Ua.ExpandedNodeId"),
("Opc.Ua.QualifiedNameCollection", "Opc.Ua.QualifiedName"),
("Opc.Ua.LocalizedTextCollection", "Opc.Ua.LocalizedText"),
("Opc.Ua.StatusCodeCollection", "Opc.Ua.StatusCode"),
("Opc.Ua.VariantCollection", "Opc.Ua.Variant"),
("Opc.Ua.DiagnosticInfoCollection", "Opc.Ua.DiagnosticInfo"),
("Opc.Ua.DataValueCollection", "Opc.Ua.DataValue"),
("Opc.Ua.ExtensionObjectCollection", "Opc.Ua.ExtensionObject"),
("Opc.Ua.ArgumentCollection", "Opc.Ua.Argument"),
("Opc.Ua.ServerSecurityPolicyCollection", "Opc.Ua.ServerSecurityPolicy"),
("Opc.Ua.TransportConfigurationCollection", "Opc.Ua.TransportConfiguration"),
("Opc.Ua.ReverseConnectClientCollection", "Opc.Ua.ReverseConnectClient")
];
/// <summary>
/// Convenience: returns the element type metadata name if
/// <paramref name="type"/> is one of the removed collection wrappers.
/// </summary>
public static bool TryGetRemovedCollectionElement(this ITypeSymbol type, out string elementName)
{
elementName = null;
if (type is null)
{
return false;
}
string typeFullName = type.ToDisplayString();
foreach ((string collection, string element) in RemovedCollectionTypes)
{
if (collection == typeFullName)
{
elementName = element;
return true;
}
}
return false;
}
}
}