mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-19 07:02:16 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
166 lines
6.7 KiB
C#
166 lines
6.7 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Text.Json;
|
|
using System.Xml;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Opc.Ua.Bindings;
|
|
|
|
namespace Opc.Ua.Fuzzing
|
|
{
|
|
public static partial class FuzzableCode
|
|
{
|
|
public static ServiceMessageContext MessageContext { get; } =
|
|
CreateMessageContext();
|
|
|
|
/// <summary>
|
|
/// Print information about the fuzzer target.
|
|
/// </summary>
|
|
public static void FuzzInfo()
|
|
{
|
|
Console.WriteLine("OPC UA Core Encoder Fuzzer for afl-fuzz and libfuzzer.");
|
|
Console.WriteLine("Fuzzing targets for various aspects of the Binary, Json and Xml encoders.");
|
|
}
|
|
|
|
internal static MemoryStream PrepareArraySegmentStream(ReadOnlySpan<byte> input, int segmentSize = 0x40)
|
|
{
|
|
if (segmentSize <= 0)
|
|
{
|
|
throw new ArgumentOutOfRangeException(nameof(segmentSize));
|
|
}
|
|
|
|
var buffers = new BufferCollection();
|
|
while (!input.IsEmpty)
|
|
{
|
|
int length = Math.Min(input.Length, segmentSize);
|
|
buffers.Add(new ArraySegment<byte>(input[..length].ToArray()));
|
|
input = input[length..];
|
|
}
|
|
if (buffers.Count == 0)
|
|
{
|
|
buffers.Add(new ArraySegment<byte>(Array.Empty<byte>()));
|
|
}
|
|
return new ArraySegmentStream(buffers);
|
|
}
|
|
|
|
internal static ServiceMessageContext CreateMessageContext()
|
|
{
|
|
ServiceMessageContext context = ServiceMessageContext.Create(new FuzzTelemetryContext());
|
|
context.NamespaceUris.Append("urn:opcfoundation:fuzzing:application");
|
|
context.NamespaceUris.Append("urn:opcfoundation:fuzzing:devices");
|
|
context.NamespaceUris.Append("urn:opcfoundation:fuzzing:diagnostics");
|
|
context.NamespaceUris.Append("urn:opcfoundation:fuzzing:types");
|
|
context.ServerUris.Append("urn:opcfoundation:fuzzing:server");
|
|
|
|
// Limits a mutated input of a few KB can exceed, so the limit oracle can observe a
|
|
// decoder that does not enforce them (the defaults need 64 KB strings). Every seed
|
|
// stays well within them.
|
|
context.MaxStringLength = FuzzMaxStringLength;
|
|
context.MaxByteStringLength = FuzzMaxByteStringLength;
|
|
context.MaxArrayLength = FuzzMaxArrayLength;
|
|
|
|
// Decimal is not in the default factory, so an ExtensionObject Decimal body is kept
|
|
// raw and never decoded. Register it so the targets exercise Decimal.Decode, which
|
|
// the T1-3 octet cap guards (OPC 10000-6 5.1.10).
|
|
context.Factory.AddEncodeableType(typeof(Decimal));
|
|
return context;
|
|
}
|
|
|
|
internal const int FuzzMaxStringLength = 4096;
|
|
internal const int FuzzMaxByteStringLength = 8192;
|
|
internal const int FuzzMaxArrayLength = 4096;
|
|
|
|
/// <summary>
|
|
/// Runs a decode under the allocation oracle and checks the decoded value against the
|
|
/// limits of <see cref="MessageContext"/>.
|
|
/// </summary>
|
|
internal static T DecodeWithOracles<T>(string decoder, long inputLength, Func<T> decode)
|
|
{
|
|
T value = FuzzOracles.MeasureAllocation(decoder, inputLength, decode);
|
|
FuzzOracles.CheckDecodedLimits(value!, MessageContext, decoder);
|
|
return value;
|
|
}
|
|
|
|
private static long GetRemainingLength(Stream stream)
|
|
{
|
|
return stream.CanSeek ? stream.Length - stream.Position : -1;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Prepare a seekable memory stream from the input stream.
|
|
/// </summary>
|
|
private static MemoryStream PrepareArraySegmentStream(Stream stream)
|
|
{
|
|
const int segmentSize = 0x40;
|
|
|
|
// AFL stdin is non-seekable; separate buffers also exercise chunk boundaries.
|
|
MemoryStream memoryStream;
|
|
using (var binaryStream = new BinaryReader(stream))
|
|
{
|
|
var bufferCollection = new BufferCollection();
|
|
byte[] buffer;
|
|
do
|
|
{
|
|
buffer = binaryStream.ReadBytes(segmentSize);
|
|
bufferCollection.Add(new ArraySegment<byte>(buffer));
|
|
} while (buffer.Length == segmentSize);
|
|
memoryStream = new ArraySegmentStream(bufferCollection);
|
|
}
|
|
|
|
return memoryStream;
|
|
}
|
|
|
|
private static bool IsExpectedDecodingError(ServiceResultException exception)
|
|
{
|
|
if (exception.StatusCode != StatusCodes.BadDecodingError &&
|
|
exception.StatusCode != StatusCodes.BadEncodingLimitsExceeded)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
return exception.InnerException switch
|
|
{
|
|
null or EndOfStreamException or XmlException or JsonException or FormatException => true,
|
|
ServiceResultException inner => IsExpectedDecodingError(inner),
|
|
_ => false
|
|
};
|
|
}
|
|
|
|
private sealed class FuzzTelemetryContext : TelemetryContextBase
|
|
{
|
|
public FuzzTelemetryContext()
|
|
: base(NullLoggerFactory.Instance)
|
|
{
|
|
}
|
|
}
|
|
}
|
|
}
|