mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-17 05:11:13 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
254 lines
11 KiB
C#
254 lines
11 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Diagnostics;
|
|
using System.IO;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
using Win32Exception = System.ComponentModel.Win32Exception;
|
|
|
|
namespace Opc.Ua.Fuzzing.Tests
|
|
{
|
|
[TestFixture]
|
|
[Category("Fuzzing")]
|
|
[NonParallelizable]
|
|
public sealed class ProcessHostTests : IDisposable
|
|
{
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_inputs = new TestInputDirectory();
|
|
}
|
|
|
|
[TearDown]
|
|
public void Dispose()
|
|
{
|
|
m_inputs?.Dispose();
|
|
}
|
|
|
|
[TestCase(nameof(FuzzableCode.ThrowingStreamTarget))]
|
|
[TestCase(nameof(FuzzableCode.ThrowingStringTarget))]
|
|
[TestCase(nameof(FuzzableCode.ThrowingSpanTarget))]
|
|
public async Task InjectedTargetFailureProducesANonzeroHostExitAsync(string target)
|
|
{
|
|
string file = await m_inputs.WriteAsync("failing input", [0x41]).ConfigureAwait(false);
|
|
|
|
(int exitCode, bool timedOut, string output, string error) =
|
|
await RunHostAsync(target, file).ConfigureAwait(false);
|
|
|
|
Assert.That(timedOut, Is.False, error);
|
|
Assert.That(exitCode, Is.Not.Zero);
|
|
Assert.That(error, Does.Contain("Injected fuzz target failure.").And.Contain(target));
|
|
Assert.That(output, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task MissingTargetPreservesTheHostUsageExitCodeAsync()
|
|
{
|
|
string file = Path.Combine(m_inputs.DirectoryPath, "not-read");
|
|
|
|
(int exitCode, bool timedOut, string output, string error) =
|
|
await RunHostAsync("MissingTarget", file).ConfigureAwait(false);
|
|
|
|
Assert.That(timedOut, Is.False, error);
|
|
Assert.That(exitCode, Is.EqualTo(2));
|
|
Assert.That(error, Does.Contain("The fuzzing function MissingTarget was not found."));
|
|
Assert.That(output, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task MissingInputFileProducesANonzeroHostExitAsync()
|
|
{
|
|
string file = Path.Combine(m_inputs.DirectoryPath, "missing input");
|
|
|
|
(int exitCode, bool timedOut, string output, string error) =
|
|
await RunHostAsync(nameof(FuzzableCode.SpanTarget), file).ConfigureAwait(false);
|
|
|
|
Assert.That(timedOut, Is.False, error);
|
|
Assert.That(exitCode, Is.Not.Zero);
|
|
Assert.That(error, Does.Contain(nameof(FileNotFoundException)).And.Contain(file));
|
|
Assert.That(output, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task EmptyCorpusProducesANonzeroHostExitAsync()
|
|
{
|
|
(int exitCode, bool timedOut, string output, string error) =
|
|
await RunHostAsync(nameof(FuzzableCode.SpanTarget), m_inputs.DirectoryPath).ConfigureAwait(false);
|
|
|
|
Assert.That(timedOut, Is.False, error);
|
|
Assert.That(exitCode, Is.Not.Zero);
|
|
Assert.That(error, Does.Contain("Replay corpus is empty:").And.Contain(m_inputs.DirectoryPath));
|
|
Assert.That(output, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task SuccessfulReplayPreservesZeroExitAndActuallyInvokesTheTargetAsync()
|
|
{
|
|
string file = await m_inputs.WriteAsync("successful input", FuzzableCode.CompletedInput.ToArray())
|
|
.ConfigureAwait(false);
|
|
|
|
(int exitCode, bool timedOut, string output, string error) =
|
|
await RunHostAsync(nameof(FuzzableCode.HangingSpanTarget), file).ConfigureAwait(false);
|
|
|
|
Assert.That(timedOut, Is.False, error);
|
|
Assert.That(exitCode, Is.Zero);
|
|
Assert.That(output, Is.EqualTo(FuzzableCode.TargetCompleted + Environment.NewLine));
|
|
Assert.That(error, Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public async Task SharedWatchdogDrainsBothRedirectedStreamsBeforeProcessExitAsync()
|
|
{
|
|
string file = await m_inputs.WriteAsync("large output input", FuzzableCode.LargeOutputInput.ToArray())
|
|
.ConfigureAwait(false);
|
|
|
|
(int exitCode, bool timedOut, string output, string error) =
|
|
await RunHostAsync(nameof(FuzzableCode.HangingSpanTarget), file).ConfigureAwait(false);
|
|
|
|
Assert.That(timedOut, Is.False);
|
|
Assert.That(exitCode, Is.Zero);
|
|
Assert.That(output, Is.EqualTo(new string('o', FuzzableCode.OutputLength)));
|
|
Assert.That(error, Is.EqualTo(new string('e', FuzzableCode.OutputLength)));
|
|
}
|
|
|
|
[Test]
|
|
public async Task SharedWatchdogTerminatesAHangingCallbackAfterItHasEnteredAsync()
|
|
{
|
|
string file = await m_inputs.WriteAsync("hanging input", FuzzableCode.HangingInput.ToArray())
|
|
.ConfigureAwait(false);
|
|
ProcessStartInfo startInfo = CreateReplayStartInfo(nameof(FuzzableCode.HangingSpanTarget), file);
|
|
var elapsed = Stopwatch.StartNew();
|
|
|
|
(int exitCode, bool timedOut, string output, string error) =
|
|
await FuzzProcessWatchdog.RunAsync(startInfo, TimeSpan.FromSeconds(5))
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(output, Is.EqualTo(FuzzableCode.HangingTargetEntered + Environment.NewLine));
|
|
Assert.That(error, Is.Empty);
|
|
Assert.That(timedOut, Is.True);
|
|
Assert.That(exitCode, Is.Not.Zero);
|
|
Assert.That(elapsed.Elapsed, Is.LessThan(TimeSpan.FromSeconds(20)),
|
|
"The shared watchdog must honor the short budget, not the area's 30-second default.");
|
|
}
|
|
|
|
[Test]
|
|
public async Task SharedWatchdogRejectsNullStartInformationAsync()
|
|
{
|
|
Func<Task> run = async () =>
|
|
_ = await FuzzProcessWatchdog.RunAsync(null!, TimeSpan.FromSeconds(5)).ConfigureAwait(false);
|
|
|
|
await Assert.ThatAsync(run, Throws.TypeOf<ArgumentNullException>()
|
|
.With.Property(nameof(ArgumentException.ParamName)).EqualTo("startInfo")).ConfigureAwait(false);
|
|
}
|
|
|
|
[TestCase(0L)]
|
|
[TestCase(-1L)]
|
|
[TestCase(-TimeSpan.TicksPerMillisecond)]
|
|
[TestCase(-TimeSpan.TicksPerSecond)]
|
|
[TestCase(((long)int.MaxValue * TimeSpan.TicksPerMillisecond) + 1)]
|
|
[TestCase(long.MaxValue)]
|
|
[TestCase(long.MinValue)]
|
|
public async Task SharedWatchdogRejectsInvalidTimeoutBeforeStartingOrChangingTheProcessAsync(long ticks)
|
|
{
|
|
ProcessStartInfo startInfo = CreateMissingExecutableStartInfo();
|
|
TimeSpan timeout = TimeSpan.FromTicks(ticks);
|
|
Func<Task> run = async () =>
|
|
_ = await FuzzProcessWatchdog.RunAsync(startInfo, timeout).ConfigureAwait(false);
|
|
|
|
await Assert.ThatAsync(run, Throws.TypeOf<ArgumentOutOfRangeException>()
|
|
.With.Property(nameof(ArgumentException.ParamName)).EqualTo("timeout")).ConfigureAwait(false);
|
|
|
|
Assert.That(startInfo.UseShellExecute, Is.True);
|
|
Assert.That(startInfo.RedirectStandardOutput, Is.False);
|
|
Assert.That(startInfo.RedirectStandardError, Is.False);
|
|
}
|
|
|
|
[TestCase(5000)]
|
|
[TestCase(int.MaxValue)]
|
|
public async Task SharedWatchdogPropagatesLaunchFailureForAllowedTimeoutsAsync(int milliseconds)
|
|
{
|
|
ProcessStartInfo startInfo = CreateMissingExecutableStartInfo();
|
|
Func<Task> run = async () =>
|
|
_ = await FuzzProcessWatchdog.RunAsync(startInfo, TimeSpan.FromMilliseconds(milliseconds))
|
|
.ConfigureAwait(false);
|
|
|
|
await Assert.ThatAsync(run, Throws.TypeOf<Win32Exception>()
|
|
.With.Property(nameof(Win32Exception.NativeErrorCode)).EqualTo(2)).ConfigureAwait(false);
|
|
|
|
Assert.That(startInfo.UseShellExecute, Is.False);
|
|
Assert.That(startInfo.RedirectStandardOutput, Is.True);
|
|
Assert.That(startInfo.RedirectStandardError, Is.True);
|
|
}
|
|
|
|
private static Task<(int ExitCode, bool TimedOut, string Output, string Error)> RunHostAsync(
|
|
string target,
|
|
string input)
|
|
{
|
|
return FuzzProcessWatchdog.RunAsync(CreateReplayStartInfo(target, input), TimeSpan.FromSeconds(15));
|
|
}
|
|
|
|
private static ProcessStartInfo CreateReplayStartInfo(string target, string input)
|
|
{
|
|
string assembly = typeof(Program).Assembly.Location;
|
|
#if NETFRAMEWORK
|
|
string executable = assembly;
|
|
string prefix = string.Empty;
|
|
#else
|
|
string executable = Environment.GetEnvironmentVariable("DOTNET_HOST_PATH") ?? "dotnet";
|
|
string prefix = $"\"{assembly}\" ";
|
|
#endif
|
|
return new ProcessStartInfo
|
|
{
|
|
FileName = executable,
|
|
Arguments = $"{prefix}--replay {target} \"{input}\"",
|
|
WorkingDirectory = AppContext.BaseDirectory,
|
|
UseShellExecute = false,
|
|
RedirectStandardOutput = true,
|
|
RedirectStandardError = true,
|
|
CreateNoWindow = true
|
|
};
|
|
}
|
|
|
|
private ProcessStartInfo CreateMissingExecutableStartInfo()
|
|
{
|
|
return new ProcessStartInfo
|
|
{
|
|
FileName = Path.Combine(m_inputs.DirectoryPath, "missing-replay-host.exe"),
|
|
UseShellExecute = true,
|
|
RedirectStandardOutput = false,
|
|
RedirectStandardError = false
|
|
};
|
|
}
|
|
|
|
private TestInputDirectory m_inputs = null!;
|
|
}
|
|
}
|