Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

326 lines
14 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using NUnit.Framework;
namespace Opc.Ua.Fuzzing.Tests
{
[TestFixture]
[Category("Fuzzing")]
[NonParallelizable]
public sealed class ProgramTests : IDisposable
{
[SetUp]
public void SetUp()
{
FuzzableCode.Reset();
m_inputs = new TestInputDirectory();
m_directory = m_inputs.DirectoryPath;
}
[TearDown]
public void Dispose()
{
m_inputs?.Dispose();
}
[Test]
public void ListEmitsOnlySupportedTargetNamesWithoutInvokingThem()
{
int exitCode = Run("--list");
Assert.That(exitCode, Is.Zero);
Assert.That(m_standardOutput.Split([Environment.NewLine], StringSplitOptions.None),
Is.EquivalentTo(new[]
{
nameof(FuzzableCode.StreamTarget),
nameof(FuzzableCode.StringTarget),
nameof(FuzzableCode.SpanTarget),
nameof(FuzzableCode.ThrowingStreamTarget),
nameof(FuzzableCode.ThrowingStringTarget),
nameof(FuzzableCode.ThrowingSpanTarget),
nameof(FuzzableCode.HangingSpanTarget),
nameof(FuzzableCode.DeepRecursionSpanTarget),
string.Empty
}));
Assert.That(m_standardError, Is.Empty);
Assert.That(FuzzableCode.Invocations, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[Test]
public void HelpReturnsSuccessAndWritesUsageWithoutInvokingTargets()
{
int exitCode = Run("--help");
Assert.That(exitCode, Is.Zero);
Assert.That(m_standardOutput, Is.Empty);
Assert.That(m_standardError, Does.Contain("Usage:").And.Contain("--list").And.Contain("--replay"));
Assert.That(m_standardError, Does.Contain(nameof(FuzzableCode.StreamTarget))
.And.Contain(nameof(FuzzableCode.StringTarget)).And.Contain(nameof(FuzzableCode.SpanTarget)));
Assert.That(FuzzableCode.Invocations, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[TestCaseSource(nameof(InvalidArguments))]
public void InvalidArgumentsReturnUsageErrorWithoutInvokingTargets(string[] args)
{
int exitCode = Run(args);
Assert.That(exitCode, Is.EqualTo(2));
Assert.That(m_standardError, Does.Contain("Usage:"));
Assert.That(m_standardOutput, Is.Empty);
Assert.That(FuzzableCode.Invocations, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[TestCaseSource(typeof(FuzzableCode), nameof(FuzzableCode.InvalidTargetNames))]
[TestCase("MissingTarget")]
[TestCase("spantarget")]
[TestCase("")]
public void ReplayRejectsInvalidTargetsBeforeReadingTheInput(string target)
{
string missingFile = Path.Combine(m_directory, "missing-input");
int exitCode = Run("--replay", target, missingFile);
Assert.That(exitCode, Is.EqualTo(2));
Assert.That(m_standardError, Does.Contain("The fuzzing function " + target));
Assert.That(m_standardOutput, Is.Empty);
Assert.That(FuzzableCode.Invocations, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[TestCase(nameof(FuzzableCode.StreamTarget))]
[TestCase(nameof(FuzzableCode.StringTarget))]
[TestCase(nameof(FuzzableCode.SpanTarget))]
public async Task ReplayFileInvokesOnlyTheExactRequestedTargetAsync(string target)
{
byte[] input = [0x41, 0x00, 0xc3, 0xa9];
string file = await WriteInputAsync("input with spaces", input).ConfigureAwait(false);
int exitCode = Run("--replay", target, file);
Assert.That(exitCode, Is.Zero);
Assert.That(FuzzableCode.Invocations.Select(call => call.Target), Is.EqualTo(new[] { target }));
Assert.That(FuzzableCode.Invocations[0].Input, Is.EqualTo(input));
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
Assert.That(m_standardOutput, Is.Empty);
Assert.That(m_standardError, Is.Empty);
}
[TestCase(nameof(FuzzableCode.StreamTarget))]
[TestCase(nameof(FuzzableCode.StringTarget))]
[TestCase(nameof(FuzzableCode.SpanTarget))]
public async Task ReplayEmptyFileStillInvokesTheRequestedTargetAsync(string target)
{
string file = await WriteInputAsync("empty", []).ConfigureAwait(false);
int exitCode = Run("--replay", target, file);
Assert.That(exitCode, Is.Zero);
Assert.That(FuzzableCode.Invocations.Select(call => call.Target), Is.EqualTo(new[] { target }));
Assert.That(FuzzableCode.Invocations[0].Input, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
Assert.That(m_standardOutput, Is.Empty);
Assert.That(m_standardError, Is.Empty);
}
[TestCase(nameof(FuzzableCode.StreamTarget))]
[TestCase(nameof(FuzzableCode.StringTarget))]
[TestCase(nameof(FuzzableCode.SpanTarget))]
public async Task ReplayCorpusRecursesInOrdinalOrderAndUsesOnlyTheRequestedTargetAsync(string target)
{
_ = await WriteInputAsync("z-last.bin", [0x7a]).ConfigureAwait(false);
_ = await WriteInputAsync(Path.Combine("middle corpus", "seed without extension"), [0x6d])
.ConfigureAwait(false);
_ = await WriteInputAsync("a-second.bin", [0x61]).ConfigureAwait(false);
_ = await WriteInputAsync("Z-first.bin", [0x5a]).ConfigureAwait(false);
int exitCode = Run("--replay", target, m_directory);
Assert.That(exitCode, Is.Zero);
Assert.That(FuzzableCode.Invocations.Select(call => call.Target),
Is.EqualTo(new[] { target, target, target, target }));
Assert.That(FuzzableCode.Invocations.Select(call => call.Input),
Is.EqualTo(new[]
{
new byte[] { 0x5a },
new byte[] { 0x61 },
new byte[] { 0x6d },
new byte[] { 0x7a }
}));
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
Assert.That(m_standardOutput, Is.Empty);
Assert.That(m_standardError, Is.Empty);
}
[TestCase(nameof(FuzzableCode.StreamTarget))]
[TestCase(nameof(FuzzableCode.StringTarget))]
[TestCase(nameof(FuzzableCode.SpanTarget))]
public void ReplayMissingFileThrowsWithoutInvokingTargets(string target)
{
string missingFile = Path.Combine(m_directory, "missing-input");
FileNotFoundException exception =
Assert.Throws<FileNotFoundException>(() => Run("--replay", target, missingFile))!;
Assert.That(exception!.FileName, Is.EqualTo(missingFile));
Assert.That(FuzzableCode.Invocations, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[Test]
public void ReplayMissingParentDirectoryThrowsWithoutInvokingTargets()
{
string missingFile = Path.Combine(m_directory, "missing-corpus", "missing-input");
Assert.That(() => Run("--replay", nameof(FuzzableCode.SpanTarget), missingFile),
Throws.TypeOf<DirectoryNotFoundException>());
Assert.That(FuzzableCode.Invocations, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[TestCase(false)]
[TestCase(true)]
public void ReplayEmptyCorpusThrowsEvenWhenItContainsAnEmptySubdirectory(bool hasSubdirectory)
{
if (hasSubdirectory)
{
Directory.CreateDirectory(Path.Combine(m_directory, "empty-subdirectory"));
}
InvalidOperationException exception = Assert.Throws<InvalidOperationException>(
() => Run("--replay", nameof(FuzzableCode.SpanTarget), m_directory))!;
Assert.That(exception!.Message, Does.Contain("Replay corpus is empty:").And.Contain(m_directory));
Assert.That(FuzzableCode.Invocations, Is.Empty);
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[TestCase(nameof(FuzzableCode.ThrowingStreamTarget))]
[TestCase(nameof(FuzzableCode.ThrowingStringTarget))]
[TestCase(nameof(FuzzableCode.ThrowingSpanTarget))]
public async Task ReplayDoesNotSwallowOrWrapTheTargetExceptionAsync(string target)
{
byte[] input = [0x41, 0x00, 0xc3, 0xa9];
string file = await WriteInputAsync("failing-input", input).ConfigureAwait(false);
InvalidOperationException exception =
Assert.Throws<InvalidOperationException>(() => Run("--replay", target, file))!;
Assert.That(exception, Is.SameAs(FuzzableCode.InjectedFailure));
Assert.That(FuzzableCode.Invocations.Select(call => call.Target), Is.EqualTo(new[] { target }));
Assert.That(FuzzableCode.Invocations[0].Input, Is.EqualTo(input));
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
[TestCase(nameof(FuzzableCode.ThrowingStreamTarget))]
[TestCase(nameof(FuzzableCode.ThrowingStringTarget))]
[TestCase(nameof(FuzzableCode.ThrowingSpanTarget))]
public async Task ReplayCorpusStopsAtTheFirstThrownTargetExceptionAsync(string target)
{
_ = await WriteInputAsync("z-unreached", [0x7a]).ConfigureAwait(false);
_ = await WriteInputAsync("a-failing", [0x61]).ConfigureAwait(false);
InvalidOperationException exception =
Assert.Throws<InvalidOperationException>(() => Run("--replay", target, m_directory))!;
Assert.That(exception, Is.SameAs(FuzzableCode.InjectedFailure));
Assert.That(FuzzableCode.Invocations.Select(call => call.Target), Is.EqualTo(new[] { target }));
Assert.That(FuzzableCode.Invocations[0].Input, Is.EqualTo(new byte[] { 0x61 }));
Assert.That(FuzzableCode.FuzzInfoCalls, Is.Zero);
}
private static IEnumerable<TestCaseData> InvalidArguments()
{
yield return ArgumentsCase("MissingArgumentsReturnUsageError");
yield return ArgumentsCase("UnknownOptionReturnsUsageError", "--unknown");
yield return ArgumentsCase("UnknownTargetReturnsUsageError", "MissingTarget");
yield return ArgumentsCase("EmptyTargetReturnsUsageError", string.Empty);
yield return ArgumentsCase("TargetNamesAreCaseSensitive", "spantarget");
yield return ArgumentsCase("ReplayWithoutTargetReturnsUsageError", "--replay");
yield return ArgumentsCase("ReplayWithoutInputReturnsUsageError",
"--replay", nameof(FuzzableCode.SpanTarget));
yield return ArgumentsCase("ReplayWithExtraArgumentsReturnsUsageError",
"--replay", nameof(FuzzableCode.SpanTarget), "missing-input", "extra");
yield return ArgumentsCase("ListWithExtraArgumentsReturnsUsageError", "--list", "extra");
yield return ArgumentsCase("HelpWithExtraArgumentsReturnsUsageError", "--help", "extra");
yield return ArgumentsCase("TargetWithExtraArgumentsReturnsUsageError",
nameof(FuzzableCode.SpanTarget), "extra");
yield return ArgumentsCase("MultipleModesReturnUsageError", "--list", "--help");
yield return ArgumentsCase("InvalidSingleTargetReturnsUsageError",
nameof(FuzzableCode.ReturningSpanTarget));
}
private static TestCaseData ArgumentsCase(string name, params string[] args)
{
return new TestCaseData(new[] { args }).SetName(name);
}
private Task<string> WriteInputAsync(string name, byte[] input)
{
return m_inputs.WriteAsync(name, input);
}
private int Run(params string[] args)
{
TextWriter previousOutput = Console.Out;
TextWriter previousError = Console.Error;
using var output = new StringWriter(CultureInfo.InvariantCulture);
using var error = new StringWriter(CultureInfo.InvariantCulture);
try
{
Console.SetOut(output);
Console.SetError(error);
return Program.Main(args);
}
finally
{
Console.SetOut(previousOutput);
Console.SetError(previousError);
m_standardOutput = output.ToString();
m_standardError = error.ToString();
}
}
private string m_directory = null!;
private TestInputDirectory m_inputs = null!;
private string m_standardOutput = null!;
private string m_standardError = null!;
}
}