mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-29 07:07:24 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
202 lines
9.0 KiB
C#
202 lines
9.0 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using System.Reflection;
|
|
using Microsoft.Extensions.Time.Testing;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.PubSub.Diagnostics;
|
|
using Opc.Ua.PubSub.Encoding;
|
|
using Opc.Ua.PubSub.MetaData;
|
|
|
|
namespace Opc.Ua.Fuzzing
|
|
{
|
|
/// <summary>
|
|
/// Retained PubSub callbacks participate in the standard corpus replay harness.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Fuzzing")]
|
|
public sealed class PubSubTests : FuzzTargetTestsBase
|
|
{
|
|
[DatapointSource]
|
|
public static readonly FuzzTargetFunction[] FuzzableFunctions =
|
|
CreateFuzzTargetFunctions(typeof(FuzzableCode));
|
|
|
|
protected override Type FuzzableCodeType => typeof(FuzzableCode);
|
|
|
|
[Test]
|
|
public void PublicSurfaceContainsExactlySixCallbacksAndFuzzInfo()
|
|
{
|
|
string[] streamNames =
|
|
[
|
|
"AflfuzzPubSubJsonDecode",
|
|
"AflfuzzUadpNetworkMessageDecode",
|
|
"AflfuzzUadpChunkReassembly"
|
|
];
|
|
string[] spanNames =
|
|
[
|
|
"LibfuzzPubSubJsonDecode",
|
|
"LibfuzzUadpNetworkMessageDecode",
|
|
"LibfuzzUadpChunkReassembly"
|
|
];
|
|
string[] callbackNames = [.. streamNames, .. spanNames];
|
|
string[] publicNames = ["FuzzInfo", .. callbackNames];
|
|
MethodInfo[] methods = typeof(FuzzableCode).GetMethods(
|
|
BindingFlags.Public | BindingFlags.Static | BindingFlags.DeclaredOnly);
|
|
|
|
Assert.That(
|
|
methods.Select(static method => method.Name),
|
|
Is.EquivalentTo(publicNames));
|
|
foreach (MethodInfo method in methods)
|
|
{
|
|
Assert.That(method.ReturnType, Is.EqualTo(typeof(void)), method.Name);
|
|
Assert.That(method.ContainsGenericParameters, Is.False, method.Name);
|
|
Type[] parameters = [.. method.GetParameters().Select(static parameter => parameter.ParameterType)];
|
|
if (method.Name == "FuzzInfo")
|
|
{
|
|
Assert.That(parameters, Is.Empty);
|
|
}
|
|
else
|
|
{
|
|
Type parameterType = streamNames.Contains(method.Name)
|
|
? typeof(Stream) : typeof(ReadOnlySpan<byte>);
|
|
Assert.That(parameters, Is.EqualTo(new[] { parameterType }), method.Name);
|
|
}
|
|
}
|
|
|
|
Assert.That(FuzzableFunctions, Has.Length.EqualTo(6));
|
|
Assert.That(
|
|
FuzzableFunctions.Select(static target => target.MethodInfo.Name),
|
|
Is.EquivalentTo(callbackNames));
|
|
Assert.That(
|
|
FuzzMethods.FindFuzzMethods(typeof(FuzzMethods.AflFuzzStream))
|
|
.Select(static callback => callback.Method.Name),
|
|
Is.EquivalentTo(streamNames));
|
|
Assert.That(
|
|
FuzzMethods.FindFuzzMethods(typeof(FuzzMethods.LibFuzzSpan))
|
|
.Select(static callback => callback.Method.Name),
|
|
Is.EquivalentTo(spanNames));
|
|
Assert.That(FuzzMethods.FindFuzzMethods(typeof(FuzzMethods.AflFuzzString)), Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public void ContextUsesFixedClockAndRegistersBothWireIdentities()
|
|
{
|
|
var expectedTime = new DateTimeOffset(2026, 6, 15, 12, 0, 0, TimeSpan.Zero);
|
|
PubSubNetworkMessageContext context = FuzzableCode.NewContext();
|
|
|
|
Assert.That(context.TimeProvider.GetUtcNow(), Is.EqualTo(expectedTime));
|
|
Assert.That(context.Diagnostics.Level, Is.EqualTo(PubSubDiagnosticsLevel.High));
|
|
Assert.That(context.MetaDataRegistry.Keys.Count, Is.EqualTo(2));
|
|
string[] names = ["Running", "Count", "Temperature", "Label"];
|
|
BuiltInType[] types = [BuiltInType.Boolean, BuiltInType.Int32, BuiltInType.Double, BuiltInType.String];
|
|
NodeId[] dataTypes = [DataTypeIds.Boolean, DataTypeIds.Int32, DataTypeIds.Double, DataTypeIds.String];
|
|
foreach (ushort writerGroupId in new ushort[] { 0, 1 })
|
|
{
|
|
var key = new DataSetMetaDataKey(
|
|
PublisherId.FromUInt16(300),
|
|
writerGroupId,
|
|
1,
|
|
new Uuid("aabbccdd-1122-3344-5566-778899aabbcc"),
|
|
1);
|
|
Assert.That(
|
|
context.MetaDataRegistry.TryGet(key, out DataSetMetaDataType? metadata),
|
|
Is.EqualTo(MetaDataMatchResult.Match));
|
|
Assert.That(metadata!.Name, Is.EqualTo("RetainedFuzzDataSet"));
|
|
Assert.That(metadata.DataSetClassId, Is.EqualTo(key.DataSetClassId));
|
|
Assert.That(metadata.ConfigurationVersion.MajorVersion, Is.EqualTo(1));
|
|
Assert.That(metadata.ConfigurationVersion.MinorVersion, Is.EqualTo(2));
|
|
Assert.That(metadata.Fields.Count, Is.EqualTo(4));
|
|
for (int i = 0; i < metadata.Fields.Count; i++)
|
|
{
|
|
Assert.That(metadata.Fields[i].Name, Is.EqualTo(names[i]));
|
|
Assert.That(metadata.Fields[i].BuiltInType, Is.EqualTo((byte)types[i]));
|
|
Assert.That(metadata.Fields[i].DataType, Is.EqualTo(dataTypes[i]));
|
|
Assert.That(metadata.Fields[i].ValueRank, Is.EqualTo(ValueRanks.Scalar));
|
|
}
|
|
}
|
|
|
|
var clock = new FakeTimeProvider(expectedTime);
|
|
PubSubNetworkMessageContext other = FuzzableCode.NewContext(clock);
|
|
clock.Advance(TimeSpan.FromSeconds(1));
|
|
Assert.That(other.TimeProvider, Is.SameAs(clock));
|
|
Assert.That(other.TimeProvider.GetUtcNow(), Is.EqualTo(expectedTime.AddSeconds(1)));
|
|
Assert.That(context.TimeProvider.GetUtcNow(), Is.EqualTo(expectedTime));
|
|
other.Diagnostics.Increment(PubSubDiagnosticsCounterKind.ReceivedNetworkMessages);
|
|
Assert.That(context.Diagnostics.Read(PubSubDiagnosticsCounterKind.ReceivedNetworkMessages), Is.Zero);
|
|
}
|
|
|
|
[TestCase(0)]
|
|
[TestCase(4097)]
|
|
[TestCase(1048576)]
|
|
[TestCase(1048577)]
|
|
public void SpanAndShortReadStreamKeepOnlyTheOneMiBPrefix(int inputLength)
|
|
{
|
|
byte[] input = new byte[inputLength];
|
|
for (int i = 0; i < input.Length; i++)
|
|
{
|
|
input[i] = (byte)((i % 251) + 1);
|
|
}
|
|
int expectedLength = Math.Min(inputLength, 1024 * 1024);
|
|
byte[] expected = input.AsSpan(0, expectedLength).ToArray();
|
|
using var stream = new ShortReadStream(input);
|
|
|
|
byte[] copied = FuzzableCode.CopyCapped(input);
|
|
byte[] read = FuzzableCode.ReadCapped(stream);
|
|
|
|
Assert.That(copied, Is.EqualTo(expected));
|
|
Assert.That(read, Is.EqualTo(expected));
|
|
Assert.That(stream.Position, Is.EqualTo(expectedLength));
|
|
Assert.That(stream.CanRead, Is.True, "The caller owns the input stream.");
|
|
if (inputLength > 0)
|
|
{
|
|
Assert.That(copied, Is.Not.SameAs(input));
|
|
Assert.That(stream.ReadCalls, Is.GreaterThan(1));
|
|
}
|
|
if (inputLength > expectedLength)
|
|
{
|
|
Assert.That(stream.ReadByte(), Is.EqualTo(input[expectedLength]));
|
|
}
|
|
}
|
|
|
|
private sealed class ShortReadStream(byte[] input) : MemoryStream(input, writable: false)
|
|
{
|
|
public int ReadCalls { get; private set; }
|
|
|
|
public override int Read(byte[] buffer, int offset, int count)
|
|
{
|
|
ReadCalls++;
|
|
return base.Read(buffer, offset, Math.Min(count, 67));
|
|
}
|
|
}
|
|
}
|
|
}
|