Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00
..

SiteCompositionServer

A supervisory OPC UA server that owns no devices and composes the machines of several subordinate servers into a single live 3D scene.

This is the SCADA-level counterpart to a device server. Where PumpDeviceIntegrationServer and GeneratorServer each publish their own machines and their own twin, this server publishes a site and says which server owns what.

What it demonstrates

flowchart TD
  C["Opc.Ua.OpenUsd.Connector<br/>--federate"]
  S["SiteCompositionServer<br/>site shell + camera<br/>owns no devices"]
  P["PumpDeviceIntegrationServer<br/>pumps"]
  G["GeneratorServer<br/>generator sets"]

  C -->|"primary session"| S
  S -.->|"ComponentEndpointUrl"| P
  S -.->|"ComponentEndpointUrl"| G
  C ==>|"federated session"| P
  C ==>|"federated session"| G

  C --> STAGE[["one live stage<br/>machines from three servers"]]

The site server declares one cross-server component binding per subordinate, carrying that server's ComponentServerUri and ComponentEndpointUrl. A connector run with --federate opens a session to each named server, discovers its representations and drives its bindings into the same stage.

Nothing is mirrored. The site server never proxies a subordinate's address space: it only says where the machines are and lets the connector talk to each owner directly, so there is no cache to invalidate and no second copy of the truth.

Running it

The demo script builds the three servers, publishes the connector and viewport side by side, waits for every endpoint, and cleans up when the viewer closes:

pwsh samples/OpenUsd/SiteCompositionServer/run-site-composition-demo.ps1

Use -Renderer D3D12, -PumpCount, -GeneratorCount, or -Keep to override the defaults. -ViewerBundlePath can point at an already published connector and viewport directory.

To start each process manually, run:

Start the two device servers, then the site server:

dotnet run --project samples/DI/PumpDeviceIntegrationServer -- --host localhost --port 62542 --pumps 3
dotnet run --project samples/OpenUsd/GeneratorServer -- --host localhost --port 62543 --generators 2
dotnet run --project samples/OpenUsd/SiteCompositionServer -- --host localhost --port 62544

Then render the composed site:

dotnet run --project tools/Opc.Ua.OpenUsd.Connector -- \
    --server opc.tcp://localhost:62544/SiteCompositionServer \
    --insecure --federate --view

--pump-server and --generator-server override the subordinate endpoints.

Why --federate is opt-in

The endpoint the connector dials comes from the server being rendered, not from the operator, so honouring it is a trust decision — a server could name any endpoint it likes. The client library is fail-closed (no session factory, no federation) and the command-line connector mirrors that behind an explicit flag. Federated sessions are negotiated exactly the way the primary session is, so composing a subordinate cannot quietly downgrade security.

Federation is also best-effort per component: a subordinate that is down, unreachable or refuses the session is logged and skipped. The rest of the scene still renders and only that server's machines are missing, because one unreachable subordinate taking down the whole stage would be a poor trade.

What lands where

Each subordinate's machines compose at the prim paths that subordinate publishes — the pump server's pumps under /Plant/..., the generator server's sets under /Powerhouse/... — because the remote connector drives that server's own representation. The /Site/PumpHall and /Site/Powerhouse scopes in Site.usda are the site's own placeholders for those areas.

A verified run against three servers produces one override layer containing:

From In the stage
Pump server /Plant/Pumps/… with live impeller rotation and casing colour
Generator server /Powerhouse/Generators/GeneratorSet_1…N with frequency, power, engine hours, fan rotation and thermal colour
Site server /Site/… shell, lighting and the control-room camera

Files

File Purpose
SiteNodeManager.cs Site topology, OpenUSD facility, cross-server component bindings
Assets/Site.usda Ground, building slabs, lighting, control-room camera — deliberately no machine geometry
Program.cs Host wiring and endpoint arguments

See also