mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-16 21:02:51 +08:00
466c5cb982
Follow-ups to #4165, plus the work that followed from re-checking this branch against the specification. Everything started as a defect found by review or by probing the running code; the specification is unchanged except where noted. The TLS certificate lifetime fix (#4196) and the OpenUSD work (#4198) were both merged into this branch. #4196 has since landed on master, so it no longer appears in this diff. #4198 was closed in favour of this PR and its content is here. The MCP trim/AOT work (#4228), the `DataGenerator` null `NodeId` fix (#4227) and the NodeSet external-parent import fix (#4229) have since been merged in as well. All three are closed in favour of this PR and their content is here, described under *Making the MCP libraries trim and AOT clean*, *A generator that returned the value you opted out of* and *A NodeSet parent that lived outside the import batch* below. ## A two-arm cell could not be built `IntentExecution` carried no controller identity, and there was effectively one `IIntentExecutor` per server. An executor handed an execution therefore could not tell **which arm** it was for, so a cell with two `IntentControllerType` instances — an ordinary configuration — was not expressible through the builder or DI. Both halves are addressed: - `IntentExecution` now carries `ControllerId` (`NodeId`, the OPC UA identity) and `ControllerName`, so one shared executor can discriminate; - DI gained per-controller registration — `AddRobotIntentExecutor<TExecutor>(controllerBrowseName)` and an instance overload — so two genuinely different executors can coexist. Resolution order is `WithExecutor` → per-controller DI registration → the single DI executor → a build-time throw. There is still **no silent fallback** to a rejecting executor; that was a Critical defect fixed in #4165 and it stays fixed. `IIntentExecutor` is unchanged, so this is purely additive. ## Declarations that were quietly untrue - **`Accepts<T>` silently discarded a redeclaration.** Declaring an intent type twice — say to narrow `cancelSupported` on the second call — kept the first, wider declaration and said nothing. That is the same class of defect as the capability-honesty problems #4165 fixed (`PauseSupported` declaring a pause the host could not perform; `Aborting` degrading silently to `Buffered`). Identical redeclarations remain idempotent; conflicting ones now throw `BadInvalidArgument`. - **`RI-Interop-40010` assumed Annex B item 3 rather than checking it.** It now requires exact set equality between the OPC 40010 `TaskProgramName` values and the Robot Intent `ProgramType.ProgramId` values. Both sides are readable from the address space without commanding the robot, which is what makes the requirement structural under §12.1. ## Two things the specification requires that this did not do Re-checking the implementation against the merged draft revision turned up two genuine violations. Both are fixed, and the NodeSet is untouched by either. - **Every graphed mission reported `Failed` on success.** `MissionRules.SelectTransition` returned `null` for two different situations — a graph *terminus*, which is the normal success path, and a branch point whose conditions all evaluated false — and the caller collapsed both into `Failed`/`NoTransition`. A three-way result (`Terminus` / `Selected` / `NoConditionMatched`) separates them, so a mission that runs to its end now completes. The failure reason surfaces through the inherited Part 10 result container rather than a new member. - **Facet URIs were never published.** An upstream `may` became a `shall` in the revision this branch adopts. `RobotIntentConformanceUris.Facets` held 31 URIs with **zero** production references — the set existed but nothing emitted it. The published set is now derived from `RobotIntentFacetCalculator`, the same authority that already computed `SupportedFacets`, rather than from a second hand-maintained list that could drift; a reflection test pins the two together. ## An easy client mistake `RequestAuthorityAsync` returns a lease the caller must remember to inspect. Forgetting makes every later submission fail with `ControlNotOwned` for reasons that are invisible at the call site. `RequireAuthorityAsync` throws instead, and names the current owner. `RequestAuthorityAsync` is untouched — inspecting and branching is legitimate. ## Letting an agent drive the robot New `tools/Opc.Ua.Mcp.Robotics` gives a language model the intent API as MCP tools: 36 across discovery, monitoring, direct control and missions, behind a `Robotics` tool profile, composable into any MCP host exactly as the existing OPC UA tool packages are. The `IntentViewerClient` sample hosts them behind `--mcp` (stdio by default, HTTP when `--view`, since MCP stdio and the in-process viewer would otherwise share stdout), and the sample gained a pallet scene so an agent can pick and stack parts and watch the result in the OpenUSD viewer. All the scene logic is server-side — no viewer or connector changes. Four gaps in the client API had to be filled first, since the tools are a thin layer over it and could not have been written honestly without them: `ReadStateAsync`, `ListOperationsAsync`/`ListMissionsAsync`, controller-level `CancelIntent`/`CancelAll`/`Pause`/`Resume`/`Retry`/`ReleaseControl`, and `WaitForCompletionAsync`. The tools refuse rather than paper over: a refusal from the server is returned with its `IntentFailureEnum` and never retried, and command authority is never acquired as a side effect of a tool call. **One defect this surfaced:** `--profile robotics` shipped 36 tools that could not do anything. Every robotics tool resolves a named OPC UA session and only the connection tools can open one, so with no `Connect` in the catalogue the whole profile failed. A test had pinned the defect in place, asserting the profile did *not* contain `Connect` on the line below the `diagnostics` assertion requiring it. Each package now declares its own requirement in its registration extension rather than the host special-casing it, so an application embedding `Opc.Ua.Mcp.Robotics` directly gets a usable catalogue without reproducing the host's pairing. `Full` still takes the connection tools from the core package, so they are never registered twice. The replacement test states the invariant — a profile exposing session-scoped tools must expose the tools that open a session — rather than the instance. ## Making the MCP libraries trim and AOT clean *Merged from #4228.* `Opc.Ua.Mcp.Core` is now `IsAotCompatible` on `net10.0`, and the reflection the analysers then reported is gone. Turning the analysers on is the point: until now they were not running on these libraries at all — including on the tool library this branch adds. - **`OpcUaJsonHelper.Serialize`** went through `JsonSerializer` (IL2026 / IL3050). The conversion helpers in that class already reduce every OPC UA value to a closed set — `null`, the primitive scalars, `string`, `Dictionary<string, object?>` and lists thereof — so the JSON is now written directly with a `Utf8JsonWriter`. Output is unchanged, and that is asserted rather than assumed: `OpcUaJsonHelperTests.SerializeMatchesTheReflectionBasedSerializer` compares the new writer byte for byte against `JsonSerializer` for every shape the helpers emit, including all numeric widths, the custom-formatted scalars, nested sequences and strings that force the encoder to escape. One deliberate contract change: arbitrary object graphs are no longer accepted. Serializing them needs reflection, so `Serialize` now throws `NotSupportedException` naming the type instead of silently stringifying it. No call site in the repository passes anything outside the closed set. - **`McpSchemaFilters`** used `JsonSerializer.SerializeToElement` on a `JsonObject`; it now parses the node's own text, which needs no reflection. `Opc.Ua.Mcp.Diagnostics` is deliberately **not** marked. It depends on SharpPcap and on the reflective service-call dissection in `Opc.Ua.Core.Diagnostics`, neither of which is trim safe — which is why that package does not opt in either. Two improvements are kept regardless: `PacketDecodeTools` serializes `DecodedServiceCall` through a source-generated `JsonSerializerContext`, and `PacketCaptureTools.ListInterfaces` now carries the `RequiresUnreferencedCode` / `RequiresDynamicCode` annotations that `NetworkInterfaceEnumerator.ListLocalInterfaces` already declares, so the constraint is visible to callers instead of implicit. Nothing is suppressed. Marking an assembly `IsAotCompatible` only proves its own IL is clean; it says nothing about whether the library still functions once reflection is gone. So `Opc.Ua.Aot.Tests` references `Opc.Ua.Mcp.Core` and exercises it with JSON reflection disabled, stating what is and is not true today: - tool **results** serialize without reflection — this would fail outright if the `Utf8JsonWriter` change regressed; - tool **registration** still requires reflection, because the MCP SDK builds each tool's input schema by asking `JsonSchemaExporter` for a `JsonTypeInfo` of every parameter type. Without a source-generated context covering the tool signatures — and with the injected `OpcUaSessionManager` being described rather than treated as a service — that throws `NotSupportedException`. The second test asserts the throw. It documents the remaining gap and turns red the moment someone closes it, rather than leaving it to be found in a published binary. The package README says the same thing in prose. **Two pre-existing issues this surfaced, both outside this PR:** pulling `Opc.Ua.Mcp.Diagnostics` into an AOT publish reports `IL2046` / `IL3051` on `NicCaptureSource.StartAsync`, which is annotated `RequiresUnreferencedCode` / `RequiresDynamicCode` while the `ICaptureSource.StartAsync` it implements is not, and `IL2075` on `ServiceCallReassembler.GetCollectionCount` / `GetPropertyString`, which call `Type.GetProperty` on the result of `GetType()`. Happy to file these separately if useful. ## A generator that returned the value you opted out of *Merged from #4227. Fixes #4226.* `GetRandomNodeId(useBoundaryValues: false)` could still return `NodeId.Null` — one of the boundary values the same method offers when boundary values *are* requested. A caller that opted out should not receive one, and `GetRandomExpandedNodeId` builds on it and inherited the same behaviour. The `IdType.Opaque` branch is the practical path: `GetRandomByteString()` draws its length with `NextInt32(MaxStringLength)`, which is inclusive of zero, and a zero-length opaque identifier in namespace 0 satisfies `NodeId.IsNull`. With three namespaces and `MaxStringLength` at 10 that is roughly **one call in 130**. A numeric identifier of `0` in namespace 0 is null too, at around one in four billion. The draw is now repeated while the result is null and boundary values were not requested. Guarding the result rather than the individual branches covers every identifier type, including the numeric case, rather than only the one that happens to be reachable today. The `useBoundaryValues: true` path is untouched, so boundary values remain available when they are asked for. Four tests in `tests/Opc.Ua.Core.Tests/Types/DataGeneratorTests.cs` loop 20,000 draws, because at one call in 130 a single draw proves nothing. Against the **unmodified** generator they fail on draw 93 and draw 1346. Two of the four exist to keep the fix honest rather than to test the bug: `GetRandomNodeIdStillProducesEveryIdentifierType` catches a "fix" that simply stopped emitting opaque identifiers, which would satisfy the null assertions while silently narrowing the generator, and `GetRandomNodeIdWithBoundaryValuesStillYieldsThem` confirms the leak was closed rather than the feature removed. **How it was found:** an intermittent downstream test failure. A test server initialising a static `NodeId`-valued variable via `TestDataSystem.ReadValue` occasionally stored `NodeId.Null`; the encoder correctly writes that as JSON `null`, and a consumer asserting a value was present failed about one run in five — never reproducibly in isolation. It only surfaced under load because `UnsecureRandom.Shared` is a fixed-seed, process-global generator shared between `DataGenerator` and OPC UA transport jitter, so the number of draws preceding address-space initialisation depends on what else is running in the process. ## A NodeSet parent that lived outside the import batch *Merged from #4229.* `UANodeSetHelpers.LinkParentChildRelationships` builds its lookup table from **only the nodes in the current import batch**, links a child when the parent is found — and then cleared `instance.Handle` **unconditionally**, which is exactly where `Import` had stashed the authored `ParentNodeId`. A node whose parent lives in another NodeSet, or is owned by another NodeManager, therefore lost that parent **silently** at import, and nothing downstream could recover it. `RuntimeNodeSetNodeManager.CreateAddressSpaceAsync` already has a step that wires references to external node managers; the parent link never reached it. Such a parent is now recorded rather than discarded, and exposed through `UANodeSet.TryGetUnresolvedParentNodeId`. A parent that resolved normally inside the batch is **not** recorded, so a caller does not re-wire references that already exist. The record lives in a `ConditionalWeakTable`, so it does not keep an imported node alive and does not widen `NodeState` — whose `Handle` is a general-purpose slot a caller may legitimately use for its own purposes, and so is not a safe place to leave the value. `RuntimeNodeSetNodeManager` consumes it to report the one case that cannot be repaired automatically. In NodeSet2 the `ParentNodeId` attribute is a *hint*; the authoritative edge is the entry under `<References>`, which the reverse-reference pass already turns into an external reference. A node that names an out-of-manager parent but carries **no such Reference** materializes with no path from that parent, and no ReferenceType can be inferred to synthesise one — so it is reported as an authoring defect rather than guessed at or silently accepted. This is deliberately **not** a fix for a specific address-space symptom. It removes a silent loss of authored information and gives callers the means to act on it. Whether any particular orphaned-node report is caused by this path, or by namespace-index translation elsewhere, still needs separate diagnosis. **Changed while merging.** As authored in #4229 the accessor was `GetUnresolvedParentNodeId`, returning `NodeId?`. `NodeId` is a readonly struct implementing `INullable`, so that was a `System.Nullable<NodeId>` wrapped around a type that already carries its own null representation — which this repository excludes in favour of an `IsNull` check, and it asks for `TryGet` over casting on struct types. The tests correspondingly asserted `Is.Null` against a struct, which the testing rules also exclude. It is now `bool TryGetUnresolvedParentNodeId(NodeState, out NodeId)`, yielding `NodeId.Null` when there is no unresolved parent. The API is unshipped — it arrives with this branch — so nothing depended on the previous shape. Both tests were re-verified by mutation after the rewrite: disabling the record in `LinkParentChildRelationships` still fails `ImportKeepsAParentThatIsNotInTheSameBatch`. ## Dependencies - **OpenUSD to `0.7.0-alpha`.** All 11 issues we filed upstream are fixed, so the workarounds they justified are gone and the parts of the pump and generator samples that were blocked on them are implemented. - **ModelContextProtocol to `2.1.0`** across all five MCP tool libraries and the executable. No code changes were needed — the surface we use is unchanged in 2.x — but central package management required a cascade of pins, each commented where it sits. Both transports were verified against a running server rather than assumed. MCP 2.x is stateless (no `initialize`, no `Mcp-Session-Id`); an OPC UA session is application state addressed by a caller-supplied name, which fits that model but does assume process affinity, and that assumption is now written down rather than implied. ## Infrastructure The `code coverage` gate was measuring nothing on this branch and reporting success. It is fixed and now enforced, which immediately exposed real gaps — most usefully `RoboticsIntentJson`, which parses agent-supplied JSON (untrusted input from a language model) and had no tests at all. It is now at full line coverage in CI. Patch coverage is **90.20%** against a 75% floor. The `netstandard2.1` build leg was also failing. The MCP projects build as empty shells under a legacy `CustomTestTarget`, and the viewer sample referenced them on the target framework alone, so it tried to resolve a net10.0 shell from net8.0. The sample now derives MCP support from whether those projects are actually being built. ## From review A review pass over the branch found two real defects, both fixed. `RoboticsIntentJson` parses JSON written by a language model, so every malformed shape it can be handed is reachable input; it indexed pose arrays without checking their length and enumerated properties without checking their kind, so a short or wrongly-typed array escaped as `IndexOutOfRangeException` or `InvalidOperationException` rather than the argument error the tool descriptions promise the agent. Separately, `IntentOperationHandle` treated a zero `QueuePosition` as "not observed" and discarded it, so a handle kept reporting the last queued position after the server had said the operation left the queue. The pose validation immediately caught a latent test defect: the pallet scenario interpolated doubles into JSON with the current culture, so under a comma-decimal culture `[0.12, 0.16, 0.28]` became a six-element array. It passed only because that submission is expected to be refused for want of authority, so the wrong coordinates were never used. A third review finding — that a default-constructed `RobotIntentControllerState` hands out a null `NodeId` — was checked and rejected: `NodeId`, `QualifiedName` and `LocalizedText` are readonly structs here, so `default` is the null value and `IsNull` is `true`. The tests asserting that invariant are kept. A second review pass over the merged branch found two more, both fixed and both about an error surfacing as the wrong kind of failure rather than about a wrong result: - **Malformed agent JSON did not arrive as an argument error.** `RoboticsIntentJson` turns every *validation* failure into an `ArgumentException` — a wrong root kind, a missing property, a short pose array — but three `JsonDocument.Parse` calls and the NodeId parse were unguarded. A syntax error escaped as `JsonException` and an unparseable NodeId as `ServiceResultException`, which are the two shapes a language model is most likely to produce. That is the same defect class as the pose/kind checking above: a caller separating bad input from a genuine fault had to know to catch three unrelated exception types. Parsing now goes through one helper that reports a syntax error as an `ArgumentException` naming the argument, keeping the `JsonException` as the inner exception so the position is not lost, and the NodeId goes through `NodeId.TryParse` rather than `Parse`, collapsing its two failure modes into one. `MalformedIntentJsonIsRejected` had asserted `InstanceOf<JsonException>`, pinning the behaviour rather than the intended contract; it now asserts `ArgumentException` like every neighbouring test, and three tests cover the newly guarded paths. - **`ConditionalWeakTable.Add` throws on a duplicate key.** Not reachable today, but `TryGetUnresolvedParentNodeId` documents `Handle` as a general-purpose slot a caller may use for its own purposes — and a caller doing exactly that before re-importing into the same collection would take a hard throw from inside the import pipeline. Removing first makes the most recent import win. `AddOrUpdate` would say this more directly but does not exist on `netstandard2.0`. ## Deliberately not fixed here `FastenIntentDataType.Joint` is refused when the Server exposes no OPC 40450/40451 model, and a client cannot discover that before calling. That is **not fixable in this repository**: §5.4.2 makes `Joint` the defining mechanism while §11.3 says the parameters otherwise stand alone, and `IntentCapabilityDataType` declares capabilities at intent-type granularity with no member-level mechanism anywhere in the model. It is a specification gap, raised as S4 on [marcschier/opcua-drafts#60](https://github.com/marcschier/opcua-drafts/pull/60) rather than worked around with a bespoke mechanism the spec does not define. ## Validation `dotnet build UA.slnx -c Release` on the merged branch — **0 errors, 0 warnings**, with the AOT analysers now running over `Opc.Ua.Mcp.Core`. | Suite (net10.0) | Tests | |---|---| | `Opc.Ua.Core.Tests` | 4247 (86 skipped) | | `Opc.Ua.Robotics.Tests` | 540 | | `Opc.Ua.OpenUsd.Tests` | 909 | | `Opc.Ua.Tools.Tests` | 419 | | `Opc.Ua.Server.Tests` — `RuntimeNodeSet` | 94 | | `Opc.Ua.Robotics.Intent.Tests` | 22 | | `Opc.Ua.Aot.Tests` — `McpAotTests` | 3 | 0 failures. `Opc.Ua.Tools.Tests` rose from 409 to 419 with the serializer-equivalence tests from #4228 and the malformed-JSON tests from the second review pass, and `Opc.Ua.Core.Tests` covers the `DataGenerator` tests from #4227 and the import tests from #4229. `UANodeSetHelpers` also passes on **net48** (5/5). The MCP agent-usability grader scores Core 100 / Full 100. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: a248a589-9a20-4372-868e-5d347e57001b Copilot-Session: 9e6a5abf-3299-4cd1-9855-010fedbf0ad8 Copilot-Session: a0718e8a-a158-45c5-929d-e1d6c0982431
271 lines
12 KiB
C#
271 lines
12 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Globalization;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging;
|
|
using Opc.Ua;
|
|
using Opc.Ua.Client;
|
|
using Opc.Ua.Robotics.Client.Intent;
|
|
using Opc.Ua.RobotIntent;
|
|
|
|
namespace IntentViewerClient
|
|
{
|
|
internal sealed partial class PickProcessor : IDisposable
|
|
{
|
|
public PickProcessor(
|
|
RobotIntentControllerClient controller,
|
|
ISession session,
|
|
IReadOnlyList<TargetLocation> targets,
|
|
ILogger logger,
|
|
bool canCommand)
|
|
{
|
|
m_controller = controller;
|
|
m_session = session;
|
|
m_targets = targets;
|
|
m_logger = logger;
|
|
m_canCommand = canCommand;
|
|
}
|
|
|
|
public async Task ProcessPickAsync(string primPath, CancellationToken cancellationToken)
|
|
{
|
|
await m_pickGate.WaitAsync(cancellationToken).ConfigureAwait(false);
|
|
try
|
|
{
|
|
await ProcessPickCoreAsync(primPath, cancellationToken).ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
m_pickGate.Release();
|
|
}
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
m_pickGate.Dispose();
|
|
}
|
|
|
|
private async Task ProcessPickCoreAsync(string primPath, CancellationToken cancellationToken)
|
|
{
|
|
TargetLocation? target = m_targets.FirstOrDefault(
|
|
t => string.Equals(t.PrimPath, primPath, StringComparison.Ordinal));
|
|
if (target is null)
|
|
{
|
|
Console.Error.WriteLine($"Picked {primPath}, but the server did not publish a LocationType mapping for it.");
|
|
return;
|
|
}
|
|
|
|
Console.Error.WriteLine($"Picked {target.Name} at {target.PrimPath}; reading {target.LocationNodeId} Pose.");
|
|
Pose3DDataType pose;
|
|
try
|
|
{
|
|
pose = await Program.ReadLocationPoseForProcessorAsync(
|
|
m_session, target.LocationNodeId, cancellationToken).ConfigureAwait(false);
|
|
}
|
|
catch (ServiceResultException exception) when (exception.StatusCode == StatusCodes.BadUnexpectedError)
|
|
{
|
|
Console.Error.WriteLine(
|
|
$"Location {target.Name} ({target.LocationNodeId}) published a Pose value this " +
|
|
"client could not decode; skipping that target.");
|
|
return;
|
|
}
|
|
if (!m_canCommand)
|
|
{
|
|
Console.Error.WriteLine(
|
|
"Read-only mode: the client discovered and decoded the target, but did not submit an " +
|
|
"intent because command authority was not granted.");
|
|
return;
|
|
}
|
|
LinearMoveIntentDataType intent = RobotIntentBuilder
|
|
.LinearMove(pose, 0.35).CartesianSpeed(0.20).Exact().Build();
|
|
IntentSubmissionResult submission = await m_controller.TrySubmitIntentAsync(intent, cancellationToken)
|
|
.ConfigureAwait(false);
|
|
if (!submission.Accepted)
|
|
{
|
|
PrintRefusal(submission.Failure, submission.Message);
|
|
LogPickRefused(m_logger, target.PrimPath, submission.Failure, submission.Message.Text ?? string.Empty);
|
|
return;
|
|
}
|
|
|
|
Console.Error.WriteLine($"Intent admitted: {submission.IntentId}; operation {submission.Operation}.");
|
|
LogPickSubmitted(m_logger, target.PrimPath, submission.IntentId);
|
|
IntentOperationHandle handle = await m_controller.TrackOperationAsync(
|
|
submission.IntentId, submission.Operation, cancellationToken).ConfigureAwait(false);
|
|
await using (handle.ConfigureAwait(false))
|
|
{
|
|
handle.Changed += PrintSnapshot;
|
|
using var cancelWatchCts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
|
|
Task cancelTask = WatchForCancelKeyAsync(handle, cancelWatchCts.Token);
|
|
IntentResultDataType result = await handle.Completion
|
|
.WaitAsync(cancellationToken).ConfigureAwait(false);
|
|
await cancelWatchCts.CancelAsync().ConfigureAwait(false);
|
|
await ObserveCancelWatchAsync(cancelTask).ConfigureAwait(false);
|
|
Console.Error.WriteLine("Operation terminal result:");
|
|
PrintResult(result);
|
|
LogPickCompleted(m_logger, submission.IntentId, handle.Current.ExecutionState);
|
|
}
|
|
}
|
|
|
|
private static async Task ObserveCancelWatchAsync(Task task)
|
|
{
|
|
try
|
|
{
|
|
await task.ConfigureAwait(false);
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
}
|
|
}
|
|
|
|
private static async Task WatchForCancelKeyAsync(
|
|
IntentOperationHandle handle,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
if (Console.IsInputRedirected)
|
|
{
|
|
return;
|
|
}
|
|
Console.Error.WriteLine("Press C while the robot is moving to request CancelIntent.");
|
|
while (!cancellationToken.IsCancellationRequested)
|
|
{
|
|
await Task.Delay(100, cancellationToken).ConfigureAwait(false);
|
|
if (!Console.KeyAvailable)
|
|
{
|
|
continue;
|
|
}
|
|
ConsoleKeyInfo key = Console.ReadKey(intercept: true);
|
|
if (key.Key != ConsoleKey.C)
|
|
{
|
|
continue;
|
|
}
|
|
IntentCommandOutcome outcome = await handle.CancelAsync(StopModeEnum.ProcessStop, cancellationToken)
|
|
.ConfigureAwait(false);
|
|
if (outcome.Accepted)
|
|
{
|
|
Console.Error.WriteLine(
|
|
"CancelIntent accepted. Waiting for ExecutionState=Cancelled; " +
|
|
"Cancelling is not terminal motion.");
|
|
}
|
|
else
|
|
{
|
|
Console.Error.WriteLine("CancelIntent refused by the server; continuing to observe the operation.");
|
|
}
|
|
return;
|
|
}
|
|
}
|
|
|
|
private static void PrintSnapshot(IntentOperationSnapshot snapshot)
|
|
{
|
|
string pose = FormatPose(snapshot.CurrentPose);
|
|
Console.Error.WriteLine(string.Format(
|
|
CultureInfo.InvariantCulture,
|
|
"State={0}; progress={1:0.0}%; pose={2}",
|
|
snapshot.ExecutionState,
|
|
snapshot.Progress,
|
|
pose));
|
|
if (snapshot.ExecutionState == ExecutionStateEnum.Cancelling)
|
|
{
|
|
Console.Error.WriteLine("ExecutionState=Cancelling is still in motion; waiting for Cancelled.");
|
|
}
|
|
}
|
|
|
|
private static void PrintResult(IntentResultDataType result)
|
|
{
|
|
Console.Error.WriteLine($" Failure: {result.Failure}");
|
|
Console.Error.WriteLine($" Message: {result.Message.Text}");
|
|
if (result.HasAchievedPose)
|
|
{
|
|
Console.Error.WriteLine($" AchievedPose: {FormatPose(result.AchievedPose)}");
|
|
}
|
|
}
|
|
|
|
private static void PrintRefusal(IntentFailureEnum failure, LocalizedText message)
|
|
{
|
|
Console.Error.WriteLine($"Intent refused: {failure} - {message.Text}");
|
|
string action = failure switch
|
|
{
|
|
IntentFailureEnum.SafetyStop or IntentFailureEnum.SafetyLimitExceeded =>
|
|
"Safety system refused the motion; this client observed that decision and will not override it.",
|
|
IntentFailureEnum.ControlNotOwned =>
|
|
"Retry after obtaining command authority or ask the current operator to release control.",
|
|
IntentFailureEnum.CapabilityNotSupported =>
|
|
"Re-plan with an intent the controller capability declaration accepts.",
|
|
IntentFailureEnum.ParameterInvalid =>
|
|
"Re-plan with slower or less restrictive motion constraints.",
|
|
IntentFailureEnum.QueueFull =>
|
|
"Retry after the controller drains its queue.",
|
|
_ =>
|
|
"Escalate to the operator with the server's refusal message."
|
|
};
|
|
Console.Error.WriteLine($"Decision: {action}");
|
|
}
|
|
|
|
private static string FormatPose(Pose3DDataType pose)
|
|
{
|
|
string frame = string.IsNullOrEmpty(pose.FrameId) ? "<default>" : pose.FrameId;
|
|
if (pose.Position.Count < 3)
|
|
{
|
|
return $"frame={frame}; position=<unavailable>";
|
|
}
|
|
return FormattableString.Invariant(
|
|
$"frame={frame}; x={pose.Position[0]:0.###}, y={pose.Position[1]:0.###}, z={pose.Position[2]:0.###}");
|
|
}
|
|
|
|
[LoggerMessage(EventId = IntentViewerClientEventIds.PickSubmitted, Level = LogLevel.Information,
|
|
Message = "Submitted pick {PrimPath} as intent {IntentId}.")]
|
|
private static partial void LogPickSubmitted(ILogger logger, string primPath, string intentId);
|
|
|
|
[LoggerMessage(EventId = IntentViewerClientEventIds.PickCompleted, Level = LogLevel.Information,
|
|
Message = "Intent {IntentId} completed in state {ExecutionState}.")]
|
|
private static partial void LogPickCompleted(
|
|
ILogger logger,
|
|
string intentId,
|
|
ExecutionStateEnum executionState);
|
|
|
|
[LoggerMessage(EventId = IntentViewerClientEventIds.PickRefused, Level = LogLevel.Warning,
|
|
Message = "Pick {PrimPath} was refused with {Failure}: {Message}.")]
|
|
private static partial void LogPickRefused(
|
|
ILogger logger,
|
|
string primPath,
|
|
IntentFailureEnum failure,
|
|
string message);
|
|
|
|
private readonly RobotIntentControllerClient m_controller;
|
|
private readonly ISession m_session;
|
|
private readonly IReadOnlyList<TargetLocation> m_targets;
|
|
private readonly ILogger m_logger;
|
|
private readonly bool m_canCommand;
|
|
private readonly SemaphoreSlim m_pickGate = new(1, 1);
|
|
}
|
|
}
|