mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-18 22:55:08 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
283 lines
11 KiB
C#
283 lines
11 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using BenchmarkDotNet.Attributes;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Client.TestFramework;
|
|
using Opc.Ua.Server.TestFramework;
|
|
using Quickstarts.ReferenceServer;
|
|
|
|
namespace Opc.Ua.Client.ComplexTypes.Tests
|
|
{
|
|
/// <summary>
|
|
/// Data dictionary load tests
|
|
/// </summary>
|
|
public class DataDictionaryTests : ClientTestFramework
|
|
{
|
|
public const int MaxByteStringLengthForTest = 4096;
|
|
|
|
public DataDictionaryTests()
|
|
: base(Utils.UriSchemeOpcTcp)
|
|
{
|
|
}
|
|
|
|
public DataDictionaryTests(string uriScheme = Utils.UriSchemeOpcTcp)
|
|
: base(uriScheme)
|
|
{
|
|
}
|
|
|
|
/// <summary>
|
|
/// Set up a Server and a Client instance.
|
|
/// </summary>
|
|
[OneTimeSetUp]
|
|
public override Task OneTimeSetUpAsync()
|
|
{
|
|
SupportsExternalServerUrl = true;
|
|
return base.OneTimeSetUpAsync();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tear down the Server and the Client.
|
|
/// </summary>
|
|
[OneTimeTearDown]
|
|
public override Task OneTimeTearDownAsync()
|
|
{
|
|
return base.OneTimeTearDownAsync();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Test setup.
|
|
/// </summary>
|
|
[SetUp]
|
|
public override Task SetUpAsync()
|
|
{
|
|
return base.SetUpAsync();
|
|
}
|
|
|
|
public override async Task CreateReferenceServerFixtureAsync(
|
|
bool enableTracing,
|
|
bool disableActivityLogging,
|
|
bool securityNone)
|
|
{
|
|
// start Ref server
|
|
ServerFixture = new ServerFixture<ReferenceServer>(
|
|
t => new ReferenceServer(t),
|
|
enableTracing,
|
|
disableActivityLogging)
|
|
{
|
|
UriScheme = UriScheme,
|
|
SecurityNone = securityNone,
|
|
AutoAccept = true,
|
|
AllNodeManagers = true,
|
|
OperationLimits = true
|
|
};
|
|
|
|
await ServerFixture.LoadConfigurationAsync(PkiRoot).ConfigureAwait(false);
|
|
ServerFixture.Config.TransportQuotas!.MaxMessageSize = TransportQuotaMaxMessageSize;
|
|
ServerFixture.Config.TransportQuotas.MaxByteStringLength = MaxByteStringLengthForTest;
|
|
ServerFixture.Config.TransportQuotas.MaxStringLength = TransportQuotaMaxStringLength;
|
|
ServerFixture.Config.ServerConfiguration!.UserTokenPolicies +=
|
|
new UserTokenPolicy(UserTokenType.UserName);
|
|
ServerFixture.Config.ServerConfiguration.UserTokenPolicies +=
|
|
new UserTokenPolicy(UserTokenType.Certificate);
|
|
ServerFixture.Config.ServerConfiguration.UserTokenPolicies +=
|
|
new UserTokenPolicy(UserTokenType.IssuedToken)
|
|
{
|
|
IssuedTokenType = Profiles.JwtUserToken
|
|
};
|
|
|
|
ReferenceServer = await ServerFixture.StartAsync()
|
|
.ConfigureAwait(false);
|
|
ReferenceServer.TokenValidator = TokenValidator;
|
|
ServerFixturePort = ServerFixture.Port;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Test teardown.
|
|
/// </summary>
|
|
[TearDown]
|
|
public override Task TearDownAsync()
|
|
{
|
|
return base.TearDownAsync();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Global Setup for benchmarks.
|
|
/// </summary>
|
|
[GlobalSetup]
|
|
public override void GlobalSetup()
|
|
{
|
|
base.GlobalSetup();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Global cleanup for benchmarks.
|
|
/// </summary>
|
|
[GlobalCleanup]
|
|
public override void GlobalCleanup()
|
|
{
|
|
base.GlobalCleanup();
|
|
}
|
|
|
|
[Test]
|
|
[Order(100)]
|
|
public async Task ReadDictionaryByteStringAsync()
|
|
{
|
|
var dictionaryIds = new List<NodeId> {
|
|
VariableIds.OpcUa_BinarySchema,
|
|
await GetTestDataDictionaryNodeIdAsync().ConfigureAwait(false) };
|
|
|
|
ISession theSession = Session;
|
|
|
|
foreach (NodeId dataDictionaryId in dictionaryIds)
|
|
{
|
|
var referenceDescription = new ReferenceDescription
|
|
{
|
|
NodeId = NodeId.ToExpandedNodeId(
|
|
dataDictionaryId,
|
|
theSession.NodeCache.NamespaceUris)
|
|
};
|
|
|
|
// make sure the dictionary is too large to fit in a single message
|
|
var readValueId = new ReadValueId
|
|
{
|
|
NodeId = dataDictionaryId,
|
|
AttributeId = Attributes.Value,
|
|
IndexRange = null,
|
|
DataEncoding = default
|
|
};
|
|
|
|
ArrayOf<ReadValueId> nodesToRead = [readValueId];
|
|
|
|
ServiceResultException x = Assert.ThrowsAsync<ServiceResultException>(async () =>
|
|
await theSession.ReadAsync(
|
|
null,
|
|
0,
|
|
TimestampsToReturn.Neither,
|
|
nodesToRead,
|
|
default).ConfigureAwait(false));
|
|
|
|
Assert.That(x.StatusCode, Is.EqualTo(StatusCodes.BadEncodingLimitsExceeded));
|
|
|
|
// now ensure we get the dictionary in chunks
|
|
DataDictionary dictionary = await LoadDataDictionaryAsync(
|
|
theSession,
|
|
referenceDescription).ConfigureAwait(false);
|
|
Assert.That(dictionary, Is.Not.Null);
|
|
|
|
// Sanity checks: verify that some well-known information is present
|
|
Assert.That(dictionary.TypeSystemName, Is.EqualTo("OPC Binary"));
|
|
|
|
if (dataDictionaryId == dictionaryIds[0])
|
|
{
|
|
Assert.That(dictionary.DataTypes, Has.Count.GreaterThan(160));
|
|
Assert.That(
|
|
dictionary.DataTypes.ContainsKey(VariableIds.OpcUa_BinarySchema_Union),
|
|
Is.True);
|
|
Assert.That(
|
|
dictionary.DataTypes.ContainsKey(VariableIds.OpcUa_BinarySchema_OptionSet),
|
|
Is.True);
|
|
Assert.That(
|
|
dictionary.TypeDictionary!.TargetNamespace,
|
|
Is.EqualTo("http://opcfoundation.org/UA/"));
|
|
}
|
|
else if (dataDictionaryId == dictionaryIds[1])
|
|
{
|
|
Assert.That(dictionary.DataTypes, Has.Count.GreaterThanOrEqualTo(10));
|
|
Assert.That(
|
|
dictionary.TypeDictionary!.TargetNamespace,
|
|
Is.EqualTo("http://test.org/UA/Data/"));
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Load the data dictionary from the server.
|
|
/// </summary>
|
|
private Task<DataDictionary> LoadDataDictionaryAsync(
|
|
ISession session,
|
|
ReferenceDescription dictionaryNode,
|
|
CancellationToken ct = default)
|
|
{
|
|
// check if the dictionary has already been loaded.
|
|
var dictionaryId = ExpandedNodeId.ToNodeId(
|
|
dictionaryNode.NodeId,
|
|
session.NamespaceUris);
|
|
|
|
var nodeCacheResolver = new NodeCacheResolver(session, Telemetry);
|
|
|
|
// load the dictionary.
|
|
return nodeCacheResolver.LoadDictionaryAsync(dictionaryId, dictionaryNode.ToString(), ct);
|
|
}
|
|
|
|
/// <summary>
|
|
/// retrieve the node id of the test data dictionary without relying on
|
|
/// hard coded identifiers
|
|
/// </summary>
|
|
/// <exception cref="InvalidOperationException"></exception>
|
|
private async Task<NodeId> GetTestDataDictionaryNodeIdAsync(CancellationToken ct = default)
|
|
{
|
|
var browseDescription = new BrowseDescription
|
|
{
|
|
NodeId = ObjectIds.OPCBinarySchema_TypeSystem,
|
|
BrowseDirection = BrowseDirection.Forward,
|
|
ReferenceTypeId = ReferenceTypeIds.HasComponent,
|
|
IncludeSubtypes = true,
|
|
NodeClassMask = (uint)NodeClass.Variable,
|
|
ResultMask = (uint)BrowseResultMask.All
|
|
};
|
|
ArrayOf<BrowseDescription> browseDescriptions = [browseDescription];
|
|
|
|
Assert.That(Session, Is.Not.Null, "Client not connected to Server.");
|
|
BrowseResponse response = await Session.BrowseAsync(
|
|
null,
|
|
null,
|
|
0,
|
|
browseDescriptions,
|
|
ct).ConfigureAwait(false);
|
|
|
|
ArrayOf<BrowseResult> results = response.Results;
|
|
ArrayOf<DiagnosticInfo> diagnosticInfos = response.DiagnosticInfos;
|
|
|
|
if (results[0] == null || results[0].StatusCode != StatusCodes.Good)
|
|
{
|
|
throw new InvalidOperationException("cannot read the id of the test dictionary");
|
|
}
|
|
ReferenceDescription referenceDescription = results[0]
|
|
.References.Find(a => a.BrowseName.Name == "TestData");
|
|
Assert.That(referenceDescription, Is.Not.Null, "cannot find the test dictionary node");
|
|
return ExpandedNodeId.ToNodeId(referenceDescription.NodeId, Session.NamespaceUris);
|
|
}
|
|
}
|
|
}
|