Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

375 lines
14 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading;
using System.Xml;
using NUnit.Framework;
using Opc.Ua.Core.TestFramework;
using Opc.Ua.Test;
using ComplexStructure = Opc.Ua.Encoders.Structure;
namespace Opc.Ua.Client.ComplexTypes.Tests
{
/// <summary>
/// Namespace constants for the default complex type tests.
/// </summary>
public static class Namespaces
{
/// <summary>
/// The URI for the OpcUa namespace.
/// </summary>
public const string OpcUa = "http://opcfoundation.org/UA/";
/// <summary>
/// The URI for the OpcUaXsd namespace.
/// </summary>
public const string OpcUaXsd = "http://opcfoundation.org/UA/2008/02/Types.xsd";
/// <summary>
/// The URI for the test encoder namespace.
/// </summary>
public const string OpcUaEncoderTests = "http://opcfoundation.org/UA/DefaultComplexTypeTests/";
}
/// <summary>
/// Common base class for default complex type tests.
/// Uses DefaultComplexTypeFactory/Builder instead of Reflection.Emit.
/// </summary>
public abstract class DefaultComplexTypesCommon : EncoderCommon
{
protected DefaultComplexTypeFactory m_factory;
protected IComplexTypeBuilder m_complexTypeBuilder;
protected int m_nodeIdCount;
[OneTimeSetUp]
protected new void OneTimeSetUp()
{
m_nodeIdCount = 0;
m_factory = new DefaultComplexTypeFactory();
m_complexTypeBuilder = m_factory.Create(
Namespaces.OpcUaEncoderTests,
3,
"DefaultTests");
}
[OneTimeTearDown]
protected new void OneTimeTearDown()
{
}
[SetUp]
protected new void SetUp()
{
}
[TearDown]
protected new void TearDown()
{
}
/// <summary>
/// Parameter class for structure field tests.
/// </summary>
public class StructureFieldParameter : IFormattable
{
public StructureFieldParameter(StructureField structureField)
{
Name = structureField.Name!;
BuiltInType = TypeInfo.GetBuiltInType(structureField.DataType);
}
public string Name { get; set; } = null!;
public BuiltInType BuiltInType { get; set; }
public string ToString(string? format, IFormatProvider? formatProvider)
{
return Name;
}
}
[DatapointSource]
public StructureType[] StructureTypes =
#if NET8_0_OR_GREATER
Enum.GetValues<StructureType>();
#else
(StructureType[])Enum.GetValues(typeof(StructureType));
#endif
[DatapointSource]
public StructureFieldParameter[] StructureField =
[
.. GetAllBuiltInTypesFields().Select(s => new StructureFieldParameter(s))
];
internal IEncodeableType BuildComplexTypeWithAllBuiltInTypes(
StructureType structureType,
string testFunc)
{
return BuildComplexTypeWithAllBuiltInTypes(null!, structureType, testFunc, out _);
}
/// <summary>
/// Builds a complex type with all BuiltInTypes as properties
/// using the DefaultComplexTypeBuilder.
/// </summary>
private IEncodeableType BuildComplexTypeWithAllBuiltInTypes(
IServiceMessageContext context,
StructureType structureType,
string testFunc,
out ExpandedNodeId nodeId)
{
uint typeId = (uint)Interlocked.Add(ref m_nodeIdCount, 100);
var complexTypeStructure = new StructureDefinition
{
BaseDataType = structureType == StructureType.Union
? DataTypeIds.Union
: DataTypeIds.Structure,
DefaultEncodingId = default,
Fields = GetAllBuiltInTypesFields(),
StructureType = structureType
};
IComplexTypeFieldBuilder fieldBuilder = m_complexTypeBuilder.AddStructuredType(
QualifiedName.From(structureType + "." + testFunc),
complexTypeStructure);
nodeId = new ExpandedNodeId(typeId++, m_complexTypeBuilder.TargetNamespace);
var binaryEncodingId = new ExpandedNodeId(
typeId++,
m_complexTypeBuilder.TargetNamespace);
var xmlEncodingId = new ExpandedNodeId(typeId++, m_complexTypeBuilder.TargetNamespace);
fieldBuilder.AddTypeIdAttribute(nodeId, binaryEncodingId, xmlEncodingId);
int i = 1;
foreach (StructureField field in complexTypeStructure.Fields)
{
IType fieldType = TypeInfo.GetSystemType(field.DataType, null!)!;
field.IsOptional = structureType == StructureType.StructureWithOptionalFields;
fieldBuilder.AddField(field, fieldType, i++, false);
}
IEncodeableType complexType = fieldBuilder.CreateType();
if (context != null)
{
context.Factory.Builder.AddEncodeableType(nodeId, complexType).Commit();
context.Factory.Builder.AddEncodeableType(binaryEncodingId, complexType).Commit();
context.Factory.Builder.AddEncodeableType(xmlEncodingId, complexType).Commit();
}
return complexType;
}
/// <summary>
/// Return a collection of fields with BuiltInTypes.
/// </summary>
private static List<StructureField> GetAllBuiltInTypesFields()
{
var collection = new List<StructureField>();
foreach (BuiltInType builtInType in BuiltInTypes)
{
if (builtInType
is BuiltInType.Null
or BuiltInType.Variant
or BuiltInType.DataValue
or BuiltInType.ExtensionObject
or >= BuiltInType.Number)
{
continue;
}
collection.Add(
new StructureField
{
Name = builtInType.ToString(),
DataType = new NodeId((uint)builtInType),
ArrayDimensions = default,
Description = LocalizedText.From($"A BuiltInType.{builtInType} property."),
IsOptional = false,
MaxStringLength = 0,
ValueRank = -1
});
}
return collection;
}
/// <summary>
/// Create complex types for all structure types and register them.
/// </summary>
internal void CreateComplexTypes(
IServiceMessageContext context,
Dictionary<StructureType, (ExpandedNodeId, IEncodeableType)> dict,
string nameExtension)
{
foreach (StructureType structureType in StructureTypes)
{
IEncodeableType encodeableType = BuildComplexTypeWithAllBuiltInTypes(
context,
structureType,
nameof(CreateComplexTypes) + nameExtension,
out ExpandedNodeId nodeId);
dict[structureType] = (nodeId, encodeableType);
}
}
/// <summary>
/// Helper to fill a Structure-based type with default or random values.
/// </summary>
internal void FillStructWithValues(
ComplexStructure structType,
bool randomValues,
NamespaceTable namespaceUris)
{
int index = 0;
foreach (IStructureField property in structType.GetFields())
{
BuiltInType builtInType = property.TypeInfo.BuiltInType;
Variant newObj = randomValues
? DataGenerator.GetRandomVariant(builtInType, !property.TypeInfo.IsScalar)
: Variant.CreateDefault(TypeInfo.Create(builtInType, property.TypeInfo.ValueRank));
if (newObj.IsNull)
{
switch (builtInType)
{
case BuiltInType.XmlElement:
var doc = new XmlDocument();
newObj = Variant.From(XmlElement.From(doc.CreateElement("name")));
break;
case BuiltInType.ByteString:
newObj = Variant.From(ByteString.From([1, 2, 3]));
break;
case BuiltInType.String:
newObj = Variant.From("This is a test");
break;
case BuiltInType.ExtensionObject:
newObj = Variant.From(ExtensionObject.Null);
break;
default:
newObj = Variant.CreateDefault(property.TypeInfo);
break;
}
}
structType[property.Name!] = newObj;
Assert.That(newObj, Is.EqualTo(structType[property.Name!]));
Assert.That(newObj, Is.EqualTo(structType[index]));
index++;
}
}
/// <summary>
/// Encode and decode a default complex type, verify the result.
/// </summary>
protected void EncodeDecodeComplexType(
IServiceMessageContext encoderContext,
MemoryStreamType memoryStreamType,
EncodingType encoderType,
JsonEncodingType jsonEncodingType,
bool useXmlParser,
StructureType structureType,
ExpandedNodeId nodeId,
IEncodeable data)
{
string encodeInfo = $"Encoder: {encoderType} Type:{structureType}";
TestOutput.WriteLine(encodeInfo);
TestOutput.WriteLine(data);
ExtensionObject expected = CreateExtensionObject(structureType, nodeId, data);
Assert.That(expected.IsNull, Is.False, "Expected DataValue is Null, " + encodeInfo);
TestOutput.WriteLine("Expected:");
TestOutput.WriteLine(expected);
byte[] buffer;
using (MemoryStream encoderStream = CreateEncoderMemoryStream(memoryStreamType))
{
using (
IEncoder encoder = CreateEncoder(
encoderType,
encoderContext,
encoderStream,
typeof(DataValue),
jsonEncodingType))
{
encoder.WriteExtensionObject("ExtensionObject", expected);
}
buffer = encoderStream.ToArray();
}
switch (encoderType)
{
case EncodingType.Binary:
TestOutput.WriteLine(PrettifyAndValidateBinary(buffer));
break;
case EncodingType.Json:
TestOutput.WriteLine(PrettifyAndValidateJson(buffer));
break;
case EncodingType.Xml:
TestOutput.WriteLine(PrettifyAndValidateXml(buffer));
break;
}
using var decoderStream = new MemoryStream(buffer);
using IDecoder decoder = CreateDecoder(
encoderType,
useXmlParser,
encoderContext,
decoderStream,
typeof(DataValue));
ExtensionObject result = decoder.ReadExtensionObject("ExtensionObject");
TestOutput.WriteLine("Result:");
TestOutput.WriteLine(result);
Assert.That(result.IsNull, Is.False, "Resulting DataValue is Null, " + encodeInfo);
Assert.That(result.Encoding, Is.EqualTo(expected.Encoding), encodeInfo);
Assert.That(result, Is.EqualTo(expected),
$"Failed to compare expected and result.\r\n{encodeInfo}.\r\n{expected}\r\n!=\r\n{result}.");
}
/// <summary>
/// Create an ExtensionObject for a complex type.
/// </summary>
/// <exception cref="ArgumentException"></exception>
protected ExtensionObject CreateExtensionObject(
StructureType structureType,
ExpandedNodeId nodeId,
object data)
{
switch (data)
{
case ByteString b:
return new ExtensionObject(nodeId, b);
case XmlElement x:
return new ExtensionObject(nodeId, x);
case IEncodeable e:
return new ExtensionObject(nodeId, e, true);
default:
throw new ArgumentException(
$"Unsupported data type {data.GetType()}" +
$" for structure type {structureType}.");
}
}
}
}