mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-18 14:43:08 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
367 lines
14 KiB
C#
367 lines
14 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.IO;
|
|
using System.Xml;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
using OptionSetEncoder = Opc.Ua.Encoders.OptionSet;
|
|
|
|
namespace Opc.Ua.Client.ComplexTypes.Tests
|
|
{
|
|
/// <summary>
|
|
/// Tests for the OptionSet type created by DefaultComplexTypeBuilder.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("DefaultComplexTypes")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public class DefaultOptionSetTests
|
|
{
|
|
private const ushort kNamespaceIndex = 3;
|
|
private const string kTypeNamespace = Namespaces.OpcUaEncoderTests;
|
|
|
|
private static readonly ExpandedNodeId s_typeId =
|
|
new(1001u, kTypeNamespace);
|
|
|
|
private static readonly ExpandedNodeId s_binaryId =
|
|
new(1002u, kTypeNamespace);
|
|
|
|
private static readonly ExpandedNodeId s_xmlId =
|
|
new(1003u, kTypeNamespace);
|
|
|
|
private DefaultComplexTypeFactory m_factory;
|
|
private IComplexTypeBuilder m_builder;
|
|
|
|
[OneTimeSetUp]
|
|
public void OneTimeSetUp()
|
|
{
|
|
m_factory = new DefaultComplexTypeFactory();
|
|
m_builder = m_factory.Create(
|
|
kTypeNamespace,
|
|
kNamespaceIndex,
|
|
"OptionSetTests");
|
|
}
|
|
|
|
private static EnumDefinition CreateAccessRightsDefinition()
|
|
{
|
|
return new EnumDefinition
|
|
{
|
|
IsOptionSet = true,
|
|
Fields =
|
|
[
|
|
new EnumField { Name = "CurrentRead", Value = 0 },
|
|
new EnumField { Name = "CurrentWrite", Value = 1 },
|
|
new EnumField { Name = "HistoryRead", Value = 2 },
|
|
new EnumField { Name = "HistoryWrite", Value = 3 }
|
|
]
|
|
};
|
|
}
|
|
|
|
[Test]
|
|
public void AddOptionSetTypeReturnsRegisterableType()
|
|
{
|
|
EnumDefinition definition = CreateAccessRightsDefinition();
|
|
|
|
IEncodeableType encodeableType = m_builder.AddOptionSetType(
|
|
QualifiedName.From("AccessRights"),
|
|
s_typeId,
|
|
s_binaryId,
|
|
s_xmlId,
|
|
definition);
|
|
|
|
Assert.That(encodeableType, Is.Not.Null);
|
|
Assert.That(encodeableType.Type, Is.EqualTo(typeof(OptionSetEncoder)));
|
|
Assert.That(
|
|
encodeableType.XmlName,
|
|
Is.EqualTo(new XmlQualifiedName("AccessRights", kTypeNamespace)));
|
|
|
|
IEncodeable instance = encodeableType.CreateInstance();
|
|
Assert.That(instance, Is.InstanceOf<OptionSetEncoder>());
|
|
var optionSet = (OptionSetEncoder)instance;
|
|
Assert.That(optionSet.TypeId, Is.EqualTo(s_typeId));
|
|
Assert.That(optionSet.BinaryEncodingId, Is.EqualTo(s_binaryId));
|
|
Assert.That(optionSet.XmlEncodingId, Is.EqualTo(s_xmlId));
|
|
Assert.That(optionSet.Definition, Is.SameAs(definition));
|
|
Assert.That(optionSet.Value.IsEmpty, Is.True);
|
|
Assert.That(optionSet.ValidBits.IsEmpty, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void BitAccessorsByNameSetValueAndValidBits()
|
|
{
|
|
EnumDefinition definition = CreateAccessRightsDefinition();
|
|
var optionSet = new OptionSetEncoder(
|
|
new XmlQualifiedName("AccessRights", kTypeNamespace),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
definition);
|
|
|
|
optionSet["CurrentRead"] = true;
|
|
optionSet["HistoryWrite"] = true;
|
|
|
|
Assert.That(optionSet["CurrentRead"], Is.True);
|
|
Assert.That(optionSet["CurrentWrite"], Is.False);
|
|
Assert.That(optionSet["HistoryRead"], Is.False);
|
|
Assert.That(optionSet["HistoryWrite"], Is.True);
|
|
|
|
// Value bits 0 and 3 set => 0b1001 = 0x09
|
|
Assert.That(optionSet.Value.Span.ToArray(), Is.EqualTo("\t"u8.ToArray()));
|
|
// ValidBits mirror any Set bit
|
|
Assert.That(optionSet.ValidBits.Span.ToArray(), Is.EqualTo("\t"u8.ToArray()));
|
|
|
|
Assert.That(
|
|
optionSet.GetSetFieldNames(),
|
|
Is.EqualTo(["CurrentRead", "HistoryWrite"]));
|
|
}
|
|
|
|
[Test]
|
|
public void BitAccessorByIndexOutsideValueIsFalse()
|
|
{
|
|
EnumDefinition definition = CreateAccessRightsDefinition();
|
|
var optionSet = new OptionSetEncoder(
|
|
new XmlQualifiedName("AccessRights", kTypeNamespace),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
definition);
|
|
|
|
Assert.That(optionSet[0], Is.False);
|
|
Assert.That(optionSet[63], Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void BinaryRoundTripPreservesValueAndValidBits()
|
|
{
|
|
EnumDefinition definition = CreateAccessRightsDefinition();
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
var context = ServiceMessageContext.Create(telemetry);
|
|
context.NamespaceUris.GetIndexOrAppend(kTypeNamespace);
|
|
|
|
// Register the type for decode via the factory.
|
|
IEncodeableType type = m_builder.AddOptionSetType(
|
|
QualifiedName.From("AccessRights"),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
definition);
|
|
context.Factory.Builder
|
|
.AddEncodeableType(s_binaryId, type)
|
|
.AddEncodeableType(s_typeId, type)
|
|
.AddEncodeableType(type)
|
|
.Commit();
|
|
|
|
var source = (OptionSetEncoder)type.CreateInstance();
|
|
source["CurrentWrite"] = true;
|
|
source["HistoryRead"] = true;
|
|
|
|
byte[] buffer;
|
|
using (var stream = new MemoryStream())
|
|
using (var encoder = new BinaryEncoder(stream, context, false))
|
|
{
|
|
encoder.WriteExtensionObject("os", new ExtensionObject(source, true));
|
|
buffer = stream.ToArray();
|
|
}
|
|
|
|
OptionSetEncoder decoded;
|
|
using (var stream = new MemoryStream(buffer))
|
|
using (var decoder = new BinaryDecoder(stream, context))
|
|
{
|
|
ExtensionObject eo = decoder.ReadExtensionObject("os");
|
|
Assert.That(eo.IsNull, Is.False);
|
|
Assert.That(eo.TryGetValue(out IEncodeable? body), Is.True);
|
|
decoded = (body as OptionSetEncoder)!;
|
|
Assert.That(decoded, Is.Not.Null, "Decoded body is not an OptionSet.");
|
|
}
|
|
|
|
Assert.That(decoded.Value.Span.ToArray(),
|
|
Is.EqualTo(source.Value.Span.ToArray()));
|
|
Assert.That(decoded.ValidBits.Span.ToArray(),
|
|
Is.EqualTo(source.ValidBits.Span.ToArray()));
|
|
Assert.That(decoded["CurrentWrite"], Is.True);
|
|
Assert.That(decoded["HistoryRead"], Is.True);
|
|
Assert.That(decoded["CurrentRead"], Is.False);
|
|
Assert.That(decoded["HistoryWrite"], Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void WireFormatDecodesHandcraftedBytes()
|
|
{
|
|
EnumDefinition definition = CreateAccessRightsDefinition();
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
var context = ServiceMessageContext.Create(telemetry);
|
|
context.NamespaceUris.GetIndexOrAppend(kTypeNamespace);
|
|
|
|
IEncodeableType type = m_builder.AddOptionSetType(
|
|
QualifiedName.From("AccessRights"),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
definition);
|
|
context.Factory.Builder
|
|
.AddEncodeableType(s_binaryId, type)
|
|
.AddEncodeableType(s_typeId, type)
|
|
.AddEncodeableType(type)
|
|
.Commit();
|
|
|
|
// Build a body matching Part 6 encoding:
|
|
// Value : ByteString [0x03]
|
|
// ValidBits : ByteString [0x03]
|
|
byte[] body;
|
|
using (var bodyStream = new MemoryStream())
|
|
using (var bodyEncoder = new BinaryEncoder(bodyStream, context, false))
|
|
{
|
|
bodyEncoder.WriteByteString(null, new byte[] { 0x03 });
|
|
bodyEncoder.WriteByteString(null, new byte[] { 0x03 });
|
|
body = bodyStream.ToArray();
|
|
}
|
|
|
|
var eo = new ExtensionObject(s_binaryId, ByteString.From(body));
|
|
byte[] buffer;
|
|
using (var stream = new MemoryStream())
|
|
using (var encoder = new BinaryEncoder(stream, context, false))
|
|
{
|
|
encoder.WriteExtensionObject("os", eo);
|
|
buffer = stream.ToArray();
|
|
}
|
|
|
|
using var decodeStream = new MemoryStream(buffer);
|
|
using var decoder = new BinaryDecoder(decodeStream, context);
|
|
ExtensionObject decodedEo = decoder.ReadExtensionObject("os");
|
|
Assert.That(decodedEo.TryGetValue(out IEncodeable? decodedBody), Is.True);
|
|
var decoded = decodedBody as OptionSetEncoder;
|
|
Assert.That(decoded, Is.Not.Null);
|
|
Assert.That(decoded[0], Is.True);
|
|
Assert.That(decoded[1], Is.True);
|
|
Assert.That(decoded[2], Is.False);
|
|
Assert.That(
|
|
decoded.GetSetFieldNames(),
|
|
Is.EqualTo(["CurrentRead", "CurrentWrite"]));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateInstanceProducesFreshInstance()
|
|
{
|
|
EnumDefinition definition = CreateAccessRightsDefinition();
|
|
IEncodeableType type = m_builder.AddOptionSetType(
|
|
QualifiedName.From("AccessRights"),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
definition);
|
|
|
|
var a = (OptionSetEncoder)type.CreateInstance();
|
|
a["CurrentRead"] = true;
|
|
var b = (OptionSetEncoder)type.CreateInstance();
|
|
|
|
Assert.That(b.Value.IsEmpty, Is.True);
|
|
Assert.That(b.ValidBits.IsEmpty, Is.True);
|
|
Assert.That(a.Definition, Is.SameAs(b.Definition));
|
|
}
|
|
|
|
[Test]
|
|
public void CloneProducesIndependentCopy()
|
|
{
|
|
EnumDefinition definition = CreateAccessRightsDefinition();
|
|
var optionSet = new OptionSetEncoder(
|
|
new XmlQualifiedName("AccessRights", kTypeNamespace),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
definition);
|
|
optionSet["HistoryRead"] = true;
|
|
|
|
var clone = (OptionSetEncoder)optionSet.Clone();
|
|
Assert.That(clone, Is.Not.SameAs(optionSet));
|
|
Assert.That(clone["HistoryRead"], Is.True);
|
|
|
|
clone["CurrentRead"] = true;
|
|
Assert.That(optionSet["CurrentRead"], Is.False,
|
|
"Mutating the clone must not affect the source.");
|
|
}
|
|
|
|
[Test]
|
|
public void ByteLengthIsDerivedFromHighestBit()
|
|
{
|
|
// Bits 0..3 => ceil(4 / 8) = 1 byte.
|
|
var oneByte = new OptionSetEncoder(
|
|
new XmlQualifiedName("AccessRights", kTypeNamespace),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
CreateAccessRightsDefinition());
|
|
Assert.That(oneByte.ByteLength, Is.EqualTo(1));
|
|
|
|
// Bit 10 => ceil(11 / 8) = 2 bytes.
|
|
var twoBytes = new OptionSetEncoder(
|
|
new XmlQualifiedName("TwoByteOptionSet", kTypeNamespace),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
new EnumDefinition
|
|
{
|
|
IsOptionSet = true,
|
|
Fields =
|
|
[
|
|
new EnumField { Name = "Bit0", Value = 0 },
|
|
new EnumField { Name = "Bit10", Value = 10 }
|
|
]
|
|
});
|
|
Assert.That(twoBytes.ByteLength, Is.EqualTo(2));
|
|
}
|
|
|
|
[Test]
|
|
public void SetBitOutsideFixedLengthThrows()
|
|
{
|
|
// AccessRights-style OptionSet has max bit 3, so ByteLength == 1.
|
|
var optionSet = new OptionSetEncoder(
|
|
new XmlQualifiedName("AccessRights", kTypeNamespace),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
CreateAccessRightsDefinition());
|
|
|
|
// Bit 8 is outside the 1-byte fixed length— must throw per Part 3 §8.40.
|
|
Assert.That(
|
|
() => optionSet[8] = true,
|
|
Throws.TypeOf<System.ArgumentOutOfRangeException>());
|
|
}
|
|
|
|
[Test]
|
|
public void SetBitPadsValueAndValidBitsToFixedLength()
|
|
{
|
|
// Max bit 10 => ByteLength 2.
|
|
var optionSet = new OptionSetEncoder(
|
|
new XmlQualifiedName("TwoByteOptionSet", kTypeNamespace),
|
|
s_typeId, s_binaryId, s_xmlId,
|
|
new EnumDefinition
|
|
{
|
|
IsOptionSet = true,
|
|
Fields =
|
|
[
|
|
new EnumField { Name = "Bit0", Value = 0 },
|
|
new EnumField { Name = "Bit10", Value = 10 }
|
|
]
|
|
});
|
|
|
|
optionSet[0] = true;
|
|
|
|
// Even though we only touched byte 0, the fixed-length invariant
|
|
// means Value and ValidBits are materialized to 2 bytes.
|
|
Assert.That(optionSet.Value.Length, Is.EqualTo(2));
|
|
Assert.That(optionSet.ValidBits.Length, Is.EqualTo(2));
|
|
}
|
|
}
|
|
}
|